[PATCH] D66273: [Tooling] Add a hack to work around issues with matcher binding in r368681.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368958: [Tooling] Add a hack to work around issues with matcher binding in r368681. (authored by dlj, committed by ).

[PATCH] D66273: [Tooling] Add a hack to work around issues with matcher binding in r368681.

dlj created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The change in r368681 contains a (probably unintentional) behavioral change for rewrite rules with a single matcher. Previously, the single matcher would not need to be bound (`joinCaseMatchers`

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

dlj accepted this revision. dlj added a comment. In D57303#1373163 , @mgorny wrote: > Given that this path changes with every clang release, so you're effectively > making a hard dependency on the clang version used to build the program, I > dare say

[PATCH] D48242: [ASTMatchers] Add support for matching the type of a friend decl.

This revision was automatically updated to reflect the committed changes. Closed by commit rL334930: [ASTMatchers] Add support for matching the type of a friend decl. (authored by dlj, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D48242: [ASTMatchers] Add support for matching the type of a friend decl.

dlj added a comment. Ping for Manuel... Repository: rC Clang https://reviews.llvm.org/D48242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48269: [ASTMatchers] Don't assert-fail in specifiesTypeLoc().

dlj created this revision. dlj added a reviewer: klimek. dlj added a project: clang. Herald added a subscriber: cfe-commits. The specifiesTypeLoc() matcher narrows a nestedNameSpecifier matcher based on a typeloc within the NNS. However, the matcher does not guard against NNS which are a

[PATCH] D48242: [ASTMatchers] Add support for matching the type of a friend decl.

dlj added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:2900-2904 +AST_POLYMORPHIC_MATCHER_P_OVERLOAD( +hasType, +AST_POLYMORPHIC_SUPPORTED_TYPES(Expr, FriendDecl, ValueDecl), +internal::Matcher, InnerMatcher, 1) { + QualType QT =

[PATCH] D48242: [ASTMatchers] Add support for matching the type of a friend decl.

dlj updated this revision to Diff 151593. dlj marked 3 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D48242 Files: include/clang/ASTMatchers/ASTMatchers.h include/clang/ASTMatchers/ASTMatchersInternal.h unittests/ASTMatchers/ASTMatchersNodeTest.cpp Index:

[PATCH] D48242: [ASTMatchers] Add support for matching the type of a friend decl.

dlj created this revision. dlj added a reviewer: klimek. dlj added a project: clang. This allows matchers like: friendDecl(hasType(cxxRecordDecl(...))) friendDecl(hasType(asString(...))) It seems that hasType is probably the most reasonable narrowing matcher to overload, since it is already

[PATCH] D47759: [Format] Do not use a global static value for EOF within ScopedMacroState.

This revision was automatically updated to reflect the committed changes. Closed by commit rL334801: [Format] Do not use a global static value for EOF within ScopedMacroState. (authored by dlj, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D47759: [Format] Do not use a global static value for EOF within ScopedMacroState.

dlj added a comment. Ping... Repository: rC Clang https://reviews.llvm.org/D47759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47759: [Format] Do not use a global static value for EOF within ScopedMacroState.

dlj created this revision. dlj added a reviewer: djasper. dlj added a project: clang. Herald added a subscriber: klimek. ScopedMacroState injects its own EOF token under certain conditions, and the returned token may be modified in several different locations. If multiple reformat operations are

[PATCH] D44123: [AST] Enhance comment accessing interface. (NFC)

dlj created this revision. dlj added a reviewer: rsmith. dlj added a project: clang. Herald added a subscriber: sanjoy. Previously, these methods were available for looking up comments: 1. getCommentForDecl: returns a FullComment attached to a decl, or any of its redecls, or any of its bases.

[PATCH] D44122: [AST] Factor out RawComment lookup and caching. (NFC)

dlj created this revision. dlj added a reviewer: rsmith. dlj added a project: clang. Herald added a subscriber: sanjoy. This changes how RawComments are looked up, so that they can be added to the cache or updated independently of parsing. Loosely, the comment cache has two conceptually separate

[PATCH] D43663: [NFC] Move CommentOpts checks to the call sites that depend on it.

This revision was automatically updated to reflect the committed changes. Closed by commit rL326501: [NFC] Move CommentOpts checks to the call sites that depend on it. (authored by dlj, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43800: [ASTMatchers] Allow file-based narrowing matches to work with NestedNameSpecifierLocs.

dlj created this revision. dlj added a reviewer: rsmith. Herald added subscribers: sanjoy, klimek. The narrowing matchers isExpansionInMainFile, isExpansionInSystemHeader, and isExpansionInFileMatching work for TypeLocs, but not NestedNameSpecifierLocs. This changes the matchers to use

[PATCH] D43663: [NFC] Move CommentOpts checks to the call sites that depend on it.

dlj created this revision. dlj added a reviewer: rsmith. Herald added a subscriber: sanjoy. When parsing comments, for example, for -Wdocumentation, slightly different behaviour occurs when -fparse-all-comments is specified. However, these differences are subtle: 1. All comments are saved during

[PATCH] D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

dlj requested changes to this revision. dlj added a comment. This revision now requires changes to proceed. Hmm, looking more at this change... while it does make the behaviour consistent for Forward and Input iterators, I think it's just making them both do the wrong thing. Specifically,

[PATCH] D38059: Rename list::base to list::__base.

dlj created this revision. Herald added a subscriber: sanjoy. Even though the base typedef is private, it still participates in lookup. For example: void base() {} struct X : private std::list { X() { base(); } }; https://reviews.llvm.org/D38059 Files: include/list Index:

[PATCH] D37538: [libc++] Remove problematic ADL in container implementations.

dlj added a comment. In https://reviews.llvm.org/D37538#871515, @EricWF wrote: > @dlj I went ahead and committed the fixes to `std::allocator_traits` in > r313324, because I think we agree those are bugs, and I didn't want this > discussion to hold up that fix. I hope you don't mind. Nope,

[PATCH] D37538: [libc++] Remove problematic ADL in container implementations.

dlj updated this revision to Diff 115165. dlj added a comment. - Remove deque from the test for now. https://reviews.llvm.org/D37538 Files: include/__split_buffer include/memory test/std/containers/containers.general/construct_destruct.pass.cpp Index:

[PATCH] D37538: [libc++] Remove problematic ADL in container implementations.

dlj updated this revision to Diff 115164. dlj added a comment. - Remove deque from the test for now. https://reviews.llvm.org/D37538 Files: include/__split_buffer include/deque include/memory test/std/containers/containers.general/construct_destruct.pass.cpp Index:

[PATCH] D37538: [libc++] Remove problematic ADL in container implementations.

dlj marked 2 inline comments as done. dlj added inline comments. Comment at: include/deque:1167-1168 allocator_type& __a = __alloc(); -for (iterator __i = begin(), __e = end(); __i != __e; ++__i) -__alloc_traits::destroy(__a, _VSTD::addressof(*__i)); +for

[PATCH] D37818: [lit] Update clang and lld to use the new shared LLVMConfig stuff

dlj added inline comments. Comment at: clang/test/lit.cfg:23 # the test runner updated. -config.test_format = lit.formats.ShTest(execute_external) +config.test_format = lit.formats.ShTest(not llvm_config.use_lit_shell) Minor nit: it seems reasonable enough to

[PATCH] D37538: [libc++] Remove problematic ADL in container implementations.

dlj created this revision. Herald added a subscriber: sanjoy. Herald added a reviewer: EricWF. Some container operations require ADL. For example, std::advance is required to use specific operators, which will participate in ADL. However, implementation details which rely on SFINAE should be

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

dlj accepted this revision. dlj added a comment. I think this change is structurally fine, but I'll defer to others on whether it's actually doing the right thing. (I'm pretty sure it is, but I'm far from an expert on Solaris or Sparc.) Comment at:

[PATCH] D34853: Fix (benignly) incorrect GoogleTest specs in various lit configs.

dlj added a comment. In https://reviews.llvm.org/D34853#798699, @andrewng wrote: > Hi, > > I believe that this "build mode" is intended for the Visual Studio MSVC > build. This build is special in that it can produce builds for multiple > configurations, e.g. Debug, Release & RelWithDebInfo,

[PATCH] D34853: Fix (benignly) incorrect GoogleTest specs in various lit configs.

dlj created this revision. dlj added projects: lld, clang. Herald added subscribers: mehdi_amini, sanjoy. The GoogleTest lit format accepts two parameters to its constructor: a subdirectory to find test binaries, and a required suffix for the test filenames. Typically, the config should look

[PATCH] D30372: [Driver] Consolidate tools and toolchains by target platform. (NFC)

dlj added a comment. In https://reviews.llvm.org/D30372#688154, @mehdi_amini wrote: > In https://reviews.llvm.org/D30372#687060, @ahatanak wrote: > > > In https://reviews.llvm.org/D30372#687054, @dlj wrote: > > > > > In https://reviews.llvm.org/D30372#686871, @ahatanak wrote: > > > > > > > Have

[PATCH] D30372: [Driver] Consolidate tools and toolchains by target platform. (NFC)

dlj added a comment. In https://reviews.llvm.org/D30372#686871, @ahatanak wrote: > Have you considered using "include_directories" in CMakeLists.txt to avoid > including "../Something.h"? I don't want to take that approach, and there's a specific reason why: my concern isn't with three extra

[PATCH] D29737: Updates documentation to include command to run clang-tidy tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rL294689: Adds the commandline need to run clang-tidy tests. (authored by dlj). Changed prior to commit: https://reviews.llvm.org/D29737?vs=87728=87930#toc Repository: rL LLVM

[PATCH] D29737: Updates documentation to include command to run clang-tidy tests.

dlj added a comment. LGTM. I will land shortly. https://reviews.llvm.org/D29737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28478: Check for musl-libc's max_align_t in addition to other variants.

This revision was automatically updated to reflect the committed changes. Closed by commit rL294683: Check for musl-libc's max_align_t in addition to other variants. (authored by dlj). Changed prior to commit: https://reviews.llvm.org/D28478?vs=83681=87925#toc Repository: rL LLVM

[PATCH] D28478: Check for musl-libc's max_align_t in addition to other variants.

dlj added a comment. In https://reviews.llvm.org/D28478#672959, @EricWF wrote: > IDK how to meaningly test this though. Heh. Well... I can tell you that with this change (and a couple of others), I'm able to bootstrap Clang (2-stage) using libc++ on Alpine Linux. It totally works, I promise!

[PATCH] D16135: Macro Debug Info support in Clang

dlj added inline comments. Comment at: cfe/trunk/lib/CodeGen/MacroPPCallbacks.cpp:125 + switch (Status) { + default: +llvm_unreachable("Do not expect to enter a file from current scope"); As a heads up... this fails under -Werror:

[PATCH] D28007: Switch TableGen to emit calls to ASTRecordReader for AttrPCHRead.

This revision was automatically updated to reflect the committed changes. Closed by commit rL292868: Switch TableGen to emit calls to ASTRecordReader for AttrPCHRead. (authored by dlj). Changed prior to commit: https://reviews.llvm.org/D28007?vs=85493=85498#toc Repository: rL LLVM

[PATCH] D28007: Switch TableGen to emit calls to ASTRecordReader for AttrPCHRead.

dlj updated this revision to Diff 85493. dlj added a comment. - Pull, merge, etc. https://reviews.llvm.org/D28007 Files: include/clang/Serialization/ASTReader.h lib/Serialization/ASTReaderDecl.cpp utils/TableGen/ClangAttrEmitter.cpp Index: utils/TableGen/ClangAttrEmitter.cpp

[PATCH] D28478: Check for musl-libc's max_align_t in addition to other variants.

dlj added a comment. Ping? https://reviews.llvm.org/D28478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28477: Add LF_ prefix to LibFunc enums in TargetLibraryInfo.

dlj added a comment. Ping? https://reviews.llvm.org/D28477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28007: Switch TableGen to emit calls to ASTRecordReader for AttrPCHRead.

dlj added a comment. Ping? https://reviews.llvm.org/D28007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28427: Allow constexpr construction of subobjects unconditionally, not just in C++14.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291480: Allow constexpr construction of subobjects unconditionally, not just in C++14. (authored by dlj). Changed prior to commit: https://reviews.llvm.org/D28427?vs=83650=83686#toc Repository: rL

[PATCH] D28478: Check for musl-libc's max_align_t in addition to other variants.

dlj created this revision. dlj added a reviewer: mclow.lists. dlj added a subscriber: cfe-commits. Libcxx will define its own max_align_t when it is not available. However, the availability checks today only check for Clang's definition and GCC's definition. In particular, it does not check for

[PATCH] D28477: Add LF_ prefix to LibFunc enums in TargetLibraryInfo.

dlj created this revision. dlj added a reviewer: rsmith. dlj added a subscriber: cfe-commits. The LibFunc::Func enum holds enumerators named for libc functions. Unfortunately, there are real situations, including libc implementations, where function names are actually macros (musl uses "#define

[PATCH] D28427: Allow constexpr construction of subobjects unconditionally, not just in C++14.

dlj updated this revision to Diff 83650. dlj added a comment. - Fix lit checks. https://reviews.llvm.org/D28427 Files: lib/AST/ExprConstant.cpp test/CXX/basic/basic.start/basic.start.init/p2.cpp test/CodeGenCXX/global-array-destruction.cpp Index:

[PATCH] D28427: Allow constexpr construction of subobjects unconditionally, not just in C++14.

dlj added a comment. Test added, and fixed another one that I missed before. https://reviews.llvm.org/D28427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28427: Allow constexpr construction of subobjects unconditionally, not just in C++14.

dlj created this revision. dlj added a reviewer: rsmith. dlj added subscribers: cfe-commits, EricWF. Per https://wg21.link/CWG1677, the C++11 standard did not clarify that constant initialization of an object allowed constexpr brace-or-equal initialization of subobjects: struct foo_t { union {

[PATCH] D28008: Rename several methods on ASTRecordReader to follow LLVM style (lowerCamelCase).

This revision was automatically updated to reflect the committed changes. Closed by commit rL290236: Rename several methods on ASTRecordReader to follow LLVM style (lowerCamelCase). (authored by dlj). Changed prior to commit: https://reviews.llvm.org/D28008?vs=82183=82197#toc Repository: rL

[PATCH] D28008: Rename several methods on ASTRecordReader to follow LLVM style (lowerCamelCase).

dlj created this revision. dlj added a reviewer: rsmith. dlj added a subscriber: cfe-commits. This follows up to r290217, and makes functions on ASTRecordReader consistent and valid style. https://reviews.llvm.org/D28008 Files: include/clang/Serialization/ASTReader.h

[PATCH] D28007: Switch TableGen to emit calls to ASTRecordReader for AttrPCHRead.

dlj created this revision. dlj added a reviewer: rsmith. dlj added a subscriber: cfe-commits. This patch changes TableGen-generated code in AttrPCHRead to call functions on ASTRecordReader, instead of passing separate parameters to ASTReader. This is a follow-up to r290217.

[PATCH] D27836: Store the "current position" index within the ASTRecordReader.

dlj added a comment. In https://reviews.llvm.org/D27836#628029, @rsmith wrote: > LGTM, any chance I can tempt you to lowerCamelCase all the other > ASTRecordReader members to match the new ones as a follow-up change? Yup, will do. https://reviews.llvm.org/D27836

[PATCH] D27836: Store the "current position" index within the ASTRecordReader.

dlj added a comment. Yeah, that makes more sense. Switched to readInt/peekInt/skipInts, let me know if you have a better idea for the names. https://reviews.llvm.org/D27836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27784: Add a class ASTRecordReader which wraps an ASTReader, a RecordData, and ModuleFile.

dlj added a comment. https://reviews.llvm.org/D27784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits