https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/151157
>From 714a9cb319a8946fa670c7e8bbe7f29f847fa45f Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 29 Jul 2025 14:17:56 +
Subject: [PATCH 1/2] [clang] Only build c-index-test when clang tests are
DavidSpickett wrote:
ping!
https://github.com/llvm/llvm-project/pull/151157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
I will be away for the next week, so don't wait for my approval.
https://github.com/llvm/llvm-project/pull/153587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,2 +1,5 @@
-if "host-supports-jit" not in config.available_features:
+import sys
+
+# clang-repl is not supported on AIX and zOS
+if "host-supports-jit" not in config.available_features or sys.platform ==
"aix" or sys.platform == "zos":
DavidSpickett wrote:
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/153587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett commented:
I don't know the overlap or not between AIX and zOS but I'll assume you do.
Thanks for following up.
https://github.com/llvm/llvm-project/pull/153587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
DavidSpickett wrote:
https://github.com/llvm/llvm-project/pull/152993 fixes this.
Pretty sure there's no problem with this PR, it uncovered an existing problem
in the formatter itself.
https://github.com/llvm/llvm-project/pull/147835
___
cfe-commits
DavidSpickett wrote:
This has changed the output of lldb's std::string formatter when it's not a
valid std::string object:
```
TEST 'lldb-api ::
functionalities/data-formatter/data-formatter-stl/generic/string/TestDataFormatterStdString.py'
FAILED
Scri
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/150348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
Looks good, thanks!
Let's see what the maintainer has to say.
https://github.com/llvm/llvm-project/pull/150348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -364,15 +366,34 @@ int main(int argc, const char **argv) {
}
Input += L;
+ // If we add more % commands, there should be better architecture than
+ // this.
if (Input == R"(%quit)") {
break;
}
if (Input == R"(%undo)") {
DavidSpickett wrote:
Please update the PR description to reflect the current changes.
@vgvassilev what do you think of this?
Only question I have is whether there's a special way to print non-error
output, or whether stdout is fine? In theory `%help` is just like
`printf("..."); but it prints
@@ -159,8 +159,31 @@ Lamdas:
clang-repl> welcome();
Welcome to REPL
-Using Dynamic Library:
-==
+Comments:
+=
+
+.. code-block:: text
+
+ clang-repl> // Comments in Clang-Repl
+ clang-repl> /* Comments in Clang-Repl */
+
+
@@ -364,15 +366,34 @@ int main(int argc, const char **argv) {
}
Input += L;
+ // If we add more % commands, there should be better architecture than
+ // this.
if (Input == R"(%quit)") {
break;
}
if (Input == R"(%undo)") {
DavidSpickett wrote:
Use the ostream then. We'll see if other reviewers think differently.
https://github.com/llvm/llvm-project/pull/150348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
@@ -159,8 +159,21 @@ Lamdas:
clang-repl> welcome();
Welcome to REPL
-Using Dynamic Library:
-==
+Built in Commands:
+==
+clang-repl has some special commands that are of the form `%`. To
list all these commands, use the `%help` comman
@@ -370,9 +378,24 @@ int main(int argc, const char **argv) {
if (Input == R"(%undo)") {
if (auto Err = Interp->Undo())
llvm::logAllUnhandledErrors(std::move(Err), llvm::errs(), "error: ");
+ } else if (Input == R"(%help)") {
+auto Err =
+
@@ -189,21 +202,40 @@ Using Dynamic Library:
clang++-17 -c -o print.o print.cpp
clang-17 -shared print.o -o print.so
-Comments:
-=
+Undo:
+=
+The `%undo` command reverts the previous input.
DavidSpickett wrote:
I would say "undoes". I know
@@ -370,9 +378,24 @@ int main(int argc, const char **argv) {
if (Input == R"(%undo)") {
if (auto Err = Interp->Undo())
llvm::logAllUnhandledErrors(std::move(Err), llvm::errs(), "error: ");
+ } else if (Input == R"(%help)") {
+auto Err =
+
@@ -185,7 +185,7 @@ struct ReplListCompleter {
clang::Interpreter &MainInterp;
ReplListCompleter(clang::IncrementalCompilerBuilder &CB,
clang::Interpreter &Interp)
- : CB(CB), MainInterp(Interp){};
+ : CB(CB), MainInterp(Interp) {};
---
@@ -159,8 +159,21 @@ Lamdas:
clang-repl> welcome();
Welcome to REPL
-Using Dynamic Library:
-==
+Built in Commands:
+==
+clang-repl has some special commands that are of the form `%`. To
list all these commands, use the `%help` comman
@@ -189,21 +202,40 @@ Using Dynamic Library:
clang++-17 -c -o print.o print.cpp
clang-17 -shared print.o -o print.so
-Comments:
-=
+Undo:
+=
+The `%undo` command reverts the previous input.
.. code-block:: text
- clang-repl> // Comments in Clang-Repl
@@ -347,7 +348,15 @@ int main(int argc, const char **argv) {
}
}
+ // if we add more % commands, there should be better architecture than this
DavidSpickett wrote:
It's fine, point is, it's very clear to the next person that they should think
about th
https://github.com/DavidSpickett commented:
So this is great, just some small things to fix.
Next you need to add tests for:
* %help
* %lib with no argument
* %rubbish error message
I would do all those as their own test files. You could add the %lib bit to one
of the existing tests, but each
@@ -159,8 +159,21 @@ Lamdas:
clang-repl> welcome();
Welcome to REPL
-Using Dynamic Library:
-==
+Built in Commands:
+==
+clang-repl has some special commands that are of the form `%`. To
list all these commands, use the `%help` comman
@@ -370,9 +378,24 @@ int main(int argc, const char **argv) {
if (Input == R"(%undo)") {
if (auto Err = Interp->Undo())
llvm::logAllUnhandledErrors(std::move(Err), llvm::errs(), "error: ");
+ } else if (Input == R"(%help)") {
+auto Err =
+
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/150348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/151157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/151157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/151157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/151157
>From 714a9cb319a8946fa670c7e8bbe7f29f847fa45f Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 29 Jul 2025 14:17:56 +
Subject: [PATCH 1/2] [clang] Only build c-index-test when clang tests are
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/151157
c-index-test is only used for testing, and it's used in tests that are already
guarded by CLANG_INCLUDE_TESTS in clang/CMakeLists.txt.
This change enables us to do builds with LLVM_INSTALL_TOOLCHAIN_ONLY=
https://github.com/DavidSpickett commented:
I had a dark thought that maybe mutli-line input would mess up checking for %
commands, but luckily it does not.
```
clang-repl> int a = 1;
clang-repl> int b = 10 \
clang-repl... %undo
In file included from <<< inputs >>>:1:
input_line_2:1:13: error
@@ -197,6 +197,20 @@ Comments:
clang-repl> // Comments in Clang-Repl
clang-repl> /* Comments in Clang-Repl */
+Help:
DavidSpickett wrote:
I think the doc needs to at some point introduce the concept of % commands, so
how about adding a title like "Buil
@@ -347,7 +348,15 @@ int main(int argc, const char **argv) {
}
}
+ // if we add more % commands, there should be better architecture than this
+ const char *help_output = "%help\tlist clang-repl %commands\n"
+"%undo\tundo the previous input\
@@ -28,6 +28,7 @@
#include "llvm/Support/ManagedStatic.h" // llvm_shutdown
#include "llvm/Support/Signals.h"
#include "llvm/Support/TargetSelect.h"
+#include "llvm/Support/raw_ostream.h"
DavidSpickett wrote:
If we leave the welcome message out, you can remove
@@ -370,6 +379,10 @@ int main(int argc, const char **argv) {
if (Input == R"(%undo)") {
if (auto Err = Interp->Undo())
llvm::logAllUnhandledErrors(std::move(Err), llvm::errs(), "error: ");
+ } else if (Input == R"(%help)") {
+OS << help_outp
@@ -347,7 +348,15 @@ int main(int argc, const char **argv) {
}
}
+ // if we add more % commands, there should be better architecture than this
DavidSpickett wrote:
Another factor here is code locality. If this was spread across files the
threshold for
@@ -347,7 +348,15 @@ int main(int argc, const char **argv) {
}
}
+ // if we add more % commands, there should be better architecture than this
DavidSpickett wrote:
Format your comments as if they were normal written sentences. Which means
capital lett
@@ -197,6 +197,20 @@ Comments:
clang-repl> // Comments in Clang-Repl
clang-repl> /* Comments in Clang-Repl */
+Help:
+=
+
+.. code-block:: text
+
+ clang-repl>%help
+
+Undo:
+=
+
DavidSpickett wrote:
I know it seems obvious what this does, but
@@ -347,7 +348,15 @@ int main(int argc, const char **argv) {
}
}
+ // if we add more % commands, there should be better architecture than this
+ const char *help_output = "%help\tlist clang-repl %commands\n"
+"%undo\tundo the previous input\
@@ -197,6 +197,20 @@ Comments:
clang-repl> // Comments in Clang-Repl
clang-repl> /* Comments in Clang-Repl */
+Help:
+=
+
+.. code-block:: text
+
+ clang-repl>%help
DavidSpickett wrote:
Actual clang-repl prints a space after the >, include that in
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/150348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -370,6 +379,10 @@ int main(int argc, const char **argv) {
if (Input == R"(%undo)") {
if (auto Err = Interp->Undo())
llvm::logAllUnhandledErrors(std::move(Err), llvm::errs(), "error: ");
+ } else if (Input == R"(%help)") {
+OS << help_outp
@@ -370,6 +379,10 @@ int main(int argc, const char **argv) {
if (Input == R"(%undo)") {
if (auto Err = Interp->Undo())
llvm::logAllUnhandledErrors(std::move(Err), llvm::errs(), "error: ");
+ } else if (Input == R"(%help)") {
+OS << help_outp
DavidSpickett wrote:
Sorry, I didn't realise this was a PR! So tunnel visioned on the comment
notification. So if any of what I said made not much sense, that's why :)
Will review this today.
https://github.com/llvm/llvm-project/pull/150348
___
cfe-c
DavidSpickett wrote:
To be clear, not saying you have to do all of the things suggested here. If you
find something else to work on, please do :)
https://github.com/llvm/llvm-project/pull/150348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
DavidSpickett wrote:
> I've added %undo to the documentation and implemented %help. Would it be good
> to also add %help to the documentation?
Yes add %help. It feels a bit redundant and it is, but it'll also be a hint for
future developers to say "hey, remember that new commands have to appea
https://github.com/DavidSpickett requested changes to this pull request.
I'm going to go out on a limb and suggest that a certain sort of assistive
interactive tool was used to generate this. Which I don't venture an opinion on
in general but in this case, it's didn't do so well.
A glance at t
DavidSpickett wrote:
Please change your email settings as explained in
https://llvm.org/docs/DeveloperPolicy.html#email-addresses. Right now it would
be merged with a GitHub noreply address.
https://github.com/llvm/llvm-project/pull/144368
___
cfe-co
https://github.com/DavidSpickett approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/144368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
> Do I need to do anything else?
No, all good.
> Or is squashing the commits and merging up to someone with write permissions?
GitHub will do the squashing, and yes I just clicked the merge button for you.
Once you have established a track record you can [ask for
permiss
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/149396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
> Any other ideas or should we just revert everything while you try to figure
> it out?
It requires the x86 target, but not in an obvious way, clang's cc1 generates an
option that requires the target. Rather than what you see in the RUN line
requiring it.
Should be fixed
Author: David Spickett
Date: 2025-07-23T08:44:57Z
New Revision: 52737ea6d69d79fb104480d9cd67bf85711fc939
URL:
https://github.com/llvm/llvm-project/commit/52737ea6d69d79fb104480d9cd67bf85711fc939
DIFF:
https://github.com/llvm/llvm-project/commit/52737ea6d69d79fb104480d9cd67bf85711fc939.diff
LOG
DavidSpickett wrote:
I don't have an opinion either way but there are more users of `GlobPattern` so
you should check the impact on them.
https://github.com/llvm/llvm-project/pull/149886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
DavidSpickett wrote:
FYI
https://discourse.llvm.org/t/rfc-rename-source-files-in-clang-lib-codegen-targetbuiltins/87462
https://github.com/llvm/llvm-project/pull/132252
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/DavidSpickett approved this pull request.
LGTM
@aadanen you won't be able to merge this yourself but I can once you've fixed
the formatting.
https://github.com/llvm/llvm-project/pull/149396
___
cfe-commits mailing list
cfe-commits@
DavidSpickett wrote:
You have formatting to fix, I suggest you just copy and paste the diff in this
one time.
Folks will have different ways to setup clang-format, I use the script
https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting and
manually run it (because I am too
DavidSpickett wrote:
> I am able to build clang, compile the project, and I am currently running the
> "ninja check-clang-unit" tests. Although it does take an incredibly long time
> ( 45 minutes to an hour) but that's off topic
llvm/clang is not a light build at the best of times, but there a
DavidSpickett wrote:
Looks great! CI should confirm the test is correct, and I added the clang-repl
maintainer on review in case they have anything to say.
https://github.com/llvm/llvm-project/pull/149396
___
cfe-commits mailing list
cfe-commits@lists
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/149396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/149396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -158,12 +158,12 @@ TEST_F(InterpreterTest, UndoCommand) {
// Fail to undo.
auto Err1 = Interp->Undo();
- EXPECT_EQ("Operation failed. Too many undos",
+ EXPECT_EQ("Operation failed. No input left to undo",
llvm::toString(std::move(Err1)));
auto Err2 =
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/149396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/149396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
https://github.com/llvm/llvm-project/pull/149396#issuecomment-3088555387 is one
of our automated checks, please follow its guidance. The reason we do this is
so we can attribute changes for reasons around the licensing of contributions,
there's more info in those links. It
@@ -158,12 +158,12 @@ TEST_F(InterpreterTest, UndoCommand) {
// Fail to undo.
auto Err1 = Interp->Undo();
- EXPECT_EQ("Operation failed. Too many undos",
+ EXPECT_EQ("Operation failed. No input left to undo",
llvm::toString(std::move(Err1)));
auto Err2 =
@@ -158,12 +158,12 @@ TEST_F(InterpreterTest, UndoCommand) {
// Fail to undo.
auto Err1 = Interp->Undo();
- EXPECT_EQ("Operation failed. Too many undos",
+ EXPECT_EQ("Operation failed. No input left to undo",
llvm::toString(std::move(Err1)));
auto Err2 =
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/149235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/149235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
The actual error is the same as seen elsewhere:
```
$ /home/david.spickett/build-llvm-aarch64/bin/flang
--target=aarch64-pc-windows-msvc -Werror
../llvm-project/flang/test/Semantics/windows.f90
flang-21: warning: unable to find a Visual Studio installation; try running
Cla
Author: David Spickett
Date: 2025-07-03T13:36:30Z
New Revision: d805707ee435fbe83440ceaf0eb515bf1d536f01
URL:
https://github.com/llvm/llvm-project/commit/d805707ee435fbe83440ceaf0eb515bf1d536f01
DIFF:
https://github.com/llvm/llvm-project/commit/d805707ee435fbe83440ceaf0eb515bf1d536f01.diff
LOG
DavidSpickett wrote:
The warning:
```
RUN: at line 1 has no command after substitutions
```
Is because the test looks for the wrong target to be enabled, this will be
fixed by: https://github.com/llvm/llvm-project/pull/146869
It's not the cause of the failure.
https://github.com/llvm/llvm-proj
DavidSpickett wrote:
I've reverted this due to a test failure on our Linux bots:
https://lab.llvm.org/buildbot/#/builders/17/builds/9292
And if I understand correctly, flang needs another patch before it can build
properly on Windows:
```
FAILED: include/flang/__fortran_builtins.mod
C:/Users/
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/146836
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/146836
Reverts llvm/llvm-project#146582
Due to failures on many of Linaro's Linux flang bots:
https://lab.llvm.org/buildbot/#/builders/17/builds/9292
```
TEST 'Flang :: Semantics/windows.f9
DavidSpickett wrote:
I also got a report of a downstream failure:
```
09:53:25 FAIL: Clang :: Sema/deep_recursion.c (18481 of 84779)
09:53:25 TEST 'Clang :: Sema/deep_recursion.c' FAILED
09:53:25 Exit Code: 139
09:53:25
09:53:25 Command Output (std
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
DavidSpickett wrote:
When applied to 7c15edb306932e41c159f3d69c161ed0d89d47b7, this fixes the
problem and passes check-clang.
Reland in whatever way you prefer (no need for extra review), as you know, the
bot will rapi
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
DavidSpickett wrote:
Short of cross-compiling, a debug build isn't happening.
I know so far is that the last thing it attempts to do is construct an APInt
with:
```
Bitwidth: 2, val: 0xffe64100
```
We need to fi
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
DavidSpickett wrote:
This only reproduces if we build it with clang (19.1.7, but might not be
version specific). I added a debug trap in place of the assert and got a better
traceback:
```
-- Testing: 1 tests, 1 workers
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
DavidSpickett wrote:
So after the fixup this failed again:
https://lab.llvm.org/buildbot/#/builders/154/builds/17588
```
TEST 'Clang :: AST/ByteCode/intap.cpp' FAILED
Exit Code:
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
DavidSpickett wrote:
I see you reverted due to
https://lab.llvm.org/buildbot/#/builders/154/builds/17549. In case you don't
know, that builder is Armv8 32-bit.
Unless you get reports from our other, 64-bit builders, it
DavidSpickett wrote:
I've disabled the failing `RUN` line on Windows and opened
https://github.com/llvm/llvm-project/issues/143547 with details of what's
happening.
Let me know if anything stands out to you. Also would be useful if I can see
the code produced at the different optimisation lev
Author: David Spickett
Date: 2025-06-10T15:13:34Z
New Revision: beffd1509af7b12eeab0d5ae85b2f8322e039287
URL:
https://github.com/llvm/llvm-project/commit/beffd1509af7b12eeab0d5ae85b2f8322e039287
DIFF:
https://github.com/llvm/llvm-project/commit/beffd1509af7b12eeab0d5ae85b2f8322e039287.diff
LOG
DavidSpickett wrote:
Thanks for confirming, yes, your patch is working as expected but something
about Windows' output is tripping up FileCheck I think.
Linux does not print the `clang-repl>` (maybe because it can tell it's
outputting to a non-interactive pipe):
```
$ cat ../llvm-project/clang
DavidSpickett wrote:
Also failing on Windows x64, but this time the error is better:
https://lab.llvm.org/buildbot/#/builders/63/builds/7023
And now I see the actual problem, all I had to do was scroll up :)
```
# .---command stderr
# | In file included from <<< inputs >>>:1:
# | inp
DavidSpickett wrote:
After this change the test labda.cpp is failing on Linaro's Windows on Arm
clang bots. They were stuck for other reasons and only just got back up to
date, so here's a new build showing the failure:
https://lab.llvm.org/buildbot/#/builders/161/builds/6473
```
cat
C:\Users\
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/141921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/141921
This was added by 8eb34700c2b1847ec6dfb8f92b305b65278d2ec0 which added an opt
into the new ignore list behaviour.
Then 81d1df2a39f0616be4b530cbf86b3f575442a347 flipped it so you had to opt into
the old b
DavidSpickett wrote:
I've
[disabled](https://github.com/llvm/llvm-project/commit/f7fdc8d0cf7cd5caa7d463e1e80e0d5a08c71bb2)
the test when threads are disabled.
I don't think it needs to be limited to Apple Silicon actually, because a new
OS thread should pass the test (and apparently does). Bu
DavidSpickett wrote:
That build sets `-DLLVM_ENABLE_THREADS=OFF`. `LLVM_HAS_SPLIT_STACKS_AARCH64`
and `LLVM_HAS_SPLIT_STACKS` are false, which means we use:
```
void llvm::runOnNewStack(unsigned StackSize, function_ref Fn) {
llvm::thread Thread(
StackSize == 0 ? std::nullopt : std::optio
DavidSpickett wrote:
Same sort of thing on our Armv8 32-bit build:
https://lab.llvm.org/buildbot/#/builders/122/builds/1478
```
../llvm/llvm/unittests/Support/ProgramStackTest.cpp:32
Expected: (StackDistance) > (llvm::sys::Process::getPageSizeEstimate()),
actual: 8 vs 4096
```
https://github.
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/134612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -463,6 +466,7 @@ X86 Support
Arm and AArch64 Support
^^^
+- For ARM targets, cc1as now considers the FPU's features for the selected CPU
or Arch.
DavidSpickett wrote:
Arch -> architecture
https://github.com/llvm/llvm-project/pull/1346
@@ -0,0 +1,32 @@
+// REQUIRES: arm-registered-target
+// Ensures that when targeting an ARM target with an Asm file, clang
DavidSpickett wrote:
I have often been asked to use `///` for comments that were actually comments.
I think it is marginally easier to read
@@ -0,0 +1,32 @@
+// REQUIRES: arm-registered-target
+// Ensures that when targeting an ARM target with an Asm file, clang
+// collects the features from the FPU. This is critical in the
+// activation of NEON for supported targets. The Cortex-R52 will be
+// used and tested for V
@@ -0,0 +1,32 @@
+// REQUIRES: arm-registered-target
+// Ensures that when targeting an ARM target with an Asm file, clang
+// collects the features from the FPU. This is critical in the
+// activation of NEON for supported targets. The Cortex-R52 will be
+// used and tested for V
@@ -679,20 +679,17 @@ llvm::ARM::FPUKind arm::getARMTargetFeatures(const Driver
&D,
CPUArgFPUKind != llvm::ARM::FK_INVALID ? CPUArgFPUKind :
ArchArgFPUKind;
(void)llvm::ARM::getFPUFeatures(FPUKind, Features);
} else {
-bool Generic = true;
-if (!ForAS) {
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/134366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 723 matches
Mail list logo
