[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty added a comment. In D159339#4642210 , @v.g.vassilev wrote: > In D159339#4642147 , @daltenty > wrote: > >> FYI: I tried to reproduce this on `powerpc64le-linux-gnu` at `-02` and >> didn't see it at this

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty added a comment. FYI: I tried to reproduce this on `powerpc64le-linux-gnu` at `-02` and didn't see it at this point, though I get a whole lot of other uninitialized reads, so there's definitely some general problems in this space in the LLVM codebase Repository: rG LLVM Github Monor

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM as a workaround. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2389 if (getTarget().getCXXABI().areMemberFunctionsAligned()) { -if (F->getPointerAlignment(g

[PATCH] D159339: [urgent][CodeGen] First check the kind and then the llvm::Function properties.

daltenty added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2389 if (getTarget().getCXXABI().areMemberFunctionsAligned()) { -if (F->getPointerAlignment(getDataLayout()) < 2 && isa(D)) +if (isa(D) && F->getPointerAlignment(getDataLayout()) < 2)

[PATCH] D147184: [clang][CodeGenCXX] Improve handling of itanium ABI member function alignment requirements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG196c144d0bc1: [clang][CodeGenCXX] Improve handling of itanium ABI member function alignment… (authored by daltenty). Herald added a project: clang. H

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, with minor fixup as noted Comment at: clang/test/Driver/aix-ld.c:1123 +// CHECK-K-UNUSED: clang: warning: -K: 'linker' input unused [-Wunused-command-line-argument

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6331 + if (Arg *A = Args.getLastArg(options::OPT_K); A && !TC.getTriple().isOSAIX()) +D.Diag(diag::err_drv_unsupported_opt_for_target) Let's not claim here, just in case this

[PATCH] D147016: [PowerPC] Add function pointer alignment to DataLayout

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d2e9fc8553c: [PowerPC] Add function pointer alignment to DataLayout (authored by daltenty). Herald added a project: clang. Herald added a subscriber

[PATCH] D146459: [clang][PowerPC] Remove remaining Darwin support

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fe49ea0d07d: [clang][PowerPC] Remove remaining Darwin support (authored by daltenty). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llv

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

daltenty added a comment. LGTM, with a small nit about the test that should be addressed before committing Comment at: clang/test/Driver/aix-ld.c:1085 +// RUN:--sysroot %S/Inputs/aix_ppc_tree \ +// RUN:--unwindlib=libunwind \ +// RUN:-r \ ---

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1696 if (TC.getTriple().isOSAIX()) { + if (Args.hasArg(options::OPT_r)) +break; I think this is redundant, we guard out this whole function call in the block

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:237 +// Add directory to library search path. +Args.AddAllArgs(CmdArgs, options::OPT_L); +ToolChain.AddFilePathLibArgs(Args, CmdArgs); This mostly looks good, but I'm not

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

daltenty added a comment. Reopen since this was reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145610: [clang][driver][AIX] accept maix32/maix64 gcc compat options

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a733e8a2c58: [clang][driver] accept maix32/maix64 gcc compat options (authored by daltenty). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://revi

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6327 } - if (Arg *A = Args.getLastArgNoClaim(options::OPT_p)) { + if (Arg *A = Args.getLastArg(options::OPT_p)) { if (TC.getTriple().isOSAIX()) { Actually, a question here

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 __

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, with small nit to address before commit Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6287-6292 if (!TC.getTriple().isOSAIX() && !TC.getTriple().isOSOpenBS

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

daltenty added inline comments. Comment at: clang/include/clang/Driver/Options.td:4141 HelpText<"Warn on language extensions">, MarshallingInfoFlag>; +def p : Flag<["-"], "p">, HelpText<"Enable mcount instrumentation with prof">, Flags<[CC1Option]>; def pg : Flag<["-"], "pg

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

daltenty added inline comments. Comment at: clang/test/SemaCXX/class-layout.cpp:616-617 +// This ends the #if !defined(__MVS__) && !defined(__AIX__) block from line 12 +#endif + nit: line numbers may shift on you as other commits touch this file. Prefer a sa

[PATCH] D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. Some minor nits about how we can shorten the test, but otherwise LGTM Comment at: clang/test/Driver/aix-ld.c:1027 +// RUN:-fopenmp \ +// RUN: | FileCheck --chec

[PATCH] D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified

daltenty added a comment. Needs a test, I think we should add a couple of `-fopenmp=foo` run lines to `clang/test/Driver/aix-ld.c` to verify that the correct linker options are produced for each. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14186

[PATCH] D128223: [clang] Cached linkage assertion for static locals of static function

daltenty accepted this revision. daltenty added a comment. New revision LGTM, VisibleNoLinkage is typical reserved for types from inline functions so it doesn't seem sensible to return. Looking at the C++ standard, I'm not even convinced this is guaranteed to be the same object if the function

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

daltenty added a comment. In D130327#3944591 , @vsapsai wrote: > In D130327#3944188 , @NancyWang > wrote: > >> @vsapsai hi Volodymyr Sapsai , test case >> clang/test/Modules/hidden-duplicates.m is failing o

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

daltenty accepted this revision. daltenty added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137986/new/ https://reviews.llvm.org/D137986 ___ cfe-commits mailing list cfe-commit

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

daltenty added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:110 + // The AIX library functions frexpl, ldexpl, and modfl are for 128-bit + // 'long double'. Map to the 'double' versions if it is 64-bit 'long + // double' mode. I feel like we sh

[PATCH] D128223: [clang] Linkage computation of static locals may require forcing visibility computation

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM. Doing the inner computation while observing visibility seems like the right thing to do in this case. Comment at: clang/lib/AST/Decl.cpp:1355 +!Context.get

[PATCH] D134284: [AIX] change "llvm-nm" to "env OBJECT_MODE=any llvm-nm" in clang/test for AIX OS

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM to unblock the AIX buildbots. We can follow up on a separate env later if desired. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134284

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

daltenty added a comment. > It looks to me like > https://github.com/llvm/llvm-project/blob/b982ba2a6e0f11340b4e75d1d4eba9ff62a81df7/clang/lib/Driver/Driver.cpp#L554 > should be modified to accept the OBJECT_MODE values you've implemented for > llvm-nm and llvm-ar. Otherwise, you'll never be ab

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

daltenty added a comment. > If OBJECT_MODE isn't an environment variable that clang uses, surely it > should ignore it? The clang driver does in fact respect OBJECT_MODE on AIX, but I'm guessing it doesn't accept the `any` setting (since it doesn't really make sense in that context). Reposit

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

daltenty accepted this revision. daltenty added a comment. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 ___ cfe-commits mailing list cfe-commits

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

daltenty added a comment. Suggest adding the following text to `clang/docs/ReleaseNotes.rst` under the AIX section with this change: * When using `-shared`, the clang driver now invokes llvm-nm to create an export list if the user doesn't specify one via linker flag or pass an alternative ex

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

daltenty marked an inline comment as done. daltenty added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1228 GV->setDLLStorageClass(llvm::GlobalVariable::DLLImportStorageClass); -else if (D->hasAttr() && !GV->isDeclarationForLinker()) +else if ((

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

daltenty updated this revision to Diff 435609. daltenty added a comment. - Don't try to export internal linkage RTTI types - Make shouldMapVisibilityToDLLExport inline and provide a short-circuit evaluation in the case where no mapping is in effect. This should hopefully solve the compile time i

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

daltenty added a comment. In D126340#3552645 , @nikic wrote: > It looks like this causes a major compile-time regression in the clang > frontend: > http://llvm-compile-time-tracker.com/compare.php?from=6232a8f3d61e5856c17e7b314385e9ea8068cdc1&to=8c8a267

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c8a2679a20f: [clang][AIX] add option mdefault-visibility-export-mapping (authored by daltenty). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorep

[PATCH] D122519: [NFC][tests][AIX] XFAIL test for lack of visibility support

daltenty added a comment. Resolved by https://reviews.llvm.org/D125141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122519/new/ https://reviews.llvm.org/D122519 ___ cfe-commits mailing list cfe-commits@

[PATCH] D125141: [clang][AIX] Don't ignore XCOFF visibility by default

daltenty added a comment. Resolved by https://reviews.llvm.org/D125141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125141/new/ https://reviews.llvm.org/D125141 ___ cfe-commits mailing list cfe-commits@

[PATCH] D125141: [clang][AIX] Don't ignore XCOFF visibility by default

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9c1d3cbcb97: [clang][AIX] Don't ignore XCOFF visibility by default (authored by daltenty). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://review

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

daltenty added a comment. In D122983#3464759 , @aaron.ballman wrote: > In D122983#3464724 , @Jake-Egan > wrote: > >> Hi, we also have a failure on AIX with test-suite `call to undeclared >> library function '%0

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

daltenty added a comment. Thanks for getting this fixed this so quickly and sorry for the messy revert. > What you're seeing is a symptom of a libc++ issue (PR12704) that was fixed > >10 years ago (rGbff1bfc6be0615ba3036a861fd27b75c96e3297c >

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

daltenty added a comment. In D123345#3460639 , @Jake-Egan wrote: > Hi, unfortunately there's a build failure on AIX: > https://lab.llvm.org/buildbot/#/builders/214/builds/779/steps/9/logs/stdio. > Could you take a look? Hi, any feedback on the AIX brea

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2512a875ccac: [clang] Adding Platform/Architecture Specific Resource Header Installation… (authored by qiongsiwu1, committed by daltenty). Repositor

[PATCH] D121709: [NFC][AIX] Disable precompiled module file test on AIX

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121709/new/ https://reviews.llvm.org/D121709 __

[PATCH] D117935: [AIX][clang] include_next through clang provided float.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27ee91162dd3: [AIX][clang] include_next through clang provided float.h (authored by daltenty). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D117935: [AIX][clang] include_next through clang provided float.h

daltenty updated this revision to Diff 404083. daltenty added a comment. Use more unique macro name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117935/new/ https://reviews.llvm.org/D117935 Files: clang/lib/Headers/float.h clang/test/Headers/Inputs/include/float.h clang/test/Hea

[PATCH] D118477: [NFC][AIX]Disable new pcm tests on AIX

daltenty accepted this revision. daltenty added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118477/new/ https://reviews.llvm.org/D118477 ___ cfe-commits mailing list cfe-commit

[PATCH] D118474: [NFC][AIX][clang] un-XFAIL gcc profile flag compat test

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9939bb668212: [NFC][AIX][clang] un-XFAIL gcc profile flag compat t

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

daltenty added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5204 /// Warn if a pointer or reference argument passed to a function points to an /// object that is less aligned than the parameter. This can happen when This function definitely se

[PATCH] D117935: [AIX][clang] include_next through clang provided float.h

daltenty updated this revision to Diff 402720. daltenty added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117935/new/ https://reviews.llvm.org/D117935 Files: clang/lib/Headers/float.h clang/test/Headers/Inputs/include/float.h clang/test/Header

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, with minor nit. Comment at: clang/test/ClangScanDeps/modules-pch-common-submodule.c:1 +// UNSUPPORTED: aix + Let's add a comment, to let folks know

[PATCH] D113428: [AIX] Define WCHAR_T_TYPE as unsigned int on 64-bit AIX for wchar.c test

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113428/new/ https://reviews.llvm.org/D113428 __

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

daltenty added a comment. > Making a change to whether a platform has __int128 affects the ABI of > libc++'s std::chrono::file_clock. We should make sure the mitigation patch is > posted and accepted. Good point, but the std::chrono::file_clock interface hasn't shipped yet on the platform libc

[PATCH] D110428: [AIX] Define WCHAR_T_TYPE as unsigned short on AIX for wchar.c test case.

daltenty added a comment. This doesn't appear to be true for 64-bit AIX: extern "C" int printf(const char *, ...); int main() { printf("wchar_t: %ld\nunsigned short: %ld\n",sizeof(wchar_t),sizeof(unsigned short)); return 0; } $ clang++ -m64 foo.cc $ ./a.out wchar_

[PATCH] D110431: Explicitly specify -fintegrated-as to clang/test/Driver/compilation_database.c test case.

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM (without the integrated assembler there will be an assembler invocation in the compilation database that actually produces the `.o` instead of the clang invocation we are looking for)

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f3925e25ae0: [clang][driver][AIX] Add system libc++ header paths to driver (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 372570. daltenty added a comment. - Fix additional test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/li

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 372566. daltenty added a comment. - Update check patttern to allow windows directory seperators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Dr

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:31 +// CHECK-INTERNAL-INCLUDE: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-INTERNAL-INCLUDE-CXX: "-internal-isystem" "[[SYSROOT]]/opt/IBM/openxlCSDK/include/c++/v1" +// CHECK-INTERNAL-INC

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 371078. daltenty added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:240-242 + case ToolChain::CST_Libstdcxx: +llvm::report_fatal_error( +"picking up libstdc++ headers is unimplemented on AIX"); ZarkoCA wrote: > nit: it would be my prefere

[PATCH] D109139: [AIX][RFC] Undefine __STDC_NO_ATOMICS__ to enable c11 atomics functionality

daltenty added a comment. For the missing library implementation, we may be able to use the implementation in compiler-rt. Seems like some other platforms do so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109139/new/ https://reviews.llvm.org/D1

[PATCH] D109139: [AIX][RFC] Undefine __STDC_NO_ATOMICS__ to enable c11 atomics functionality

daltenty added a comment. Hmm, I'm not sure that the limitations you outline in the description are the only problems that cause us to define the macro in the first place (though the lack of libc implementation was part of it). I'll try to dig up the original issues. Repository: rG LLVM Git

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, stevewan, ZarkoCA. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds the system libc++ header location to the driver. As well we defi

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

daltenty added a comment. In D105112#2850990 , @stevewan wrote: > I'm not familiar with `getCanonicalType()`, can you confirm whether it sees > through nested typedef's? Add a test case that hopefully will cover the case you intend Repository: rG LL

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

daltenty updated this revision to Diff 355741. daltenty added a comment. - Update test case with nested typedef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112 Files: clang/include/clang/Basic/LangOptio

[PATCH] D105242: [clang] Don't emit uninstantiated templates with -fdump-record-layouts-complete

daltenty created this revision. daltenty added a reviewer: stevewan. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A follow on to D104484 , this blocks the emitting of some template cases where

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

daltenty created this revision. daltenty added reviewers: stevewan, dexonsmith. Herald added a subscriber: dang. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option implies -fdump-record-layouts but dumps record layout info

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

This revision was automatically updated to reflect the committed changes. Closed by commit rG7942ebdf01b3: [clang] Add cc1 option for dumping layout for all complete types (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104484/n

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

daltenty updated this revision to Diff 353636. daltenty added a comment. - clang-format - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104484/new/ https://reviews.llvm.org/D104484 Files: clang/include/clang/Basic/LangOptions.de

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

daltenty created this revision. Herald added subscribers: dexonsmith, dang. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds an option which, in addition to dumping the record layout as is done by -fdump-record-layo

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

daltenty accepted this revision as: daltenty. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101323/new/ https://reviews.llvm.org/D101323 _

[PATCH] D99483: [clang][AIX] Define __STDC_NO_ATOMICS__ for c11 and above

daltenty created this revision. Herald added a subscriber: jfb. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The libc implementation on AIX does not have stdatomic.h and the requisite interfaces for c11 atomics, so for now it's

[PATCH] D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

daltenty accepted this revision. daltenty added inline comments. Comment at: clang/test/CodeGen/hidden-visibility.c:1 -// RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 %s -fvisibility default -emit-llvm -o - | FileCheck %s DiggerLin wrot

[PATCH] D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

daltenty added inline comments. Comment at: clang/test/CodeGen/hidden-visibility.c:1 -// RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 %s -fvisibility default -emit-llvm -o - | FileCheck %s dunno if this is also accepted, but I think we

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

daltenty added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3630 + // no -fvisibility=* option. + if (T.isOSAIX() && (Args.hasArg(OPT_mignore_xcoff_visibility) || + !Args.hasArg(OPT_fvisibility))) No sure if we int

[PATCH] D97574: [AIX][clang][driver] Restrict /usr/lib to internal library search paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG66799bf0e281: [AIX][clang][driver] Restrict /usr/lib to internal library search paths (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D97574: [AIX][clang][driver] Restrict /usr/lib to internal library search paths

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, stevewan, jasonliu. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding it to the general filepaths results in it being added to the linker argume

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:68 +Per = dyn_cast(F.getPersonalityFn()->stripPointerCasts()); + bool EmitEHBlock = + HasLandingPa

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:68 +Per = dyn_cast(F.getPersonalityFn()->stripPointerCasts()); + bool EmitEHBlock = + HasLandingPads || (F.hasPersonalityFn() && This logic seems very similar to th

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:889 + CompactUnwindSection = + Ctx->getXCOFFSection(".eh_info_table", XCOFF::StorageMappingClass::XMC_RW, + XCOFF::XTY_SD, SectionKind::getData()); jason

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:889 + CompactUnwindSection = + Ctx->getXCOFFSection(".eh_info_table", XCOFF::StorageMappingClass::XMC_RW, + XCOFF::XTY_SD, SectionKind::getData()); I thi

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:48 + const DataLayout &DL = MMI->getModule()->getDataLayout(); + const unsigned PointerSize = DL.getPointerSizeInBits() == 64 ? 8 : 4; + nit: Why not just call `getPointerS

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91361/new/ https://reviews.llvm.org/D91361 ___ cfe-commits mailing list cf

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137 -if (D.CCCIsCXX()) +if (D.CCCIsCXX() || D.CCCIsCC()) CmdArgs.push_back(Args.MakeArgString( Xiangling_L wrote: > daltenty wrote: > > I think that rather that addin

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137 -if (D.CCCIsCXX()) +if (D.CCCIsCXX() || D.CCCIsCC()) CmdArgs.push_back(Args.MakeArgString( I think that rather that adding CC, we should just pull the if and unc

[PATCH] D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. Thanks! I've verified this fixes the test on AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89904/new/ https://reviews.llvm.org/D89904

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty added a comment. In D89696#2344797 , @jhuber6 wrote: > In D89696#2344753 , @daltenty wrote: > >> In D89696#2344508 , @jhuber6 wrote: >> >>> @daltenty Do you think th

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty added a comment. In D89696#2344508 , @jhuber6 wrote: > @daltenty Do you think this will fix the problem on AIX? It's not just AIX that will have this problem I suspect. If you configure any cross-compiling build with a 64-bit host, targeting a 3

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

daltenty added inline comments. Comment at: clang/test/OpenMP/driver-openmp-target.c:2 +// REQUIRES: x86-registered-target +// REQUIRES: clang-64-bits +// RUN: %clang %s -c -E -dM -fopenmp=libomp -fopenmp-version=45 -fopenmp-targets=x86_64-unknown-unknown -o - | FileCheck --che

[PATCH] D87451: add new option -mignore-xcoff-visibility

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, other minor nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/ https://reviews.llvm.org/D87451

[PATCH] D87451: add new option -mignore-xcoff-visibility

daltenty added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2622 + +Do not emit any visibility attribute for asm on AIX or give all symbols 'unspecified' visibility in xcoff object file (XCOFF only) + nit: plural. capitalization. =

[PATCH] D87451: add new option -mignore-xcoff-visibility

daltenty added inline comments. Comment at: llvm/lib/CodeGen/CommandFlags.cpp:339 + "ignore-xcoff-visibility", + cl::desc("Not emit the visibility attribute for asm in AIX OS or give " + "all symbols 'unspecified' visibility in xcoff object file"), ---

[PATCH] D87451: add new option ignore-xcoff-visibility

daltenty added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2622 + +Do not emit any visibility attribute for asm on AIX or give all symbols 'unspecified' visibility in xcoff object file(XCOFF only) + nit: add a space before parens

[PATCH] D88500: [AIX][Clang][Driver] Link libm in c++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGafc277b0ed0d: [AIX][Clang][Driver] Link libm in c++ mode (authored by daltenty). Changed prior to commit: https://reviews.llvm.org/D88500?vs=295111&id=295355#toc Repository: rG LLVM Github Monorepo

[PATCH] D88500: [AIX][Clang][Driver] Link libm in c++ mode

daltenty updated this revision to Diff 295111. daltenty marked an inline comment as done. daltenty added a comment. - Make dependant on just c++ mode - Add missing colons Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88500/new/ https://reviews.llvm

[PATCH] D88500: [AIX][Clang][Driver] Link libm when we would libc++

daltenty updated this revision to Diff 295107. daltenty added a comment. - Add blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88500/new/ https://reviews.llvm.org/D88500 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix

[PATCH] D88500: [AIX][Clang][Driver] Link libm when we would libc++

daltenty updated this revision to Diff 295105. daltenty added a comment. - Remove deps comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88500/new/ https://reviews.llvm.org/D88500 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Drive

[PATCH] D88500: [AIX][Clang][Driver] Link libm along with libc++

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, DiggerLin. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. since libc++ has dependencies on libm. Repository: rG LLVM Github Monorepo https://re

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

This revision was automatically updated to reflect the committed changes. Closed by commit rGee80615b5c1c: [clang][driver][AIX] Set compiler-rt as default rtlib (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88182/new/ https:/

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

daltenty updated this revision to Diff 294822. daltenty added a comment. - Remove blankline - Fix path seperators in second test as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88182/new/ https://reviews.llvm.org/D88182 Files: clang/lib/Dr

  1   2   >