Re: [PATCH] D48721: Patch to fix pragma metadata for do-while loops

2018-06-28 Thread Deepak Panickal via cfe-commits
I had based it on the other tests in clang/test/CodeGen. Do we not need the `-o` to output to standard output? Or did you mean something else? On Thu, Jun 28, 2018 at 10:25 PM Roman Lebedev via Phabricator < revi...@reviews.llvm.org> wrote: > lebedev.ri added a comment. > > I'm not sure we can us

Re: [PATCH] D48721: Patch to fix pragma metadata for do-while loops

2018-06-28 Thread Deepak Panickal via cfe-commits
> > Phab is the correct way to submit patches. > But having a bugreport in bugzilla is good too. > But the test will be needed regardless of the patch submission method. > And yes, please do always upload all patches with full context (`-U9`). Sorry about the context. Can I add the test file

Re: [PATCH] D48721: Patch to fix pragma metadata for do-while loops

2018-06-28 Thread Deepak Panickal via cfe-commits
It's a patch for a bug in clang. I have requested for a Bugzilla account, however thought of putting up the patch in the meantime. Do I need to mark it '[Private]'? On Thu, Jun 28, 2018 at 2:41 PM Roman Lebedev via Phabricator < revi...@reviews.llvm.org> wrote: > lebedev.ri added a comment. > > T