Author: dzobnin
Date: Wed May 25 06:32:42 2016
New Revision: 270686
URL: http://llvm.org/viewvc/llvm-project?rev=270686&view=rev
Log:
[ms][dll] #26935 Defining a dllimport function should cause it to be exported
If we have some function with dllimport attribute and then we have the function
defin
Author: dzobnin
Date: Fri Apr 29 17:50:16 2016
New Revision: 268129
URL: http://llvm.org/viewvc/llvm-project?rev=268129&view=rev
Log:
[NFC] Initialize a variable to make buildbot green.
In r268085 "[MS] Make #pragma pack use PragmaStack<> class." there was an
uninitialized variable 'Alignment', w
Author: dzobnin
Date: Fri Apr 29 13:17:40 2016
New Revision: 268085
URL: http://llvm.org/viewvc/llvm-project?rev=268085&view=rev
Log:
[MS] Make #pragma pack use PragmaStack<> class.
Make implementation of #pragma pack consistent with other "stack" pragmas.
Use PragmaStack<> class instead of old r
d.zobnin.bugzilla added inline comments.
Comment at: lib/Sema/SemaAttr.cpp:277-278
@@ -276,4 @@
- // empty.
- Diag(PragmaLoc, diag::warn_pragma_pop_failed)
- << "pack" << (Name ? "no record matching name" : "stack empty");
-
Here I removed the "
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added a reviewer: rnk.
d.zobnin.bugzilla added subscribers: thakis, cfe-commits.
An attempt to make implementation of #pragma pack consistent with other "stack"
pragmas. Also modifies #pragma options align, since it shares the stack with
d.zobnin.bugzilla updated this revision to Diff 55581.
d.zobnin.bugzilla added a comment.
Herald added a subscriber: joker.eph.
Updated the patch after r266292 commit: [ASTImporter] Implement some
expression-related AST node import.
http://reviews.llvm.org/D18700
Files:
include/clang/AST/Stm
d.zobnin.bugzilla added a comment.
Reid, thanks for review! I've changed the patch according to your comments and
also moved implementation of RAII object to SemaAttr.cpp file (implementation
in header broke many buildbots).
Nico, I will look at serialization and try to implement the desired be
Author: dzobnin
Date: Fri Apr 29 06:27:00 2016
New Revision: 268029
URL: http://llvm.org/viewvc/llvm-project?rev=268029&view=rev
Log:
Recommit "[MS] Improved implementation of stack pragmas (vtordisp, *_seg)"
Slightly updated version, double-checked build and tests.
Improve implementation of MS p
Author: dzobnin
Date: Thu Apr 28 06:32:10 2016
New Revision: 267870
URL: http://llvm.org/viewvc/llvm-project?rev=267870&view=rev
Log:
Revert "[MS] Improved implementation of MS stack pragmas (vtordisp, *_seg)"
This reverts commit r267866.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
cfe
Author: dzobnin
Date: Thu Apr 28 05:13:18 2016
New Revision: 267866
URL: http://llvm.org/viewvc/llvm-project?rev=267866&view=rev
Log:
[MS] Improved implementation of MS stack pragmas (vtordisp, *_seg)
Rework implementation of several MS pragmas that use internal stack:
vtordisp, {bss|code|const|d
d.zobnin.bugzilla added a comment.
This is just a weekly friendly ping.
Please take a look at the new patch!
Thank you,
Denis Zobnin
http://reviews.llvm.org/D18700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added a reviewer: rnk.
d.zobnin.bugzilla added a subscriber: cfe-commits.
This patch attempts to improve implementation of several MS pragmas that use
stack (vtordisp, { bss | code | const | data }_seg) and fix some compatibility
issues.
Author: dzobnin
Date: Thu Apr 21 05:59:18 2016
New Revision: 266976
URL: http://llvm.org/viewvc/llvm-project?rev=266976&view=rev
Log:
Correctly parse GCC-style asm line following MS-style asm line.
Quit parsing MS-style inline assembly if the following statement has GCC style.
Enables compilation
d.zobnin.bugzilla added a comment.
Richard, Eric,
Please take a look at the patch.
Thank you,
Denis Zobnin
http://reviews.llvm.org/D18652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
d.zobnin.bugzilla added a comment.
Friendly ping, please take a look.
Thank you,
Denis Zobnin
http://reviews.llvm.org/D18657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
d.zobnin.bugzilla marked an inline comment as done.
d.zobnin.bugzilla added a comment.
Friendly ping, please take a look.
Thank you,
Denis Zobnin
http://reviews.llvm.org/D18700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
d.zobnin.bugzilla added a comment.
Richard, please let me know what in your opinion we should do with this
revision.
Thank you,
Denis Zobnin
http://reviews.llvm.org/D18698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
d.zobnin.bugzilla added a reviewer: rsmith.
d.zobnin.bugzilla removed a subscriber: rsmith.
d.zobnin.bugzilla updated this revision to Diff 53543.
d.zobnin.bugzilla added a comment.
Richard, thank you for the review!
I've created a static function to check if this is a GCC asm statement as you
r
d.zobnin.bugzilla updated this revision to Diff 53414.
d.zobnin.bugzilla added a comment.
John, thanks for the review!
Please take a look at the updated patch -- did I understand your comments
correctly?
The test passes and ds2 application is compiled successfully.
Thank you,
Denis Zobnin
htt
d.zobnin.bugzilla updated this revision to Diff 53400.
d.zobnin.bugzilla added a comment.
Eric, thank you for the review!
I've renamed the test, but have also made it a .cpp file for the reasons
described below.
You are right -- GCC looks at "target" attribute applied to the function in
which
d.zobnin.bugzilla added a comment.
Friendly ping, please take a look.
Thank you,
Denis Zobnin
http://reviews.llvm.org/D18657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
d.zobnin.bugzilla added a comment.
Richard, thank you for the review and explanation!
I don't have any examples of useful code using this extension, I was trying to
fix the PR... So, do you think we should add this GCC extension to Clang (with
a proper warning, of course) for compatibility reaso
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added a reviewer: echristo.
d.zobnin.bugzilla added a subscriber: cfe-commits.
Handle an inline assembly feature of GCC: code prefixed with "%v", e. g.
"%vpcmpestri" is transformed into "vpcmpestri" instruction if target supports
AVX and
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added a reviewer: rsmith.
d.zobnin.bugzilla added a subscriber: cfe-commits.
Treat _Atomic pointers as pointer types (check value type of AtomicType) in
case of handling the "restrict" qualifier. Accept such code (so does GCC):
int * res
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added reviewers: doug.gregor, rjmccall.
d.zobnin.bugzilla added a subscriber: cfe-commits.
If new function is missing empty exception specification "throw()" and
"throw()" came from system header, don't emit errors. It is already implemen
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added a reviewer: echristo.
d.zobnin.bugzilla added a subscriber: cfe-commits.
Clang fails to compile the following code:
void f() {
__asm mov ebx, ecx
__asm__("movl %ecx, %edx");
}
reporting unexpected token "__asm__" at start of st
Author: dzobnin
Date: Thu Feb 11 05:26:03 2016
New Revision: 260510
URL: http://llvm.org/viewvc/llvm-project?rev=260510&view=rev
Log:
[MCU] Fix assertion failure on function returning empty union.
Treat empty struct/union in return type as void for MCU ABI. PR26438.
Differential Revision: http:/
Author: dzobnin
Date: Wed Feb 10 05:23:48 2016
New Revision: 260373
URL: http://llvm.org/viewvc/llvm-project?rev=260373&view=rev
Log:
Fix assertion "Chunk.Kind == DeclaratorChunk::Function" with attributed type.
This patch is to upgrade FunctionTypeUnwrapper for correct processing of
AttributedTy
d.zobnin.bugzilla updated this revision to Diff 47333.
d.zobnin.bugzilla added a comment.
Thank you for your reply!
Added a check for empty struct/union to treat them as void, updated the test
accordingly.
Please take a look.
http://reviews.llvm.org/D16808
Files:
lib/CodeGen/TargetInfo.cpp
d.zobnin.bugzilla added a comment.
Thank you for the review!
David, I started from the assertion failure and was going up the call stack
trying to understand what should be changed to make the assertion go away. In
shouldReturnTypeInRegister() function there is isRegisterSize(Size) check for
i
d.zobnin.bugzilla marked 2 inline comments as done.
d.zobnin.bugzilla added a comment.
@thakis, it is needed to be able to compile SPEC2000: 255.vortex.
http://reviews.llvm.org/D16770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
d.zobnin.bugzilla marked 5 inline comments as done.
Comment at: include/clang/AST/ASTContext.h:1772-1783
@@ -1771,1 +1771,14 @@
+ /// Return true is the given typedef types are compatible in C from MSVC's
+ /// point of view.
+ //
+ // Conditions:
+ // 1. Both typedef typ
d.zobnin.bugzilla updated this revision to Diff 46781.
d.zobnin.bugzilla added a comment.
Thanks for the review!
Updated the patch according to the comments: allowed only integer, enum and
pointer types which have the same qualifiers, signedness, width and alignment.
Changed the diagnostic text
Author: dzobnin
Date: Tue Feb 2 11:33:09 2016
New Revision: 259532
URL: http://llvm.org/viewvc/llvm-project?rev=259532&view=rev
Log:
PR23057: Fix assertion `Val && "isa<> used on a null pointer"' on invalid
for-range expression.
Fix the issue discovered by fuzzing (PR23057, comment 18) by handl
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added reviewers: mkuper, rnk, DavidKreitzer.
d.zobnin.bugzilla added a subscriber: cfe-commits.
Add missing check for zero-sized type for MCU ABI in order to return zero-sized
types (empty structs and unions) via memory.
http://reviews.l
Author: dzobnin
Date: Tue Feb 2 07:50:39 2016
New Revision: 259497
URL: http://llvm.org/viewvc/llvm-project?rev=259497&view=rev
Log:
Fix for PR8901: attribute "mode" rejected for enums and dependent types.
Allow "mode" attribute for enum types, except for vector modes, for
compatibility with GC
Author: dzobnin
Date: Tue Feb 2 06:39:08 2016
New Revision: 259492
URL: http://llvm.org/viewvc/llvm-project?rev=259492&view=rev
Log:
Test commit (NFC).
Modified:
cfe/trunk/test/CodeGenCXX/alignment.cpp
Modified: cfe/trunk/test/CodeGenCXX/alignment.cpp
URL:
http://llvm.org/viewvc/llvm-proje
d.zobnin.bugzilla added inline comments.
Comment at: lib/Parse/ParseStmt.cpp:1719-1724
@@ -1718,6 +1718,8 @@
if (ForRange) {
+ExprResult CorrectedRange =
+Actions.CorrectDelayedTyposInExpr(ForRangeInit.RangeExpr.get());
ForRangeStmt = Actions.ActOnCXXForRangeSt
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added reviewers: rnk, majnemer.
d.zobnin.bugzilla added a subscriber: cfe-commits.
Allow typedef redefinition with different types in C if the types are equally
qualified, sized and aligned. MSVC allows such redefinition, emits warning
C
d.zobnin.bugzilla updated this revision to Diff 46521.
d.zobnin.bugzilla added a comment.
Thanks for the review!
Only updated the text of diagnostics, NFC.
http://reviews.llvm.org/D16219
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Attr
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added reviewers: kcc, rsmith.
d.zobnin.bugzilla added a subscriber: cfe-commits.
Fix the issue discovered by fuzzing
(https://llvm.org/bugs/show_bug.cgi?id=23057#c18) by handling nullptr in
Sema::ActOnCXXForRangeDecl and correct delayed
d.zobnin.bugzilla added a comment.
Friendly ping, please take a look.
http://reviews.llvm.org/D16219
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
d.zobnin.bugzilla updated this revision to Diff 45401.
d.zobnin.bugzilla added a comment.
Updated the patch after committed fix for http://reviews.llvm.org/D16301
(r258213).
This patch:
1. Adds "Enum" Subject to 'mode' attribute to be able to compile code like
"typedef enum { X } __attribute__
d.zobnin.bugzilla added a subscriber: ABataev.
d.zobnin.bugzilla added a comment.
I am going to ask @ABataev to commit this. Hope to get commit access soon (this
is my 5th patch) :)
http://reviews.llvm.org/D16216
___
cfe-commits mailing list
cfe-co
d.zobnin.bugzilla updated this revision to Diff 45295.
d.zobnin.bugzilla added a comment.
Thank you for the review! Updated the patch: parser now skips the rest of the
initializers if the previous one was invalid, added several checks to the test.
http://reviews.llvm.org/D16216
Files:
lib/Pa
d.zobnin.bugzilla abandoned this revision.
d.zobnin.bugzilla added a comment.
This issue is fixed in http://reviews.llvm.org/rL253926.
http://reviews.llvm.org/D13285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added a reviewer: aaron.ballman.
d.zobnin.bugzilla added a subscriber: cfe-commits.
Allow "mode" attribute for enum types, except for vector modes, for
compatibility with GCC. Support "mode" attribute with dependent types.
http://reviews
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added reviewers: kcc, rsmith.
d.zobnin.bugzilla added a subscriber: cfe-commits.
Fix for a case found by fuzzing PR23057 (comment #33
https://llvm.org/bugs/show_bug.cgi?id=23057#c33). Diagnose and consume
unexpected ::new and ::delete to
d.zobnin.bugzilla updated this revision to Diff 44859.
d.zobnin.bugzilla added a comment.
Thanks for the review! Updated the patch: added Subjects line for the attribute
and removed the "err_attr_wrong_decl" diagnostics.
http://reviews.llvm.org/D16112
Files:
include/clang/AST/Decl.h
includ
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added a reviewer: aaron.ballman.
d.zobnin.bugzilla added a subscriber: cfe-commits.
Allow "mode" attribute to be applied to VarDecl, not ValueDecl (which includes
FunctionDecl and EnumConstantDecl), emit an error if this attribute is used
d.zobnin.bugzilla added inline comments.
Comment at: test/SemaCXX/pragma-vtordisp.cpp:34-35
@@ -33,6 +33,4 @@
struct C {
-// FIXME: Our implementation based on token insertion makes it impossible for
-// the pragma to appear everywhere we should support it.
-//#pragma vtordisp(
d.zobnin.bugzilla updated this revision to Diff 40380.
d.zobnin.bugzilla added a comment.
Only tests have been updated: enabled a test case for Sema, which pass with
these changes, added corresponding test case for CodeGen.
http://reviews.llvm.org/D14467
Files:
include/clang/Sema/Sema.h
li
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added a reviewer: rnk.
d.zobnin.bugzilla added a subscriber: cfe-commits.
This patch adds support of #pragma vtordisp inside functions in attempt to
improve compatibility. Microsoft compiler appears to save the stack of vtordisp
modes on
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added reviewers: rsmith, rjmccall.
d.zobnin.bugzilla added a subscriber: cfe-commits.
This patch fixes an assertion failure, caused by EmitCall function producing
llvm::InvokeInst* when llvm::CallInst* is needed (when multiplication of
c
54 matches
Mail list logo
