[PATCH] D152522: [NFC][SetVector] Update some usages of SetVector to SmallSetVector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e580b7edd15: [NFC][SetVector] Update some usages of SetVector to SmallSetVector (authored by 0xdc03). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D152522: [NFC][SetVector] Update some usages of SetVector to SmallSetVector

0xdc03 created this revision. 0xdc03 added a reviewer: nikic. Herald added subscribers: ChuanqiXu, StephenFan, haicheng, hiraditya, MatzeB. Herald added a project: All. 0xdc03 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. In D143803#4171728 , @erichkeane wrote: > Not thrilled about 'mangled name' still, but I can't think of anything better > after all this time, so LGTM. Oh wow your reply was much faster than I expected 😅. If you can, please land

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. Okay, I have now modified the diagnostic to look like this: ../bug/ifunc-#59164.cpp:17:16: error: ifunc must point to a defined function __attribute__((ifunc("resolver"))) ^ ../bug/ifunc-#59164.cpp:17:16: note: the function specified in an ifunc must

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 updated this revision to Diff 502660. 0xdc03 added a comment. - Reword the diagnostic messages - Refactor tests to match updated diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143803/new/ https://reviews.llvm.org/D143803 Files:

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. In D143803#4155266 , @erichkeane wrote: > I think updating that test with this additional note is the right thing to do. Will do, will also add checks for the fix-its. > As far as that note, saying 'mangled name' is perhaps not

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. Okay, I have now modified the diagnostic to look something like (as per the discussion at https://discord.com/channels/636084430946959380/636732781086638081/1079356357024694363): ../../bug/ifunc-#59164.cpp:17:16: error: ifunc must point to a defined function __attri

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 updated this revision to Diff 500715. 0xdc03 edited the summary of this revision. 0xdc03 added a comment. - Update to address reviewer comments - Add release note - Redo notes to match reviewer comments - Make the fix-it highlight the whole attribute - Update tests to check new diagnostics

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. I will try to come up with a better diagnostic for this issue and will try and update the patch as soon as I can. In D143803#4150423 , @aaron.ballman wrote: > Btw, these changes should come with a release note as well. Are all

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. nudge! at anyone who knows what to do here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143803/new/ https://reviews.llvm.org/D143803 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. Note that as it stands currently, this patch cannot be committed because the test `clang/test/SemaCXX/externc-ifunc-resolver.cpp` fails to run. The contents of the test are as follows: // RUN: %clang_cc1 -emit-llvm-only -triple x86_64-linux-gnu -verify %s extern "

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 created this revision. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. 0xdc03 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When an alias or ifunc attribute refers to a function name that is mangled, a di