[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

d-smirnov added a comment. We have some improvements with the patch, most notable: 549.fotonik_3d improves about 6%. @nikic Should we revert the patch and try another location for it (in LICM pass, as you previously suggested)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

d-smirnov marked an inline comment as done. d-smirnov added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 ___ cfe-commits mailing list cfe-

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

d-smirnov updated this revision to Diff 557609. d-smirnov added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 Files: clang/test/CodeGenCXX/microsoft-abi-dynamic-cast.cpp llvm/lib/

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

d-smirnov marked an inline comment as done. d-smirnov added a comment. @nikic Amended. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 ___ cfe-commits mailing l

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

d-smirnov updated this revision to Diff 557538. d-smirnov marked 2 inline comments as done. d-smirnov added a comment. amended Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 Files: clang/test/CodeGenCX

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

d-smirnov updated this revision to Diff 557537. d-smirnov added a comment. amended Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 Files: clang/test/CodeGenCXX/microsoft-abi-dynamic-cast.cpp llvm/lib/

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

d-smirnov added a comment. @nikic Updated. Please review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

d-smirnov updated this revision to Diff 557187. d-smirnov added a comment. comment updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 Files: clang/test/CodeGenCXX/microsoft-abi-dynamic-cast.cpp l

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Reassociate loop invariant GEP index calculations.

d-smirnov marked an inline comment as done. d-smirnov added a comment. updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 ___ cfe-commits mailing list cfe-

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Reassociate loop invariant GEP index calculations.

d-smirnov updated this revision to Diff 557138. d-smirnov marked 3 inline comments as done. d-smirnov added a comment. Reordered and removed extra check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 Fil

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Reassociate loop invariant GEP index calculations.

d-smirnov updated this revision to Diff 557128. d-smirnov added a comment. Amended Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 Files: clang/test/CodeGenCXX/microsoft-abi-dynamic-cast.cpp llvm/lib/

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Reassociate loop invariant GEP index calculations.

d-smirnov added a comment. @nikic Could you check out the updated code to make sure we're on the right track before I try to fix the rest of the unit tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Reassociate loop invariant GEP index calculations.

d-smirnov updated this revision to Diff 556894. d-smirnov added a comment. unit test fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 Files: clang/test/CodeGen/SystemZ/systemz-inline-asm-03.c cla

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Reassociate loop invariant GEP index calculations.

d-smirnov updated this revision to Diff 556884. d-smirnov added a comment. updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 Files: clang/test/CodeGenCXX/microsoft-abi-dynamic-cast.cpp llvm/lib/

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Reassociate loop invariant GEP index calculations.

d-smirnov updated this revision to Diff 556881. d-smirnov added a comment. Herald added subscribers: cfe-commits, wangpc, zzheng. Herald added a project: clang. Relaxed checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://review