[PATCH] D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line""

dchai updated this revision to Diff 198585. dchai added a comment. This revision is now accepted and ready to land. no-op to try to get rid of "Changes Planned" state Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60661/new/ https://reviews.llvm.org/D60661 Files:

[PATCH] D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line""

dchai planned changes to this revision. dchai added a comment. Hi, can someone please merge this on my behalf? I don't have commit access. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60661/new/ https://reviews.llvm.org/D60661 ___

[PATCH] D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line""

dchai added a comment. Friendly ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60661/new/ https://reviews.llvm.org/D60661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line""

dchai created this revision. dchai added a reviewer: krasimir. Herald added a project: clang. Herald added a subscriber: cfe-commits. Top-level "package" and "import" statements should generally be kept on one line, for all languages. This reverts commit rL356912

[PATCH] D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive

dchai removed a subscriber: cfe-commits. dchai added a comment. Can someone please merge this for me? I don't have commit access. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60541/new/ https://reviews.llvm.org/D60541

[PATCH] D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive

dchai created this revision. dchai added a reviewer: krasimir. Herald added a project: clang. Herald added a subscriber: cfe-commits. AnnotatingParser::next() is needed to implicitly set TT_BlockComment versus TT_LineComment. On most other paths through AnnotatingParser::parseLine(), all tokens a

[PATCH] D59627: [clang-format] Keep protobuf "package" statement on one line

dchai added a comment. Just to confirm, the regression is in the number of spaces before a trailing comment? Before (2 spaces): package foo.bar; // foo.bar package After (1 space): package foo.bar; // foo.bar package Top-level options are handled the same way. I'll see if I can address

[PATCH] D59629: [clang-format] correctly format protobuf fields named "enum".

dchai added a comment. I don't have commit access; can someone please merge this on my behalf? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59629/new/ https://reviews.llvm.org/D59629 ___ cfe-commits mailing list cfe

[PATCH] D59627: [clang-format] Keep protobuf "package" statement on one line

dchai updated this revision to Diff 191734. dchai added a comment. Use "isOneOf" instead of two calls to "is". Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59627/new/ https://reviews.llvm.org/D59627 Files: lib/Format/TokenAnnotator.cpp unittests/Format/Form

[PATCH] D59629: [clang-format] correctly format protobuf fields named "enum".

dchai created this revision. dchai added a reviewer: krasimir. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to TypeScript, "enum" is not a reserved word. Repository: rC Clang https://reviews.llvm.org/D59629 Files: lib/Format/UnwrappedLineParser.cpp unitt

[PATCH] D59627: [clang-format] Keep protobuf "package" statement on one line

dchai created this revision. dchai added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Top-level "package" and "import" statements should generally be kept on one line, for all languages. Repository: rC Clang https://reviews.llvm.org/D59627 Fil