This revision was automatically updated to reflect the committed changes.
Closed by commit rL286599: Fix mismatched enum value name and diagnostic text.
(authored by dougk).
Changed prior to commit:
https://reviews.llvm.org/D26459?vs=77367=77624#toc
Repository:
rL LLVM
Author: dougk
Date: Fri Nov 11 10:51:40 2016
New Revision: 286599
URL: http://llvm.org/viewvc/llvm-project?rev=286599=rev
Log:
Fix mismatched enum value name and diagnostic text.
ExpectedFunctionGlobalVarMethodOrProperty
would previously say "functions and global variables"
instead of
dougk added a comment.
Also note: In this change, the diagnostic messages are correct; it's the enum
name that's bad. The diagnostic message is wrong for the 'section' attribute,
which is fixed by https://reviews.llvm.org/D26459
https://reviews.llvm.org/D26454
dougk updated this revision to Diff 77367.
dougk added a comment.
inadvertent omission of attr-section.c test
https://reviews.llvm.org/D26459
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/AttributeList.h
test/Sema/attr-section.c
dougk created this revision.
dougk added a reviewer: aaron.ballman.
dougk added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
ExpectedFunctionGlobalVarMethodOrProperty would previously say "functions and
global variables" instead of "functions, methods, properties, and global
Author: dougk
Date: Wed Nov 9 11:02:07 2016
New Revision: 286380
URL: http://llvm.org/viewvc/llvm-project?rev=286380=rev
Log:
[Sparc] Unbreak test
Modified:
cfe/trunk/test/CodeGen/atomics-inlining.c
Modified: cfe/trunk/test/CodeGen/atomics-inlining.c
URL:
dougk created this revision.
dougk added a reviewer: aaron.ballman.
dougk added a subscriber: cfe-commits.
This was already submitted as r284272.
Regarding the use of Attr as a local variable name, I would prefer to remain
consistent with the existing code in CodeGenFunction.cpp which was not
will do. I'll initiate a review for the original change and a new one for
the suggestions.
The ExpectedFunctionGlobalVarMethodOrProperty diagnostic was essentially a
copy-and-paste from here:
def Alias : Attr {
let Spellings = [GCC<"alias">];
let Args = [StringArgument<"Aliasee">];
let
Author: dougk
Date: Wed Nov 9 09:43:51 2016
New Revision: 286376
URL: http://llvm.org/viewvc/llvm-project?rev=286376=rev
Log:
[Sparc] LLONG is not lock-free atomic on v8
Differential Revision: https://reviews.llvm.org/D26286
Modified:
cfe/trunk/lib/Basic/Targets.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286376: [Sparc] LLONG is not lock-free atomic on v8
(authored by dougk).
Changed prior to commit:
https://reviews.llvm.org/D26286?vs=76879=77353#toc
Repository:
rL LLVM
at 7:19 PM, Kostya Serebryany <k...@google.com> wrote:
> ping
>
> On Mon, Oct 17, 2016 at 5:57 PM, Kostya Serebryany <k...@google.com> wrote:
>
>> Did you code-review this?
>> (sorry if I missed it)
>>
>> On Fri, Oct 14, 2016 at 12:55 PM, Douglas Katz
dougk updated this revision to Diff 76879.
dougk added a comment.
fix atomics-inlining test
https://reviews.llvm.org/D26286
Files:
lib/Basic/Targets.cpp
test/CodeGen/atomics-inlining.c
test/Preprocessor/init.c
Index: test/Preprocessor/init.c
dougk created this revision.
dougk added a reviewer: jyknight.
dougk added a subscriber: cfe-commits.
https://reviews.llvm.org/D26286
Files:
lib/Basic/Targets.cpp
test/Preprocessor/init.c
Index: test/Preprocessor/init.c
===
Author: dougk
Date: Tue Oct 25 18:02:30 2016
New Revision: 285140
URL: http://llvm.org/viewvc/llvm-project?rev=285140=rev
Log:
[Myriad] Find libc++ adjacent to libstdc++
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/Tools.cpp
Author: dougk
Date: Wed Oct 19 12:30:40 2016
New Revision: 284617
URL: http://llvm.org/viewvc/llvm-project?rev=284617=rev
Log:
[Myriad] Find libc++ headers next to clang binary
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/test/Driver/myriad-toolchain.c
Modified:
Author: dougk
Date: Fri Oct 14 14:55:09 2016
New Revision: 284272
URL: http://llvm.org/viewvc/llvm-project?rev=284272=rev
Log:
Implement no_sanitize_address for global vars
Modified:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Author: dougk
Date: Fri Oct 7 16:02:38 2016
New Revision: 283601
URL: http://llvm.org/viewvc/llvm-project?rev=283601=rev
Log:
Visually align table def with respective enum. NFC
'warn_attribute_wrong_decl_type' has to stay in sync with
'enum AttributeDeclKind' which is much easier when they line
Author: dougk
Date: Thu Sep 29 14:59:12 2016
New Revision: 282757
URL: http://llvm.org/viewvc/llvm-project?rev=282757=rev
Log:
[Myriad] Silently ignore -fno-split-dwarf-inlining
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/myriad-toolchain.c
Modified:
Author: dougk
Date: Fri Sep 9 13:20:49 2016
New Revision: 281071
URL: http://llvm.org/viewvc/llvm-project?rev=281071=rev
Log:
Myriad: nominally "support" ASAN.
Doesn't work, but needs to be enabled in order to get there.
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
Author: dougk
Date: Mon Jul 25 11:36:02 2016
New Revision: 276646
URL: http://llvm.org/viewvc/llvm-project?rev=276646=rev
Log:
[Myriad]: better compatibility with vendor source
- Accept ma{2100,2150,2150} for -mcpu
- Define more preprocessor macros
- Don't append "le/" to little-endian lib dirs
Author: dougk
Date: Mon May 9 14:09:59 2016
New Revision: 268956
URL: http://llvm.org/viewvc/llvm-project?rev=268956=rev
Log:
[Myriad] Use Generic_ELF::addClangTargetOptions()
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/ToolChains.h
Author: dougk
Date: Tue Apr 19 13:55:53 2016
New Revision: 266797
URL: http://llvm.org/viewvc/llvm-project?rev=266797=rev
Log:
Fix PR26999 better- RenderDebugEnablingArgs() once only
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
Author: dougk
Date: Tue Apr 19 12:43:54 2016
New Revision: 266775
URL: http://llvm.org/viewvc/llvm-project?rev=266775=rev
Log:
Pass dwarf-version to cc1as.
Fix PR26999 - crashing in cc1as with any '*bsd' target.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/save-temps.c
Author: dougk
Date: Tue Mar 15 17:34:02 2016
New Revision: 263596
URL: http://llvm.org/viewvc/llvm-project?rev=263596=rev
Log:
Myriad: define __myriad2 macro automatically
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/Driver/myriad-toolchain.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263556: Myriad: Pass -mcpu to movi{Compile,Asm} (authored by
dougk).
Changed prior to commit:
http://reviews.llvm.org/D18186?vs=50739=50748#toc
Repository:
rL LLVM
http://reviews.llvm.org/D18186
Author: dougk
Date: Tue Mar 15 11:41:31 2016
New Revision: 263556
URL: http://llvm.org/viewvc/llvm-project?rev=263556=rev
Log:
Myriad: Pass -mcpu to movi{Compile,Asm}
Differential Revision: http://reviews.llvm.org/D18186
Modified:
cfe/trunk/lib/Driver/Tools.cpp
dougk updated this revision to Diff 50739.
dougk added a comment.
also moviAsm
http://reviews.llvm.org/D18186
Files:
lib/Driver/Tools.cpp
test/Driver/myriad-toolchain.c
Index: test/Driver/myriad-toolchain.c
===
---
dougk created this revision.
dougk added a reviewer: jyknight.
dougk added a subscriber: cfe-commits.
http://reviews.llvm.org/D18186
Files:
lib/Driver/Tools.cpp
test/Driver/myriad-toolchain.c
Index: test/Driver/myriad-toolchain.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256897: Avoid assert failure on some invalid cc1 options.
(authored by dougk).
Changed prior to commit:
http://reviews.llvm.org/D15882?vs=43958=44074#toc
Repository:
rL LLVM
Author: dougk
Date: Tue Jan 5 19:37:57 2016
New Revision: 256897
URL: http://llvm.org/viewvc/llvm-project?rev=256897=rev
Log:
Avoid assert failure on some invalid cc1 options.
Addressing review comment in D13221.
Differential Revision: http://reviews.llvm.org/D15882
Modified:
dougk created this revision.
dougk added reviewers: thakis, probinson.
dougk added a subscriber: cfe-commits.
Something like this was suggested in http://reviews.llvm.org/D13221
http://reviews.llvm.org/D15882
Files:
lib/Frontend/CompilerInvocation.cpp
test/Driver/debug-options.c
Index:
Author: dougk
Date: Thu Nov 19 22:58:12 2015
New Revision: 253647
URL: http://llvm.org/viewvc/llvm-project?rev=253647=rev
Log:
[Myriad]: handle Preprocess job action (-E)
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/Tools.cpp
Author: dougk
Date: Wed Nov 18 10:24:46 2015
New Revision: 253467
URL: http://llvm.org/viewvc/llvm-project?rev=253467=rev
Log:
[Myriad]: insert -L paths into linker cmd only when they exist.
Differential Revision: http://reviews.llvm.org/D14754
Added:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253467: [Myriad]: insert -L paths into linker cmd only when
they exist. (authored by dougk).
Changed prior to commit:
http://reviews.llvm.org/D14754?vs=40442=40516#toc
Repository:
rL LLVM
Author: dougk
Date: Tue Nov 17 11:41:23 2015
New Revision: 253350
URL: http://llvm.org/viewvc/llvm-project?rev=253350=rev
Log:
Add trivial utility to append -L arguments to linker step. NFC
Modified:
cfe/trunk/include/clang/Driver/ToolChain.h
cfe/trunk/lib/Driver/ToolChain.cpp
Author: dougk
Date: Mon Nov 16 09:38:40 2015
New Revision: 253213
URL: http://llvm.org/viewvc/llvm-project?rev=253213=rev
Log:
[Myriad]: pass the 'std=' option to moviCompile
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/myriad-toolchain.c
Modified:
Author: dougk
Date: Wed Oct 21 14:33:54 2015
New Revision: 250932
URL: http://llvm.org/viewvc/llvm-project?rev=250932=rev
Log:
[Myriad]: Always add -L paths even if -nostdlib is set.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
Author: dougk
Date: Tue Oct 13 11:22:51 2015
New Revision: 250173
URL: http://llvm.org/viewvc/llvm-project?rev=250173=rev
Log:
Always pass a -dwarf-version argument to integrated as.
This removes the default of 3 hidden in the assembler previously.
Fixes breakage caused by r249655, reported by
Author: dougk
Date: Fri Oct 9 15:26:20 2015
New Revision: 249893
URL: http://llvm.org/viewvc/llvm-project?rev=249893=rev
Log:
[Myriad]: put libstdc++ and libc in the right order
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/myriad-toolchain.c
Modified:
Author: dougk
Date: Thu Oct 8 00:25:03 2015
New Revision: 249658
URL: http://llvm.org/viewvc/llvm-project?rev=249658=rev
Log:
Use itostr(), not std::to_string() because of Android.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
dougk marked an inline comment as done.
dougk added a comment.
James, you're right, 'gdwarf-2' followed by 'line-tables-only' works, but the
opposite order doesn't.
So it halfway works, which is better than not working at all.
Comment at: lib/Driver/Tools.cpp:2353
@@ +2352,3
dougk marked an inline comment as done.
dougk added a comment.
http://reviews.llvm.org/D13221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dougk
Date: Fri Oct 2 09:41:38 2015
New Revision: 249138
URL: http://llvm.org/viewvc/llvm-project?rev=249138=rev
Log:
Fix bogus comment.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
Author: dougk
Date: Fri Oct 2 13:39:08 2015
New Revision: 249166
URL: http://llvm.org/viewvc/llvm-project?rev=249166=rev
Log:
[Myriad]: Accept '-nostdlib' option
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/myriad-toolchain.c
Modified: cfe/trunk/lib/Driver/Tools.cpp
dougk added a comment.
A few more remarks:
- The code which emits line-tables-only seems to understand dwarf2 versus
dwarf4, but due solely to the way that arguments were parsed, the dwarf version
did not propagate through to the compiler invocation if you also specified
line-tables-only.
Author: dougk
Date: Wed Sep 30 10:55:59 2015
New Revision: 248912
URL: http://llvm.org/viewvc/llvm-project?rev=248912=rev
Log:
Alias "-ggdbN" to "-gN" options, fixing some incompatibilities.
* assembling from a .s file mistook -ggdb0 for -g
* -ggdb1 is supposed to mean basically -g1, not -gN for
dougk created this revision.
dougk added reviewers: chandlerc, jyknight.
dougk added a subscriber: cfe-commits.
Both the Driver and the cc1 frontend play games with various combinations of
'g' group options.
It would be nice if at least the frontend could be sane, leaving the decision
of what
dougk added a comment.
I think the best thing to do is introduce new cc1 arguments that control the
Opts explicitly, and cease accepting the equivalent driver arguments in cc1.
I would propose '-gdwarf-version={2|3|4}' and
'-gdebug-info-kind={line-tables|limited|full}'
dougk abandoned this revision.
Comment at: lib/Driver/Tools.cpp:9110
@@ +9109,3 @@
+
+ const char *ToolsRoot = ::getenv("MV_TOOLS_DIR");
+ // The version is numbered 'n.n.n.n' for arbitrary values that are opaque
jyknight wrote:
> Perhaps this should be a
Author: dougk
Date: Fri Sep 18 10:23:16 2015
New Revision: 247995
URL: http://llvm.org/viewvc/llvm-project?rev=247995=rev
Log:
Use None instead of an explicit constructor.
And remove a needless 'const' since ArrayRef is immutable.
Both as suggested by dblaikie on cfe-commits.
Modified:
dougk updated this revision to Diff 34998.
dougk marked 3 inline comments as done.
dougk added a comment.
Use the same logic as Solaris::Solaris to die in the toolchain constructor if
getArch() is unexpected.
Also don't hardcode -EL in linker.
http://reviews.llvm.org/D12541
Files:
Author: dougk
Date: Thu Sep 17 11:45:12 2015
New Revision: 247900
URL: http://llvm.org/viewvc/llvm-project?rev=247900=rev
Log:
createOutputFile should set Error to something if it returns null.
This is not portably unit-testable because the only visible
effect is a change from one random message
Author: dougk
Date: Thu Sep 17 15:00:09 2015
New Revision: 247926
URL: http://llvm.org/viewvc/llvm-project?rev=247926=rev
Log:
[Shave]: Rename test file from 'shave-' to 'myriad-'
Added:
cfe/trunk/test/Driver/myriad-toolchain.c
- copied, changed from r247924,
This revision was automatically updated to reflect the committed changes.
dougk marked 2 inline comments as done.
Closed by commit rL247924: [Shave]: Drive sparc-myriad-elf-ld directly rather
than via gcc. (authored by dougk).
Changed prior to commit:
Author: dougk
Date: Thu Sep 17 14:56:40 2015
New Revision: 247924
URL: http://llvm.org/viewvc/llvm-project?rev=247924=rev
Log:
[Shave]: Drive sparc-myriad-elf-ld directly rather than via gcc.
Differential Revision: http://reviews.llvm.org/D12541
Added:
Author: dougk
Date: Thu Sep 17 15:25:09 2015
New Revision: 247932
URL: http://llvm.org/viewvc/llvm-project?rev=247932=rev
Log:
Try to unbreak windows compiler after r247926.
It might not like {} implicitly cast to an Arrayref.
That's the theory, since I can't test it.
Modified:
Author: dougk
Date: Thu Sep 17 16:20:16 2015
New Revision: 247948
URL: http://llvm.org/viewvc/llvm-project?rev=247948=rev
Log:
[Myriad]: add "/include" to standard search path
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/ToolChains.h
dougk updated the summary for this revision.
dougk updated this revision to Diff 34682.
dougk added a comment.
Changes per review - but only a minimally correct change to finding the
libraries. Using multilibs remains as a future task.
Also renamed SHAVE::Linker to Myriad::Linker.
dougk added a comment.
This patch is wrong. Fixes are pending.
http://reviews.llvm.org/D12845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dougk
Date: Mon Sep 14 15:31:28 2015
New Revision: 247611
URL: http://llvm.org/viewvc/llvm-project?rev=247611=rev
Log:
Driver should forward at most one gdwarf-N flag to cc1as.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/integrated-as.s
Modified:
dougk updated this revision to Diff 34729.
dougk added a comment.
Delete the overrides of getTool() and buildAssembler() in MyriadToolChain.
http://reviews.llvm.org/D12541
Files:
lib/Driver/Driver.cpp
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247052: [Shave]: add a -MT option to moviCompile if there
wasn't one (authored by dougk).
Changed prior to commit:
http://reviews.llvm.org/D12622?vs=34006=34239#toc
Repository:
rL LLVM
Author: dougk
Date: Tue Sep 8 14:29:55 2015
New Revision: 247052
URL: http://llvm.org/viewvc/llvm-project?rev=247052=rev
Log:
[Shave]: add a -MT option to moviCompile if there wasn't one
Differential Revision: http://reviews.llvm.org/D12622
Modified:
cfe/trunk/lib/Driver/Tools.cpp
dougk created this revision.
dougk added a reviewer: chandlerc.
dougk added a subscriber: cfe-commits.
http://reviews.llvm.org/D12622
Files:
lib/Driver/Tools.cpp
test/Driver/shave-toolchain.c
Index: test/Driver/shave-toolchain.c
Author: dougk
Date: Wed Sep 2 16:18:10 2015
New Revision: 246715
URL: http://llvm.org/viewvc/llvm-project?rev=246715=rev
Log:
Remove inadvertent debug output from prior change.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
Author: dougk
Date: Wed Sep 2 16:14:53 2015
New Revision: 246714
URL: http://llvm.org/viewvc/llvm-project?rev=246714=rev
Log:
Use new utility function to clean leading junk from pathnames. NFC
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/lib/Frontend/DependencyFile.cpp
Modified:
Author: dougk
Date: Wed Sep 2 08:33:42 2015
New Revision: 246650
URL: http://llvm.org/viewvc/llvm-project?rev=246650=rev
Log:
[Sparc]: GCCInstallationDetector should not care if little-endian
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
Modified: cfe/trunk/lib/Driver/ToolChains.cpp
URL:
Author: dougk
Date: Wed Sep 2 08:42:43 2015
New Revision: 246652
URL: http://llvm.org/viewvc/llvm-project?rev=246652=rev
Log:
[Shave]: pass through more clang options to moviCompile
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/shave-toolchain.c
Modified:
dougk created this revision.
dougk added reviewers: jyknight, chandlerc.
dougk added a subscriber: cfe-commits.
Herald added a subscriber: jyknight.
Rename SHAVE toolchain to Myriad toolchain.
Run the Myriad linker whenever the vendor [sic] is Myriad.
Also recognize RTEMS as the OS, and do
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245595: [Sparc] Add '-EL' when invoking gcc to link
little-endian binaries. (authored by dougk).
Changed prior to commit:
http://reviews.llvm.org/D12201?vs=32715id=32716#toc
Repository:
rL LLVM
Author: dougk
Date: Thu Aug 20 13:32:26 2015
New Revision: 245595
URL: http://llvm.org/viewvc/llvm-project?rev=245595view=rev
Log:
[Sparc] Add '-EL' when invoking gcc to link little-endian binaries.
Differential Revision: http://reviews.llvm.org/D12201
Modified:
dougk created this revision.
dougk added a reviewer: jyknight.
dougk added a subscriber: cfe-commits.
http://reviews.llvm.org/D12201
Files:
lib/Driver/Tools.cpp
test/Driver/biarch.c
Index: test/Driver/biarch.c
===
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245063: Represent 2 parallel string arrays as one
string[][2] array. (authored by dougk).
Changed prior to commit:
http://reviews.llvm.org/D11991?vs=31977id=32157#toc
Repository:
rL LLVM
dougk created this revision.
dougk added a reviewer: chandlerc.
dougk added a subscriber: cfe-commits.
I think this conveys the intent better. Alternatively, since it's effectively
trying to take llvm::sys::path::parent_path() for a number of times determined
by the occurrences of '/' in one
Author: dougk
Date: Wed Aug 12 13:36:12 2015
New Revision: 244791
URL: http://llvm.org/viewvc/llvm-project?rev=244791view=rev
Log:
Don't compare getArchName() to tce as a string. NFC.
Modified:
cfe/trunk/lib/Driver/Driver.cpp
Modified: cfe/trunk/lib/Driver/Driver.cpp
URL:
Author: dougk
Date: Thu Aug 6 17:36:24 2015
New Revision: 244290
URL: http://llvm.org/viewvc/llvm-project?rev=244290view=rev
Log:
Range-forify a loop, delete trailing whitespace. NFC
Modified:
cfe/trunk/lib/Driver/ToolChain.cpp
Modified: cfe/trunk/lib/Driver/ToolChain.cpp
URL:
76 matches
Mail list logo
