[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

This revision was automatically updated to reflect the committed changes. Closed by commit rG03a9526fe5ad: [CGExprAgg] Fix infinite loop in `findPeephole` (authored by ekatz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78098/new/ https://reviews.

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz updated this revision to Diff 257794. ekatz added a comment. Changed the name of the test file to pr45476.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78098/new/ https://reviews.llvm.org/D78098 Files: clang/lib/CodeGen/CGExprAgg.cpp clang/test/CodeGen/pr45476.cpp Inde

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz updated this revision to Diff 257665. ekatz edited the summary of this revision. ekatz added a comment. Simplify function using IgnoreParenNoopCasts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78098/new/ https://reviews.llvm.org/D78098 Files: clang/lib/CodeGen/CGExprAgg.cpp

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz marked an inline comment as done. ekatz added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688 + +op = castE; } rjmccall wrote: > ekatz wrote: > > rjmccall wrote: > > > ekatz wrote: > > > > rjmccall wrote: > > > > > I liked the struct

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz marked an inline comment as done. ekatz added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688 + +op = castE; } ekatz wrote: > rjmccall wrote: > > ekatz wrote: > > > rjmccall wrote: > > > > ekatz wrote: > > > > > rjmccall wrote: > > >

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz marked an inline comment as done. ekatz added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688 + +op = castE; } rjmccall wrote: > ekatz wrote: > > rjmccall wrote: > > > I liked the structure of the old code better, in case we want to

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz updated this revision to Diff 257482. ekatz added a comment. Use the old structure of the algorithm, with the fix, as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78098/new/ https://reviews.llvm.org/D78098 Files: clang/lib/CodeGen/CGExprAgg.cpp clang/test/CodeGen/

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz marked an inline comment as done. ekatz added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688 + +op = castE; } rjmccall wrote: > I liked the structure of the old code better, in case we want to look through > other kinds of expressi

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz updated this revision to Diff 257299. ekatz added a comment. Herald added a subscriber: jfb. Added test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78098/new/ https://reviews.llvm.org/D78098 Files: clang/lib/CodeGen/CGExprAgg.cpp clang/test/CodeGen/atomic-struct-bug.cpp

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz created this revision. ekatz added reviewers: craig.topper, rjmccall, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix PR45476 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78098 Files: clang/lib/CodeGen/CGExprAgg.cpp Index: clang/l

[PATCH] D69770: [APFloat] Add recoverable string parsing errors to APFloat

ekatz marked an inline comment as done. ekatz added inline comments. Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:3133 return TokError("invalid floating point literal"); - } else if (Value.convertFromString(IDVal, APFloat::rmNearestTiesToEven) == - APFloat::

[PATCH] D69770: [APFloat] Add recoverable string parsing errors to APFloat

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5fb73c5d1b3: [APFloat] Add recoverable string parsing errors to APFloat (authored by ekatz). Changed prior to commit: https://reviews.llvm.org/D69770?vs=227917&id=236304#toc Repository: rG LLVM Gith

[PATCH] D69770: [APFloat] Add recoverable string parsing errors to APFloat

ekatz added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69770: [APFloat] Add recoverable string parsing errors to APFloat

ekatz added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

This revision was automatically updated to reflect the committed changes. Closed by commit rGc63f1b160eb6: [DeclCXX] Remove unknown external linkage specifications (authored by ekatz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69935/new/ https:/

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz updated this revision to Diff 228860. ekatz added a comment. In D69935#1741995 , @uabelho wrote: > In D69935#1739235 , @dblaikie wrote: > > > In D69935#1738273 , @uabel

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. In D69935#1741268 , @dblaikie wrote: > In D69935#1739235 , @dblaikie wrote: > > > +1 to this & then it seems fine (probably without a committed test, but I > > wouldn't mind a copy/paste of c

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz updated this revision to Diff 228755. ekatz added a comment. Removed DWARF reference from LinkageSpecDecl::LanguageIDs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69935/new/ https://reviews.llvm.org/D69935 Files: clang/include/clang/AST/DeclCXX.h clang/lib/AST/DeclPrinter.

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. No problem. For the source code: extern "C++11" int x; In clang 9.0 the compilation fails with the message: :1:8: error: unknown linkage language extern "C++11" int x; ^~~ 1 error generated. while on the trunk it just pass without any error. Reposi

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. In D69935#1738311 , @SouraVX wrote: > I created that patch, for purpose of emitting C++ language standards C++11, > C++14 in the debug information to be available for consumer's[GDB,LLDB]. > DW_TAG_lang_c_plus_plus_11 .. 14 --new

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. Yes, these changes regard to the same thing - the removal of the "Linkage-Spec LanguageIDs". As you described it nicely, it is for linkage only, meaning C vs C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69935/new/ htt

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. With this change (current trunk) you can write code as follows: extern "C++11" int x; And it will pass compilation. No other compiler support it, nor it should, as there is no such thing as `extern "C++11"` nor `extern "C++14"`. Repository: rG LLVM Github Monorepo

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz created this revision. ekatz added reviewers: SouraVX, aprantl, dblaikie, JDevlieghere, uabelho, rsmith. ekatz added a project: clang. Herald added a subscriber: cfe-commits. Partial revert of r372681 "Support for DWARF-5 C++ language tags". The change introduced new external linkage langu

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz updated this revision to Diff 227917. ekatz added a comment. Fixed requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 Files: clang/lib/Lex/LiteralSupport.cpp llvm/include/llvm/ADT/APFloat.h llvm/lib/MC/MCParser/AsmPar

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz marked 2 inline comments as done. ekatz added inline comments. Comment at: llvm/lib/Support/APFloat.cpp:273 + if (p != end) +return createError("Invalid exponent in exponent"); arsenm wrote: > Error message sounds like nonsense It is actually incorr

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz created this revision. ekatz added reviewers: chandlerc, lattner, rsmith. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, hiraditya, nhaehnle, jvesely, arsenm. Herald added projects: clang, LLVM. Implementing the APFloat part in PR4745. Repository: rG LLVM Github Monore