exv created this revision.
exv added reviewers: krasimir, MyDeveloperDay.
exv requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This adds support for the null-coalescing assignment and null-forgiving
oeprators.
https://docs.microsoft.com/en-
exv updated this revision to Diff 342497.
exv added a comment.
Remove special whitespace handling for ??=
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101702/new/
https://reviews.llvm.org/D101702
Files:
clang/lib/Format/TokenAnnotator.cpp
cla
exv added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:3197
+Right.is(TT_CSharpNullCoalescingAssignment))
+ return true;
+
MyDeveloperDay wrote:
> should this honour SpaceBeforeAssignmentOperators ?
Good point. Looking more closel
exv updated this revision to Diff 342521.
exv added a comment.
Herald added a subscriber: JDevlieghere.
Fixing arc, hopefully?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101702/new/
https://reviews.llvm.org/D101702
Files:
clang/lib/Format/For
exv updated this revision to Diff 342520.
exv added a comment.
Herald added subscribers: llvm-commits, libcxx-commits, lldb-commits,
Sanitizers, dcaballe, cota, teijeong, frasercrmck, dexonsmith, rdzhabarov,
tatianashp, lxfind, dang, msifontes, jurahul, Kayjukh, grosul1, Joonsoo,
stephenneuendor
exv added a comment.
Hey all, I'm really sorry for the noise, I screwed up my arc command to revise
the submission.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101702/new/
https://reviews.llvm.org/D101702
___
exv added inline comments.
Comment at: clang/unittests/Format/FormatTestCSharp.cpp:365
+
+ verifyFormat("test \?\?= ABC;", Style);
+ verifyFormat("test \?\?= true;", Style);
HazardyKnusperkeks wrote:
> Why do you escape `?`? I've never seen that.
Apparently, ??
exv updated this revision to Diff 342594.
exv marked 2 inline comments as done.
exv added a comment.
- [clang-format] Add more support for C# 8 nullables
- Fix null-coalescing assignment whitespace behavior
- Incorporate feedback from curdeius
- Combine JS and CS types/parsing
Repository:
rG L
exv added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:1593
+tok::kw_namespace, tok::r_paren, tok::r_square, tok::r_brace,
+tok::kw_false, tok::kw_true, Keywords.kw_type, Keywords.kw_get,
+Keywords.kw_set) ||
---
exv updated this revision to Diff 342813.
exv marked an inline comment as done.
exv added a comment.
- Remove obsolete comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101702/new/
https://reviews.llvm.org/D101702
Files:
clang/lib/Format/For
exv marked an inline comment as done.
exv added a comment.
According to the wiki, it seems like someone who has commit access must now
submit this change.
Comment at: clang/lib/Format/FormatTokenLexer.cpp:102
+
+// FIXME: Investigate what token type gives the correct opera
exv marked an inline comment as done.
exv added a comment.
Eliza Velasquez
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101702/new/
https://reviews.llvm.org/D101702
___
cfe-commits mailing list
cfe-com
12 matches
Mail list logo