[PATCH] D23329: [NFC] Reducing allocations in AST attributes

2016-08-09 Thread Eugene via cfe-commits
kevgs created this revision. kevgs added reviewers: rsmith, bkramer. kevgs added a subscriber: cfe-commits. In my test case max resident memory changed from 65760k to 64476k which is 1.9% improvement. Allocations in grow_pod changed from 8847 to 4872 according to tcmalloc heap profiler. Overa

Re: [PATCH] D23329: [NFC] Reducing allocations in AST attributes

2016-08-09 Thread Eugene via cfe-commits
kevgs added a comment. My test case is: clang++ -std=c++14 -fsyntax-only test.cc #include #include #include int main() { std::vector v = {1, 2, 3}; std::for_each(v.begin(), v.end(), [](auto i) { std::cout << i; }); return 0; } https://reviews.llvm.org/D23329 _

Re: [PATCH] D23329: [NFC] Reducing allocations in AST attributes

2016-08-09 Thread Eugene via cfe-commits
kevgs added a comment. Btw, ConstAttrVec is never used. https://reviews.llvm.org/D23329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23329: [NFC] Reducing allocations in AST attributes

2016-08-12 Thread Eugene via cfe-commits
kevgs updated this revision to Diff 67955. kevgs added a comment. clang-formatted + dead code removed https://reviews.llvm.org/D23329 Files: include/clang/AST/AttrIterator.h Index: include/clang/AST/AttrIterator.h === --- includ

Re: [PATCH] D23329: [NFC] Reducing allocations in AST attributes

2016-08-12 Thread Eugene via cfe-commits
kevgs added a comment. I have no commit rights. https://reviews.llvm.org/D23329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19108: [Sema] Fixed assert failure in template code analyzer

2016-04-14 Thread Eugene via cfe-commits
kevgs created this revision. kevgs added reviewers: rsmith, dblaikie. kevgs added a subscriber: cfe-commits. Fix for this bug https://llvm.org/bugs/show_bug.cgi?id=27312 http://reviews.llvm.org/D19108 Files: lib/Sema/SemaAccess.cpp test/SemaTemplate/crash-bug-27258.cpp Index: test/SemaTempl

Re: [PATCH] D20100: [NFC] Header cleanup

2016-05-10 Thread Eugene via cfe-commits
kevgs added a comment. Sadly, I dont know such a tool. I was using a simple script to find unused headers ack --cpp -l 'SmallString\.h"' | xargs grep -L 'SmallString[ (http://reviews.llvm.org/D20100 ___ cfe-commits mailing list cfe-commits@lists.llvm

Re: [PATCH] D20100: [NFC] Header cleanup

2016-07-16 Thread Eugene via cfe-commits
kevgs added a comment. Good. I have no commit rights. https://reviews.llvm.org/D20100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits