Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

2016-05-07 Thread Evangelos Foutras via cfe-commits
foutrelis added a subscriber: foutrelis. Comment at: test/CodeGenCXX/mangle-abi-tag.cpp:115 @@ +114,3 @@ +C1 f9() { return C1(); } +// CHECK: @_Z2f9B6Names1v() + I'm seeing a test failure on i686 on Arch Linux (all tests pass on x86_64): {F1899075} I'm using thi

Re: [PATCH] D12834: add gcc abi_tag support

2016-01-15 Thread Evangelos Foutras via cfe-commits
foutrelis added a comment. The latest patch still applies (relatively cleanly) to Clang 3.7.x which is nice. The infinite recursion segfaults appear to be gone, thanks! There are a few test failures which I assume will be need to be addressed later on: F1315853: clang-diff-44973-test-failures.l

Re: [PATCH] D12834: add gcc abi_tag support

2015-12-26 Thread Evangelos Foutras via cfe-commits
foutrelis added a comment. In http://reviews.llvm.org/D12834#314136, @elizafox wrote: > In http://reviews.llvm.org/D12834#311890, @foutrelis wrote: > > > We have received a few reports of clang crashes after applying the abi_tag > > support patch to our llvm/clang package in Arch Linux. > > > Wh

Re: [PATCH] D12834: add gcc abi_tag support

2015-12-16 Thread Evangelos Foutras via cfe-commits
foutrelis added a comment. We have received a few reports of clang crashes after applying the abi_tag support patch to our llvm/clang package in Arch Linux. Compiling F1182170: test.cc with `clang++ -std=c++14 -c test.cc` should trigger the segmentation fault

Re: [PATCH] D13206: Add clang-query tool to installation targets

2015-09-28 Thread Evangelos Foutras via cfe-commits
foutrelis added a comment. Thanks for the review. Can you please commit the patch to `clang-tools-extra/trunk` (since I don't have commit rights)? http://reviews.llvm.org/D13206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D13206: Add clang-query tool to installation targets

2015-09-28 Thread Evangelos Foutras via cfe-commits
foutrelis created this revision. foutrelis added a subscriber: cfe-commits. It has been requested in a bug report downstream in Arch Linux to include the clang-query tool as part of our clang-tools-extra package. [1] This point has also been brought up on the cfe-dev list and the LLVM bug track

Re: [PATCH] D13206: Add clang-query tool to installation targets

2015-09-28 Thread Evangelos Foutras via cfe-commits
foutrelis added a comment. Just a note that this change is specific to CMake since autotools already installs clang-query (along with some other tools). http://reviews.llvm.org/D13206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l