https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/139271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,221 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/MaskRay approved this pull request.
LGTM. Thanks for removing this tech debt.
https://github.com/llvm/llvm-project/pull/144222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
https://github.com/MaskRay commented:
LGTM!
https://github.com/llvm/llvm-project/pull/134621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1635,8 +1656,13 @@ bool tools::addSanitizerRuntimes(const ToolChain &TC,
const ArgList &Args,
}
// If there is a static runtime with no dynamic list, force all the symbols
// to be dynamic to be sure we export sanitizer interface functions.
- if (AddExportDynamic)
-
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/143124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -18,6 +18,53 @@
using namespace llvm;
using namespace AMDGPU;
+/// Find KV in array using binary search.
+static const BasicSubtargetSubTypeKV *
+Find(StringRef S, ArrayRef A) {
MaskRay wrote:
`find` (functionName in new code)
https://github.com/llvm/llvm
@@ -18,6 +18,53 @@
using namespace llvm;
using namespace AMDGPU;
+/// Find KV in array using binary search.
+static const BasicSubtargetSubTypeKV *
+Find(StringRef S, ArrayRef A) {
+ // Binary search the array
+ auto F = llvm::lower_bound(A, S);
+ // If not found then retur
@@ -0,0 +1,19 @@
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
+
+// Create PCH without -ignore-pch.
+// RUN: %clang -x c++-header %S/../Modules/Inputs/codegen-flags/foo.h -###
2>&1 | FileCheck %s -check-prefix=CHECK-EMIT-PCH
MaskRay wrote:
`%S/../` references auxilia
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/143533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/143268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
-mlong-calls is an old-fashioned compiler option. I think it was added before
linkers knew range extension thunks (aka stubs, veneers, etc).
Can you use -fno-plt instead? It works with both SelectionDAG and GlobalISel.
You will get GOT-generating code sequence that can be optimi
MaskRay wrote:
Should call this "option". Within LLVM, we use flag for options without a value.
https://github.com/llvm/llvm-project/pull/142901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
@@ -16,6 +16,7 @@
#include "llvm/ADT/StringMap.h"
#include "llvm/ADT/StringRef.h"
+#include "llvm/MC/MCSubtargetInfo.h"
MaskRay wrote:
@diggerlin This is blocking and should be addressed before landing.
https://github.com/llvm/llvm-project/pull/137670
__
https://github.com/MaskRay commented:
LGTM
https://github.com/llvm/llvm-project/pull/141562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/142396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
> Thanks for working on this! This will be the first time I'm not going to
> oppose an effort to remove Native Client support 🎉 Although I am going to ask
> you to wait a couple of months to land it, until we finally turn it off for
> good and start deleting the support code fro
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/140556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -614,3 +614,30 @@ nvfortran defines `-fast` as
- `-Mcache_align`: there is no equivalent flag in Flang or Clang.
- `-Mflushz`: flush-to-zero mode - when `-ffast-math` is specified, Flang will
link to `crtfastmath.o` to ensure denormal numbers are flushed to zero.
+
+
+#
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/140556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -614,3 +614,30 @@ nvfortran defines `-fast` as
- `-Mcache_align`: there is no equivalent flag in Flang or Clang.
- `-Mflushz`: flush-to-zero mode - when `-ffast-math` is specified, Flang will
link to `crtfastmath.o` to ensure denormal numbers are flushed to zero.
+
+
+#
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/132680
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,12 @@
+! RUN: env FCC_OVERRIDE_OPTIONS="#+-Os +-Oz +-O +-O3 +-Oignore +a +b +c xb Xa
Omagic ^-### " %flang -target x86_64-unknown-linux-gnu %s -O2 b -O3 2>&1 |
FileCheck %s
MaskRay wrote:
`--target=x86_64-unknown-linux-gnu` instead of the long depre
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/140556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay commented:
clang driver code looks good
https://github.com/llvm/llvm-project/pull/140556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
> Thank you for confirming.
>
> @MaskRay, do you have any comments regarding the handling of warning messages?
Sorry for the delayed response. Does this implement the last-option-win
behavior as suggested in the last few comments of
https://discourse.llvm.org/t/the-priority-of
@@ -2997,6 +2997,7 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
LangOptions::ComplexRangeKind Range = LangOptions::ComplexRangeKind::CX_None;
std::string ComplexRangeStr = "";
std::string GccRangeComplexOption = "";
+ std::string LastC
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/141921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -27,3 +27,10 @@
// RUN: not %clang --target=x86_64 -### -mhtm -lc %s 2>&1 \
// RUN: | FileCheck %s -check-prefix=UNSUP_OPT
// UNSUP_OPT: error: unsupported option
+
+
+// RUN: not %clang -c --target=aarch64-- -mfpu=crypto-neon-fp-armv8 %s 2>&1 | \
+// RUN: FileCheck %s --c
@@ -27,3 +27,10 @@
// RUN: not %clang --target=x86_64 -### -mhtm -lc %s 2>&1 \
// RUN: | FileCheck %s -check-prefix=UNSUP_OPT
// UNSUP_OPT: error: unsupported option
+
+
+// RUN: not %clang -c --target=aarch64-- -mfpu=crypto-neon-fp-armv8 %s 2>&1 | \
MaskRay
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/141698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -44,7 +44,11 @@ define void @varargs_caller() nounwind {
; CHECK-NEXT:stp xzr, x30, [sp, #24] // 8-byte Folded Spill
; CHECK-NEXT:stp x9, x8, [sp]
; CHECK-NEXT:str xzr, [sp, #16]
-; CHECK-NEXT:bl varargs_callee
+; CHECK-NEXT:.weak_anti_dep varargs_callee
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/74178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/140874
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/133031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2331,6 +2337,65 @@ bool RISCVAsmParser::generateVTypeError(SMLoc ErrorLoc) {
"e[8|16|32|64],m[1|2|4|8|f2|f4|f8],[ta|tu],[ma|mu]");
}
+ParseStatus RISCVAsmParser::parseXSfmmVType(OperandVector &Operands) {
+ SMLoc S = getLoc();
+
+ unsigned Widen = 0;
+ unsigned SE
@@ -355,6 +349,9 @@ function(add_link_opts target_name)
set_property(TARGET ${target_name} APPEND_STRING PROPERTY
LINK_FLAGS " -Wl,-brtl")
endif()
+
+ check_linker_flag(CXX "-Wl,-Bsymbolic-functions"
MaskRay wrote:
@mati865 This might b
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/79539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -355,6 +349,9 @@ function(add_link_opts target_name)
set_property(TARGET ${target_name} APPEND_STRING PROPERTY
LINK_FLAGS " -Wl,-brtl")
endif()
+
+ check_linker_flag(CXX "-Wl,-Bsymbolic-functions"
MaskRay wrote:
While I am aware of h
@@ -355,6 +349,9 @@ function(add_link_opts target_name)
set_property(TARGET ${target_name} APPEND_STRING PROPERTY
LINK_FLAGS " -Wl,-brtl")
endif()
+
+ check_linker_flag(CXX "-Wl,-Bsymbolic-functions"
MaskRay wrote:
Add a comment what ta
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/139457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
LGTM with a few nits. Please give other reviewers some time to chime in
https://github.com/llvm/llvm-project/pull/139457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
@@ -0,0 +1,19 @@
+// Related to #139457
+// Clang uses 1-based indexing for source locations given from the
command-line.
+// Verify that `clang-refactor` rejects 0 as an invalid value for line or
column number.
+
+// For range start:
+// RUN: not clang-refactor local-rename -se
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/139457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,12 @@
+// Related to #139375
MaskRay wrote:
I don't why some regression tests are named `crash-*`, but I would not name
this `crash-*`.
I'd just name this source-loc-zero.cpp and change this comment to `//
Regression test for #139375`
https://githu
@@ -89,8 +92,13 @@ struct ParsedSourceRange {
// probably belongs to the filename which menas the whole
// string should be parsed.
RangeSplit.first = Str;
- } else
+ } else {
+// Column and line numbers are 1-based
Mas
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/139455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
You might want to test two configurations to ensure that -rtlib= -stdlib=
-unwindlib= defaults do not make the new test fail.
* default
* -DCLANG_DEFAULT_RTLIB=compiler-rt -DCLANG_DEFAULT_UNWINDLIB=libunwind
-DCLANG_DEFAULT_CXX_STDLIB=libc++
https://github.com/llvm/llvm-projec
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/139271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1622,6 +1622,11 @@
// RUN: %clang_cc1 -x c -std=c99 -E -dM -ffreestanding
-triple=amd64-unknown-openbsd < /dev/null | FileCheck -match-full-lines
-check-prefix OPENBSD-STDC-N %s
// OPENBSD-STDC-N-NOT:#define __STDC_NO_THREADS__ 1
//
+// RUN: %clang_cc1 -triple=aarch64-unk
@@ -228,6 +228,8 @@ static const char *getLDMOption(const llvm::Triple &T,
const ArgList &Args) {
return "elf_iamcu";
return "elf_i386";
case llvm::Triple::aarch64:
+if (T.isOSManagarm())
+ return "aarch64managarm";
MaskRay wrote:
Is this
MaskRay wrote:
Since the option has been renamed to `-fextend-variable-liveness`, I think you
want to edit this title and the description to reflect the naming change as
well. I wanted to check the status the effort and I tried `git log --grep
fextend-lifetimes` but found nothing, then I reali
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/125643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/125643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/125643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,109 @@
+//===--- Cygwin.cpp - Cygwin ToolChain Implementations --*- C++
-*-===//
MaskRay wrote:
In new code, can remove the comments per the updated
https://llvm.org/docs/CodingStandards.html#file-headers
https://github.com/llvm/llvm-project
@@ -2632,6 +2632,27 @@ void
Generic_GCC::GCCInstallationDetector::AddDefaultGCCPrefixes(
return;
}
+ if (TargetTriple.isWindowsCygwinEnvironment()) {
+static const char *const CygwinX86Triples[] = {"i686-pc-cygwin",
+
https://github.com/MaskRay commented:
LGTM. But I hope folks more familiar with Windows can take a look.
Can you describe the support triples in the description and state why we need
the msys ones?
(Wow, MSYS and Cygwin... familiar names! I used them back in 2009, but then I
made the switch to
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/135691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -391,6 +391,7 @@ Improvements to Clang's diagnostics
- An error is now emitted when a ``musttail`` call is made to a function
marked with the ``not_tail_called`` attribute. (#GH133509).
+- The ``-mcmodel=tiny`` option will now be diagnosed on all targets other than
ARM o
https://github.com/MaskRay commented:
clang/test/Driver/Inputs/resource_dir/lib/aix/libclang_rt.asan-powerpc.a is the
old runtime path.
Does $triple/libclang_rt.asan.a work? If yes, the new hierarchy is preferred
https://github.com/llvm/llvm-project/pull/129925
_
@@ -256,6 +256,8 @@ def err_drv_malformed_sanitizer_metadata_ignorelist : Error<
"malformed sanitizer metadata ignorelist: '%0'">;
def err_drv_unsupported_static_sanitizer_darwin : Error<
MaskRay wrote:
Rename this one to `err_drv_unsupported_static_sanitizer
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/138466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
It's not due to non-Unix hosts. It's likely due to these builds setting
CLANG_DEFAULT_RTLIB and CLANG_DEFAULT_UNWINDLIB.
https://github.com/llvm/llvm-project/pull/138466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
MaskRay wrote:
We should avoid introducing a new cmake config for changes like this. You could
utilize clang config file to specify the option.
lld change should have been separated
https://github.com/llvm/llvm-project/pull/136660
___
cfe-commits ma
https://github.com/MaskRay approved this pull request.
(I have limited internet access between April 20th and May 4th, and my response
time may be delayed..)
https://github.com/llvm/llvm-project/pull/137141
___
cfe-commits mailing list
cfe-commits@li
https://github.com/MaskRay approved this pull request.
LGTM!
(I will have limited internet access between April 20th and May 4th, and my
response time may be delayed..)
https://github.com/llvm/llvm-project/pull/100714
___
cfe-commits mailing list
cf
@@ -0,0 +1,9 @@
+// RUN: %clang_cc1 -std=c99 -fsyntax-only -pedantic %s 2>&1 | grep 'warning:
this style of line directive is a GNU extension'
MaskRay wrote:
We prefer `FileCheck` to `grep`. FileCheck enables testing the line number, e.g.
```
// CHECK: [[#@LINE
@@ -0,0 +1,6 @@
+/// Check that -Xclangas/-Xclangas= are passed to -cc1as.
+// RUN: %clang -### -Xclangas -target-feature -Xclangas=+v5t %s 2>&1 | \
MaskRay wrote:
Also add a `-Werror` to test `Arg->claim();`. I haven't tested, but without
`Arg->claim();` there
@@ -0,0 +1,6 @@
+/// Check that -Xclangas/-Xclangas= are passed to -cc1as.
+// RUN: %clang -### -Xclangas -target-feature -Xclangas=+v5t %s 2>&1 | \
+// RUN: FileCheck -check-prefix=ARGS %s
+// ARGS: -cc1as
+// ARGS: -target-feature
MaskRay wrote:
Use `-SAME:`
@@ -0,0 +1,6 @@
+/// Check that -Xclangas/-Xclangas= are passed to -cc1as.
+// RUN: %clang -### -Xclangas -target-feature -Xclangas=+v5t %s 2>&1 | \
+// RUN: FileCheck -check-prefix=ARGS %s
MaskRay wrote:
unnecessary to use a custom check prefix. Just omit it a
MaskRay wrote:
> This is one of the ideas I gave in
> https://github.com/llvm/llvm-project/issues/97517. I opted to propose this
> one first as introducing a new -Xclangas option comes with no concerns about
> GCC compatibility as with -Xassembler.
Please update the description/commit messag
@@ -0,0 +1,6 @@
+// Check that -Xclangas passes args to -cc1as.
MaskRay wrote:
`/// ` for non-RUN non-CHECK comments to make them stand out
https://github.com/llvm/llvm-project/pull/100714
___
cfe-commits mailing list
https://github.com/MaskRay approved this pull request.
(I will have limited internet access between April 20th and May 4th, and my
response time may be delayed..)
https://github.com/llvm/llvm-project/pull/100714
___
cfe-commits mailing list
cfe-commi
@@ -0,0 +1,6 @@
+// Check that -Xclangas passes args to -cc1as.
+// RUN: %clang -### -Xclangas -target-feature -Xclangas +v5t %s 2>&1 | \
MaskRay wrote:
change one arg to use `-Xclangas=`
https://github.com/llvm/llvm-project/pull/100714
_
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/100714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
The patch mixes the following changes
* Triple
* llvm/lib/Support/Unix
* clang/lib/Driver
I think we need 3 PRs. The Triple and Support code looks good.
I will have limited internet access between April 20th and May 4th, and my
response t
@@ -395,6 +395,36 @@ class LLVM_LIBRARY_VISIBILITY LinuxTargetInfo : public
OSTargetInfo {
}
};
+// Managarm Target
+template
+class LLVM_LIBRARY_VISIBILITY ManagarmTargetInfo : public OSTargetInfo
{
+protected:
+ void getOSDefines(const LangOptions &Opts, const llvm::Tr
@@ -0,0 +1,227 @@
+//===--- Managarm.h - Managarm ToolChain Implementations *- C++
-*-===//
MaskRay wrote:
For new files, just use
`//===--===//`
per latest https://llvm.org/docs/Coding
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/87845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,13 @@
+// REQUIRES: mips-registered-target
MaskRay wrote:
`clang++ -target "mipsel-w64-windows-gnu" -c test.cpp` avoid deprecated
`-target `. Use `--target=`
https://github.com/llvm/llvm-project/pull/135524
___
@@ -0,0 +1,13 @@
+// REQUIRES: mips-registered-target
MaskRay wrote:
https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-too-little#the-test-checks-at-the-wrong-layer
Should generally avoid clang/test/CodeGen test for lib/Target changes.
llvm/t
MaskRay wrote:
You might want to change the `DisableFree` default for library uses so that
users don't need to specify `-no-disable-free`.
```
// Clang calls BuryPointer on the internal AST and CodeGen-related elements
like TargetMachine.
// This will cause memory leaks if `compile` is exe
@@ -1755,6 +1755,18 @@ Compilation *Driver::BuildCompilation(ArrayRef ArgList) {
<< TC.getTriple().str();
}
+ // Throw diagnosis if mcmodel=tiny option is passed for targets other than
ARM
+ // or AArch64.
+ if (Arg *A = UArgs->getLastArg(options::OPT_mcmodel_EQ)
@@ -1755,6 +1755,18 @@ Compilation *Driver::BuildCompilation(ArrayRef ArgList) {
<< TC.getTriple().str();
}
+ // Throw diagnosis if mcmodel=tiny option is passed for targets other than
ARM
+ // or AArch64.
+ if (Arg *A = UArgs->getLastArg(options::OPT_mcmodel_EQ)
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/118026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay requested changes to this pull request.
We typically add such incompatibility check in clang/lib/Driver instead of
clang/lib/Frontend.
(Apologies, I will have limited internet access between April 20th and May 4th,
and my response time may be delayed.. Happy if a reg
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/135546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/135546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
I don't, but I wonder what's the GCC behavior. It seems to suppress the
diagnostic when processing a .i file.
https://github.com/llvm/llvm-project/pull/134621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/135128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay updated
https://github.com/llvm/llvm-project/pull/135128
>From f6d368f889acb08443e9cc425d1d8aab4d05bfef Mon Sep 17 00:00:00 2001
From: Fangrui Song
Date: Wed, 9 Apr 2025 21:24:40 -0700
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UTF
MaskRay wrote:
> Thanks for improving code health! :-)
>
> LGTM but I'm not familiar with this area of LLVM nor a code owner, so I'll
> defer to the code owners.
>
> Nit: this patch does a few drive-by fixes (deletes the createAsmStreamer
> variant with three bools; rename to createSystemZAsm
MaskRay wrote:
I am not sure clang driver should does this unusual suppression.
You'd also get a warning with: `clang test.c -E -Wall -pedantic; clang test.i
-S -Wall -pedantic`
There might be a different strategy to suppress this diagnostic?
https://github.com/llvm/llvm-project/pull/134621
@@ -541,8 +542,8 @@ static bool ExecuteAssemblerImpl(AssemblerInvocation &Opts,
// FIXME: There is a bit of code duplication with addPassesToEmitFile.
if (Opts.OutputType == AssemblerInvocation::FT_Asm) {
-MCInstPrinter *IP = TheTarget->createMCInstPrinter(
-ll
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/135128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/135128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/134362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7,35 +7,106 @@
!! LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON, use
!! resource_dir_with_per_target_subdir as inputs.
-! Check powerpc64-ibm-aix 64-bit linking to static flang-rt
+! Check powerpc64-ibm-aix 64-bit linking to static flang-rt by default
! RUN: %flang %s -### 2>&1
@@ -7,35 +7,106 @@
!! LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON, use
!! resource_dir_with_per_target_subdir as inputs.
-! Check powerpc64-ibm-aix 64-bit linking to static flang-rt
+! Check powerpc64-ibm-aix 64-bit linking to static flang-rt by default
! RUN: %flang %s -### 2>&1
1 - 100 of 1833 matches
Mail list logo
