[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

fhahn added a comment. (splitting up huge monolithic tests likely also speeds up overall testing time on multi-core systems) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123601/new/ https://reviews.llvm.org/D123601 __

[PATCH] D123300: [Clang] Enable opaque pointers by default

fhahn added a comment. In D123300#3454215 , @aeubanks wrote: > $ cat /tmp/a.ll > target triple = "thumbv8-unknown-linux-gnueabihf" > > define void @zot() { > bb: > br label %bb1 > > bb1: ;

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

fhahn added a comment. In D122983#3464331 , @xbolva00 wrote: > In D122983#3464315 , @aaron.ballman > wrote: > >> In D122983#3463561 , @MaskRay >> wrote: >> >>> Adding a

[PATCH] D69740: [profile] Support counter relocation at runtime

fhahn added inline comments. Herald added subscribers: abrachet, MaskRay. Herald added a project: All. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:673 +auto *Add = Builder.CreateAdd(Builder.CreatePtrToInt(Addr, Int64Ty), LI); +Addr = Builder.CreateI

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

fhahn added a comment. > @fhahn Remind me - why did you want me to split these? If we're initially > just going for integer support, can't both be done at the same time in this > patch? I think my original thinking was that `__builtin_reduce_mul` isn't defined at the moment https://clang.llvm.

[PATCH] D124741: [Clang] Add integer add reduction builtin

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks > For other reductions, we've tried to share builtins for float/integer > vectors, but the fadd reduction builtins also take a starting value argument. > Technically I could suppor

[PATCH] D117829: [Clang] Add integer mul reduction builtin

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! IIRC @scanon had some opinions about `__builtin_reduce_mul` during some earlier discussions. Please wait a few days in case there are additional comments. Repository: rG LLVM G

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. In D113779#3207936 , @SjoerdMeijer wrote: >> If anybody has contacts to GCC that would be very helpful. Unfortunately I >> don't think I will be able to drive this.

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

fhahn created this revision. fhahn added reviewers: rjmccall, aaron.ballman, scanon, rsmith, hfinkel. Herald added subscribers: jeroen.dobbelaere, kosarev. Herald added a project: All. fhahn requested review of this revision. Herald added a project: clang. This patch extends Clang's TBAA generatio

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

fhahn added a comment. In D122573#3412109 , @rjmccall wrote: > Hmm. We know that the big picture here, distinguishing pointers by pointee > type, is going to be disruptive and will probably need a specific > enabling/disabling option. I'm not sure tha

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 418961. fhahn added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. I rebased the patch and added new pm support based on the latest version of D32198 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

fhahn added a comment. In D124699#3507250 , @qcolombet wrote: > Thanks @thakis ! > > @fhahn are you okay with the clang tests update as well? Yes looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

fhahn accepted this revision. fhahn added a comment. LGTM with additional suggestions inline, thanks! Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:10462 +} else { + ORE->emit([&]() { +return OptimizationRemarkAnalysisAliasing( I

[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

fhahn accepted this revision. fhahn added a comment. Still LGTM, thanks! The remaining suggestion can be addressed directly before committing the patch. Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h:324 + /// Check if the number of runtime checks exceed

[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

fhahn added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122126/new/ https://reviews.llvm.org/D122126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

fhahn added a comment. Thanks for breaking this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121093/new/ https://reviews.llvm.org/D121093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

fhahn added a comment. In D124836#3528109 , @vvereschaka wrote: > Hi @void , > > the `zero-call-used-regs.ll` test gets failed on > `llvm-clang-x86_64-expensive-checks-ubuntu` builder with the following errors: > > ... > *** Bad machine code: Illega

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

fhahn added a comment. It looks like this commit is breaking bootstrap builds of LLVM/Clang, e.g. https://lab.llvm.org/buildbot/#/builders/37/builds/14224 FAILED: lib/Bitcode/Reader/CMakeFiles/LLVMBitReader.dir/BitcodeReader.cpp.o /b/sanitizer-x86_64-linux-autoconf/build/tsan_debug_build/bi

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 440264. fhahn added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def clang/include/clang/Basic/Sanitiz

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 434471. fhahn added a comment. Rebase & address comments, thanks! Also update the code to link tysan runtime with static linking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 435508. fhahn added a comment. Add TySan library when building on Darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

fhahn abandoned this revision. fhahn added a comment. My understanding is that https://reviews.llvm.org/D35436 prevents the case described in this review from happening. Thanks for having a look! https://reviews.llvm.org/D35081 ___ cfe-commits mail

[PATCH] D35826: [Driver] Error if ARM mode was selected explicitly for M-profile CPUs.

fhahn created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. M-class profiles do not support ARM execution mode, so providing -marm/-mno-thumb does not make sense in combination with -mcpu/-march options that support the M-profile. This is a follow-up patch to http

[PATCH] D35884: Update to use enum classes for various ARM *Kind enums

fhahn created this revision. Herald added subscribers: kristof.beyls, aemerson. This updates the relevant Clang parts for the LLVM change https://reviews.llvm.org/D35882. https://reviews.llvm.org/D35884 Files: lib/Basic/Targets/AArch64.cpp lib/Basic/Targets/ARM.cpp lib/Basic/Targets/ARM.

[PATCH] D35884: Update to use enum classes for various ARM *Kind enums

fhahn updated this revision to Diff 108479. fhahn marked an inline comment as done. fhahn added a comment. Addressed reviewer comments https://reviews.llvm.org/D35884 Files: lib/Basic/Targets/AArch64.cpp lib/Basic/Targets/ARM.cpp lib/Basic/Targets/ARM.h lib/Driver/ToolChain.cpp lib/Dr

[PATCH] D35884: Update to use enum classes for various ARM *Kind enums

fhahn added inline comments. Comment at: lib/Basic/Targets/AArch64.cpp:94 llvm::AArch64::parseCPUArch(Name) != - static_cast(llvm::AArch64::ArchKind::AK_INVALID); + llvm::AArch64::ArchKind::INVALID; } rovka wrote: > My eyes might be

[PATCH] D40299: [Complex] Don't use __div?c3 when building with fast-math.

fhahn added reviewers: arphaman, GorNishanov, hfinkel, fhahn. fhahn added a comment. Looks good to me, with some nits. However it seems that we do not use the fast math flags anywhere else in Clang codegen, so it would be good to clarify if it is OK to use it here. Comment at

[PATCH] D102494: [Clang, Driver] Default to Darwin_libsystem_m veclib on iOS based targets.

fhahn abandoned this revision. fhahn added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. As of now, I don't think this is safe to do with the precision guarantees Darwin_libsystem_m provides unfortunately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

fhahn added a comment. I'm not familiar with HLSL but I think making use of the existing vector builtins makes sense here! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133737/new/ https://reviews.llvm.org/D133737

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

fhahn added a comment. In D133737#3787066 , @RKSimon wrote: > The elementwise builtins should work for scalars as well (and IIRC we do test > this as well). Yep they should, it is specially specified here: https://clang.llvm.org/docs/LanguageExtensions

[PATCH] D134316: [clang][docs] Fix supported element types for `__builtin_reduce_(add|mul)`

fhahn added a comment. In D134316#3808544 , @jloser wrote: > This landed with > https://github.com/llvm/llvm-project/commit/cf77333da986720e9aded4301d81a581e2be9611. > The revision didn't auto-close for some reason. You need to make sure the commit me

[PATCH] D134441: [ObjC][ARC] Don't use operand bundle "clang.arc.attachedcall" in codegen for Windows

fhahn added a comment. In D134441#3808655 , @sgraenitz wrote: > The symptom is that Clang emits `movq %rax, %rdi` instead of `movq %rax, > %rcx` while `objc_retainAutoreleasedReturnValue()` still expects the value in > `%rcx`. > It appears related to D9

[PATCH] D134441: [ObjC][ARC] Fix target register for call expanded from CALL_RVMARKER on Windows

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! You might want to extend the windows check lines to the other tests as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134441/ne

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

fhahn added a comment. Herald added a project: All. In D106005#2904865 , @SaurabhJha wrote: > In D106005#2904424 , @fhahn wrote: > >> In D106005#2896080 , @SaurabhJha >>

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

fhahn added a comment. Looks like a nice improvement, thanks! Comment at: llvm/unittests/ADT/SmallVectorTest.cpp:867 - template - static unsigned NumBuiltinElts(const SmallVector&) { return N; } }; This seems like an unrelated change unless I am missing som

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

fhahn added a comment. In D122768#3700486 , @cor3ntin wrote: > In D122768#3700451 , @aeubanks > wrote: > >> in the commit message >> >> In addition, capturing an anonymous union member, >> a bitfield, or a st

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129231/new/ https://reviews.llvm.org/D129231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

This revision was automatically updated to reflect the committed changes. Closed by commit rGef110a491f70: [Builtins] Do not claim most libfuncs are readnone with trapping math. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D129231?vs=448628&id=451800#toc Repository:

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1409 -LIBBUILTIN(round, "dd", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundf, "ff", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundl, "LdLd", "fnc", "math.h", ALL_LANGUAGES) +LIBBUILTIN(round,

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn added a comment. In D129231#3716363 , @scanon wrote: >>> Looking at implementations of these functions, it looks like GNU libm >>> doesn't raise inexact, but the bionic libm does. I think I'm leaning >>> towards marking all of them as "fng" as it'

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn added a comment. @john.brawn Are you OK with treating those functions as not setting inexact, as per the C23 clarification, as the committed version does? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129231/new/ https://reviews.llvm.org/D12

[PATCH] D132488: [CMake] Move cxx-headers to RUNTIME_DISTRIBUTION_COMPONENTS in Apple-stage2.cmake

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132488/new/ https://reviews.llvm.org/D132488

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn updated this revision to Diff 458407. fhahn added a comment. Rebase and ping :) The potential benefit of having -m flags is also mentioned in this recent bug report: https://github.com/llvm/llvm-project/issues/57588 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 469270. fhahn added a comment. Rebase on top of current `main`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def clang/in

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

fhahn updated this revision to Diff 469329. fhahn added a comment. Rebased on current main In D122573#3630767 , @rui.zhang wrote: > I like the direction where this change is leading to and hope there is some > way to land it incrementally. Since Builtin

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

fhahn added a comment. It looks like GISel crashes when building `llvm-test-suite` with -O3 on ARM64. If it isn't trivial to fix we should probably revert the patch to bring things back to green. Reproducer: ; llc -global-isel -O3 target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

fhahn accepted this revision. fhahn added a comment. LGTM with the suggested changes, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 ___ cfe-commits ma

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn commandeered this revision. fhahn added a reviewer: CJ-Johnson. fhahn added a comment. Commandeering after the recent updates to make review + follow-ups easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.or

[PATCH] D135011: Add sin and cos llvm intrinsics

fhahn added a comment. Could you update the title to make it clear this adds new Clang builtins, not intrinsics (they are lowered to LLVM intrinsics). The behavior of the new builtins should be specified in `LanguageExtensions.rst` (https://clang.llvm.org/docs/LanguageExtensions.html#vector-bui

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

fhahn added a comment. > Adding this metadata allows {loop.vectorize.enable, false} to be used without > disabling the whole pass. Could you please describe the behavior in more detail here? The new metadata should also be documented in `LangRef`, the new pragma in https://clang.llvm.org/docs/

[PATCH] D139640: clang: Add __builtin_elementwise canonicalize and copysign

fhahn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:644 magnitude than x + T__builtin_elementwise_canonicalize(T x) return the platform specific canonical encoding of a floating-point number floati

[PATCH] D139640: clang: Add __builtin_elementwise canonicalize and copysign

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, but please make sure the `.rst` file builds with `sphinx`. Comment at: clang/docs/LanguageExtensions.rst:644 magnitude than

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. Unfortunately it looks like this commit breaks building on ARM64 macOS. I reverted the change for now and added more details on the error in the revert commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. In D137836#3950825 , @lenary wrote: > In D137836#3950815 , @fhahn wrote: > >> Unfortunately it looks like this commit breaks building on ARM64 macOS. I >> reverted the change for now and ad

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. (it looks like this job should have sent an email: https://green.lab.llvm.org/green/job/clang-stage1-RA/32031/console) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 _

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. In D137836#3950883 , @lenary wrote: > In D137836#3950846 , @fhahn wrote: > >> (it looks like this job should have sent an email: >> https://green.lab.llvm.org/green/job/clang-stage1-RA/3203

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

fhahn added a comment. Someone filed https://github.com/llvm/llvm-project/issues/53540, which covers some of the issues also discussed here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100879/new/ https://reviews.llvm.org/D100879 __

[PATCH] D111529: Specify Clang vector builtins.

fhahn created this revision. fhahn added reviewers: scanon, erichkeane, rjmccall, aaron.ballman, dexonsmith, rsmith, craig.topper. fhahn requested review of this revision. Herald added a project: clang. This patch specifies a set of vector builtins for Clang, as discussed on cfe-dev: https://list

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn abandoned this revision. fhahn added a comment. The vector builtin support took a different direction, see D111529 and following Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108832/new/ https://reviews.ll

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

fhahn added a comment. Could you add tests on the LLVM side for the new options as well? See also D95541 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113738/new/ https://reviews.llvm.org/D113738

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn created this revision. fhahn added reviewers: aemerson, ab, dmgreen, SjoerdMeijer, scanon. Herald added subscribers: dang, kristof.beyls. fhahn requested review of this revision. Herald added a project: clang. This patch adds support for `-m[no]fpf16`, ` `-m[no]fpf16fml` and `-m[no]dotprod`

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn added a comment. In D113779#3130701 , @SjoerdMeijer wrote: > This introduces another way of setting (optional) architecture extensions and > having two ways to do the same is nearly always a bad thing, which is how one > of my colleagues phrased

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn added a comment. In D113779#3130744 , @DavidSpickett wrote: > There was a similar proposal for crypto https://reviews.llvm.org/D60472. > > Quoting @manojgupta for the pitch for that: > >> The motivation for this change is to make "crypto" setting a

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn added a comment. In D113779#3130853 , @paulwalker-arm wrote: > Rather than adding connivence options after the fact what about allowing > `-march=` to be specified multiple times? The first must be the usual format > with later ones required to s

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

fhahn added a comment. It is also breaking building `llvm-project/llvm/unittests/Support/Host.cpp` on macOS: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/25781/consoleFull FAILED: unittests/Support/CMakeFiles/SupportTests.dir/Host.cpp.o /Applications/Xcode.app/Co

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added a comment. Thanks for the patch! I left a suggestion inline. Comment at: clang/lib/Sema/SemaChecking.cpp:16721 +bool Sema::SemaBuiltinElementwiseMathFloatArg(CallExpr *TheCall) { + if (checkArgCount(*this, TheCall, 1)) If I understand correctly,

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11337 +def err_builtin_float_invalid_arg_type: Error < + "%ordinal0 argument must be a " There's no need to add a new error message here. `err_builtin_invalid_arg_type`

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2104 +TheCall, [this](QualType ArgTy, SourceLocation ArgLoc) -> bool { + QualType EltTy = ArgTy; + if (auto *VecTy = EltTy->getAs()) Could you add a com

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16727-16728 QualType TyA = A.get()->getType(); - if (checkMathBuiltinElementType(*this, ArgLoc, TyA)) + if (checkMathBuiltinElementType(*this, ArgLoc, TyA) || + ExtraCheck(TyA, ArgLoc)) return

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2113 + case Builtin::BI__builtin_reduce_xor: if (SemaBuiltinReduceMath(TheCall)) return ExprError(); I think `reduce_xor` is only specified for integer types, so I think we need

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added a comment. Thanks for the update, it looks like it should be in line with @aaron.ballman's suggestions! I think it might be good to split off the refactoring of `SemaBuiltinElementwiseMathOneArg`-> `PrepareBuiltinElementwiseMathOneArgCall` and the update for `BI__builtin_elementwis

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2116 + + // __builtin_reduce_xor restricts the element type to vector of integers type + // only. nit: the element type will be restricted to `int`, so maybe say something like `only supp

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn added a comment. ping :) Any additional thoughts? Since the original concerns were raised both @manojgupta and myself tried to share a bit of additional background on the motivation and to clarify the difference between `-mXXX` and `-march`. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn added a comment. In D113779#3192009 , @SjoerdMeijer wrote: > Ok, fair enough, perhaps adding features is a valid use-case. > > I will refrain from commenting on "things are terribly broken". I agree it > is broken, but in a different way than sug

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

fhahn accepted this revision. fhahn added a comment. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

fhahn added a reviewer: aaron.ballman. fhahn added inline comments. Comment at: clang/test/CodeGen/aarch64-complex-half-math.c:1 +// RUN: %clang_cc1 %s -O1 -emit-llvm -triple aarch64-unknown-unknown -ffast-math -o - | FileCheck %s --check-prefix=AARCH64 + peterw

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

fhahn added a comment. It looks like this patch changed the value of `__FLT_EVAL_METHOD__` when building on macOS for some configurations. This is causing build failures when using macOS 10.15's `math.h` and that is breaking most builds on GreenDragon, e.g. : https://green.lab.llvm.org/green/j

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

fhahn added a comment. In D109239#3340872 , @zahiraam wrote: > @fhahn I think the last commit fixes the issue. I am currently testing it on > MacOS 10.14 and it is still going (slow remote machine). I would like to get > your permission to push this pa

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

fhahn created this revision. fhahn added reviewers: simon_tatham, dmgreen, tmatheson, tyb0807. Herald added a subscriber: kristof.beyls. Herald added a project: All. fhahn requested review of this revision. Herald added a project: clang. This test file has grown to the point where it takes a huge

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

fhahn added a comment. Herald added a subscriber: pcwang-thead. Herald added a project: All. Unfortunately some of the intrinsics tests have grown so large the the consistently hit the 10 minute timeout in the Phabricator precommit tests, e.g. see https://reviews.llvm.org/harbormaster/unit/15222

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

fhahn added a comment. Also see https://github.com/llvm/llvm-project/issues/54168 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117860/new/ https://reviews.llvm.org/D117860 ___ cfe-commits mailing list c

[PATCH] D120876: [Driver] Split up huge arm-cortex-cpus.c test.

fhahn created this revision. fhahn added reviewers: simon_tatham, dmgreen, tmatheson, tyb0807. Herald added a subscriber: kristof.beyls. Herald added a project: All. fhahn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test file has g

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

fhahn added a comment. In D120875#3356432 , @simon_tatham wrote: >> While splitting up the test file is not ideal [...] > > Actually I'm not so sure. I'd almost rather go further, and split it up into > lots of //much// smaller files, each with some kin

[PATCH] D120967: [NFC] Divide tests into smaller files

fhahn accepted this revision. fhahn added a comment. Thanks for splitting up the tests! Looks like pre-commit CI is happy again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120967/new/ https://reviews.llvm.org/D120967 ___

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

fhahn updated this revision to Diff 412971. fhahn added a comment. Thanks everyone! I added a TODO for splitting up by category and plan to land this soon. The update also adds a missing GENERIC check line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f5bdaf481c3: [Driver] Split up huge aarch64-cpus.c test. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D120876: [Driver] Split up huge arm-cortex-cpus.c test.

fhahn updated this revision to Diff 412974. fhahn added a comment. Thanks! I added a TODO to split it up by categories and I'll plan to land the change soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120876/new/ https://reviews.llvm.org/D1208

[PATCH] D120876: [Driver] Split up huge arm-cortex-cpus.c test.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb42e557d8b4: [Driver] Split up huge arm-cortex-cpus.c test. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

fhahn added a comment. Thanks! Comment at: clang/test/Driver/aarch64-cpus.c:2 +// Check target CPUs are correctly passed. +// TODO: The files should be split up by categories, e.g. by architecture versions, to avoid excessive test // times for large single test files. ---

[PATCH] D116736: [Clang] Add __builtin_reduce_or and __builtin_reduce_and

fhahn added a comment. @junaire did you already get commit access or should I commit this change on your behalf? In D116736#3239530 , @junaire wrote: > In D116736#3230040 , @fhahn wrote: > >> LGTM, thanks! >> >>

[PATCH] D116736: [Clang] Add __builtin_reduce_or and __builtin_reduce_and

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. In D116736#3242623 , @junaire wrote: >> @junaire did you already get commit access or should I commit this change on >> your behalf? > > Yeah, I already

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

fhahn added a comment. Not really familiar with testing for clang headers. Is it possible to test the new attributes have the desired effect? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 _

[PATCH] D117431: [IRBuilder] Migrate and-folding to value-based FoldAnd.

fhahn created this revision. fhahn added reviewers: reames, nikic, lebedev.ri, nhaehnle. Herald added a subscriber: dexonsmith. fhahn requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Similar to the migration of or-folding to FoldOr, the

[PATCH] D117431: [IRBuilder] Migrate and-folding to value-based FoldAnd.

fhahn updated this revision to Diff 400531. fhahn added a comment. Rebase to re-trigger tests. Looks like there are a couple of additional tests that need updating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117431/new/ https://reviews.llvm.org

[PATCH] D117431: [IRBuilder] Migrate and-folding to value-based FoldAnd.

fhahn updated this revision to Diff 400583. fhahn added a subscriber: Meinersbur. fhahn added a comment. Herald added a reviewer: bollu. Fix failing polly tests. @Meinersbur looks like some Polly tests were relying on the IRBuilder folding `and i1 %X, true`. This patch moves the logic to a dedic

[PATCH] D117431: [IRBuilder] Migrate and-folding to value-based FoldAnd.

fhahn updated this revision to Diff 401253. fhahn added a comment. rebase to trigger new run of precommit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117431/new/ https://reviews.llvm.org/D117431 Files: clang/test/CodeGen/catch-nullptr-an

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2535 ArgAttrs[FirstIRArg + i] = llvm::AttributeSet::get(getLLVMContext(), Attrs); } nlopes wrote: > ab wrote: > > Hmm, if I'm reading this right, this overwrites the

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2535 ArgAttrs[FirstIRArg + i] = llvm::AttributeSet::get(getLLVMContext(), Attrs); } nlopes wrote: > fhahn wrote: > > nlopes wrote: > > > ab wrote: > > > > Hmm, if I'm

[PATCH] D117431: [IRBuilder] Migrate and-folding to value-based FoldAnd.

This revision was automatically updated to reflect the committed changes. Closed by commit rG782c0dd1a1c2: [IRBuilder] Migrate and-folding to value-based FoldAnd. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117431/new/ https:/

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2535 ArgAttrs[FirstIRArg + i] = llvm::AttributeSet::get(getLLVMContext(), Attrs); } nlopes wrote: > sammccall wrote: > > fhahn wrote: > > > nlopes wrote: > > > > fhah

<    1   2   3   4   5   6   7   8   >