fcharlie added a comment.
@compnerd Please commit this, Thanks
Repository:
rCXX libc++
https://reviews.llvm.org/D42354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fcharlie accepted this revision.
fcharlie added a comment.
libcxx: Fix libcxx MSVC C++17 redefinition of 'align_val_t'
Differential Revision: https://reviews.llvm.org/D42354
Repository:
rCXX libc++
https://reviews.llvm.org/D42354
___
fcharlie added a comment.
In https://reviews.llvm.org/D42354#988656, @mclow.lists wrote:
> I'm pretty sure I don't want to know what MSFT is doing putting `align_val_t`
> in *that* header file.
>
> Now I'm wondering if those values `__zero` and `__max` are actually used.
Use
> grep
fcharlie added a comment.
In https://reviews.llvm.org/D42354#988656, @mclow.lists wrote:
> I'm pretty sure I don't want to know what MSFT is doing putting `align_val_t`
> in *that* header file.
>
> Now I'm wondering if those values `__zero` and `__max` are actually used.
Use
> grep
fcharlie added a comment.
In https://reviews.llvm.org/D42354#984067, @STL_MSFT wrote:
> Seems reasonable to me.
Thanks
Repository:
rCXX libc++
https://reviews.llvm.org/D42354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
fcharlie updated this revision to Diff 130871.
https://reviews.llvm.org/D42354
Files:
include/new
Index: include/new
===
--- include/new
+++ include/new
@@ -160,6 +160,7 @@
#endif // defined(_LIBCPP_BUILDING_NEW) ||
fcharlie created this revision.
Herald added a reviewer: EricWF.
Herald added a subscriber: cfe-commits.
When use
clang-cl -std:c++17 -Iinclude\c++\v1 hello.cc c++.lib
In file included from hello.cc:1:
In file included from include\c++\v1\iostream:38:
In file included from
