[PATCH] D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD

fcambus added a comment. Agreed, that makes sense. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128757/new/ https://reviews.llvm.org/D128757 ___ cfe-commits mailing list

[PATCH] D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD

fcambus added a comment. In D128757#3616795 , @MaskRay wrote: > I am unsure it is useful to add a test for all OSxfuse_ld_value combinations, > especially for an ELF OS like NetBSD which shares many characteristics with > other ELF OSes. It will be

[PATCH] D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD

fcambus created this revision. fcambus added a reviewer: MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D128620: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for NetBSD

fcambus added a comment. In D128620#3611156 , @MaskRay wrote: > It's best to switch to LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on layout at some > point. Noted, thanks. I will investigate switching both NetBSD and OpenBSD in the future. Repository: rG

[PATCH] D128620: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa89bb3435e0: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for NetBSD (authored by fcambus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128620: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for NetBSD

fcambus created this revision. fcambus added a reviewer: MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to D128512

[PATCH] D128512: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for OpenBSD

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ff4fb6573c1: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for OpenBSD (authored by fcambus). Changed prior to commit:

[PATCH] D109051: Use Component in OpenBSD::getCompilerRT to find libraries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3caa32b26f5a: [Driver] Use Component in OpenBSD::getCompilerRT to find libraries (authored by blackgnezdo, committed by fcambus). Repository: rG

[PATCH] D128512: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for OpenBSD.

fcambus created this revision. fcambus added a reviewer: MaskRay. Herald added subscribers: StephenFan, krytarowski. Herald added a project: All. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was requested in D109244

[PATCH] D114530: [clang][scan-build] Use cc/c++ instead of gcc/g++ on FreeBSD.

This revision was automatically updated to reflect the committed changes. Closed by commit rG69deb1371fd4: Use cc/c++ instead of gcc/g++ on FreeBSD. (authored by fcambus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114530/new/

[PATCH] D114530: [clang][scan-build] Use cc/c++ instead of gcc/g++ on FreeBSD.

fcambus created this revision. fcambus added reviewers: emaste, mgorny. Herald added subscribers: krytarowski, arichardson. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All supported FreeBSD platforms do not have GCC in base

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ecd4a4d01a3: [clang][scan-build] Use uname -s to detect the operating system. (authored by fcambus). Repository: rG LLVM Github Monorepo

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

fcambus added a comment. Sure, I reverted to the previous revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111797/new/ https://reviews.llvm.org/D111797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

fcambus updated this revision to Diff 383293. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111797/new/ https://reviews.llvm.org/D111797 Files: clang/tools/scan-build/libexec/ccc-analyzer Index: clang/tools/scan-build/libexec/ccc-analyzer

[PATCH] D111760: [clang] Support __float128 on DragonFlyBSD.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb471e25a5924: [clang] Support __float128 on DragonFlyBSD. (authored by fcambus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111760/new/

[PATCH] D111760: [clang] Support __float128 on DragonFlyBSD.

fcambus added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:182 DefineStd(Builder, "unix", Opts); +if (this->HasFloat128) + Builder.defineMacro("__FLOAT128__"); mgorny wrote: > Maybe I'm missing something but do you actually need

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

fcambus added a comment. In D111797#3069103 , @brad wrote: > I'm not a Perl guy but I'm wondering about simplifying what it is doing there > to just `uname -s` eq 'OpenBSD'? Yes, I think it makes sense. Just sent an updated revision. CHANGES SINCE

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

fcambus updated this revision to Diff 380263. fcambus added a comment. Avoid using regexps and use the 'eq' operator for doing string comparison. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111797/new/ https://reviews.llvm.org/D111797 Files:

[PATCH] D109051: Use Component in OpenBSD::getCompilerRT to find libraries

fcambus added a comment. Any update on this? For info, we started shipping libraries in the OpenBSD base system using this naming scheme for architectures on which we build Clang. CHANGES SINCE LAST ACTION

[PATCH] D111805: [Driver][NetBSD] Use T reference instead of getToolChain().getTriple().

This revision was automatically updated to reflect the committed changes. Closed by commit rGecef0359538c: [Driver][NetBSD] Use Triple reference instead of ToolChain.getTriple(). (authored by fcambus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111805: [Driver][NetBSD] Use T reference instead of getToolChain().getTriple().

fcambus marked an inline comment as done. fcambus added a comment. Yes, I rebuilt everything with the updated diff and ran `check-clang-driver`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111805/new/ https://reviews.llvm.org/D111805 ___

[PATCH] D111805: [Driver][NetBSD] Use T reference instead of getToolChain().getTriple().

fcambus marked an inline comment as done. fcambus added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:35 const Driver = ToolChain.getDriver(); + const llvm::Triple = ToolChain.getTriple(); mgorny wrote: > Is there a specific reason

[PATCH] D111805: [Driver][NetBSD] Use T reference instead of getToolChain().getTriple().

fcambus updated this revision to Diff 379934. fcambus added a comment. Use 'Triple' instead of 'T'. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111805/new/ https://reviews.llvm.org/D111805 Files: clang/lib/Driver/ToolChains/NetBSD.cpp Index:

[PATCH] D111793: [Driver][Darwin] Use T reference instead of getToolChain().getTriple().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ecbcd058fbd: [Driver][Darwin] Use T reference instead of getToolChain().getTriple(). (authored by fcambus). Repository: rG LLVM Github Monorepo

[PATCH] D111786: [Driver][WebAssembly] Use ToolChain reference instead of getToolChain().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7a3214306cb: [Driver][WebAssembly] Use ToolChain reference instead of getToolChain(). (authored by fcambus). Repository: rG LLVM Github Monorepo

[PATCH] D111805: [Driver][NetBSD] Use T reference instead of getToolChain().getTriple().

fcambus created this revision. fcambus added reviewers: krytarowski, mgorny. Herald added a subscriber: fedor.sergeev. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

fcambus created this revision. fcambus added a reviewer: brad. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111797 Files:

[PATCH] D111793: [Driver][Darwin] Use T reference instead of getToolChain().getTriple().

fcambus created this revision. fcambus added reviewers: arphaman, vsk, ahatanak, thakis. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111793 Files:

[PATCH] D111786: [Driver][WebAssembly] Use ToolChain reference instead of getToolChain().

fcambus created this revision. fcambus added reviewers: sbc100, aheejin. Herald added subscribers: ecnelises, sunfish, jgravelle-google, dschuff. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D111760: [clang] Support __float128 on DragonFlyBSD.

fcambus created this revision. fcambus added reviewers: emaste, joerg, mgorny, krytarowski. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111760 Files:

[PATCH] D111462: [Driver][OpenBSD] Use ToolChain reference instead of getToolChain().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6417260a57dd: [Driver][OpenBSD] Use ToolChain reference instead of getToolChain(). (authored by fcambus). Repository: rG LLVM Github Monorepo

[PATCH] D111462: [Driver][OpenBSD] Use ToolChain reference instead of getToolChain().

fcambus created this revision. fcambus added a reviewer: brad. Herald added a subscriber: fedor.sergeev. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111462

[PATCH] D111340: [Driver][NetBSD] Use ToolChain reference instead of getToolChain().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. fcambus marked an inline comment as done. Closed by commit rG1f90b365bd62: [Driver][NetBSD] Use ToolChain reference instead of getToolChain(). (authored by fcambus).

[PATCH] D111340: [Driver][NetBSD] Use ToolChain reference instead of getToolChain().

fcambus marked an inline comment as done. fcambus added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:32 const char *LinkingOutput) const { const Driver = getToolChain().getDriver(); mgorny wrote:

[PATCH] D111340: [Driver][NetBSD] Use ToolChain reference instead of getToolChain().

fcambus updated this revision to Diff 378124. fcambus added a comment. Herald added a subscriber: fedor.sergeev. Also define and use ToolChain reference in netbsd::Assembler::ConstructJob(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111340/new/ https://reviews.llvm.org/D111340

[PATCH] D111340: [Driver][NetBSD] Use ToolChain reference instead of getToolChain().

fcambus created this revision. fcambus added reviewers: krytarowski, mgorny. fcambus requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D110836: [CMake] Fix typo in error message for LLD in bootstrap builds.

fcambus added a comment. @xgupta Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110836/new/ https://reviews.llvm.org/D110836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110836: [CMake] Fix typo in error message for LLD in bootstrap builds.

fcambus created this revision. fcambus added a reviewer: xgupta. Herald added a subscriber: mgorny. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110836 Files:

[PATCH] D110763: [clang] Update Clang version from 13 to 14 in scan-build.1.

fcambus created this revision. fcambus added a reviewer: xgupta. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110763 Files:

[PATCH] D110750: [clang] Fix sentence in the usage section of ThinLTO docs.

fcambus created this revision. fcambus added reviewers: tejohnson, xgupta. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D110715: [clang] Fix library name (libsupc++) in the admonition note.

fcambus created this revision. fcambus added reviewers: rsmith, xgupta. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110715 Files: clang/docs/Toolchain.rst

[PATCH] D110041: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils.

fcambus added a comment. > I can push this for you @fcambus. Thanks for committing this. I also have a similar diff for compiler-rt, in D110039 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110041/new/

[PATCH] D110041: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils.

fcambus created this revision. fcambus added a reviewer: JDevlieghere. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110041 Files:

[PATCH] D109349: [clang][scan-build] Use cc/c++ instead of gcc/g++ on OpenBSD.

fcambus created this revision. fcambus added a reviewer: brad. Herald added a subscriber: krytarowski. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The default was gcc/g++ for all platforms other than Darwin, but most OpenBSD

[PATCH] D109244: [clang] Allow the OpenBSD driver to link the libclang_rt.profile library.

fcambus created this revision. fcambus added a reviewer: brad. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this change, passing -fprofile-instr-generate -fcoverage-mapping when building programs will attempt linking

[PATCH] D106867: [scan-build] Fix a typo in the manual page: s/contraint/constraint.

fcambus created this revision. fcambus added a reviewer: mgorny. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix a typo in the scan-build manual page: s/contraint/constraint. While there, update hardcoded Clang version

[PATCH] D106664: [clang][docs] Fix typos in Options.td and regen ClangCommandLineReference.rst.

fcambus created this revision. Herald added a subscriber: dang. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix a couple of typos in Options.td and regenerate ClangCommandLineReference.rst. Repository: rG LLVM Github