[clang] Reapply "[Clang] Take libstdc++ into account during GCC detection" #154368 (PR #154487)

2025-08-21 Thread Frederik Harwath via cfe-commits
frederik-h wrote: @MaskRay This fixes the two issues that you mentioned in your [comment](https://github.com/llvm/llvm-project/pull/145056#issuecomment-3204637760) on the original PR. I have checked the build bot errors and I did not see any other issues. This means the patch can probably be r

[clang] [Clang] Take libstdc++ into account during GCC detection (PR #145056)

2025-08-20 Thread Frederik Harwath via cfe-commits
frederik-h wrote: > > LLVM Buildbot has detected a new failure on builder > > `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while > > building `clang` at step 6 "test-build-unified-tree-check-all". > > Full details are available at: > > [lab.llvm.org/buildbot#/builders/144/

[clang] Reapply "[Clang] Take libstdc++ into account during GCC detection" #154368 (PR #154487)

2025-08-20 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h created https://github.com/llvm/llvm-project/pull/154487 This patch reapplies https://github.com/llvm/llvm-project/pull/145056. The test in the original PR did not specify a target in the clang RUN line and used a wrong way of piping to FileCheck. >From a203bd094

[clang] Revert "[Clang] Take libstdc++ into account during GCC detection" (PR #154368)

2025-08-19 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h closed https://github.com/llvm/llvm-project/pull/154368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Take libstdc++ into account during GCC detection" (PR #154368)

2025-08-19 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h auto_merge_enabled https://github.com/llvm/llvm-project/pull/154368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Take libstdc++ into account during GCC detection" (PR #154368)

2025-08-19 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h updated https://github.com/llvm/llvm-project/pull/154368 >From f139b512b4fa5aca1afb5005e6967c9bae43973e Mon Sep 17 00:00:00 2001 From: Frederik Harwath Date: Tue, 19 Aug 2025 17:57:41 +0200 Subject: [PATCH 1/2] Revert "[Clang] Take libstdc++ into account during GCC

[clang] Revert "[Clang] Take libstdc++ into account during GCC detection" (PR #154368)

2025-08-19 Thread Frederik Harwath via cfe-commits
frederik-h wrote: I need some time to look into the build bot failures. The new test probably needs to be restricted to a specific target. https://github.com/llvm/llvm-project/pull/154368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] Revert "[Clang] Take libstdc++ into account during GCC detection" (PR #154368)

2025-08-19 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h created https://github.com/llvm/llvm-project/pull/154368 Reverts llvm/llvm-project#145056 >From f139b512b4fa5aca1afb5005e6967c9bae43973e Mon Sep 17 00:00:00 2001 From: Frederik Harwath Date: Tue, 19 Aug 2025 17:57:41 +0200 Subject: [PATCH] Revert "[Clang] Take lib

[clang] [Clang] Take libstdc++ into account during GCC detection (PR #145056)

2025-08-19 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h closed https://github.com/llvm/llvm-project/pull/145056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Take libstdc++ into account during GCC detection (PR #145056)

2025-08-19 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h updated https://github.com/llvm/llvm-project/pull/145056 >From 87c03ace23467a7d6cb7e466a02309b5b287a013 Mon Sep 17 00:00:00 2001 From: Frederik Harwath Date: Wed, 19 Feb 2025 16:01:56 +0100 Subject: [PATCH 1/8] [Clang] Take libstdc++ into account during GCC detecti

[clang] [Clang] Take libstdc++ into account during GCC detection (PR #145056)

2025-08-18 Thread Frederik Harwath via cfe-commits
frederik-h wrote: > Signalling my support for the changes. It looks like @MaskRay is also happy > with them. So I'd say let's give folks one more week for additional before > landing the changes. Thanks @AaronBallman! I am going to merge the PR tomorrow. https://github.com/llvm/llvm-project/

[clang] [Clang] Take libstdc++ into account during GCC detection (PR #145056)

2025-08-11 Thread Frederik Harwath via cfe-commits
frederik-h wrote: Ping. https://github.com/llvm/llvm-project/pull/145056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Take libstdc++ into account during GCC detection (PR #145056)

2025-08-01 Thread Frederik Harwath via cfe-commits
frederik-h wrote: > > This looks quite good. I'm curious if others have any feedback. > > No additional feedback from me, but this is far enough outside of my > wheelhouse that I don't feel my LG should be enough to land it on. Can anyone else help with a review (@jyknight, @tahonermann, ...)?

[clang] [Clang] Take libstdc++ into account during GCC detection (PR #145056)

2025-07-29 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h updated https://github.com/llvm/llvm-project/pull/145056 >From 87c03ace23467a7d6cb7e466a02309b5b287a013 Mon Sep 17 00:00:00 2001 From: Frederik Harwath Date: Wed, 19 Feb 2025 16:01:56 +0100 Subject: [PATCH 1/8] [Clang] Take libstdc++ into account during GCC detecti

[clang] [Clang] Take libstdc++ into account during GCC detection (PR #145056)

2025-07-28 Thread Frederik Harwath via cfe-commits
frederik-h wrote: Ping. https://github.com/llvm/llvm-project/pull/145056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Take libstdc++ into account during GCC detection (PR #145056)

2025-07-09 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h updated https://github.com/llvm/llvm-project/pull/145056 >From 87c03ace23467a7d6cb7e466a02309b5b287a013 Mon Sep 17 00:00:00 2001 From: Frederik Harwath Date: Wed, 19 Feb 2025 16:01:56 +0100 Subject: [PATCH 1/7] [Clang] Take libstdc++ into account during GCC detecti

[clang] [Clang] Take libstdc++ into account during GCC detection (PR #145056)

2025-07-08 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h edited https://github.com/llvm/llvm-project/pull/145056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] WIP: Take libstdc++ into account during GCC detection (PR #145056)

2025-07-08 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h updated https://github.com/llvm/llvm-project/pull/145056 >From 87c03ace23467a7d6cb7e466a02309b5b287a013 Mon Sep 17 00:00:00 2001 From: Frederik Harwath Date: Wed, 19 Feb 2025 16:01:56 +0100 Subject: [PATCH 1/5] [Clang] Take libstdc++ into account during GCC detecti

[clang] [Clang] WIP: Take libstdc++ into account during GCC detection (PR #145056)

2025-07-08 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h updated https://github.com/llvm/llvm-project/pull/145056 >From 87c03ace23467a7d6cb7e466a02309b5b287a013 Mon Sep 17 00:00:00 2001 From: Frederik Harwath Date: Wed, 19 Feb 2025 16:01:56 +0100 Subject: [PATCH 1/4] [Clang] Take libstdc++ into account during GCC detecti

[clang] [Clang] WIP: Take libstdc++ into account during GCC detection (PR #145056)

2025-07-08 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h updated https://github.com/llvm/llvm-project/pull/145056 >From 87c03ace23467a7d6cb7e466a02309b5b287a013 Mon Sep 17 00:00:00 2001 From: Frederik Harwath Date: Wed, 19 Feb 2025 16:01:56 +0100 Subject: [PATCH 1/3] [Clang] Take libstdc++ into account during GCC detecti

[clang] [clang][test] Remove duplication from gcc toolchain test (NFC) (PR #146487)

2025-07-01 Thread Frederik Harwath via cfe-commits
frederik-h wrote: Merging without review as this change is trivial. https://github.com/llvm/llvm-project/pull/146487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][test] Remove duplication from gcc toolchain test (NFC) (PR #146487)

2025-07-01 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h created https://github.com/llvm/llvm-project/pull/146487 Changes from Commit 40aab0412fe7a14781e133627c2bb0a22761eac8 "[test] Migrate -gcc-toolchain with space separator to --gcc-toolchain=" made two previously different RUN lines equal. Remove one RUN line. >Fr

[clang] [Clang] WIP: Take libstdc++ into account during GCC detection (PR #145056)

2025-06-20 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h edited https://github.com/llvm/llvm-project/pull/145056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] WIP: Take libstdc++ into account during GCC detection (PR #145056)

2025-06-20 Thread Frederik Harwath via cfe-commits
frederik-h wrote: See also this related [discourse thread](https://discourse.llvm.org/t/rfc-take-libstdc-into-account-during-gcc-detection/86992). https://github.com/llvm/llvm-project/pull/145056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Take libstdc++ into account during GCC detection (PR #145056)

2025-06-20 Thread Frederik Harwath via cfe-commits
https://github.com/frederik-h created https://github.com/llvm/llvm-project/pull/145056 The Generic_GCC::GCCInstallationDetector class always picks the latest available GCC installation directory. This often breaks C++ compilation on systems on which this directory does not contain a libstdc++