gburgessiv wrote:
OK, thanks! I'll try to find someone with more context later today :)
https://github.com/llvm/llvm-project/pull/111439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
gburgessiv wrote:
Hey Damyan, GH suggested you as a reviewer for this. Would you be able to TAL?
Happy to find someone else if not :)
https://github.com/llvm/llvm-project/pull/111439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
https://github.com/gburgessiv created
https://github.com/llvm/llvm-project/pull/111439
At present, `__builtin_available` is really restrictive with its use. Overall,
this seems like a good thing, since the analyses behind it are not very
expensive.
That said, it's very straightforward to supp
Author: George Burgess IV
Date: 2021-08-03T19:56:27Z
New Revision: 2e75986a21e543ac9f169a067542eec590339ac0
URL:
https://github.com/llvm/llvm-project/commit/2e75986a21e543ac9f169a067542eec590339ac0
DIFF:
https://github.com/llvm/llvm-project/commit/2e75986a21e543ac9f169a067542eec590339ac0.diff
Author: Michael Benfield
Date: 2021-07-28T20:52:57Z
New Revision: e12e02df09a967f644cf28136a7361bce7a5bb91
URL:
https://github.com/llvm/llvm-project/commit/e12e02df09a967f644cf28136a7361bce7a5bb91
DIFF:
https://github.com/llvm/llvm-project/commit/e12e02df09a967f644cf28136a7361bce7a5bb91.diff
L
Author: Michael Benfield
Date: 2021-06-14T10:25:59-07:00
New Revision: 20f7b5f3f9c8ebbbe7bf6648c824b815385d4bf7
URL:
https://github.com/llvm/llvm-project/commit/20f7b5f3f9c8ebbbe7bf6648c824b815385d4bf7
DIFF:
https://github.com/llvm/llvm-project/commit/20f7b5f3f9c8ebbbe7bf6648c824b815385d4bf7.di
Author: Michael Benfield
Date: 2021-06-01T15:38:48-07:00
New Revision: cf49cae278b4e972cd2547d72f9ee7d9d69a3af4
URL:
https://github.com/llvm/llvm-project/commit/cf49cae278b4e972cd2547d72f9ee7d9d69a3af4
DIFF:
https://github.com/llvm/llvm-project/commit/cf49cae278b4e972cd2547d72f9ee7d9d69a3af4.di
Author: George Burgess IV
Date: 2021-01-20T11:03:34-08:00
New Revision: b270fd59f0a86fe737853abc43e76b9d29a67eea
URL:
https://github.com/llvm/llvm-project/commit/b270fd59f0a86fe737853abc43e76b9d29a67eea
DIFF:
https://github.com/llvm/llvm-project/commit/b270fd59f0a86fe737853abc43e76b9d29a67eea.d
Author: Jeffrey T Mott
Date: 2021-01-07T12:34:07-08:00
New Revision: 275f30df8ad6de75e1f29e4b33eaeb67686caf0d
URL:
https://github.com/llvm/llvm-project/commit/275f30df8ad6de75e1f29e4b33eaeb67686caf0d
DIFF:
https://github.com/llvm/llvm-project/commit/275f30df8ad6de75e1f29e4b33eaeb67686caf0d.diff
Author: Christopher Di Bella
Date: 2020-11-02T11:03:28-08:00
New Revision: ba18bc4925d8cbd4a9354629617cbcafbbd48941
URL:
https://github.com/llvm/llvm-project/commit/ba18bc4925d8cbd4a9354629617cbcafbbd48941
DIFF:
https://github.com/llvm/llvm-project/commit/ba18bc4925d8cbd4a9354629617cbcafbbd4894
Author: Christopher Di Bella
Date: 2020-10-28T16:18:23-07:00
New Revision: 425a83a5f069eb1a692145d2c92e6d3bfe564a62
URL:
https://github.com/llvm/llvm-project/commit/425a83a5f069eb1a692145d2c92e6d3bfe564a62
DIFF:
https://github.com/llvm/llvm-project/commit/425a83a5f069eb1a692145d2c92e6d3bfe564a6
Author: Florian Mayer
Date: 2020-10-01T10:09:26-07:00
New Revision: 9d40fb808fd0fbd33eb3b50c20d7f402de5db91e
URL:
https://github.com/llvm/llvm-project/commit/9d40fb808fd0fbd33eb3b50c20d7f402de5db91e
DIFF:
https://github.com/llvm/llvm-project/commit/9d40fb808fd0fbd33eb3b50c20d7f402de5db91e.diff
Author: George Burgess IV
Date: 2020-04-16T11:54:10-07:00
New Revision: 94908088a831141cfbdd15fc5837dccf30cfeeb6
URL:
https://github.com/llvm/llvm-project/commit/94908088a831141cfbdd15fc5837dccf30cfeeb6
DIFF:
https://github.com/llvm/llvm-project/commit/94908088a831141cfbdd15fc5837dccf30cfeeb6.d
Author: George Burgess IV
Date: 2020-04-15T11:05:22-07:00
New Revision: 2dd17ff08165e6118e70f00e22b2c36d2d4e0a9a
URL:
https://github.com/llvm/llvm-project/commit/2dd17ff08165e6118e70f00e22b2c36d2d4e0a9a
DIFF:
https://github.com/llvm/llvm-project/commit/2dd17ff08165e6118e70f00e22b2c36d2d4e0a9a.d
Author: George Burgess IV
Date: 2020-04-14T14:33:01-07:00
New Revision: 91c8c74180ced4b82da02f2544f3978f72003d37
URL:
https://github.com/llvm/llvm-project/commit/91c8c74180ced4b82da02f2544f3978f72003d37
DIFF:
https://github.com/llvm/llvm-project/commit/91c8c74180ced4b82da02f2544f3978f72003d37.d
Author: George Burgess IV
Date: 2019-11-22T20:11:16-08:00
New Revision: 380a6452b2e98d9c34828503edf8032f6b4c82d3
URL:
https://github.com/llvm/llvm-project/commit/380a6452b2e98d9c34828503edf8032f6b4c82d3
DIFF:
https://github.com/llvm/llvm-project/commit/380a6452b2e98d9c34828503edf8032f6b4c82d3.d
Author: George Burgess IV
Date: 2019-11-22T18:13:18-08:00
New Revision: 9f13a032b6d7f720caf6511d0c9b1b6b7d2bbc67
URL:
https://github.com/llvm/llvm-project/commit/9f13a032b6d7f720caf6511d0c9b1b6b7d2bbc67
DIFF:
https://github.com/llvm/llvm-project/commit/9f13a032b6d7f720caf6511d0c9b1b6b7d2bbc67.d
Author: gbiv
Date: Mon Aug 5 16:19:15 2019
New Revision: 367947
URL: http://llvm.org/viewvc/llvm-project?rev=367947&view=rev
Log:
[Sema] attempt to appease buildbots after r367940
A buildbot got angry about this new test, with error messages like:
warn-nullchar-nullptr.c Line 16: use of undecla
Author: gbiv
Date: Mon Aug 5 15:15:40 2019
New Revision: 367940
URL: http://llvm.org/viewvc/llvm-project?rev=367940&view=rev
Log:
[Sema] Add -Wpointer-compare
This patch adds a warning that diagnoses comparisons of pointers to
'\0'. This is often indicative of a bug (e.g. the user might've
forgo
Author: gbiv
Date: Thu Jul 25 15:23:40 2019
New Revision: 367067
URL: http://llvm.org/viewvc/llvm-project?rev=367067&view=rev
Log:
[Sema] add -Walloca to flag uses of `alloca`
This CL adds an optional warning to diagnose uses of the
`__builtin_alloca` family of functions. The use of these functio
Author: gbiv
Date: Tue Jul 16 15:32:17 2019
New Revision: 366276
URL: http://llvm.org/viewvc/llvm-project?rev=366276&view=rev
Log:
Fix a typo in target features
There was a slight typo in r364352 that ended up causing our backend to
complain on some x86 Android builds. This CL fixes that.
Differ
Author: gbiv
Date: Fri Jun 21 13:49:47 2019
New Revision: 364104
URL: http://llvm.org/viewvc/llvm-project?rev=364104&view=rev
Log:
clang-format a block; NFC
The indentation of the return here was off, and confusing as a result.
Cleaned up a bit extra while I was in the area.
Modified:
cfe/tr
Author: gbiv
Date: Thu Jun 13 17:35:17 2019
New Revision: 363346
URL: http://llvm.org/viewvc/llvm-project?rev=363346&view=rev
Log:
[Targets] Move soft-float-abi filtering to `initFeatureMap`
ARM has a special target feature called soft-float-abi. This feature is
special, since we get it passed to
Author: gbiv
Date: Wed Jun 5 22:21:45 2019
New Revision: 362673
URL: http://llvm.org/viewvc/llvm-project?rev=362673&view=rev
Log:
android: add a close-on-exec check on pipe()
On Android, pipe() is better to be replaced by pipe2() with O_CLOEXEC
flag to avoid file descriptor leakage.
Patch by Ji
Author: gbiv
Date: Wed Jun 5 22:21:39 2019
New Revision: 362672
URL: http://llvm.org/viewvc/llvm-project?rev=362672&view=rev
Log:
android: add a close-on-exec check on pipe2()
On Android, pipe2() is better to set O_CLOEXEC flag to avoid file
descriptor leakage.
Patch by Jian Cai!
Differential
Author: gbiv
Date: Wed May 22 19:52:39 2019
New Revision: 361457
URL: http://llvm.org/viewvc/llvm-project?rev=361457&view=rev
Log:
Remove unnecessary const&s; NFC
It's uncommon to rely on temporary lifetime extension when having a
regular, non-`const&` value behaves identically. Since `Twine::str
Author: gbiv
Date: Fri Mar 29 10:50:43 2019
New Revision: 357290
URL: http://llvm.org/viewvc/llvm-project?rev=357290&view=rev
Log:
Various fixes and additions to creduce-clang-crash.py
Some more additions to the script - mainly reducing the clang args after
the creduce run by removing them one by
Author: gbiv
Date: Wed Mar 20 18:01:53 2019
New Revision: 356636
URL: http://llvm.org/viewvc/llvm-project?rev=356636&view=rev
Log:
creduce-clang-crash.py: preprocess file + reduce commandline
This CL causes our creduce-clang-crash.py util to:
- try to preprocess the file before reducing
- try to
Author: gbiv
Date: Tue Mar 12 10:48:53 2019
New Revision: 355944
URL: http://llvm.org/viewvc/llvm-project?rev=355944&view=rev
Log:
Add a creduce script for clang crashes
This CL adds a script that calls C-Reduce on an input file and given the
clang crash script, which is used to generate an inter
Author: gbiv
Date: Sat Aug 4 18:37:07 2018
New Revision: 338962
URL: http://llvm.org/viewvc/llvm-project?rev=338962&view=rev
Log:
Use Optional instead of unique_ptr; NFC
Looks like the only reason we use a unique_ptr here is so that we can
conditionally construct a LogicalErrorHandler. It's a sm
Author: gbiv
Date: Mon Jul 23 19:10:53 2018
New Revision: 337796
URL: http://llvm.org/viewvc/llvm-project?rev=337796&view=rev
Log:
Fix unused variable warnings; NFC
Looks like MTE was previously used for its SourceLoc, but we're now
using a seperate SourceLocation here.
Modified:
cfe/trunk/l
Author: gbiv
Date: Thu Jun 28 14:36:00 2018
New Revision: 335927
URL: http://llvm.org/viewvc/llvm-project?rev=335927&view=rev
Log:
[Parse] Make -Wgcc-compat complain about for loop inits in C89
While clang allows declarations in for loop init statements in c89 and
gnu89, gcc does not. So, we shou
Thanks. :)
On Fri, May 25, 2018, 7:56 PM Richard Smith wrote:
> Congratulations?
>
> On Fri, 25 May 2018, 19:33 George Burgess IV via cfe-commits, <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: gbiv
>> Date: Fri May 25 19:29:14 2018
>> New Revision: 3
Author: gbiv
Date: Fri May 25 19:29:14 2018
New Revision: 33
URL: http://llvm.org/viewvc/llvm-project?rev=33&view=rev
Log:
Test commit; please ignore.
Modified:
cfe/trunk/lib/Sema/SemaAttr.cpp
Modified: cfe/trunk/lib/Sema/SemaAttr.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tru
Author: gbiv
Date: Fri May 25 16:40:59 2018
New Revision: 24
URL: http://llvm.org/viewvc/llvm-project?rev=24&view=rev
Log:
Fix typo + reflow comment; NFC
Reflow brings said comment below 80 cols
Modified:
cfe/trunk/include/clang/AST/ASTContext.h
Modified: cfe/trunk/include/clang/AST
Author: gbiv
Date: Tue Apr 10 14:22:22 2018
New Revision: 329759
URL: http://llvm.org/viewvc/llvm-project?rev=329759&view=rev
Log:
[clang-tidy] Add a `android-comparison-in-temp-failure-retry` check
This check attempts to catch buggy uses of the `TEMP_FAILURE_RETRY`
macro, which is provided by bo
Author: gbiv
Date: Mon Apr 9 18:11:26 2018
New Revision: 329652
URL: http://llvm.org/viewvc/llvm-project?rev=329652&view=rev
Log:
[AST] Attempt to fix buildbot warnings + appease MSVC; NFCI
GCC 4.8.4 on a bot was warning about `ArgPassingKind` not fitting in
`ArgPassingRestrictions`, which appea
Author: gbiv
Date: Fri Apr 6 10:22:36 2018
New Revision: 329428
URL: http://llvm.org/viewvc/llvm-project?rev=329428&view=rev
Log:
[clang-tidy] Sort includes; NFC
Modified:
clang-tools-extra/trunk/clang-tidy/android/AndroidTidyModule.cpp
Modified: clang-tools-extra/trunk/clang-tidy/android/A
Author: gbiv
Date: Mon Mar 19 20:27:44 2018
New Revision: 327945
URL: http://llvm.org/viewvc/llvm-project?rev=327945&view=rev
Log:
Properly construct `inline` members without initializers
Digging through commit logs, it appears the checks in this block predate
`inline` class variables. With them,
Author: gbiv
Date: Sat Mar 10 15:06:31 2018
New Revision: 327229
URL: http://llvm.org/viewvc/llvm-project?rev=327229&view=rev
Log:
[CodeGen] Eagerly emit lifetime.end markers for calls
In C, we'll wait until the end of the scope to clean up aggregate
temporaries used for returns from calls. This
Author: gbiv
Date: Fri Mar 9 17:11:17 2018
New Revision: 327192
URL: http://llvm.org/viewvc/llvm-project?rev=327192&view=rev
Log:
[CodeGen] Try to not call a dtor after lifetime.end
If CodeGenFunction::EmitCall is:
- asked to emit a call with an indirectly returned value,
- given an invalid retu
Author: gbiv
Date: Wed Mar 7 21:32:30 2018
New Revision: 326988
URL: http://llvm.org/viewvc/llvm-project?rev=326988&view=rev
Log:
[CodeGen] Emit lifetime.ends in both EH and non-EH blocks
Before this, we'd only emit lifetime.ends for these temps in
non-exceptional paths. This potentially made ou
Author: gbiv
Date: Wed Mar 7 18:15:12 2018
New Revision: 326980
URL: http://llvm.org/viewvc/llvm-project?rev=326980&view=rev
Log:
Fix an unused variable warning; NFC
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp
URL:
h
Author: gbiv
Date: Wed Mar 7 16:22:04 2018
New Revision: 326968
URL: http://llvm.org/viewvc/llvm-project?rev=326968&view=rev
Log:
Fix a doc typo; NFC
Modified:
cfe/trunk/lib/CodeGen/CGExpr.cpp
Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib
Author: gbiv
Date: Tue Mar 6 21:02:27 2018
New Revision: 326873
URL: http://llvm.org/viewvc/llvm-project?rev=326873&view=rev
Log:
Remove a placeholder
...Running tests in the wrong directory will often make them seem to
pass. Oops. :)
Modified:
cfe/trunk/test/CodeGenCXX/alloc-size.cpp
Modi
ed, I reverted your change
> in 326869 too. It should hopefully be easy for you to reland it.
>
> On Tue, Mar 6, 2018 at 2:42 AM, George Burgess IV via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: gbiv
>> Date: Mon Mar 5 23:42:36 2018
>> New Re
Author: gbiv
Date: Tue Mar 6 20:52:34 2018
New Revision: 326872
URL: http://llvm.org/viewvc/llvm-project?rev=326872&view=rev
Log:
Reland r326766 (with a slightly modified test)
The original revert was done in r326869, since reverting r326602 broke
the test added by this.
The new test should be
Author: gbiv
Date: Tue Mar 6 15:09:01 2018
New Revision: 326845
URL: http://llvm.org/viewvc/llvm-project?rev=326845&view=rev
Log:
Fix a typo from r326844; NFC
Modified:
cfe/trunk/test/CodeGen/64bit-swiftcall.c
Modified: cfe/trunk/test/CodeGen/64bit-swiftcall.c
URL:
http://llvm.org/viewvc/l
Author: gbiv
Date: Tue Mar 6 15:07:00 2018
New Revision: 326844
URL: http://llvm.org/viewvc/llvm-project?rev=326844&view=rev
Log:
[CodeGen] Don't emit lifetime.end without lifetime.start
EmitLifetimeStart returns a non-null `size` pointer if it actually
emits a lifetime.start. Later in this func
Author: gbiv
Date: Mon Mar 5 23:45:11 2018
New Revision: 326767
URL: http://llvm.org/viewvc/llvm-project?rev=326767&view=rev
Log:
Fix an unused variable warning; NFC
Modified:
cfe/trunk/lib/Analysis/CFG.cpp
Modified: cfe/trunk/lib/Analysis/CFG.cpp
URL:
http://llvm.org/viewvc/llvm-project/c
Author: gbiv
Date: Mon Mar 5 23:42:36 2018
New Revision: 326766
URL: http://llvm.org/viewvc/llvm-project?rev=326766&view=rev
Log:
[ExprConstant] Look through ExprWithCleanups for `allocsize`
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
cfe/trunk/test/CodeGenCXX/alloc-size.cpp
Modified:
Author: gbiv
Date: Fri Mar 2 12:10:38 2018
New Revision: 326607
URL: http://llvm.org/viewvc/llvm-project?rev=326607&view=rev
Log:
Range-ify a for loop. NFC
Modified:
cfe/trunk/lib/CodeGen/CGBlocks.cpp
Modified: cfe/trunk/lib/CodeGen/CGBlocks.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe
Author: gbiv
Date: Wed Feb 28 21:43:23 2018
New Revision: 326416
URL: http://llvm.org/viewvc/llvm-project?rev=326416&view=rev
Log:
Remove redundant casts. NFC
So I wrote a clang-tidy check to lint out redundant `isa`, `cast`, and
`dyn_cast`s for fun. This is a portion of what it found for clang;
Author: gbiv
Date: Tue Jan 16 20:46:04 2018
New Revision: 322618
URL: http://llvm.org/viewvc/llvm-project?rev=322618&view=rev
Log:
[CodeGen] Fix a crash on mangling multiversioned functions
`multiVersionSortPriority` expects features to have no prefix. We
currently carry them around in the format
Author: gbiv
Date: Mon Jan 15 19:01:50 2018
New Revision: 322530
URL: http://llvm.org/viewvc/llvm-project?rev=322530&view=rev
Log:
[Sema] Fix a crash on invalid features in multiversioning
We were trying to emit a diag::err_bad_multiversion_option diagnostic,
which expects an int as its first arg
inspired by GCC's documentation on the builtin.
On Mon, Oct 16, 2017 at 3:58 PM, George Burgess IV via cfe-commits
wrote:
> Author: gbiv
> Date: Mon Oct 16 15:58:37 2017
> New Revision: 315951
>
> URL: http://llvm.org/viewvc/llvm-project?rev=315951&view=rev
> Log:
> Mak
Author: gbiv
Date: Mon Oct 16 15:58:37 2017
New Revision: 315951
URL: http://llvm.org/viewvc/llvm-project?rev=315951&view=rev
Log:
Make __builtin_types_compatible_p more like GCC's
GCC ignore qualifiers on array types. Since we seem to have this
function primarily for GCC compatibility, we should
Author: gbiv
Date: Wed Aug 16 15:44:17 2017
New Revision: 311051
URL: http://llvm.org/viewvc/llvm-project?rev=311051&view=rev
Log:
Fix typos in comments; NFC
Modified:
cfe/trunk/include/clang/Lex/MultipleIncludeOpt.h
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/include/clang/Lex/M
Sorry, I meant
bin/clang -Wthread-safety-attributes -Wthread-safety-analysis
/tmp/tc.cpp -std=c++17 -c -o/dev/null
(had -Wthread-safety-attributes twice in the email)
George
On Thu, Aug 10, 2017 at 4:08 PM, George Burgess IV
wrote:
> Hello!
>
> It looks like this is causing buildbot failures r
;>
>>> See ASAN+UBSAN bot on Green Dragon:
>>> http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/4065/console
>>>
>>> On Tue, Aug 8, 2017 at 9:02 PM, George Burgess IV via cfe-commits
>>> wrote:
>>>>
>>>> A
Hello!
It looks like this is causing buildbot failures related to libc++'s
lock_guard and scoped_lock:
http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan_check/4070/consoleFull
Here's a reduced test-case (from libc++'s __mutex_base):
struct __attribute__((capability("mutex"))) mutex {
;
>> See ASAN+UBSAN bot on Green Dragon:
>> http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/4065/console
>>
>> On Tue, Aug 8, 2017 at 9:02 PM, George Burgess IV via cfe-commits
>> wrote:
>>>
>>> Author: gbiv
>>> Date: Tue Au
type
> 'clang::LVComputationKind'
>
> See ASAN+UBSAN bot on Green Dragon:
> http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/4065/console
>
> On Tue, Aug 8, 2017 at 9:02 PM, George Burgess IV via cfe-commits
> wrote:
>>
>> Author: gbiv
>> D
Author: gbiv
Date: Wed Aug 9 14:20:41 2017
New Revision: 310523
URL: http://llvm.org/viewvc/llvm-project?rev=310523&view=rev
Log:
Use unsigned instead of an enum for map keys
ubsan's enum sanitizer doesn't like the latter, and we had to have
out-of-bounds values for DenseMapInfo's tombstone/empt
Author: gbiv
Date: Tue Aug 8 23:07:08 2017
New Revision: 310445
URL: http://llvm.org/viewvc/llvm-project?rev=310445&view=rev
Log:
Attempt #2 to appease buildbots
"error: unable to create target: 'No available targets are compatible
with this triple.'"
Modified:
cfe/trunk/test/CodeGenCXX/pr2
Author: gbiv
Date: Tue Aug 8 22:20:05 2017
New Revision: 310444
URL: http://llvm.org/viewvc/llvm-project?rev=310444&view=rev
Log:
Attempt to appease msc buildbot
It was timing out on this test, but for reasons unrelated to the
specific bug it was testing for. Randomly breaking in gdb with `clang
Author: gbiv
Date: Tue Aug 8 21:12:17 2017
New Revision: 310437
URL: http://llvm.org/viewvc/llvm-project?rev=310437&view=rev
Log:
[AST] Cache intermediate visibility/linkage results
This is a follow-up to r310436 with actual functional changes. Please
see that commit message for a description of
Author: gbiv
Date: Tue Aug 8 21:02:49 2017
New Revision: 310436
URL: http://llvm.org/viewvc/llvm-project?rev=310436&view=rev
Log:
[AST] Move visibility computations into a class; NFC
This is patch 1 in a 2 patch series that aims to fix PR29160. Its goal
is to cache decl visibility/linkage for th
Author: gbiv
Date: Mon Aug 7 13:26:33 2017
New Revision: 310299
URL: http://llvm.org/viewvc/llvm-project?rev=310299&view=rev
Log:
Mark static variables static; NFC.
Modified:
cfe/trunk/lib/AST/Decl.cpp
Modified: cfe/trunk/lib/AST/Decl.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/
Author: gbiv
Date: Thu Jul 13 20:23:57 2017
New Revision: 307995
URL: http://llvm.org/viewvc/llvm-project?rev=307995&view=rev
Log:
Add release notes for the overloadable attribute
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewvc
Author: gbiv
Date: Fri Jun 30 15:33:24 2017
New Revision: 306899
URL: http://llvm.org/viewvc/llvm-project?rev=306899&view=rev
Log:
[Parse] Use normalized attr name for late-parsing checks.
Modified:
cfe/trunk/lib/Parse/ParseDecl.cpp
cfe/trunk/test/Sema/diagnose_if.c
Modified: cfe/trunk/l
Author: gbiv
Date: Tue Jun 27 14:31:31 2017
New Revision: 306467
URL: http://llvm.org/viewvc/llvm-project?rev=306467&view=rev
Log:
[Sema] Allow unmarked overloadable functions.
This patch extends the `overloadable` attribute to allow for one
function with a given name to not be marked with the `o
Author: gbiv
Date: Wed Jun 21 14:59:05 2017
New Revision: 305947
URL: http://llvm.org/viewvc/llvm-project?rev=305947&view=rev
Log:
[test] Make absolute line numbers relative; NFC
Done to remove noise from https://reviews.llvm.org/D32332 (and to make
this test more resilient to changes in general)
Author: gbiv
Date: Mon Jun 12 12:44:30 2017
New Revision: 305207
URL: http://llvm.org/viewvc/llvm-project?rev=305207&view=rev
Log:
[Sema] Use the right FoldingSet.
We were doing FindNodeOrInsertPos on SubstTemplateTypeParmPackTypes, so
we should presumably be inserting into SubstTemplateTypeParmP
Author: gbiv
Date: Thu Jun 8 15:55:21 2017
New Revision: 305013
URL: http://llvm.org/viewvc/llvm-project?rev=305013&view=rev
Log:
[Sema] Refactor OverloadCandidate::BuiltinTypes. NFC.
As promised in r304996.
Modified:
cfe/trunk/include/clang/Sema/Overload.h
cfe/trunk/lib/Sema/SemaExprCX
Author: gbiv
Date: Thu Jun 8 13:19:25 2017
New Revision: 304996
URL: http://llvm.org/viewvc/llvm-project?rev=304996&view=rev
Log:
[Sema] Remove unused field from OverloadCandidate.
The only use in-tree I can find for BuiltinTypes.ResultTy is a single
store to it. We otherwise just recompute what
Author: gbiv
Date: Thu May 25 21:56:51 2017
New Revision: 303962
URL: http://llvm.org/viewvc/llvm-project?rev=303962&view=rev
Log:
[docs] Point coroutine link to an actual document
Unsure if there's a better document, but what we had before led to a
404. :)
Modified:
cfe/trunk/www/cxx_status
Author: gbiv
Date: Mon May 8 23:06:24 2017
New Revision: 302506
URL: http://llvm.org/viewvc/llvm-project?rev=302506&view=rev
Log:
[Sema] Make typeof(OverloadedFunctionName) not a pointer.
We were sometimes doing a function->pointer conversion in
Sema::CheckPlaceholderExpr, which isn't the job of
Author: gbiv
Date: Tue May 2 15:24:56 2017
New Revision: 301970
URL: http://llvm.org/viewvc/llvm-project?rev=301970&view=rev
Log:
[Sema] Update function doc; NFC
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe
Author: gbiv
Date: Thu Apr 27 18:59:45 2017
New Revision: 301601
URL: http://llvm.org/viewvc/llvm-project?rev=301601&view=rev
Log:
Use a consistent style. NFC
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tru
Author: gbiv
Date: Wed Apr 26 17:37:38 2017
New Revision: 301486
URL: http://llvm.org/viewvc/llvm-project?rev=301486&view=rev
Log:
Fix comment. NFC
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema
Author: gbiv
Date: Thu Apr 13 18:47:08 2017
New Revision: 300283
URL: http://llvm.org/viewvc/llvm-project?rev=300283&view=rev
Log:
Fix PR31934: forming refs to functions with enable_if attrs.
Modified:
cfe/trunk/lib/Sema/SemaInit.cpp
cfe/trunk/test/SemaCXX/enable_if.cpp
Modified: cfe/tru
Author: gbiv
Date: Wed Apr 5 19:23:31 2017
New Revision: 299603
URL: http://llvm.org/viewvc/llvm-project?rev=299603&view=rev
Log:
[Sema] Update CheckOverload docs
- Replace documented return values (true/false) with what's actually
returned
- Doxygenify the comment
- Reflow said comment to 80
Author: gbiv
Date: Wed Apr 5 19:08:35 2017
New Revision: 299601
URL: http://llvm.org/viewvc/llvm-project?rev=299601&view=rev
Log:
Simplify. NFC.
Two simplifications:
- We check `!Previous.empty()` above and only use `Previous` in const
contexts after that check, so the `!Previous.empty()` chec
Author: gbiv
Date: Tue Mar 21 15:09:35 2017
New Revision: 298431
URL: http://llvm.org/viewvc/llvm-project?rev=298431&view=rev
Log:
Let llvm.objectsize be conservative with null pointers
D28494 adds another parameter to @llvm.objectsize. Clang needs to be
sure to pass that third arg whenever appli
for function parameters may require us to have already merged the
> function itself into its redeclaration chain (we don't currently model that
> quite correctly, so we probably won't hit it today).
>
>
>> On Wed, Feb 15, 2017 at 4:55 PM, Richard Smith
>> wrote:
>
Author: gbiv
Date: Thu Feb 23 20:49:47 2017
New Revision: 296076
URL: http://llvm.org/viewvc/llvm-project?rev=296076&view=rev
Log:
Represent pass_object_size attrs in ExtParameterInfo
The goal of this is to fix a bug in modules where we'd merge
FunctionDecls that differed in their pass_object_siz
Thanks for catching this! :)
On Thu, Feb 23, 2017 at 2:47 PM, Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: d0k
> Date: Thu Feb 23 16:47:56 2017
> New Revision: 296034
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296034&view=rev
> Log:
> [CodeGen] Silence unus
Author: gbiv
Date: Thu Feb 23 16:14:55 2017
New Revision: 296027
URL: http://llvm.org/viewvc/llvm-project?rev=296027&view=rev
Log:
Tighten up a regex in a test
...If we're trying to match "this function has only two arguments", `.*`
probably isn't the best thing to use. :)
Modified:
cfe/trun
Author: gbiv
Date: Thu Feb 23 16:07:35 2017
New Revision: 296024
URL: http://llvm.org/viewvc/llvm-project?rev=296024&view=rev
Log:
[CodeGen] Fix ExtParameterInfo bugs in C++ CodeGen code.
This patch makes use of the prefix/suffix ABI argument distinction that
was introduced in r295870, so that we
Author: gbiv
Date: Wed Feb 22 23:59:56 2017
New Revision: 295935
URL: http://llvm.org/viewvc/llvm-project?rev=295935&view=rev
Log:
[CodeGen] Don't reemit expressions for pass_object_size params.
This fixes an assertion failure in cases where we had expression
statements that declared variables ne
Author: gbiv
Date: Wed Feb 22 16:38:25 2017
New Revision: 295894
URL: http://llvm.org/viewvc/llvm-project?rev=295894&view=rev
Log:
[CodeGen] Add param info for ctors with ABI args.
This fixes a few assertion failures. Please see the added test case.
Added:
cfe/trunk/test/CodeGenObjCXX/arc-at
Author: gbiv
Date: Wed Feb 22 14:28:02 2017
New Revision: 295870
URL: http://llvm.org/viewvc/llvm-project?rev=295870&view=rev
Log:
[CodeGen] Note where we add ABI-specific args in ctors. NFC.
Meta: The ultimate goal is to teach ExtParameterInfo about
pass_object_size attributes. This is necessary
Author: gbiv
Date: Tue Feb 21 20:35:51 2017
New Revision: 295805
URL: http://llvm.org/viewvc/llvm-project?rev=295805&view=rev
Log:
Call the correct @llvm.objectsize.
The following code would crash clang:
void foo(unsigned *const __attribute__((pass_object_size(0;
void bar(unsigned *i) { foo(
info,
so I can't immediately see why that wouldn't work.
On Wed, Feb 15, 2017 at 4:55 PM, Richard Smith
wrote:
> On 15 February 2017 at 14:43, George Burgess IV via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: gbiv
>> Date: Wed Feb 15 16:43
Author: gbiv
Date: Wed Feb 15 16:43:27 2017
New Revision: 295252
URL: http://llvm.org/viewvc/llvm-project?rev=295252&view=rev
Log:
[Modules] Consider enable_if attrs in isSameEntity.
Two functions that differ only in their enable_if attributes are
considered overloads, so we should check for thos
Author: gbiv
Date: Tue Feb 14 13:34:33 2017
New Revision: 295094
URL: http://llvm.org/viewvc/llvm-project?rev=295094&view=rev
Log:
Finish a comment + remove trailing whitespace. NFC
Modified:
cfe/trunk/include/clang/AST/DeclBase.h
Modified: cfe/trunk/include/clang/AST/DeclBase.h
URL:
http:/
Author: gbiv
Date: Mon Feb 13 23:52:57 2017
New Revision: 295032
URL: http://llvm.org/viewvc/llvm-project?rev=295032&view=rev
Log:
Delete useless / in comment. NFC.
Modified:
cfe/trunk/lib/Serialization/ASTReaderStmt.cpp
Modified: cfe/trunk/lib/Serialization/ASTReaderStmt.cpp
URL:
http://ll
Author: gbiv
Date: Mon Feb 13 23:37:36 2017
New Revision: 295029
URL: http://llvm.org/viewvc/llvm-project?rev=295029&view=rev
Log:
Add a destruct-on-exit function to ASTContext.
It looks like the only use of AddDeallocation is to indirectly call the
destructors of objects. In one case I found
(Ty
Hi Hans!
This fixes PR31843, which is a release blocker. Once the bots seem happy
with it, can we merge this into the 4.0 branch, please?
(Richard okayed this when he LGTM'ed the patch)
Thanks,
George
On Fri, Feb 10, 2017 at 2:52 PM, George Burgess IV via cfe-commits <
cfe
1 - 100 of 387 matches
Mail list logo