[PATCH] D151192: [clang-tidy] have bugprone-unchecked-optional-access check boost::optional usage

2023-05-24 Thread Giel van Schijndel via Phabricator via cfe-commits
muggenhor added a comment. FYI: I've added a set of tests. But in the process discovered there's at least one assumption that doesn't hold for boost::optional. So I'll have to adjust the implementation for that. That's a bit more involved change, so will take some time. (Specifically the assum

[PATCH] D151192: [clang-tidy] have bugprone-unchecked-optional-access check boost::optional usage

2023-05-23 Thread Giel van Schijndel via Phabricator via cfe-commits
muggenhor added a comment. Sure. Looking at the test I'm unsure though, are the `optional` implementations in there stripped copies of the real implementations? Or just a minimal implementation that fits the basic optional interface in the given namespace? Repository: rG LLVM Github Monorepo

[PATCH] D151192: [clang-tidy] have bugprone-unchecked-optional-access check boost::optional usage

2023-05-23 Thread Giel van Schijndel via Phabricator via cfe-commits
muggenhor created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. muggenhor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo