[lldb] [compiler-rt] [clang-tools-extra] [clang] [openmp] [llvm] [libcxx] [flang] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

https://github.com/ggeorgakoudis approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/70667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [flang] [clang-tools-extra] [libcxx] [lldb] [openmp] [compiler-rt] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

ggeorgakoudis wrote: LGTM but fix comments: 1. Comments should be in their own line, move them above the relevant line 2. Comments should be complete sentences ending with a full stop https://github.com/llvm/llvm-project/pull/70667 ___ cfe-commits mail

[llvm] [clang-tools-extra] [openmp] [clang] [libcxx] [lldb] [compiler-rt] [flang] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

@@ -151,6 +151,74 @@ struct RecordReplayTy { OS.close(); } + void dumpDeviceMemoryDiff(StringRef Filename) { +ErrorOr> DeviceMemoryMB = +WritableMemoryBuffer::getNewUninitMemBuffer(MemorySize); +if (!DeviceMemoryMB) + report_fatal_error("Error creat

[compiler-rt] [openmp] [clang] [flang] [llvm] [lldb] [libcxx] [clang-tools-extra] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

@@ -151,6 +151,74 @@ struct RecordReplayTy { OS.close(); } + void dumpDeviceMemoryDiff(StringRef Filename) { +ErrorOr> DeviceMemoryMB = +WritableMemoryBuffer::getNewUninitMemBuffer(MemorySize); +if (!DeviceMemoryMB) + report_fatal_error("Error creat

[lldb] [openmp] [compiler-rt] [clang] [libcxx] [clang-tools-extra] [llvm] [flang] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

@@ -151,6 +151,74 @@ struct RecordReplayTy { OS.close(); } + void dumpDeviceMemoryDiff(StringRef Filename) { +ErrorOr> DeviceMemoryMB = +WritableMemoryBuffer::getNewUninitMemBuffer(MemorySize); +if (!DeviceMemoryMB) + report_fatal_error("Error creat

[libcxx] [clang] [compiler-rt] [clang-tools-extra] [flang] [lldb] [openmp] [llvm] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

https://github.com/ggeorgakoudis edited https://github.com/llvm/llvm-project/pull/70667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [compiler-rt] [libcxx] [clang-tools-extra] [openmp] [lldb] [flang] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

https://github.com/ggeorgakoudis requested changes to this pull request. https://github.com/llvm/llvm-project/pull/70667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [openmp] [lldb] [libcxx] [flang] [compiler-rt] [clang-tools-extra] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

@@ -274,7 +317,7 @@ struct RecordReplayTy { void saveKernelOutputInfo(const char *Name) { SmallString<128> OutputFilename = { Name, (isRecording() ? ".original.output" : ".replay.output")}; -dumpDeviceMemory(OutputFilename); +dumpDeviceMemory(OutputFilenam

[clang] [compiler-rt] [clang-tools-extra] [lldb] [openmp] [llvm] [libcxx] [flang] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

@@ -274,7 +317,7 @@ struct RecordReplayTy { void saveKernelOutputInfo(const char *Name) { SmallString<128> OutputFilename = { Name, (isRecording() ? ".original.output" : ".replay.output")}; -dumpDeviceMemory(OutputFilename); +dumpDeviceMemory(OutputFilenam

[openmp] [clang-tools-extra] [llvm] [compiler-rt] [lldb] [libcxx] [flang] [clang] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

@@ -141,13 +141,56 @@ struct RecordReplayTy { if (Err) report_fatal_error("Error retrieving data for target pointer"); -StringRef DeviceMemory(DeviceMemoryMB.get()->getBufferStart(), MemorySize); std::error_code EC; raw_fd_ostream OS(Filename, EC);

[llvm] [openmp] [clang] [libcxx] [flang] [compiler-rt] [clang-tools-extra] [lldb] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

@@ -274,7 +317,7 @@ struct RecordReplayTy { void saveKernelOutputInfo(const char *Name) { SmallString<128> OutputFilename = { Name, (isRecording() ? ".original.output" : ".replay.output")}; ggeorgakoudis wrote: Create a new extensions when output

[llvm] [compiler-rt] [clang] [openmp] [lldb] [libcxx] [flang] [clang-tools-extra] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

@@ -141,13 +141,56 @@ struct RecordReplayTy { if (Err) report_fatal_error("Error retrieving data for target pointer"); -StringRef DeviceMemory(DeviceMemoryMB.get()->getBufferStart(), MemorySize); std::error_code EC; raw_fd_ostream OS(Filename, EC);

[clang-tools-extra] [clang] [openmp] [llvm] [compiler-rt] [flang] [lldb] [libcxx] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

@@ -130,7 +130,7 @@ struct RecordReplayTy { return preAllocateHeuristic(DevMemSize, ReqVAddr); } - void dumpDeviceMemory(StringRef Filename) { + void dumpDeviceMemory(StringRef Filename, bool saveDiff) { ggeorgakoudis wrote: rename saveDiff -> SaveDif

[lldb] [clang] [flang] [llvm] [openmp] [compiler-rt] [clang-tools-extra] [libcxx] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

https://github.com/ggeorgakoudis edited https://github.com/llvm/llvm-project/pull/70667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libcxx] [llvm] [lldb] [compiler-rt] [openmp] [flang] [clang] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

@@ -141,13 +141,56 @@ struct RecordReplayTy { if (Err) report_fatal_error("Error retrieving data for target pointer"); -StringRef DeviceMemory(DeviceMemoryMB.get()->getBufferStart(), MemorySize); std::error_code EC; raw_fd_ostream OS(Filename, EC);

[llvm] [openmp] [compiler-rt] [clang-tools-extra] [libcxx] [flang] [clang] [lldb] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

@@ -141,13 +141,56 @@ struct RecordReplayTy { if (Err) report_fatal_error("Error retrieving data for target pointer"); -StringRef DeviceMemory(DeviceMemoryMB.get()->getBufferStart(), MemorySize); std::error_code EC; raw_fd_ostream OS(Filename, EC);

[libcxx] [openmp] [flang] [clang] [lldb] [compiler-rt] [llvm] [clang-tools-extra] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

@@ -274,7 +317,7 @@ struct RecordReplayTy { void saveKernelOutputInfo(const char *Name) { SmallString<128> OutputFilename = { Name, (isRecording() ? ".original.output" : ".replay.output")}; -dumpDeviceMemory(OutputFilename); +dumpDeviceMemory(OutputFilenam

[clang] [compiler-rt] [llvm] [libcxx] [flang] [openmp] [clang-tools-extra] [lldb] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

https://github.com/ggeorgakoudis requested changes to this pull request. https://github.com/llvm/llvm-project/pull/70667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [openmp] Add memory diff dump for kernel record-replay (PR #70667)

ggeorgakoudis wrote: > @ggeorgakoudis To reduce the memory consumption for kernel tuning using > record/replay. I do not see this so much about saving memory consumption but more as saving disk space. Makes sense to me this way, will review shortly. https://github.com/llvm/llvm-project/pull/7

[clang-tools-extra] [openmp] Add memory diff dump for kernel record-replay (PR #70667)

ggeorgakoudis wrote: > @ggeorgakoudis To reduce the memory consumption for kernel tuning using > record/replay. I do not see this so much about saving memory consumption but more as saving disk space. Makes sense to me this way, will review shortly. https://github.com/llvm/llvm-project/pull/7

[clang-tools-extra] [openmp] Add memory diff dump for kernel record-replay (PR #70667)

ggeorgakoudis wrote: @nmustakin What's the use-case/motivation for this patch? https://github.com/llvm/llvm-project/pull/70667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f97b843 - [OpenMP] Fix non-determinism in clang copyin codegen

Author: Giorgis Georgakoudis Date: 2021-05-05T19:24:03-07:00 New Revision: f97b843d8819f824dcc1b6afa746ce9a7a386db3 URL: https://github.com/llvm/llvm-project/commit/f97b843d8819f824dcc1b6afa746ce9a7a386db3 DIFF: https://github.com/llvm/llvm-project/commit/f97b843d8819f824dcc1b6afa746ce9a7a386db

[clang] 78a7d8c - [Utils][NFC] Rename replace-function-regex in update_cc_test_checks

Author: Giorgis Georgakoudis Date: 2021-05-05T14:19:30-07:00 New Revision: 78a7d8c4dd1076dccfde2c48fc924d8f5529f4d1 URL: https://github.com/llvm/llvm-project/commit/78a7d8c4dd1076dccfde2c48fc924d8f5529f4d1 DIFF: https://github.com/llvm/llvm-project/commit/78a7d8c4dd1076dccfde2c48fc924d8f5529f4d

[clang] 92f2c39 - [Utils] Run non-filecheck runlines in-order in update_cc_test_checks

Author: Giorgis Georgakoudis Date: 2021-05-04T12:06:03-07:00 New Revision: 92f2c39f915adc8f71be02d2604df4916069c9d4 URL: https://github.com/llvm/llvm-project/commit/92f2c39f915adc8f71be02d2604df4916069c9d4 DIFF: https://github.com/llvm/llvm-project/commit/92f2c39f915adc8f71be02d2604df4916069c9d

[clang] 313ee60 - [OpenMP] Fix non-determinism in clang task codegen (lastprivates)

Author: Giorgis Georgakoudis Date: 2021-05-04T11:56:31-07:00 New Revision: 313ee609e16b93a7d81cd595f8cffdb408390495 URL: https://github.com/llvm/llvm-project/commit/313ee609e16b93a7d81cd595f8cffdb408390495 DIFF: https://github.com/llvm/llvm-project/commit/313ee609e16b93a7d81cd595f8cffdb40839049

[clang] a27ca15 - [OpenMP] Fix non-determinism in clang task codegen

Author: Giorgis Georgakoudis Date: 2021-05-03T10:34:38-07:00 New Revision: a27ca15dd08342b199e2feb5ae896475fd90a518 URL: https://github.com/llvm/llvm-project/commit/a27ca15dd08342b199e2feb5ae896475fd90a518 DIFF: https://github.com/llvm/llvm-project/commit/a27ca15dd08342b199e2feb5ae896475fd90a51

[clang] 8bc2c66 - [Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts

Author: Giorgis Georgakoudis Date: 2021-03-26T11:49:42-07:00 New Revision: 8bc2c662d9c0f241fb8538979f8db1af7f2e353e URL: https://github.com/llvm/llvm-project/commit/8bc2c662d9c0f241fb8538979f8db1af7f2e353e DIFF: https://github.com/llvm/llvm-project/commit/8bc2c662d9c0f241fb8538979f8db1af7f2e353

[clang] a80a33e - [Utils] Support lit-like substitutions in update_cc_test_checks

Author: Giorgis Georgakoudis Date: 2021-03-16T10:36:22-07:00 New Revision: a80a33e8b55393c060e51486cfd8085b380eb36d URL: https://github.com/llvm/llvm-project/commit/a80a33e8b55393c060e51486cfd8085b380eb36d DIFF: https://github.com/llvm/llvm-project/commit/a80a33e8b55393c060e51486cfd8085b380eb36

[clang] 1ce846b - Replace func name with regex for update test scripts

Author: Giorgis Georgakoudis Date: 2021-03-12T17:37:09-08:00 New Revision: 1ce846be04f8ce7f899e37424772c0bef1851f76 URL: https://github.com/llvm/llvm-project/commit/1ce846be04f8ce7f899e37424772c0bef1851f76 DIFF: https://github.com/llvm/llvm-project/commit/1ce846be04f8ce7f899e37424772c0bef1851f7

[clang] 9f9a4df - Revert "Replace func name with regex for update test scripts"

Author: Giorgis Georgakoudis Date: 2021-03-12T17:20:00-08:00 New Revision: 9f9a4dfda7348eddbc840ae558e7082677c3bab6 URL: https://github.com/llvm/llvm-project/commit/9f9a4dfda7348eddbc840ae558e7082677c3bab6 DIFF: https://github.com/llvm/llvm-project/commit/9f9a4dfda7348eddbc840ae558e7082677c3bab

[clang] 5eaf70a - Replace func name with regex for update test scripts

Author: Giorgis Georgakoudis Date: 2021-03-12T17:00:42-08:00 New Revision: 5eaf70afb5f8ae6789587e60d51c60f56caf18b0 URL: https://github.com/llvm/llvm-project/commit/5eaf70afb5f8ae6789587e60d51c60f56caf18b0 DIFF: https://github.com/llvm/llvm-project/commit/5eaf70afb5f8ae6789587e60d51c60f56caf18b

[clang] ecf6897 - Revert "Replace func name with regex in update_cc_test_checks"

Author: Giorgis Georgakoudis Date: 2021-03-10T15:05:35-08:00 New Revision: ecf68972fd020cee80c5503bbe0f2028a184c8f3 URL: https://github.com/llvm/llvm-project/commit/ecf68972fd020cee80c5503bbe0f2028a184c8f3 DIFF: https://github.com/llvm/llvm-project/commit/ecf68972fd020cee80c5503bbe0f2028a184c8f

[clang] bf58d6a - Replace func name with regex in update_cc_test_checks

Author: Giorgis Georgakoudis Date: 2021-03-10T12:57:35-08:00 New Revision: bf58d6a1f92244c797a280d318a56d7d3fc4a704 URL: https://github.com/llvm/llvm-project/commit/bf58d6a1f92244c797a280d318a56d7d3fc4a704 DIFF: https://github.com/llvm/llvm-project/commit/bf58d6a1f92244c797a280d318a56d7d3fc4a70

[clang] a2abe22 - Run non-filechecked commands in update_cc_test_checks.py

Author: Giorgis Georgakoudis Date: 2021-03-10T12:25:35-08:00 New Revision: a2abe2259c2d5b8c494f3513b840adf1572b21bc URL: https://github.com/llvm/llvm-project/commit/a2abe2259c2d5b8c494f3513b840adf1572b21bc DIFF: https://github.com/llvm/llvm-project/commit/a2abe2259c2d5b8c494f3513b840adf1572b21b

[clang] 60d4c73 - Run non-filechecked commands in update_cc_test_checks.py

Author: Giorgis Georgakoudis Date: 2021-03-08T07:18:01-08:00 New Revision: 60d4c73b30a0e324c6ae314722eb036f70f4b03a URL: https://github.com/llvm/llvm-project/commit/60d4c73b30a0e324c6ae314722eb036f70f4b03a DIFF: https://github.com/llvm/llvm-project/commit/60d4c73b30a0e324c6ae314722eb036f70f4b03