[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings updated this revision to Diff 473304. gracejennings added a comment. - Add assignment overload codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135721/new/ https://reviews.llvm.org/D135721 Files:

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue);

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings marked an inline comment as done. gracejennings added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:1158-1161 + static CXXThisExpr *Create(const ASTContext , SourceLocation Loc, + QualType Ty, bool IsImplicit) { +

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings updated this revision to Diff 472791. gracejennings marked an inline comment as done. gracejennings added a comment. - Add codegen test and fix member implicit this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135721/new/

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings marked 5 inline comments as done. gracejennings added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue);

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings marked an inline comment as done. gracejennings added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings updated this revision to Diff 466964. gracejennings added a comment. Includng formatting update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135721/new/ https://reviews.llvm.org/D135721 Files: clang/include/clang/AST/ExprCXX.h

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings updated this revision to Diff 466962. gracejennings added a comment. Formatting Added new line file ending Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135721/new/ https://reviews.llvm.org/D135721 Files:

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings created this revision. gracejennings added reviewers: python3kgae, beanz, pow2clk, bob80905. Herald added a subscriber: Anastasia. Herald added a project: All. gracejennings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.