[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

gparker42 accepted this revision. gparker42 added a comment. This revision is now accepted and ready to land. Good. `REQUIRES-ANY` was preserved when the boolean expressions were added because libc++ was still using it. libc++ has since changed their tests so removing it should be fine now.

[PATCH] D57936: [CodeGenObjC] When available, emit a direct call to objc_alloc_init(cls) instead of [objc_alloc(cls) init]

gparker42 added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:459 + llvm::Value *Receiver = + CGF.CGM.getObjCRuntime().GetClass(CGF, ObjTy->getInterface()); + return CGF.EmitObjCAllocInit(Receiver, CGF.ConvertType(OME->getType())); gparker42

[PATCH] D57936: [CodeGenObjC] When available, emit a direct call to objc_alloc_init(cls) instead of [objc_alloc(cls) init]

gparker42 added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:459 + llvm::Value *Receiver = + CGF.CGM.getObjCRuntime().GetClass(CGF, ObjTy->getInterface()); + return CGF.EmitObjCAllocInit(Receiver, CGF.ConvertType(OME->getType())); rjmccall

[PATCH] D45601: Warn on bool* to bool conversion

gparker42 added a comment. Note that we recently relaxed a similar diagnostic for `NSNumber *` in the static analyzer. Such code is semantically similar to `inttype *`. https://reviews.llvm.org/D44044 https://reviews.llvm.org/D45601 ___

[PATCH] D27214: [ObjC] Encode type arguments in property information string constants

gparker42 added a comment. This won't work. The property attribute string consists of comma-separated fields. The encoding used here embeds commas into the type value, which will break parsing of the attribute string. You'll need to use a separator other than a comma. Repository: rL LLVM

[PATCH] D34810: [Sema] -Wcomma should not warn for expressions that return void

gparker42 added a comment. I thought void-returning functions were supposed to be allowed based on the description in https://reviews.llvm.org/D3976 , but later in that discussion the definition was changed to instead allow almost nothing. Repository: rL LLVM

[PATCH] D28931: Disable aligned new/delete on Apple platforms without posix_memalign

gparker42 added a comment. No, the old versions of OS X that lack `posix_memalign` also lack `aligned_alloc`. https://reviews.llvm.org/D28931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org