parallaxe added a comment.
In https://reviews.llvm.org/D23236#557898, @dcoughlin wrote:
> Upon reflection, I don't think this is the right approach.
>
> Desugaring any AttributedType in the return type seems like a really, really
> big hammer and could be an unexpected surprise for future attrib
parallaxe added a comment.
I tried to commit by using arc, though it didn't work as I was prompted to
login into the subversion-repository, which I can't. At this point I'm not sure
if this should have worked or not, but I assumed that arc + phabricator would
handle it in a way that i wouldn't
parallaxe added a comment.
Uhm, is there something missing from my side that i have overseen to go forward
with this patch?
https://reviews.llvm.org/D23236
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
parallaxe updated this revision to Diff 69000.
parallaxe added a comment.
Moved the tests into `nullability_nullonly.mm` according to @dcoughlin.
Applied the changes according to @aaron.ballman.
https://reviews.llvm.org/D23236
Files:
lib/Sema/SemaStmt.cpp
test/Analysis/nullability_nullonly.
parallaxe marked 4 inline comments as done.
parallaxe added a comment.
In https://reviews.llvm.org/D23236#509013, @ahatanak wrote:
> +cfe-commits
>
> If this patch is applied, does clang issue a warning if a method marked
> "nonnull" returns a null value? I see a warning is issued for conditiona
