[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/altivec-generic-overload.c:74 + convert1(gv1); + // CHECK: call void @_Z8convert1Dv16_a(<16 x i8> %{{[0-9]+}}) + convert1(gv2); Checking that the call is to the expected target in ter

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added a comment. > some test points check the error report for ambiguous call because of too > many implicit cast choices from ext_vector_type to vector type. It appears the answer is to update these tests and remove the restriction on the type class. https://reviews.ll

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; wuzish wrote: > hubert.re

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; wuzish wrote: > hubert.re

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; wuzish wrote: > hubert.re

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; hubert.reinterpretcast wr

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; wuzish wrote: > hubert.re

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; wuzish wrote: > hubert.re

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; wuzish wrote: > hubert.re

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; Considering that this is

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/test/Sema/altivec-generic-overload.c:3 + +typedef signed char __v4sc __attribute__((__vector_size__(16))); +typedef unsigned char __v4uc __attribute__((__vector_size__(16))); wuzish wrote: > hubert.r

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast requested changes to this revision. hubert.reinterpretcast added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaOverload.cpp:3920 + + // Prefer a compatible vector conversion to lax vector conversion + // Fo

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/test/Sema/altivec-generic-overload.c:3 + +typedef signed char __v4sc __attribute__((__vector_size__(16))); +typedef unsigned char __v4uc __attribute__((__vector_size__(16))); `__v4sc` is suspicious.

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3908 + QualType ToType) { +assert(FromType->isVectorType() && "FromType should be a vector type"); +assert(ToType->isVectorType() &&

[PATCH] D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX339969: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D50736?vs=160923&id=

[PATCH] D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback

hubert.reinterpretcast updated this revision to Diff 160923. hubert.reinterpretcast added a comment. Address review comments by Marshall Add a line break after the template-head. Add a comment with the requested quote from the Standard. Move test from the `test/libcxx/` tree to the `test/std/`

[PATCH] D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback

hubert.reinterpretcast added a comment. In https://reviews.llvm.org/D50736#1200774, @hubert.reinterpretcast wrote: > In https://reviews.llvm.org/D50736#1200761, @mclow.lists wrote: > > > Is this test that's being added libc++ specific, or would it apply to other > > implementations as well? > >

[PATCH] D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback

hubert.reinterpretcast added a comment. In https://reviews.llvm.org/D50736#1200761, @mclow.lists wrote: > Is this test that's being added libc++ specific, or would it apply to other > implementations as well? The test can apply to other implementations as well (although I am not sure how the

[PATCH] D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: mclow.lists, EricWF, jasonliu. Herald added subscribers: ldionne, christof. When a seed sequence would lead to having no non-zero significant bits in the initial state of a `mersenne_twister_engine`, the fallbac

[PATCH] D50055: Update the coding standard about NFC changes and whitespace

hubert.reinterpretcast added inline comments. Comment at: docs/DeveloperPolicy.rst:395-408 +Commits with No Functional Change +- + +It may be permissible to commit changes without prior review when the changes +have no semantic impact on the code i

[PATCH] D41217: [Concepts] Concept Specialization Expressions

hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprCXX.cpp:1478 + { +// We do not want error diagnostics escaping here. +Sema::SFINAETrap Trap(S); saar.raz wrote: > hubert.reinterpretcast wrote: > > saar.raz wrote: > > > faisalv wrote:

[PATCH] D41217: [Concepts] Concept Specialization Expressions

hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprCXX.cpp:1478 + { +// We do not want error diagnostics escaping here. +Sema::SFINAETrap Trap(S); saar.raz wrote: > faisalv wrote: > > Hubert: This needs a TODO: the idea is not to drop

[PATCH] D41544: Use backslash escape, replacing xargs -0 in test macro-multiline.c

This revision was automatically updated to reflect the committed changes. Closed by commit rC321828: Use backslash escape, replacing xargs -0 in test macro-multiline.c (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D41544?vs=128034&id=1286

[PATCH] D41545: Replace cp -a in various Clang tests

This revision was automatically updated to reflect the committed changes. Closed by commit rC321778: Replace cp -a in various Clang tests (authored by hubert.reinterpretcast, committed by ). Changed prior to commit: https://reviews.llvm.org/D41545?vs=128584&id=128586#toc Repository: rC Clang

[PATCH] D41545: Replace cp -a in various Clang tests

hubert.reinterpretcast updated this revision to Diff 128584. hubert.reinterpretcast added a comment. Use cp -R, which is sufficient instead of cp -RPp Repository: rC Clang https://reviews.llvm.org/D41545 Files: test/Modules/crash-vfs-path-emptydir-entries.m test/Modules/crash-vfs-path-sy

[PATCH] D41545: Replace cp -a in various Clang tests

hubert.reinterpretcast added a comment. I'll commit with `cp -R` tomorrow then; thanks. Repository: rC Clang https://reviews.llvm.org/D41545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D41545: Replace cp -a in various Clang tests

hubert.reinterpretcast added a comment. Maybe `cp -R` is sufficient? `cp -RPp` was the just-to-be-safe "minimal change". Repository: rC Clang https://reviews.llvm.org/D41545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D41544: Use backslash escape, replacing xargs -0 in test macro-multiline.c

hubert.reinterpretcast added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D41544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41545: Replace cp -a in various Clang tests

hubert.reinterpretcast created this revision. `cp -a` is neither part of POSIX nor the LSB; this patch uses `cp -RPp`, the nearest equivalent under POSIX. The tree being copied in each case currently contains only directories and regular files; so the `-P` is superfluous. `test/Modules/crash-v

[PATCH] D41544: Use backslash escape, replacing xargs -0 in test macro-multiline.c

hubert.reinterpretcast created this revision. xargs supports escaping of newline characters with backslash. xargs -0 is neither part of POSIX nor the LSB. This patch removes the -0 option and adjusts the input to xargs accordingly; that is, the input is a text file not ending in an incomplete l

[PATCH] D40380: Remove old concepts parsing code

This revision was automatically updated to reflect the committed changes. Closed by commit rC319992: Remove old concepts parsing code (authored by hubert.reinterpretcast). Changed prior to commit: https://reviews.llvm.org/D40380?vs=124032&id=125844#toc Repository: rC Clang https://reviews.l

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. Looks good to me. Repository: rL LLVM https://reviews.llvm.org/D40673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

hubert.reinterpretcast added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:817 DefineFloatMacros(Builder, "LDBL", &TI.getLongDoubleFormat(), "L"); + DefineFloatMacros(Builder, "FLT128", &TI.getFloat128Format(), "Q"); + GCC //does// define the

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

hubert.reinterpretcast added inline comments. Comment at: test/Sema/_Float128.cpp:1 +// RUN: %clang_cc1 -verify -std=gnu++11 %s +// RUN: %clang_cc1 -verify -std=c++11 %s GCC documents that it does not support `_Float128` in C++ mode, and I think their decision m

[PATCH] D40381: Parse concept definition

hubert.reinterpretcast added inline comments. Comment at: include/clang/Sema/Sema.h:6194 +SourceLocation TemplateLoc, +const TemplateArgumentListInfo *TemplateArgs); + changyu wrote: > hubert.reinter

[PATCH] D40381: Parse concept definition

hubert.reinterpretcast added inline comments. Comment at: include/clang/Sema/Sema.h:6194 +SourceLocation TemplateLoc, +const TemplateArgumentListInfo *TemplateArgs); + Indentation issue here too. =

[PATCH] D40381: Parse concept definition

hubert.reinterpretcast added inline comments. Comment at: test/CXX/concepts-ts/expr/expr.prim/expr.prim.id/p3.cpp:1 +// RUN: %clang_cc1 -std=c++1z -fconcepts-ts -fcxx-exceptions -x c++ -verify %s +// expected-no-diagnostics saar.raz wrote: > Rakete wrote: >

[PATCH] D33833: Fix PR 33189: Clang assertion on template destructor declaration

hubert.reinterpretcast added a comment. In https://reviews.llvm.org/D33833#789436, @kuang_he wrote: > Can we get this patch reviewed by any chance? @kuang_he; it is customary to "ping". In this case, "Ping 2". Comment at: lib/AST/DeclCXX.cpp:1421 - CXXDestructorDecl *Dtor

[PATCH] D33833: Fix PR 33189: Clang assertion on template destructor declaration

hubert.reinterpretcast added inline comments. Comment at: lib/AST/DeclCXX.cpp:1420 DeclContext::lookup_result R = lookup(Name); - if (R.empty()) + if (R.empty() || !isa(R.front())) return nullptr; As it is, ``` return R.empty() ? nullptr : dyn_cast(R.fr

[PATCH] D33339: Fix valid-for-expr ellipses eaten as invalid decl

hubert.reinterpretcast updated this revision to Diff 99632. hubert.reinterpretcast added a comment. Remove stray ellipsis treatment entirely https://reviews.llvm.org/D9 Files: lib/Parse/ParseTentative.cpp test/Parser/cxx0x-ambig.cpp Index: test/Parser/cxx0x-ambig.cpp ==

[PATCH] D33339: Fix valid-for-expr ellipses eaten as invalid decl

hubert.reinterpretcast added a comment. In https://reviews.llvm.org/D9#759797, @rsmith wrote: > In https://reviews.llvm.org/D9#759146, @hubert.reinterpretcast wrote: > > > The `check-all` target passes even if the ellipsis-after-declarator-id > > disambiguation as a declarator is removed

[PATCH] D33339: Fix valid-for-expr ellipses eaten as invalid decl

hubert.reinterpretcast added a comment. In https://reviews.llvm.org/D9#759125, @rsmith wrote: > Should I assume our "misplaced ellipsis" diagnostic requires that we > disambiguate the ill-formed ellipsis-after-declarator-id as a declarator in > some cases? If so, do we have tests for that s

[PATCH] D33339: Fix valid-for-expr ellipses eaten as invalid decl

hubert.reinterpretcast added inline comments. Comment at: lib/Parse/ParseTentative.cpp:542 + (Tok.is(tok::greatergreater) || + (Tok.is(tok::ellipsis) && + NextToken().isOneOf(tok::greater, tok::greatergreater, Th

[PATCH] D33339: Fix valid-for-expr ellipses eaten as invalid decl

hubert.reinterpretcast created this revision. The trial parse for declarative syntax accepts an invalid pack declaration syntax, which is ambiguous with valid pack expansions of expressions. This commit restricts the invalid pack declaration syntax to avoid mistaking valid pack expansions as in

[PATCH] D32378: Insert invariant.group.barrier for pointers comparisons

hubert.reinterpretcast added a comment. Has it been discussed whether this is something to be addressed in the optimizer as opposed to the front-end? Comment at: lib/CodeGen/CGExprScalar.cpp:3069 + !isa(RHS)) { +// Based on comparisons of pointers to dynamic o

[PATCH] D29748: [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas.

hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprConstant.cpp:5061 + APValue RVal; + // FIXME: We need to make sure we're passing the right type that + // maintains cv-qualifiers. faisalv wrote: > rsmith wrote: > >

[PATCH] D25674: [Concepts] Class template associated constraints

hubert.reinterpretcast updated this revision to Diff 87855. hubert.reinterpretcast added a comment. Address review comments; update to revision 294580 Allocate ConstrainedTemplateDeclInfo separately Update comments to be sentences; NFC https://reviews.llvm.org/D25674 Files: include/clang/AS

[PATCH] D25674: [Concepts] Class template associated constraints

hubert.reinterpretcast added inline comments. Comment at: include/clang/AST/DeclTemplate.h:373-391 +class TemplateDeclWithACBase { +protected: + TemplateDeclWithACBase() = default; + + ConstrainedTemplateDeclInfo CTDInfo; +}; + rsmith wrote: > This mechanism se

[PATCH] D25674: [Concepts] Class template associated constraints

hubert.reinterpretcast added a comment. Ping 2? https://reviews.llvm.org/D25674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25674: [Concepts] Class template associated constraints

hubert.reinterpretcast added a comment. Ping! https://reviews.llvm.org/D25674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25674: [Concepts] Class template associated constraints

hubert.reinterpretcast marked 3 inline comments as done. hubert.reinterpretcast added inline comments. Comment at: include/clang/AST/DeclTemplate.h:355 protected: - // This is probably never used. - TemplateDecl(Kind DK, DeclContext *DC, SourceLocation L, DeclarationName Name

[PATCH] D25674: [Concepts] Class template associated constraints

hubert.reinterpretcast updated this revision to Diff 85752. hubert.reinterpretcast added a comment. Address review comments; update to revision 292996 Fix possibly ill-formed NDR case Test template-dependent cases for class redeclaration Address review comment: use lambda instead of do while(0)

<    3   4   5   6   7   8