Re: [PATCH] D22871: Fix incorrect -Wtautological-constant-out-of-range warnings with enums

2016-08-25 Thread Ismail Badawi via cfe-commits
ibadawi abandoned this revision. ibadawi added a comment. Abandoning for now -- might submit another patch later according to new discussion on https://llvm.org/bugs/show_bug.cgi?id=16154 https://reviews.llvm.org/D22871 ___ cfe-commits mailing

Re: [PATCH] D22871: Fix incorrect -Wtautological-constant-out-of-range warnings with enums

2016-07-27 Thread Ismail Badawi via cfe-commits
ibadawi updated this revision to Diff 65765. ibadawi added a comment. Restore the test lost in patch #2. Really sorry for the noise... https://reviews.llvm.org/D22871 Files: lib/Sema/SemaChecking.cpp test/Sema/outof-range-constant-compare.c Index: test/Sema/outof-range-constant-compare.c

Re: [PATCH] D22871: Fix incorrect -Wtautological-constant-out-of-range warnings with enums

2016-07-27 Thread Ismail Badawi via cfe-commits
ibadawi updated this revision to Diff 65763. ibadawi added a comment. Remove extra blank line added by accident https://reviews.llvm.org/D22871 Files: lib/Sema/SemaChecking.cpp Index: lib/Sema/SemaChecking.cpp === ---

[PATCH] D22871: Fix incorrect -Wtautological-constant-out-of-range warnings with enums

2016-07-27 Thread Ismail Badawi via cfe-commits
ibadawi created this revision. ibadawi added reviewers: majnemer, rjmccall. ibadawi added a subscriber: cfe-commits. This is a proposed fix for bug 16154 (https://llvm.org/bugs/show_bug.cgi?id=16154) -- it was tentatively fixed in r183084 but had the fix was backed out in r183575 because the