[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

ivanrodriguez3753 added a comment. Also, should the underlying issue and test case be filed as an issue on Github? I wasn't sure since this revision includes the bug and a description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158559/new/

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

ivanrodriguez3753 added a comment. In D158559#4608388 , @ABataev wrote: > 1. Always provide full context in the patch. Sure, would you mind mentioning what's missing? Or do you mean the stuff from debug output being shortened, as well as LLVM IR being

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

ivanrodriguez3753 created this revision. ivanrodriguez3753 added a reviewer: OpenMP. Herald added subscribers: pengfei, guansong, tpr, yaxunl. Herald added a project: All. ivanrodriguez3753 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers:

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

ivanrodriguez3753 added a comment. In D131639#3749633 , @jhuber6 wrote: > I think it's perfectly reasonable to include system files as part of a > toolchain. I think it comes down to a matter of inconveniencing the user versus the developer. We

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

ivanrodriguez3753 added a comment. They are defining their own `bool`, which aliases to the built-in `_Bool` (which is reserved, as you noted with `_[A-Z]`). I thought `bool` was fair game unless they included `stdbool.h`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

ivanrodriguez3753 added a comment. The user didn't define any `__` or `_[A-Z]` identifiers, though? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131639/new/ https://reviews.llvm.org/D131639 ___

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

ivanrodriguez3753 added a comment. This looks good to me, and I agree we should document what this is fixing. Any update on if/when this will land? In my opinion, there's nothing broken about the user code (definitely contrived, though). They didn't ask for `stdbool.h` so there should not be a