[PATCH] D131265: Fixed sm version for .and bmma operator.

JackAKirk added a comment. In D131265#3702954 , @tra wrote: > Looks like the tests needed to be updated (and I've found one bug which > explains how we've missed this). Ah yes I see it. Thanks for updating the tests. Repository: rG LLVM Github Monor

[PATCH] D131265: Fixed sm version for .and bmma operator.

JackAKirk added a comment. In D131265#3702594 , @tra wrote: > Good catch. LGTM. Thanks. If you could land it for me that would be much appreciated. I don't have the rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D131265: Fixed sm version for .and bmma operator.

JackAKirk created this revision. JackAKirk added a reviewer: tra. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. JackAKirk requested review of this revision. Herald added subscribers: cfe-commits, jholewinski. Herald added a project: clang. As stated here (h

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

JackAKirk added a comment. In D118023#3267271 , @tra wrote: > The patch uses a `@gmail.com` email. Should I change it to `JackAKirk > ` to match the sign-off email? Ah yes thanks for catching that. Please use `JackAKirk `. Repository: rG LLVM Gith

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

JackAKirk added a comment. In D118023#3266987 , @tra wrote: > If you are not sure if you have commit access, you probably do not. It must > be explicitly granted: > https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access > > As for landing the

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

JackAKirk added a comment. In D118023#3266877 , @tra wrote: > LGTM. Should I commit the patch on your behalf? > > In D118023#3265601 , @JackAKirk > wrote: > >> Note that the test, llvm/test/CodeGen/NVPTX/wmma.py

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

JackAKirk added a comment. Note that the test, llvm/test/CodeGen/NVPTX/wmma.py line 210, had the correct value already but didn't seem to cover the mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118023/new/ https://reviews.llvm.org/D118023

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

JackAKirk created this revision. JackAKirk added a reviewer: tra. JackAKirk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: JackAKirk Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118023 Files: clang/

[PATCH] D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions

JackAKirk added a comment. In D116673#3241721 , @tra wrote: > In D116673#3237873 , @JackAKirk > wrote: > I can land the patch on your behalf. Are you OK to use the name/email in this patch or do you pr

[PATCH] D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions

JackAKirk marked 2 inline comments as done. JackAKirk added a comment. >> I can land the patch on your behalf. Are you OK to use the name/email in >> this patch or do you prefer to use a different email for the LLVM commit? > > Thanks very much. Yes the name/email in the patch is fine. CHA

[PATCH] D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions

JackAKirk marked 2 inline comments as done. JackAKirk added a comment. ping @tra I thought I should let you know that I do not have commit access to land the patch. I'm also happy to wait a little longer in case you think other interested parties might still chime in. Thanks ==

[PATCH] D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions

JackAKirk updated this revision to Diff 397884. JackAKirk added a comment. Made suggested change to naming convention. Added a few missing lines from the original patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116673/new/ https://reviews.llvm.org/D116673 Files: clang/include/c

[PATCH] D116673: [Clang][NVPTX]Add NVPTX intrinsics and builtins for CUDA PTX cvt sm80 instructions

JackAKirk created this revision. JackAKirk added reviewers: Naghasan, tra, hiraditya, yaxunl. JackAKirk added projects: clang, LLVM. Herald added subscribers: asavonic, jholewinski. JackAKirk requested review of this revision. Herald added a subscriber: jdoerfert. Adds NVPTX intrinsics and builtin