jstasiak marked an inline comment as done.
jstasiak added inline comments.
Comment at: bindings/python/clang/cindex.py:3001
+contents = b(contents)
+unsaved_files_array[i].name = b(fspath(name))
+unsaved_files_array[i].contents = co
jstasiak added a comment.
Thanks. If you could commit this on my behalf I'd appreciate it (I don't have
commit access).
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56341/new/
https://reviews.llvm.org/D56341
___
cf
jstasiak created this revision.
jstasiak added reviewers: mgorny, michaelplatings, serge-sans-paille.
Herald added subscribers: cfe-commits, arphaman.
On Python 3.7 the old code raises a warning:
DeprecationWarning: Using or importing the ABCs from 'collections' instead of
from 'collec
jstasiak updated this revision to Diff 173505.
jstasiak added a comment.
That's fair, changed string to just x, should be obvious from the context what
x is.
Thank you for the review. As I don't have commit access I'd like to ask you to
commit this on my behalf.
https://reviews.llvm.org/D5412
jstasiak marked 2 inline comments as done.
jstasiak added a comment.
Thanks for the feedback, you're right those were things worth improving, I
updated the code.
https://reviews.llvm.org/D54120
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
jstasiak updated this revision to Diff 173496.
jstasiak added a comment.
Tests are skipped using unittest skipping mechanism now and pathlib imported
only when necessary.
https://reviews.llvm.org/D54120
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_cdb.py
bindi
jstasiak created this revision.
jstasiak added reviewers: mgorny, jbcoe.
Herald added a subscriber: arphaman.
Python 3.6 introduced a file system path protocol (PEP 519[1]). The standard
library APIs accepting file system paths now accept path objects too. It could
be useful to add this here as
