[PATCH] D115254: Use VersionTuple for parsing versions in Triple

jamesfarrell added a comment. In D115254#3177960 , @MaskRay wrote: > commit 219672b8dd06c4765185fa3161c98437d49b4a1b > says > `Revert "Revert "...""` > > For such commits, it is

[PATCH] D115254: Use VersionTuple for parsing versions in Triple

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG219672b8dd06: Revert Revert Use VersionTuple for parsing versions in Triple, fixing issues… (authored by jamesfarrell). Repository: rG LLVM

[PATCH] D115254: Revert "Revert "Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "

jamesfarrell added a comment. Only change from previous attempt is to call rtrim() on the output of the commands in the unit tests, since the new version parsing code fails if there are leftover characters like \n. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115254: Revert "Revert "Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "

jamesfarrell created this revision. Herald added subscribers: dexonsmith, pengfei, hiraditya. jamesfarrell requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This reverts commit 63a6348cad6caccf285c1661bc60d8ba5a40c972

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

jamesfarrell added a comment. In D114885#3174074 , @thakis wrote: > Oh, it's already reverted, apologies. We'll know if that fixed that bot in 15 > min or so then. Something to keep in mind for relanding though :) Yeah, I'm currently trying to build

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

This revision was automatically updated to reflect the committed changes. Closed by commit rG50324670342d: Use VersionTuple for parsing versions in Triple, fixing issues that caused the… (authored by jamesfarrell). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

jamesfarrell updated this revision to Diff 391323. jamesfarrell added a comment. Don't use the preprocessor to hide test cases, so we can at least tell if it compiles when testing on platforms other than Apple and AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

jamesfarrell added inline comments. Comment at: llvm/lib/MC/MCStreamer.cpp:1343 LinkedTargetVersion.getMajor(), -*LinkedTargetVersion.getMinor(), -*LinkedTargetVersion.getSubminor(),

[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

jamesfarrell created this revision. Herald added subscribers: dexonsmith, pengfei, hiraditya. jamesfarrell requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This reverts commit 40d5eeac6cd89a2360c3ba997cbaa816abca828c

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell added a comment. In D114163#3161978 , @nikic wrote: > FYI I reverted this due to test failures -- one specific assertion failure is > mentioned in https://reviews.llvm.org/rG40d5eeac6cd8. Thanks! I saw the failures and was going to revert,

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e8286467036: Use VersionTuple for parsing versions in Triple. This makes it possible to… (authored by jamesfarrell). Repository: rG LLVM Github

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell added a comment. In D114163#3160292 , @arphaman wrote: > Sorry for delay, this LGTM. Thanks for doing this cleanup! Thanks, and no worries about the time (I was out last week as well) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell added inline comments. Comment at: clang/test/Sema/attr-availability-android.c:8 #ifdef WARN_PARTIAL -// expected-note-re@+2 {{'f3' has been marked as being introduced in Android 19 here, but the deployment target is Android 16.0.0{{$ +// expected-note-re@+2

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell added a comment. In D114163#3143534 , @danalbert wrote: > Nice, that's a lot of code cleaned up! LGTM, but probably should wait for > someone from Apple to weigh in. I think the new formatting for those error > messages is better for them

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell updated this revision to Diff 388198. jamesfarrell added a comment. Remove an include that's no longer needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114163/new/ https://reviews.llvm.org/D114163 Files:

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell updated this revision to Diff 388196. jamesfarrell retitled this revision from "Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.See also

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible. See also https://gith

jamesfarrell created this revision. Herald added subscribers: danielkiss, dexonsmith, pengfei, hiraditya. jamesfarrell requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D114036: Add Android test case for -Wpartial-availability. Also update Android availability tests to match on the whole string, so we can distinguish between "Android 16" and "Android 16.0.0"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa340a491b255: Add Android test case for -Wpartial-availability. Also update Android… (authored by jamesfarrell). Repository: rG LLVM Github

[PATCH] D114036: Add Android test case for -Wpartial-availability. Also update Android availability tests to match on the whole string, so we can distinguish between "Android 16" and "Android 16.0.0"

jamesfarrell created this revision. Herald added a subscriber: danielkiss. jamesfarrell requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114036 Files:

[PATCH] D114031: Full matching for version numbers.

jamesfarrell created this revision. jamesfarrell requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114031 Files: clang/test/Sema/attr-availability-android.c Index: