[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

j0le added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75453/new/ https://reviews.llvm.org/D75453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

j0le added a comment. In D75453#2094938 , @danielkiss wrote: > Sorry for the delay, it is okay to say "ping" after a while :) > LGTM Hi Daniel, no problem, thanks for comming back to this review after that long time. I will say "ping" next time :) Can

[PATCH] D75453: [Driver][ARM] fix undefined behaviour when checking architecture version

j0le added a comment. I would like to ask, whether I could "Accept the Revision" myself, or is this only allowed to be done by code owners or other reviewers? And when the revision is accepted, do I have to commit this, or can this only be done by people who have commit access or is this done au

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

j0le updated this revision to Diff 260912. j0le retitled this revision from "[Driver][ARM] fix undefined behaviour when checking architecture version" to "[Driver][ARM] parse version of arm/thumb architecture correctly". j0le edited the summary of this revision. j0le added a comment. Changed tit

[PATCH] D75453: [Driver][ARM] fix undefined behaviour when checking architecture version

j0le updated this revision to Diff 255354. j0le added a comment. I added a test case. I hope the folder "clang/tests/Driver" is the right one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75453/new/ https://reviews.llvm.org/D75453 Files: clang/lib/Driver/ToolChains/Clang.cpp clang

[PATCH] D75453: [Driver][ARM] fix undefined behaviour when checking architecture version

j0le created this revision. j0le added a reviewer: compnerd. j0le added a project: clang. Herald added a subscriber: kristof.beyls. Hello everyone, this is my first patch to/for clang. I hope, I did everything right. If not, please tell me. I found this bug: If you execute the following command

[PATCH] D90630: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

j0le created this revision. j0le added reviewers: rogfer01, rnk. j0le added a project: clang. Herald added a subscriber: cfe-commits. j0le requested review of this revision. Hello everyone, I think, I have found the reason, why there is a difference between C and C++ for the keyword __unaligned:

[PATCH] D90630: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

j0le updated this revision to Diff 302496. j0le edited the summary of this revision. j0le added a comment. Moved comment into the else-if block. Changed Summary of the diff, so that it is better suited for a commit message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90630/new/ https:

[PATCH] D90630: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

j0le marked an inline comment as done. j0le added a comment. In D90630#2368984 , @rnk wrote: > Thanks, this basically looks correct to me, aside from some formatting > details. Do you want me to apply those fixes and land this for you? I see > that was d