[clang] [Clang] Add diagnostic about "%P" specifier with Objective-C pointers (#89968) (PR #89977)

2024-04-26 Thread Jared Grubb via cfe-commits
@@ -44,15 +44,18 @@ void test_os_log_format(const char *pc, int i, void *p, void *buf) { } // Test os_log_format primitive with ObjC string literal format argument. -void test_objc(const char *pc, int i, void *p, void *buf, NSString *nss) { +void test_objc(const char *pc,

[clang] [Clang] Add diagnostic about "%P" specifier with Objective-C pointers (#89968) (PR #89977)

2024-04-24 Thread Jared Grubb via cfe-commits
jaredgrubb wrote: Cc: @ahatanaka @egorzhdan Also cc @joker-eph as it looks like you were original author of some of this, in case you're still following it :) https://github.com/llvm/llvm-project/pull/89977 ___ cfe-commits mailing list

[clang] [Clang] Add diagnostic about "%P" specifier with Objective-C pointers (#89968) (PR #89977)

2024-04-24 Thread Jared Grubb via cfe-commits
https://github.com/jaredgrubb created https://github.com/llvm/llvm-project/pull/89977 A Darwin extension '%P' combined with an Objective-C pointer seems to always be a bug. '%P' will dump bytes at the pointed-to address (in contrast to '%p' which dumps the pointer itself). This extension is

[clang] [clang-format] Remove duplicates in @property using std::set (PR #74235)

2023-12-03 Thread Jared Grubb via cfe-commits
https://github.com/jaredgrubb edited https://github.com/llvm/llvm-project/pull/74235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Remove duplicates in @property using std::set (PR #74235)

2023-12-03 Thread Jared Grubb via cfe-commits
@@ -171,18 +171,18 @@ TEST_F(ObjCPropertyAttributeOrderFixerTest, HandlesDuplicatedAttributes) { Style.ObjCPropertyAttributeOrder = {"a", "b", "c"}; // Just a dup and nothing else. - verifyFormat("@property(a, a) int p;", Style); + verifyFormat("@property(a) int p;",

[clang] [clang-format] Remove duplicates in @property using std::set (PR #74235)

2023-12-03 Thread Jared Grubb via cfe-commits
https://github.com/jaredgrubb approved this pull request. Looks good to me! https://github.com/llvm/llvm-project/pull/74235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits