@@ -0,0 +1,96 @@
+// For CTemplate we check in case of:
+// - Implicitly instantiate whole class by up-casting:
+// * The vtable is generated with comdat
+// * Its '_vtable$' is generated
+// - Implicitly instantiate member function only:
+// # when optimized:
+// * The vta
@@ -0,0 +1,96 @@
+// For CTemplate we check in case of:
+// - Implicitly instantiate whole class by up-casting:
+// * The vtable is generated with comdat
+// * Its '_vtable$' is generated
+// - Implicitly instantiate member function only:
+// # when optimized:
+// * The vta
https://github.com/jalopezg-git edited
https://github.com/llvm/llvm-project/pull/151818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,5 +1,3 @@
-// REQUIRES: target={{x86_64.*-linux.*}}
jalopezg-git wrote:
Even if `-emit-llvm` is part of the command line, I think the target triple
affects the `DataLayout` of the emitted LLVM module (unsure as to if that is
important for this PR). IMHO,
@@ -30,23 +28,26 @@ struct CDerived : NSP_1::CBaseOne, NSP_2::CBaseTwo {
int six() override { return 66; }
};
+void use(void *, ...);
jalopezg-git wrote:
(Very minor) nit-pick: add empty line to make it look similar as other test
files (e.g. clang/test/Deb
@@ -0,0 +1,109 @@
+// For CInlined (member functions are inlined), we check in case of:
+// - The definition of its destructor is visible:
+// * The vtable is generated with comdat
+// * Its '_vtable$' is generated
+// - Otherwise:
+// * The vtable is declared
+// * Its '_
https://github.com/jalopezg-git commented:
Thank you! I have added some minor comments / suggestions that add to other
reviewer's comments :slightly_smiling_face:.
https://github.com/llvm/llvm-project/pull/151818
___
cfe-commits mailing list
cfe-comm
jalopezg-git wrote:
I am sorry for the delay in providing a review for this PR; it's on my TODO
list for the next 24h though!
https://github.com/llvm/llvm-project/pull/151818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
