[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen updated this revision to Diff 501428. jolanta.jensen added a comment. Test adjustment for Windows. Disabling read permissions using chmod does not seem to work on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144179/new/

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen updated this revision to Diff 500747. jolanta.jensen added a comment. Adjusting the test for Windows. Setting the read bits only for the config file as Windows does not have full support for chmod. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen added a comment. In D144179#4146599 , @MaskRay wrote: > This looks like introducing a footgun (when something behaves differently > from an upstream Clang, it would be difficult for toolchain maintainers to > know why). > Why can't your

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen updated this revision to Diff 499502. jolanta.jensen added a comment. Adjusting the test for Windows OS again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144179/new/ https://reviews.llvm.org/D144179 Files:

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen updated this revision to Diff 499101. jolanta.jensen added a comment. Adjusted the test for Windows OS. Once again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144179/new/ https://reviews.llvm.org/D144179 Files:

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen added a comment. In D144179#4132597 , @MaskRay wrote: > Behaviors due to a new environment variable should be very careful. How is > this useful? If you want this, you can add a wrapper around `clang` to > specify `--config=` by

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen updated this revision to Diff 498826. jolanta.jensen added a comment. Extended the test to cover Windows OS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144179/new/ https://reviews.llvm.org/D144179 Files:

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen created this revision. jolanta.jensen added reviewers: mgabka, huntergr, david-arm. Herald added a project: All. jolanta.jensen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Also added functionality to set the name

[PATCH] D141507: [NFC] Fixed a typo in clang help docs

This revision was automatically updated to reflect the committed changes. Closed by commit rG15068394858e: [NFC] Fixed a typo in clang help docs (authored by jolanta.jensen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141507/new/

[PATCH] D141507: [NFC] Fixed a typo in clang help docs

jolanta.jensen created this revision. jolanta.jensen added a reviewer: mgabka. Herald added a project: All. jolanta.jensen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed minor typo in clang help docs. Repository: rG LLVM Github

[PATCH] D129373: [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums

This revision was automatically updated to reflect the committed changes. Closed by commit rG07df9e918e3f: [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums (authored by jolanta.jensen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129373: [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums

jolanta.jensen added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:894 bool useObjCFPRetForRealType(FloatModeKind T) const { -return RealTypeUsesObjCFPRetMask & llvm::BitmaskEnumDetail::Underlying(T); +return

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

jolanta.jensen added a comment. @tahonermann, I addressed your comments in https://reviews.llvm.org/D129373. I just need to remove a tab that crept in and it seems to be more difficult than I thought as my code does not seem to have any tab and reformatting the code does not change the file.

[PATCH] D129373: [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums

jolanta.jensen updated this revision to Diff 443258. jolanta.jensen added a comment. Removing a tab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129373/new/ https://reviews.llvm.org/D129373 Files: clang/include/clang/Basic/TargetInfo.h

[PATCH] D129373: [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums

jolanta.jensen created this revision. Herald added a project: All. jolanta.jensen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129373 Files:

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

This revision was automatically updated to reflect the committed changes. Closed by commit rG32aac7babfdd: [NFC] Switch FloatModeKind enum class to use bitmask enums (authored by jolanta.jensen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

jolanta.jensen added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:225-226 unsigned HasAlignMac68kSupport : 1; - unsigned RealTypeUsesObjCFPRetMask : (int)FloatModeKind::Last + 1; + unsigned RealTypeUsesObjCFPRetMask + :

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

jolanta.jensen updated this revision to Diff 440653. jolanta.jensen added a comment. Correcting computation of RealTypeUsesObjCFPRetMask. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128182/new/ https://reviews.llvm.org/D128182 Files:

[PATCH] D127655: [AArch64] Define __FP_FAST_FMA[F]

This revision was automatically updated to reflect the committed changes. Closed by commit rG5830da1f8625: [AArch64] Define __FP_FAST_FMA[F] (authored by jolanta.jensen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127655/new/

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

jolanta.jensen updated this revision to Diff 440141. jolanta.jensen added a comment. Removed an unnecessary local variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128182/new/ https://reviews.llvm.org/D128182 Files:

[PATCH] D127655: [AArch64] Define __FP_FAST_FMA[F]

jolanta.jensen updated this revision to Diff 438344. jolanta.jensen added a comment. Removing an unnecessary test change from aarch64-target-features.c as init-aarch64.c provides enough coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

jolanta.jensen created this revision. Herald added a project: All. jolanta.jensen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using bitmask enums simplifies and clarifies the code. Repository: rG LLVM Github Monorepo

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:223-224 unsigned HasAlignMac68kSupport : 1; - unsigned RealTypeUsesObjCFPRet : 3; + unsigned RealTypeUsesObjCFPRet : (1 << (int)FloatModeKind::Float) | +

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen updated this revision to Diff 437202. jolanta.jensen added a comment. Updated Release Notes. Renamed RealTypeUsesObjCFPRet to RealTypeUsesObjCFPRetMask. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126479/new/

[PATCH] D127655: [AArch64] Define __FP_FAST_FMA[F]

jolanta.jensen created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. jolanta.jensen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Libraries use this flag to decide whether to use the fma builtin.

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:223-224 unsigned HasAlignMac68kSupport : 1; - unsigned RealTypeUsesObjCFPRet : 3; + unsigned RealTypeUsesObjCFPRet : (1 << (int)FloatModeKind::Float) | +

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen updated this revision to Diff 436217. jolanta.jensen added a comment. Correcting my buggy computation of RealTypeUsesObjCFPRet bit-field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126479/new/ https://reviews.llvm.org/D126479

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen updated this revision to Diff 435922. jolanta.jensen added a comment. Removing the implicit dependency on the FloatModeKind enumerator values. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126479/new/

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen updated this revision to Diff 434762. jolanta.jensen added a comment. Addressing review comments: 1. Added the test for mode(HF) 2. Moved Half before Float in FloatModeKind enum class to preserve precision ordering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:60 + Ibm128, + Half }; tahonermann wrote: > The existing enumerators were ordered according to precision. Consider moving > `Half` to before `Float` if doing so doesn't

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen added inline comments. Comment at: clang/test/Sema/attr-mode.c:40 +typedef _Complex float c16a __attribute((mode(HC))); +int c16a_test[sizeof(c16a) == 4 ? 1 : -1]; mgabka wrote: > shouldn't we have here and in the line below : "//

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen updated this revision to Diff 433081. jolanta.jensen added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126479/new/ https://reviews.llvm.org/D126479 Files:

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen created this revision. Herald added a project: All. jolanta.jensen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding half float to types that can be represented by __attribute__((mode(xx))). Original implementation