[clang-tools-extra] [clang-tidy] Remove redundant LINK_LIBS (PR #94588)

2024-06-09 Thread Jonas Toth via cfe-commits
JonasToth wrote: As you requested my review: The original linking was done for the `ExprMutAnalyzer` used in 'misc-const-correctness'. If clang-tidy is builtin without static analyzer Support, you get linker failure. If the `ExprMutAnalyzer` is moved (back) to clang-tidy, the issue is not

[clang-tools-extra] e66345d - [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

2022-09-26 Thread Jonas Toth via cfe-commits
Author: Jonas Toth Date: 2022-09-26T10:39:11+02:00 New Revision: e66345d54d5f5e803f54c1ace487d57bb11ee884 URL: https://github.com/llvm/llvm-project/commit/e66345d54d5f5e803f54c1ace487d57bb11ee884 DIFF: https://github.com/llvm/llvm-project/commit/e66345d54d5f5e803f54c1ace487d57bb11ee884.diff

[clang-tools-extra] b5b7503 - [docs] improve documentation for misc-const-correctness

2022-08-29 Thread Jonas Toth via cfe-commits
Author: Jonas Toth Date: 2022-08-29T11:20:47+02:00 New Revision: b5b750346346bfe95c7c6b1cceacc6cfccc8f4f4 URL: https://github.com/llvm/llvm-project/commit/b5b750346346bfe95c7c6b1cceacc6cfccc8f4f4 DIFF: https://github.com/llvm/llvm-project/commit/b5b750346346bfe95c7c6b1cceacc6cfccc8f4f4.diff

[clang] 46ae26e - [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

2022-07-24 Thread Jonas Toth via cfe-commits
Author: Jonas Toth Date: 2022-07-24T19:37:54+02:00 New Revision: 46ae26e7eb7095faeda6d6c15470c256f9294c48 URL: https://github.com/llvm/llvm-project/commit/46ae26e7eb7095faeda6d6c15470c256f9294c48 DIFF: https://github.com/llvm/llvm-project/commit/46ae26e7eb7095faeda6d6c15470c256f9294c48.diff

[clang-tools-extra] 3f0f203 - run-clang-tidy: Fix infinite loop on windows

2022-04-24 Thread Jonas Toth via cfe-commits
Author: Jonas Toth Date: 2022-04-24T17:17:02+02:00 New Revision: 3f0f20366622ee5fd35a1d65d7db5226f5e5751f URL: https://github.com/llvm/llvm-project/commit/3f0f20366622ee5fd35a1d65d7db5226f5e5751f DIFF: https://github.com/llvm/llvm-project/commit/3f0f20366622ee5fd35a1d65d7db5226f5e5751f.diff

[clang] e517e5c - [clang] improve accuracy of ExprMutAnalyzer

2020-10-09 Thread Jonas Toth via cfe-commits
Author: Jonas Toth Date: 2020-10-09T13:45:32+02:00 New Revision: e517e5cfec90a00a488ad8df901ab9b903ebb966 URL: https://github.com/llvm/llvm-project/commit/e517e5cfec90a00a488ad8df901ab9b903ebb966 DIFF: https://github.com/llvm/llvm-project/commit/e517e5cfec90a00a488ad8df901ab9b903ebb966.diff

[clang] 4e53490 - [NFC][Docs] fix clang-docs compilation

2020-09-24 Thread Jonas Toth via cfe-commits
Author: Jonas Toth Date: 2020-09-24T13:13:38+02:00 New Revision: 4e534900476d2a5c620e74ddb9c9e7d321e6d443 URL: https://github.com/llvm/llvm-project/commit/4e534900476d2a5c620e74ddb9c9e7d321e6d443 DIFF: https://github.com/llvm/llvm-project/commit/4e534900476d2a5c620e74ddb9c9e7d321e6d443.diff

[clang] 69f9831 - [ASTMatchers] extract public matchers from const-analysis into own patch

2020-09-15 Thread Jonas Toth via cfe-commits
Author: Jonas Toth Date: 2020-09-15T21:07:30+02:00 New Revision: 69f98311ca42127df92527b6fc3be99841a15f12 URL: https://github.com/llvm/llvm-project/commit/69f98311ca42127df92527b6fc3be99841a15f12 DIFF: https://github.com/llvm/llvm-project/commit/69f98311ca42127df92527b6fc3be99841a15f12.diff

Re: Getting started

2020-01-30 Thread Jonas Toth via cfe-commits
Hi Anshil, take a look at this: https://clang.llvm.org/docs/InternalsManual.html cxx1x is probably done already, but cxx2a has some outstanding features ;) In general, please use 'cfe-dev' instead of 'cfe-commits'. There is the normal discussion and questions/answers for developers. Regards

[clang] 23a799a - Revert "[ASTMatchers] extract public matchers from const-analysis into own patch"

2020-01-11 Thread Jonas Toth via cfe-commits
Author: Jonas Toth Date: 2020-01-11T19:41:27+01:00 New Revision: 23a799adf0abbe9a7be1494d5efd1ab3215ee4fb URL: https://github.com/llvm/llvm-project/commit/23a799adf0abbe9a7be1494d5efd1ab3215ee4fb DIFF: https://github.com/llvm/llvm-project/commit/23a799adf0abbe9a7be1494d5efd1ab3215ee4fb.diff

[clang] 4c48ea6 - [ASTMatchers] extract public matchers from const-analysis into own patch

2020-01-11 Thread Jonas Toth via cfe-commits
Author: Jonas Toth Date: 2020-01-11T19:21:03+01:00 New Revision: 4c48ea68e491cb42f1b5d43ffba89f6a7f0dadc4 URL: https://github.com/llvm/llvm-project/commit/4c48ea68e491cb42f1b5d43ffba89f6a7f0dadc4 DIFF: https://github.com/llvm/llvm-project/commit/4c48ea68e491cb42f1b5d43ffba89f6a7f0dadc4.diff

[clang] cdd05f2 - [NFC] format unittest for ExprMutAnalyzer

2020-01-10 Thread Jonas Toth via cfe-commits
Author: Jonas Toth Date: 2020-01-10T16:10:55+01:00 New Revision: cdd05f2aea3b950a4e2c496175117e6b47b2a050 URL: https://github.com/llvm/llvm-project/commit/cdd05f2aea3b950a4e2c496175117e6b47b2a050 DIFF: https://github.com/llvm/llvm-project/commit/cdd05f2aea3b950a4e2c496175117e6b47b2a050.diff

[clang-tools-extra] 48ee040 - [clang-tidy] fix linkage with clangSema for FixitHintUtils, undo previous wrong fix

2020-01-03 Thread Jonas Toth via cfe-commits
Author: Jonas Toth Date: 2020-01-03T22:32:10+01:00 New Revision: 48ee04033cce2e085fd8909c6ebaa0de68ab65d0 URL: https://github.com/llvm/llvm-project/commit/48ee04033cce2e085fd8909c6ebaa0de68ab65d0 DIFF: https://github.com/llvm/llvm-project/commit/48ee04033cce2e085fd8909c6ebaa0de68ab65d0.diff

[clang-tools-extra] fed2a50 - [clang-tidy] quickfix: add -fno-delayed-template-parsing as default argument for runCheckOnCode unit-tests to unbreak windows

2020-01-03 Thread Jonas Toth via cfe-commits
Author: Jonas Toth Date: 2020-01-03T22:02:11+01:00 New Revision: fed2a5033af564af390faa8f8438018fe747126a URL: https://github.com/llvm/llvm-project/commit/fed2a5033af564af390faa8f8438018fe747126a DIFF: https://github.com/llvm/llvm-project/commit/fed2a5033af564af390faa8f8438018fe747126a.diff

[clang-tools-extra] 05ebaa6 - [clang-tidy] fix broken linking for AddConstTest with adding clangSema as dependency (DeclSpec)

2020-01-03 Thread Jonas Toth via cfe-commits
Author: Jonas Toth Date: 2020-01-03T21:55:51+01:00 New Revision: 05ebaa62e0db67d7a04d47b2f50eb2faa8597cc8 URL: https://github.com/llvm/llvm-project/commit/05ebaa62e0db67d7a04d47b2f50eb2faa8597cc8 DIFF: https://github.com/llvm/llvm-project/commit/05ebaa62e0db67d7a04d47b2f50eb2faa8597cc8.diff

[clang-tools-extra] cf48101 - [clang-tidy] implement utility-function to add 'const' to variables

2020-01-03 Thread Jonas Toth via cfe-commits
Author: Jonas Toth Date: 2020-01-03T20:37:47+01:00 New Revision: cf48101200ee192dd82e6ed0512ae42e7b3162a9 URL: https://github.com/llvm/llvm-project/commit/cf48101200ee192dd82e6ed0512ae42e7b3162a9 DIFF: https://github.com/llvm/llvm-project/commit/cf48101200ee192dd82e6ed0512ae42e7b3162a9.diff

[clang-tools-extra] r360883 - [clang-tidy] Removed superfluous and slightly annoying newlines in run-clang-tidy's output.

2019-05-16 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu May 16 05:39:22 2019 New Revision: 360883 URL: http://llvm.org/viewvc/llvm-project?rev=360883=rev Log: [clang-tidy] Removed superfluous and slightly annoying newlines in run-clang-tidy's output. Summary: The output of clang-tidy itself already has enough newlines, so

[clang-tools-extra] r360882 - [clang-tidy] Handle member variables in readability-simplify-boolean-expr

2019-05-16 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu May 16 05:35:00 2019 New Revision: 360882 URL: http://llvm.org/viewvc/llvm-project?rev=360882=rev Log: [clang-tidy] Handle member variables in readability-simplify-boolean-expr - Add readability-simplify-boolean-expr test cases for member variables Fixes PR40179

[clang-tools-extra] r360869 - [clang-tidy] Do not list enabled checks when -quiet is given to run-clang-tidy.

2019-05-16 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu May 16 02:22:39 2019 New Revision: 360869 URL: http://llvm.org/viewvc/llvm-project?rev=360869=rev Log: [clang-tidy] Do not list enabled checks when -quiet is given to run-clang-tidy. Summary: When run-clang-tidy is given the -quiet flag, do not output the potentially

[clang-tools-extra] r355108 - [clang-tidy] fix documentation link in list of clang-tidy checks

2019-02-28 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Feb 28 09:53:51 2019 New Revision: 355108 URL: http://llvm.org/viewvc/llvm-project?rev=355108=rev Log: [clang-tidy] fix documentation link in list of clang-tidy checks Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified:

[clang-tools-extra] r355102 - [clang-tidy] redirection in list of checks adjusted

2019-02-28 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Feb 28 07:56:40 2019 New Revision: 355102 URL: http://llvm.org/viewvc/llvm-project?rev=355102=rev Log: [clang-tidy] redirection in list of checks adjusted Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified:

[clang-tools-extra] r355100 - [clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of checks and fix redirection

2019-02-28 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Feb 28 07:47:10 2019 New Revision: 355100 URL: http://llvm.org/viewvc/llvm-project?rev=355100=rev Log: [clang-tidy] include cppcoreguidelines-explicit-virtual-functions in list of checks and fix redirection Modified:

[clang-tools-extra] r355098 - [clang-tidy] documentation fixing the actual correct file

2019-02-28 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Feb 28 07:39:47 2019 New Revision: 355098 URL: http://llvm.org/viewvc/llvm-project?rev=355098=rev Log: [clang-tidy] documentation fixing the actual correct file Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-time-subtraction.rst Modified:

[clang-tools-extra] r355097 - [clang-tidy] tryfix documenation continued

2019-02-28 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Feb 28 07:28:36 2019 New Revision: 355097 URL: http://llvm.org/viewvc/llvm-project?rev=355097=rev Log: [clang-tidy] tryfix documenation continued Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-duration-subtraction.rst Modified:

[clang-tools-extra] r355095 - [clang-tidy] another issue in documentation, double empty line seemed to confuse code-block

2019-02-28 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Feb 28 07:18:54 2019 New Revision: 355095 URL: http://llvm.org/viewvc/llvm-project?rev=355095=rev Log: [clang-tidy] another issue in documentation, double empty line seemed to confuse code-block Modified:

[clang-tools-extra] r355094 - [clang-tidy] attempt to fix documentation build-error

2019-02-28 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Feb 28 07:01:17 2019 New Revision: 355094 URL: http://llvm.org/viewvc/llvm-project?rev=355094=rev Log: [clang-tidy] attempt to fix documentation build-error Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-time-subtraction.rst Modified:

[clang-tools-extra] r355093 - [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

2019-02-28 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Feb 28 06:55:12 2019 New Revision: 355093 URL: http://llvm.org/viewvc/llvm-project?rev=355093=rev Log: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions Addresses the bugzilla bug #30397. (https://bugs.llvm.org/show_bug.cgi?id=30397)

[clang-tools-extra] r354903 - [clang-tidy] undo bitfields in ExceptionAnalyzer

2019-02-26 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Feb 26 10:15:17 2019 New Revision: 354903 URL: http://llvm.org/viewvc/llvm-project?rev=354903=rev Log: [clang-tidy] undo bitfields in ExceptionAnalyzer Scoped enums do induce some problems with some MSVC and GCC versions if used as bitfields. Therefor this is

[clang-tools-extra] r354517 - [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

2019-02-20 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Wed Feb 20 13:04:36 2019 New Revision: 354517 URL: http://llvm.org/viewvc/llvm-project?rev=354517=rev Log: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer Summary: The analsis on the throwing behvaiour on functions and statements gave only a binary

[clang-tools-extra] r353389 - [clang-tidy] Fixed a std::bind() transformation

2019-02-07 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Feb 7 03:00:59 2019 New Revision: 353389 URL: http://llvm.org/viewvc/llvm-project?rev=353389=rev Log: [clang-tidy] Fixed a std::bind() transformation There was an extra semicolon that was somehow working in some contexts. Patch by oleg.smolsky. Modified:

[clang-tools-extra] r352741 - [clang-tidy] refactor bugprone-exception-escape analysis into class

2019-01-31 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Jan 31 02:46:37 2019 New Revision: 352741 URL: http://llvm.org/viewvc/llvm-project?rev=352741=rev Log: [clang-tidy] refactor bugprone-exception-escape analysis into class Summary: The check `bugprone-exception-escape` does an AST-based analysis to determine if a

[clang-tools-extra] r352231 - [clang-tidy] fix unit tests for dropped _Float16 support in X86

2019-01-25 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Fri Jan 25 11:05:12 2019 New Revision: 352231 URL: http://llvm.org/viewvc/llvm-project?rev=352231=rev Log: [clang-tidy] fix unit tests for dropped _Float16 support in X86 Summary: Because _Float16 was disabled for X86 targets the unit-tests started failing. Extract the

r351743 - [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers

2019-01-21 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Mon Jan 21 05:26:18 2019 New Revision: 351743 URL: http://llvm.org/viewvc/llvm-project?rev=351743=rev Log: [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers Summary: This patch adds two unit-tests that are the result of reducing a crashing TU

[clang-tools-extra] r351569 - [clang-tidy] add reproducer for PR39949 into test-suite

2019-01-18 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Fri Jan 18 10:03:11 2019 New Revision: 351569 URL: http://llvm.org/viewvc/llvm-project?rev=351569=rev Log: [clang-tidy] add reproducer for PR39949 into test-suite Summary: The underlying issue is fixed in https://reviews.llvm.org/D56444 and this test ensures the issue

[clang-tools-extra] r350814 - [clang-tidy] Fix case of local variables in modernize-use-nodiscard checker

2019-01-10 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Jan 10 03:56:44 2019 New Revision: 350814 URL: http://llvm.org/viewvc/llvm-project?rev=350814=rev Log: [clang-tidy] Fix case of local variables in modernize-use-nodiscard checker Summary: Correct the case of the local variables.. Rational: I want to be able to run

[clang-tools-extra] r350765 - [clang-tidy] another take at fixing doc

2019-01-09 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Wed Jan 9 13:27:59 2019 New Revision: 350765 URL: http://llvm.org/viewvc/llvm-project?rev=350765=rev Log: [clang-tidy] another take at fixing doc Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-nodiscard.rst Modified:

[clang-tools-extra] r350763 - [clang-tidy] tryfix documentation build

2019-01-09 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Wed Jan 9 13:19:44 2019 New Revision: 350763 URL: http://llvm.org/viewvc/llvm-project?rev=350763=rev Log: [clang-tidy] tryfix documentation build Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-nodiscard.rst Modified:

[clang-tools-extra] r350761 - [clang-tidy] fix-up failing tests

2019-01-09 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Wed Jan 9 13:03:54 2019 New Revision: 350761 URL: http://llvm.org/viewvc/llvm-project?rev=350761=rev Log: [clang-tidy] fix-up failing tests Removed: clang-tools-extra/trunk/test/clang-tidy/modernize-use-nodiscard.h Modified:

[clang-tools-extra] r350760 - [clang-tidy] Adding a new modernize use nodiscard checker

2019-01-09 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Wed Jan 9 12:50:50 2019 New Revision: 350760 URL: http://llvm.org/viewvc/llvm-project?rev=350760=rev Log: [clang-tidy] Adding a new modernize use nodiscard checker Summary: Adds a checker to clang-tidy to warn when a non void const member function, taking only

[clang-tools-extra] r350466 - [Documentation] fix order of checks in checks/list.rst

2019-01-05 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Sat Jan 5 03:40:05 2019 New Revision: 350466 URL: http://llvm.org/viewvc/llvm-project?rev=350466=rev Log: [Documentation] fix order of checks in checks/list.rst Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified:

[clang-tools-extra] r348842 - Use the standard Duration factory matcher

2018-12-11 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Dec 11 04:45:51 2018 New Revision: 348842 URL: http://llvm.org/viewvc/llvm-project?rev=348842=rev Log: Use the standard Duration factory matcher Summary: A new check came in over the weekend; it should use our existing infrastructure for matching `absl::Duration`

[clang-tools-extra] r348840 - [clang-tidy] NFC Consolidate test absl::Time implementation

2018-12-11 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Dec 11 04:42:17 2018 New Revision: 348840 URL: http://llvm.org/viewvc/llvm-project?rev=348840=rev Log: [clang-tidy] NFC Consolidate test absl::Time implementation Summary: Several tests re-implement these same prototypes (differently), so we can put them in a common

[clang-tools-extra] r348793 - [clang-tidy] insert release notes for new checkers alphabetically

2018-12-10 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Mon Dec 10 11:41:53 2018 New Revision: 348793 URL: http://llvm.org/viewvc/llvm-project?rev=348793=rev Log: [clang-tidy] insert release notes for new checkers alphabetically Summary: Almost all code review comments on new checkers {D55433} {D48866} {D54349} seem to ask

[clang-tools-extra] r348344 - Revert "[clang-tidy] new check: bugprone-branch-clone"

2018-12-05 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Wed Dec 5 01:34:18 2018 New Revision: 348344 URL: http://llvm.org/viewvc/llvm-project?rev=348344=rev Log: Revert "[clang-tidy] new check: bugprone-branch-clone" The patch broke on buildbot with assertion-failure. Revert until this is figured out. Removed:

[clang-tools-extra] r348343 - [clang-tidy] new check: bugprone-branch-clone

2018-12-05 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Wed Dec 5 01:16:25 2018 New Revision: 348343 URL: http://llvm.org/viewvc/llvm-project?rev=348343=rev Log: [clang-tidy] new check: bugprone-branch-clone Summary: Implement a check for detecting if/else if/else chains where two or more branches are Type I clones of each

[clang-tools-extra] r348341 - Fix a false positive in misplaced-widening-cast

2018-12-05 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Wed Dec 5 00:29:56 2018 New Revision: 348341 URL: http://llvm.org/viewvc/llvm-project?rev=348341=rev Log: Fix a false positive in misplaced-widening-cast Summary: bugprone-misplaced-widening-cast check used to give a false warning to the following example. enum

[clang-tools-extra] r348172 - [clang-tidy] Fix unordered_map failure with specializing std::hash<> and remove previous wrong attempt at doing so

2018-12-03 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Mon Dec 3 11:41:04 2018 New Revision: 348172 URL: http://llvm.org/viewvc/llvm-project?rev=348172=rev Log: [clang-tidy] Fix unordered_map failure with specializing std::hash<> and remove previous wrong attempt at doing so Modified:

[clang-tools-extra] r348169 - [clang-tidy] Recommit: Add the abseil-duration-comparison check

2018-12-03 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Mon Dec 3 11:22:08 2018 New Revision: 348169 URL: http://llvm.org/viewvc/llvm-project?rev=348169=rev Log: [clang-tidy] Recommit: Add the abseil-duration-comparison check Summary: This check finds instances where Duration values are being converted to a numeric value in

[clang-tools-extra] r348165 - Revert "[clang-tidy] Add the abseil-duration-comparison check"

2018-12-03 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Mon Dec 3 10:59:27 2018 New Revision: 348165 URL: http://llvm.org/viewvc/llvm-project?rev=348165=rev Log: Revert "[clang-tidy] Add the abseil-duration-comparison check" This commit broke buildbots and needs adjustments. Removed:

[clang-tools-extra] r348161 - [clang-tidy] Add the abseil-duration-comparison check

2018-12-03 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Mon Dec 3 10:35:56 2018 New Revision: 348161 URL: http://llvm.org/viewvc/llvm-project?rev=348161=rev Log: [clang-tidy] Add the abseil-duration-comparison check Summary: This check finds instances where Duration values are being converted to a numeric value in a

r347676 - Revert "[clang] - Simplify tools::SplitDebugName."

2018-11-27 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Nov 27 09:28:38 2018 New Revision: 347676 URL: http://llvm.org/viewvc/llvm-project?rev=347676=rev Log: Revert "[clang] - Simplify tools::SplitDebugName." This reverts commit r347035 as it introduced assertion failures under certain conditions. More information can be

[clang-tools-extra] r346678 - Revert "Add a test checking clang-tidy can find libc++ on Mac"

2018-11-12 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Mon Nov 12 09:22:36 2018 New Revision: 346678 URL: http://llvm.org/viewvc/llvm-project?rev=346678=rev Log: Revert "Add a test checking clang-tidy can find libc++ on Mac" This reverts commit r346653. Removed:

[clang-tools-extra] r346676 - [clang-tidy] fix ARM tests, because int and long have same width

2018-11-12 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Mon Nov 12 09:02:05 2018 New Revision: 346676 URL: http://llvm.org/viewvc/llvm-project?rev=346676=rev Log: [clang-tidy] fix ARM tests, because int and long have same width Modified: clang-tools-extra/trunk/test/clang-tidy/bugprone-too-small-loop-variable.cpp

[clang-tools-extra] r346665 - [clang-tidy] new check: bugprone-too-small-loop-variable

2018-11-12 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Mon Nov 12 08:01:39 2018 New Revision: 346665 URL: http://llvm.org/viewvc/llvm-project?rev=346665=rev Log: [clang-tidy] new check: bugprone-too-small-loop-variable The new checker searches for those for loops which has a loop variable with a "too small" type which means

[clang-tools-extra] r346555 - [clang-tidy] fix PR39583 - ignoring ParenCast for string-literals in pro-bounds-array-to-pointer-decay

2018-11-09 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Fri Nov 9 12:57:28 2018 New Revision: 346555 URL: http://llvm.org/viewvc/llvm-project?rev=346555=rev Log: [clang-tidy] fix PR39583 - ignoring ParenCast for string-literals in pro-bounds-array-to-pointer-decay Summary: The fix to the issue that `const char* p = ("foo")`

r346554 - [ASTMatchers] overload ignoringParens for Expr

2018-11-09 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Fri Nov 9 12:54:06 2018 New Revision: 346554 URL: http://llvm.org/viewvc/llvm-project?rev=346554=rev Log: [ASTMatchers] overload ignoringParens for Expr Summary: This patch allows fixing PR39583. Reviewers: aaron.ballman, sbenza, klimek Reviewed By: aaron.ballman

[clang-tools-extra] r346176 - [clang-tidy] fix example code-blocks indendation

2018-11-05 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Mon Nov 5 14:30:17 2018 New Revision: 346176 URL: http://llvm.org/viewvc/llvm-project?rev=346176=rev Log: [clang-tidy] fix example code-blocks indendation Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-special-member-functions.rst

[clang-tools-extra] r346173 - [clang-tidy] doc removew hitespace in front of code-block-line

2018-11-05 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Mon Nov 5 14:21:27 2018 New Revision: 346173 URL: http://llvm.org/viewvc/llvm-project?rev=346173=rev Log: [clang-tidy] doc removew hitespace in front of code-block-line Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/boost-use-to-string.rst

[clang-tools-extra] r345995 - [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds

2018-11-02 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Fri Nov 2 09:36:21 2018 New Revision: 345995 URL: http://llvm.org/viewvc/llvm-project?rev=345995=rev Log: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds r345961 introduced a path check in

[clang-tools-extra] r345742 - [clang-tidy] add missing '--' in RUN-line, unbreak buildbot

2018-10-31 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Wed Oct 31 10:26:10 2018 New Revision: 345742 URL: http://llvm.org/viewvc/llvm-project?rev=345742=rev Log: [clang-tidy] add missing '--' in RUN-line, unbreak buildbot Modified: clang-tools-extra/trunk/test/clang-tidy/readability-isolate-declaration.cpp Modified:

[clang-tools-extra] r345738 - [clang-tidy] add -fexceptions to failing unit-test, unbreak buildbot

2018-10-31 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Wed Oct 31 10:08:09 2018 New Revision: 345738 URL: http://llvm.org/viewvc/llvm-project?rev=345738=rev Log: [clang-tidy] add -fexceptions to failing unit-test, unbreak buildbot Modified: clang-tools-extra/trunk/test/clang-tidy/readability-isolate-declaration.cpp

r345737 - [clang] try-fix broken documentation builder

2018-10-31 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Wed Oct 31 10:00:50 2018 New Revision: 345737 URL: http://llvm.org/viewvc/llvm-project?rev=345737=rev Log: [clang] try-fix broken documentation builder Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

[clang-tools-extra] r345736 - [clang-tools-extra] fix broken link in release notes

2018-10-31 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Wed Oct 31 09:59:41 2018 New Revision: 345736 URL: http://llvm.org/viewvc/llvm-project?rev=345736=rev Log: [clang-tools-extra] fix broken link in release notes Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified:

[clang-tools-extra] r345735 - [clang-tidy] new check 'readability-isolate-declaration'

2018-10-31 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Wed Oct 31 09:50:44 2018 New Revision: 345735 URL: http://llvm.org/viewvc/llvm-project?rev=345735=rev Log: [clang-tidy] new check 'readability-isolate-declaration' Summary: This patch introduces a new clang-tidy check that matches on all `declStmt` that declare more then

[clang-tools-extra] r345167 - [clang-tidy] Add the abseil-duration-factory-float check

2018-10-24 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Wed Oct 24 10:40:50 2018 New Revision: 345167 URL: http://llvm.org/viewvc/llvm-project?rev=345167=rev Log: [clang-tidy] Add the abseil-duration-factory-float check Summary: This check finds cases where calls to an absl::Duration factory could use the more efficient

[clang-tools-extra] r344947 - [clang-tidy] tryfix windows build

2018-10-22 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Mon Oct 22 13:29:15 2018 New Revision: 344947 URL: http://llvm.org/viewvc/llvm-project?rev=344947=rev Log: [clang-tidy] tryfix windows build Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp Modified:

[clang-tools-extra] r344940 - [clang-tidy] implement cppcoreguidelines macro rules

2018-10-22 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Mon Oct 22 12:20:01 2018 New Revision: 344940 URL: http://llvm.org/viewvc/llvm-project?rev=344940=rev Log: [clang-tidy] implement cppcoreguidelines macro rules Summary: In short macros are discouraged by multiple rules (and sometimes reference randomly). [Enum.1],

[clang-tools-extra] r344442 - Revert "[clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length"

2018-10-13 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Sat Oct 13 02:30:58 2018 New Revision: 32 URL: http://llvm.org/viewvc/llvm-project?rev=32=rev Log: Revert "[clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length" This reverts commit r344374. Removed:

[clang-tools-extra] r344441 - Revert "[doc] fix markup in clang-tidy bugprone-not-null-terminated-result"

2018-10-13 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Sat Oct 13 02:30:46 2018 New Revision: 31 URL: http://llvm.org/viewvc/llvm-project?rev=31=rev Log: Revert "[doc] fix markup in clang-tidy bugprone-not-null-terminated-result" This reverts commit r344379. Modified:

r344388 - [Doc] fix second error in UsersManual

2018-10-12 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Fri Oct 12 10:57:18 2018 New Revision: 344388 URL: http://llvm.org/viewvc/llvm-project?rev=344388=rev Log: [Doc] fix second error in UsersManual Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

[clang-tools-extra] r344384 - [clangd] NFC fix semicolon warning

2018-10-12 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Fri Oct 12 10:47:43 2018 New Revision: 344384 URL: http://llvm.org/viewvc/llvm-project?rev=344384=rev Log: [clangd] NFC fix semicolon warning Modified: clang-tools-extra/trunk/clangd/index/IndexAction.cpp Modified: clang-tools-extra/trunk/clangd/index/IndexAction.cpp

r344382 - [Doc] fix BB, add code-block type

2018-10-12 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Fri Oct 12 10:44:01 2018 New Revision: 344382 URL: http://llvm.org/viewvc/llvm-project?rev=344382=rev Log: [Doc] fix BB, add code-block type Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

[clang-tools-extra] r344379 - [doc] fix markup in clang-tidy bugprone-not-null-terminated-result

2018-10-12 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Fri Oct 12 10:36:04 2018 New Revision: 344379 URL: http://llvm.org/viewvc/llvm-project?rev=344379=rev Log: [doc] fix markup in clang-tidy bugprone-not-null-terminated-result Modified:

[clang-tools-extra] r344374 - [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

2018-10-12 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Fri Oct 12 10:22:36 2018 New Revision: 344374 URL: http://llvm.org/viewvc/llvm-project?rev=344374=rev Log: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length New checker called bugprone-not-null-terminated-result. This

[clang-tools-extra] r344046 - [clang-tidy] NFC fix warnings from missing braces

2018-10-09 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Oct 9 06:29:31 2018 New Revision: 344046 URL: http://llvm.org/viewvc/llvm-project?rev=344046=rev Log: [clang-tidy] NFC fix warnings from missing braces The std::array create multiple StringRef but did not wrap them in braces. Some compilers warned for that. Adding

[clang-tools-extra] r344044 - [clangd] fix miscompiling lower_bound call

2018-10-09 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Oct 9 06:24:50 2018 New Revision: 344044 URL: http://llvm.org/viewvc/llvm-project?rev=344044=rev Log: [clangd] fix miscompiling lower_bound call Modified: clang-tools-extra/trunk/clangd/index/Index.cpp Modified: clang-tools-extra/trunk/clangd/index/Index.cpp

Re: [clang-tools-extra] r343848 - [clang-tidy] Replace deprecated std::ios_base aliases

2018-10-09 Thread Jonas Toth via cfe-commits
alone seeing it. > This is still giving the warning with clang 3.6. > > Thanks, > Mikael > >> Regards, >> Mikael >> >> On 10/05/2018 03:36 PM, Jonas Toth via cfe-commits wrote: >>> Author: jonastoth >>> Date: Fri Oct 5 06:36:00 2018 >>&g

[clang-tools-extra] r343850 - [clang-tidy] NFC refactor lexer-utils to be usable without ASTContext

2018-10-05 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Fri Oct 5 07:15:19 2018 New Revision: 343850 URL: http://llvm.org/viewvc/llvm-project?rev=343850=rev Log: [clang-tidy] NFC refactor lexer-utils to be usable without ASTContext Summary: This patch is a small refactoring necessary for 'readability-isolate-declaration' and

[clang-tools-extra] r343848 - [clang-tidy] Replace deprecated std::ios_base aliases

2018-10-05 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Fri Oct 5 06:36:00 2018 New Revision: 343848 URL: http://llvm.org/viewvc/llvm-project?rev=343848=rev Log: [clang-tidy] Replace deprecated std::ios_base aliases This check warns the uses of the deprecated member types of std::ios_base and replaces those that have a

[clang-tools-extra] r343797 - [clang-tidy] fix failing unit tests

2018-10-04 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Oct 4 09:39:41 2018 New Revision: 343797 URL: http://llvm.org/viewvc/llvm-project?rev=343797=rev Log: [clang-tidy] fix failing unit tests The removal from the FIX-IT notes through the check-clang-tidy script was done incorrect. I did not detect beforehand but

[clang-tools-extra] r343796 - [clangd] fix another ambigous constructor in DexTest

2018-10-04 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Oct 4 09:29:58 2018 New Revision: 343796 URL: http://llvm.org/viewvc/llvm-project?rev=343796=rev Log: [clangd] fix another ambigous constructor in DexTest Modified: clang-tools-extra/trunk/unittests/clangd/DexTests.cpp Modified:

[clang-tools-extra] r343792 - [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments

2018-10-04 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Oct 4 08:59:30 2018 New Revision: 343792 URL: http://llvm.org/viewvc/llvm-project?rev=343792=rev Log: [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: xazax.hun,

[clang-tools-extra] r343791 - [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init

2018-10-04 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Oct 4 08:55:37 2018 New Revision: 343791 URL: http://llvm.org/viewvc/llvm-project?rev=343791=rev Log: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers:

[clang-tools-extra] r343789 - [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up

2018-10-04 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Oct 4 08:49:25 2018 New Revision: 343789 URL: http://llvm.org/viewvc/llvm-project?rev=343789=rev Log: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up Summary: The check bugprone-exception-escape should not register if -fno-exceptions is set for the

[clang-tools-extra] r343788 - [clang-tidy] Added pointer types to clang-tidy readability-identifier-naming check.

2018-10-04 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Oct 4 08:47:57 2018 New Revision: 343788 URL: http://llvm.org/viewvc/llvm-project?rev=343788=rev Log: [clang-tidy] Added pointer types to clang-tidy readability-identifier-naming check. Summary: Option to check for different naming conventions on the following

[clang-tools-extra] r343673 - [clang-tidy] NFC reorder registering in CppCoreGuidelines module

2018-10-03 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Wed Oct 3 03:37:19 2018 New Revision: 343673 URL: http://llvm.org/viewvc/llvm-project?rev=343673=rev Log: [clang-tidy] NFC reorder registering in CppCoreGuidelines module Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

[clang-tools-extra] r343565 - [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto

2018-10-02 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Oct 2 02:38:26 2018 New Revision: 343565 URL: http://llvm.org/viewvc/llvm-project?rev=343565=rev Log: [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: nemanjai,

[clang-tools-extra] r343564 - [clang-tidy] NFC use CHECK-NOTES in tests for cppcoreguidelines-owning-memory

2018-10-02 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Oct 2 02:38:20 2018 New Revision: 343564 URL: http://llvm.org/viewvc/llvm-project?rev=343564=rev Log: [clang-tidy] NFC use CHECK-NOTES in tests for cppcoreguidelines-owning-memory Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: nemanjai,

[clang-tools-extra] r343201 - [clang-tidy] use CHECK-NOTES in tests for bugprone suspicious-enum-usage

2018-09-27 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Sep 27 05:30:44 2018 New Revision: 343201 URL: http://llvm.org/viewvc/llvm-project?rev=343201=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone suspicious-enum-usage Reviewers: alexfh, aaron.ballman, hokein Subscribers: xazax.hun, cfe-commits Differential

[clang-tools-extra] r343199 - [clang-tidy] use CHECK-NOTES in tests for bugprone-use-after-move

2018-09-27 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Sep 27 05:22:48 2018 New Revision: 343199 URL: http://llvm.org/viewvc/llvm-project?rev=343199=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone-use-after-move Reviewers: alexfh, aaron.ballman, hokein Subscribers: xazax.hun, cfe-commits Differential

[clang-tools-extra] r343198 - [clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace

2018-09-27 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Thu Sep 27 05:17:59 2018 New Revision: 343198 URL: http://llvm.org/viewvc/llvm-project?rev=343198=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace Reviewers: aaron.ballman, alexfh, hokein Subscribers: xazax.hun, cfe-commits

[clang-tools-extra] r343001 - [clang-tidy] use CHECK-NOTES in tests for bugprone-macro-repeated-side-effects

2018-09-25 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Sep 25 11:15:52 2018 New Revision: 343001 URL: http://llvm.org/viewvc/llvm-project?rev=343001=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone-macro-repeated-side-effects Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: xazax.hun,

[clang-tools-extra] r343000 - [clang-tidy] Add modernize-concat-nested-namespaces check

2018-09-25 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Sep 25 11:12:28 2018 New Revision: 343000 URL: http://llvm.org/viewvc/llvm-project?rev=343000=rev Log: [clang-tidy] Add modernize-concat-nested-namespaces check Summary: Finds instances of namespaces concatenated using explicit syntax, such as `namespace a {

[clang-tools-extra] r342468 - [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value

2018-09-18 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Sep 18 04:49:20 2018 New Revision: 342468 URL: http://llvm.org/viewvc/llvm-project?rev=342468=rev Log: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value Reviewers: aaron.ballman, alexfh, hokein Reviewed By: alexfh Subscribers: xazax.hun, cfe-commits

[clang-tools-extra] r342459 - [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload

2018-09-18 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Sep 18 03:21:33 2018 New Revision: 342459 URL: http://llvm.org/viewvc/llvm-project?rev=342459=rev Log: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload Reviewers: aaron.ballman, alexfh, hokein Reviewed By: alexfh Subscribers: xazax.hun,

[clang-tools-extra] r342458 - [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment

2018-09-18 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Sep 18 03:15:15 2018 New Revision: 342458 URL: http://llvm.org/viewvc/llvm-project?rev=342458=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment Summary: This patch uses CHECK-NOTES for the tests. Its part of an effort to test *ALL* generated

[clang-tools-extra] r342393 - [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

2018-09-17 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Mon Sep 17 06:55:10 2018 New Revision: 342393 URL: http://llvm.org/viewvc/llvm-project?rev=342393=rev Log: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly Summary: PR37913 documents wrong behaviour for a templated exception factory function. The

[clang-tools-extra] r342267 - [NFC][clangd] silence pedantic extra '; ' warning

2018-09-14 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Fri Sep 14 12:42:37 2018 New Revision: 342267 URL: http://llvm.org/viewvc/llvm-project?rev=342267=rev Log: [NFC][clangd] silence pedantic extra ';' warning Modified: clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp Modified:

r341958 - [ASTMatchers] add three matchers for dependent expressions

2018-09-11 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Sep 11 09:09:19 2018 New Revision: 341958 URL: http://llvm.org/viewvc/llvm-project?rev=341958=rev Log: [ASTMatchers] add three matchers for dependent expressions Summary: The new matchers can be used to check if an expression is type-, value- or

[clang-tools-extra] r341933 - [NFC][clangd] fix warning for extra semicolon

2018-09-11 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Sep 11 06:01:49 2018 New Revision: 341933 URL: http://llvm.org/viewvc/llvm-project?rev=341933=rev Log: [NFC][clangd] fix warning for extra semicolon Modified: clang-tools-extra/trunk/unittests/clangd/XRefsTests.cpp Modified:

  1   2   >