[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

jonathan.protzenko added a comment. I'm responding here after a ping on Bugzilla. The short version is I've stopped working on this patch. While I like the revised design that involves storing a list of tokens to make plugins even more powerful, this turned out to be a much bigger implementatio

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

jonathan.protzenko added a comment. In D86169#2241830 , @aaron.ballman wrote: >> - Upon encountering `[[ attr(X) ]]` where `attr` is a plugin-handled >> attribute: clang parses `X` as token soup, only caring about finding a >> matching parenthesis > > J

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

jonathan.protzenko added a comment. > I'm hoping we can devise a way to not require the entity being attributed to > be passed when parsing the attribute That sounds nice. My only concern with this proposal is to make sure this doesn't rule out the interesting use-cases I was mentioning, like t

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

jonathan.protzenko added a comment. I also seem to have broken a bunch of tests, although I'm not sure why. If you see an obvious cause, I'm happy to get some pointers, otherwise, I'll just dig in an debug as I extend the test suite once the patch stabilizes. Repository: rG LLVM Github Monor

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

jonathan.protzenko added a comment. Thanks for the review! Regarding Declarator: I briefly mentioned something related in the details section... actually maybe you can tell me what's the best approach here. I was thinking of just passing in a void* and expecting plugins to do if (const Decla

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

jonathan.protzenko created this revision. jonathan.protzenko added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. jonathan.protzenko requested review of this revision. This is a preliminary patch that I hope can serve as a basis for discussion. Th