[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

jhuber6 added a comment. In D128090#3649579 , @tra wrote: > In D128090#3649235 , @jhuber6 wrote: > >> Interesting, may be worthwhile to query that if it exists, though AMD does >> this with `amdgpu-arch` which

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7009 + // Host-side offloading compilation receives all device-side outputs. Include + // them in the host compilation depending on the target. if

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

jhuber6 updated this revision to Diff 444398. jhuber6 marked an inline comment as done. jhuber6 added a comment. Updating and making suggested changes. I removed the old `fgpu-rdc` in rG6abaa8e2103760025cee76528f555de7cf6698e6

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

jhuber6 marked an inline comment as done. jhuber6 added a comment. It's also worth noting that this doesn't include the `PTX` output for JIT in the fatbinary, it would be relatively easy to include that but I wanted to ask how we should handle that. Comment at:

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6998-6999 +CmdArgs.push_back(CudaDeviceInput->getFilename()); +if (IsRDCMode) + CmdArgs.push_back("-fgpu-rdc"); + } else if (IsCuda && !HostOffloadingInputs.empty() && !IsRDCMode) {

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

jhuber6 added a comment. In D128090#3649202 , @tra wrote: > In D128090#3649125 , @jhuber6 wrote: > >> It just defaults to `sm_35` if CUDA isn't present on the system IIRC. >> Alternatively we could ship a tool

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

jhuber6 added a comment. In D128090#3649059 , @tra wrote: > In D128090#3648999 , @jhuber6 wrote: > >> Right now there's `CLANG_OPENMP_NVPTX_DEFAULT_ARCH`, which is defined by >> CMake to be the architecture of

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

jhuber6 added a comment. In D128090#3648984 , @tra wrote: > At some point we should start consolidating the ways we can specify an > offload target and try to avoid adding new ones until then. Agreed, that was my intention with making `--offload-arch`

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

jhuber6 added a subscriber: tra. jhuber6 added a comment. In D128090#3648879 , @saiislam wrote: > `-Xopenmp-target -march ` used to be the only option to target a specific sub > arch before `--offload-arch`. But, it doesn't support multiple archs. >

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, JonChesterfield, yaxunl. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

jhuber6 added a comment. Sorry never noticed this revision. The purpose of this patch seems to be supporting something like this clang input.c -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target=nvptx64 -march=sm_70 -Xopenmp-target=nvptx64 -march=sm_80 Right now the above works if you replace

[PATCH] D129586: [LinkerWrapper] Support remarks files for device LTO

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: wenlei, inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This

[PATCH] D129581: [Clang] Rework LTO argument handling in the linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, MaskRay, tra, ABataev, yaxunl, tianshilei1992. Herald added subscribers: StephenFan, inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D129534: [OpenMP] Do not link static library with `-nogpulib`

This revision was automatically updated to reflect the committed changes. Closed by commit rGd214bfe78d8d: [OpenMP] Do not link static library with `-nogpulib` (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129534/new/

[PATCH] D129534: [OpenMP] Do not link static library with `-nogpulib`

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tianshilei1992, ABataev. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. In D128914#3644022 , @thakis wrote: > This breaks check-clang on mac: http://45.33.8.238/macm1/39907/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Let me know if rGfe6a391357fc

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. In D128914#3644022 , @thakis wrote: > This breaks check-clang on mac: http://45.33.8.238/macm1/39907/step_7.txt > > Please take a look and revert for now if it takes a while to fix. I changed some of the argument formats in a

[PATCH] D127304: [LinkerWrapper] Embed OffloadBinaries for OpenMP offloading images

jhuber6 updated this revision to Diff 443810. jhuber6 added a comment. Removing `.image` from section name. This was originally done to avoid it getting the `SHF_EXCLUDE` flag when it should not be removed by the linker. That behaviour was moved to the `!exclude` metadata in a previous patch.

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. In D128914#3643802 , @tra wrote: > For what it's worth, NCCL is the only > nontrivial library that needs RDC compilation that I'm aware of. > It's also self-contained for RDC purposes we only

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. In D128914#3643451 , @yaxunl wrote: > If you only unregister fatbin once for the whole program, then it should be > safe -fgpu-rdc. I am not sure if that is the case. it should be here, the generated handle is private to the

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce091eb3b91f: [HIP] Add support for handling HIP in the linker wrapper (authored by jhuber6). Changed prior to commit:

[PATCH] D128850: [HIP] Generate offloading entries for HIP with the new driver.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe88d53d25f3b: [HIP] Generate offloading entries for HIP with the new driver. (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129435: [Clang] Parse toolchain-specific offloading arguments directly

This revision was automatically updated to reflect the committed changes. Closed by commit rG359e4a824731: [Clang] Parse toolchain-specific offloading arguments directly (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. In D128914#3642869 , @yaxunl wrote: > In D128914#3642567 , @jhuber6 wrote: > >> In D128914#3642558 , >> @JonChesterfield wrote: >> >>> Code

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. In D128914#3642558 , @JonChesterfield wrote: > Code looks good to me. It's hard to be sure whether it works without running > a bunch of hip test cases through it, have you already done so? If it doesn't > work out of the box

[PATCH] D129435: [Clang] Parse toolchain-specific offloading arguments directly

jhuber6 added a comment. In D129435#3642450 , @yaxunl wrote: > need a test There's a test `clang/test/Driver/openmp-offload-gpu-new.c` already making sure that the following works, so this patch should maintain the same functionality we had before.

[PATCH] D129435: [Clang] Parse toolchain-specific offloading arguments directly

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl, MaskRay. Herald added subscribers: kosarev, StephenFan, tpr. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a

[PATCH] D129424: [LinkerWrapper] Forward `-mllvm` options to the linker wrapper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22a01b860b90: [LinkerWrapper] Forward `-mllvm` options to the linker wrapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129424: [LinkerWrapper] Forward `-mllvm` options to the linker wrapper

jhuber6 updated this revision to Diff 443464. jhuber6 added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129424/new/ https://reviews.llvm.org/D129424 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D129424: [LinkerWrapper] Forward `-mllvm` options to the linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ye-luo, JonChesterfield, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This

[PATCH] D129423: [LinkerWrapper] Fix errors not exiting inside of the LTO pipeline

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbd3ade17bc1: [LinkerWrapper] Fix errors not exiting inside of the LTO pipeline (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129423: [LinkerWrapper] Fix errors not exiting inside of the LTO pipeline

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, ye-luo. Herald added a subscriber: inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The LTO pipeline handles

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jhuber6 added a comment. In D102107#3640198 , @dhruvachak wrote: > Thanks. I followed the above steps and regenerated a couple of the AST tests > but they still fail. Perhaps I am missing some options? > > I currently have a handful of clang test

[PATCH] D129393: [Clang] Fix the wrong features being derivec in the offload packager

This revision was automatically updated to reflect the committed changes. Closed by commit rG24849c9eb504: [Clang] Fix the wrong features being derivec in the offload packager (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129383: [LinkerWrapper] Fix use of string savers and correctly pass bitcode libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rGd36b96afb224: [LinkerWrapper] Fix use of string savers and correctly pass bitcode libraries (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129393: [Clang] Fix the wrong features being derivec in the offload packager

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, ye-luo, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. The offload packager embeds the features

[PATCH] D128816: [OpenMP] Add loop tripcount argument to kernel launch and remove push function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5300263c70da: [OpenMP] Add loop tripcount argument to kernel launch and remove push function (authored by jhuber6). Repository: rG LLVM Github

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fff116645b3: [OpenMP] Change OpenMP code generation for target region entries (authored by jhuber6). Repository: rG LLVM Github Monorepo

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

jhuber6 added a comment. In D129301#3639318 , @yaxunl wrote: > I think before the new binary format supports Windows and -fno-gpu-rdc and > HIP runtime support the new binary format, we cannot deprecate > clang-offload-bundler. I expect that would take

[PATCH] D129383: [LinkerWrapper] Fix use of string savers and correctly pass bitcode libraries

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ye-luo. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes some uses of string savers that are no-longer needed. We

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

jhuber6 added a comment. In D129301#3637642 , @jdoerfert wrote: > Isn't the offload bundler on it's "way out" (=replaced and then deleted soon)? HIP still uses it to create their `fatbinary` format for CUDA-like support for multi-architecture binaries

[PATCH] D128816: [OpenMP] Add loop tripcount argument to kernel launch and remove push function

jhuber6 updated this revision to Diff 443013. jhuber6 added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128816/new/ https://reviews.llvm.org/D128816 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 443011. jhuber6 added a comment. Moving version field to struct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D129151: [Metadata] Add 'exclude' metadata to add the exclude flags on globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41fba3c107a5: [Metadata] Add exclude metadata to add the exclude flags on globals (authored by jhuber6). Repository: rG LLVM Github Monorepo

[PATCH] D129033: [Clang] Use metadata to make identifying embedded objects easier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed801ad5e5fe: [Clang] Use metadata to make identifying embedded objects easier (authored by jhuber6). Changed prior to commit:

[PATCH] D129151: [Metadata] Add 'exclude' metadata to add the exclude flags on globals

jhuber6 updated this revision to Diff 442941. jhuber6 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Addressing comments. Metadata is now empty and must be empty for the flag to be emitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D129033: [Clang] Use metadata to make identifying embedded objects easier

jhuber6 updated this revision to Diff 442926. jhuber6 added a comment. Updating to use `objects` and adding documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129033/new/ https://reviews.llvm.org/D129033 Files:

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128914/new/ https://reviews.llvm.org/D128914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 updated this revision to Diff 442356. jhuber6 added a comment. Addressing some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128914/new/ https://reviews.llvm.org/D128914 Files: clang/test/Driver/linker-wrapper-image.c

[PATCH] D128923: [LinkerWrapper] Add AMDGPU specific options to the LLD invocation

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bb1bf1b1761: [LinkerWrapper] Add AMDGPU specific options to the LLD invocation (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129033: [Clang] Use metadata to make identifying embedded objects easier

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ABataev, MaskRay, tianshilei1992. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. jhuber6 requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. Thanks for the comments. Comment at: clang/test/Driver/linker-wrapper.c:109 // RUN: clang-offload-packager -o %t-lib.out \ // RUN: --image=file=%S/Inputs/dummy-elf.o,kind=openmp,triple=nvptx64-nvidia-cuda,arch=sm_70 \ tra

[PATCH] D128923: [LinkerWrapper] Add AMDGPU specific options to the LLD invocation

jhuber6 created this revision. jhuber6 added reviewers: arsenm, JonChesterfield, saiislam, yaxunl. Herald added subscribers: kosarev, t-tye, tpr, dstuttard, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the necessary changes required

[PATCH] D128850: [HIP] Generate offloading entries for HIP with the new driver.

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the small change required to

[PATCH] D124624: [OpenMP] Add variant extension that applies to declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf892ddb3be64: [OpenMP] Add variant extension that applies to declarations (authored by jhuber6). Changed prior to commit:

[PATCH] D128816: [OpenMP] Add loop tripcount argument to kernel launch and remove push function

jhuber6 updated this revision to Diff 441049. jhuber6 added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128816/new/ https://reviews.llvm.org/D128816 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 441048. jhuber6 added a comment. Update with new version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

This revision was automatically updated to reflect the committed changes. Closed by commit rG56ab966a04dd: [CUDA] Stop adding CUDA features twice (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128752/new/

[PATCH] D128816: [OpenMP] Add loop tripcount argument to kernel launch and remove push function

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ABataev. Herald added subscribers: mattd, asavonic, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 440831. jhuber6 added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 440822. jhuber6 added a comment. Herald added subscribers: mattd, asavonic. Fix tests, lots of lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files:

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

jhuber6 added a comment. In D128752#3616831 , @tra wrote: > Do we have tests that verify `-target-feature` arguments? It may be worth > adding a test case there checking for redundant features. Yeah, we have some existing tests that check for including

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

jhuber6 added a comment. In D128752#3616675 , @tra wrote: > We already heard complaints that searching for CUDA installation in multiple > places does add a measurable delay when the search hits NFS-mounted > directories. > > Replacing uses of

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

jhuber6 added a comment. In D128752#3616553 , @tra wrote: >> we no longer will have a cached CUDA installation so we will usually create >> it twice. > > Does that result in extra output in case we find an unexpected CUDA version, > or when compiler is

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We currently call

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 439853. jhuber6 added a comment. Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 439851. jhuber6 added a comment. Simplify interface now that we use -1 to indicate a lack of teams. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files:

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 added a comment. This currently fails about 180 Clang tests. Of those about half can be automatically updated. I tried to manually update the other 90 but gave up, attempting to auto generate those tests as well would most likely result in over half a million new lined added to LLVM,

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 created this revision. jhuber6 added reviewers: ABataev, JonChesterfield, jdoerfert, tianshilei1992. Herald added subscribers: guansong, hiraditya, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1.

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d3c010f1d01: [CUDA] Do not embed a fatbinary when using the new driver (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

jhuber6 added a comment. In D128441#3605809 , @tra wrote: >> The linker wrapper cannot do anything with these embedded PTX files because >> we do not know how to link them, > > Neither, apparently does `nvlink`. It does have `--emip-ptx ` option, > but

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e6889288cdc: [Offloading] Embed the target features in the OffloadBinary (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

jhuber6 updated this revision to Diff 439384. jhuber6 added a comment. Remove comment that is no longer true now that `getInputFilename` always returns a `.cubin` variant for object types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128441/new/

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang.

[PATCH] D127901: [LinkerWrapper] Add PTX output to CUDA fatbinary in LTO-mode

jhuber6 added a comment. In D127901#3603467 , @tra wrote: > I'm not sure I follow. WDYM by "go inside the binary itself" ? I assume you > mean the per-GPU offload binaries inside per-TU .o. so that it could be used > when that GPU object gets linked

[PATCH] D127901: [LinkerWrapper] Add PTX output to CUDA fatbinary in LTO-mode

jhuber6 added a comment. In D127901#3603006 , @tra wrote: > Then we do need a knob controlling whether we do want to embed PTX or not. > The default should be "off" IMO. > We currently have `--[no-]cuda-include-ptx=` we may reuse for that purpose. We

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

jhuber6 added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127686/new/ https://reviews.llvm.org/D127686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128206: [Clang] Allow multiple comma separated arguments to `--offload-arch=`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21e29b6ce734: [Clang] Allow multiple comma separated arguments to `--offload-arch=` (authored by jhuber6). Repository: rG LLVM Github Monorepo

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG958a88505080: [LinkerWrapper] Rework the linker wrapper and use owning binaries (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 added a comment. In D127246#3599826 , @JonChesterfield wrote: > I've read it but can't promise it's correct - the diff is large and has some > spurious noise in it which distracts significantly from the functional > changes. > > Would you be

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 updated this revision to Diff 438758. jhuber6 added a comment. Adding a test to ensure we no longer write temporary files for unused inputs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127246/new/ https://reviews.llvm.org/D127246 Files:

[PATCH] D128206: [Clang] Allow multiple comma separated arguments to `--offload-arch=`

jhuber6 created this revision. jhuber6 added reviewers: tra, yaxunl, jdoerfert, JonChesterfield, ye-luo. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. This patch updates the

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 added a comment. Is anyone up to review this? I'm mostly looking for some feedback on the interfaces I've built. If no one has time to look into it I can probably just land without review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127901: [LinkerWrapper] Add PTX output to CUDA fatbinary in LTO-mode

jhuber6 added a comment. In D127901#3590402 , @tra wrote: > Playing devil's advocate, I've got to ask -- do we even want to support JIT? > > JIT brings more trouble than benefits. > > - substantial start-up time on nontrivial apps. Last time I tried

[PATCH] D127901: [LinkerWrapper] Add PTX output to CUDA fatbinary in LTO-mode

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl. Herald added subscribers: mattd, gchakrabarti, asavonic, inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D127707: [Clang] Simplify unifying target features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4a2674e21c4: [Clang] Simplify unifying target features (authored by jhuber6). Changed prior to commit:

[PATCH] D127673: [OpenMP] Fix offload packager not writing to temps correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a6484c666ed: [OpenMP] Fix offload packager not writing to temps correctly (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127707: [Clang] Simplify unifying target features

jhuber6 created this revision. jhuber6 added reviewers: yaxunl, jdoerfert, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch simplifies how we unify target features. Now we simply

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

jhuber6 updated this revision to Diff 436611. jhuber6 added a comment. Does this approach work? I'm just using the reverse iterator and only adding the argument if it hasn't been seen yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127686/new/

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

jhuber6 updated this revision to Diff 436607. jhuber6 added a comment. Adjust how we generate arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127686/new/ https://reviews.llvm.org/D127686 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

jhuber6 added a comment. Thanks for the comments, I'll try to address them. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8320 +TC->getDriver().isUsingLTO(/* IsOffload */ true) +? ",feature=" + llvm::join(FeatureArgs, ",feature=") +: "";

[PATCH] D127686: [Offloading] Embed the target features in the OffloadBinary

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tianshilei1992, tra, yaxunl, saiislam. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. The target

[PATCH] D127673: [OpenMP] Fix offload packager not writing to temps correctly

jhuber6 updated this revision to Diff 436493. jhuber6 added a comment. Addressing nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127673/new/ https://reviews.llvm.org/D127673 Files: clang/lib/Driver/Driver.cpp

[PATCH] D127673: [OpenMP] Fix offload packager not writing to temps correctly

jhuber6 marked an inline comment as done. jhuber6 added a comment. Thanks for the review. Comment at: clang/lib/Driver/Driver.cpp:5420 +/*CreatePrefixForHost=*/isa(A) || +(!!A->getOffloadingHostActiveKinds() && !AtTopLevel)); if (isa(JA)) {

[PATCH] D127673: [OpenMP] Fix offload packager not writing to temps correctly

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, tra. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang.

[PATCH] D127515: [Clang] Change host/device only compilation to a driver mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1054a7318788: [Clang] Change host/device only compilation to a driver mode (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127515: [Clang] Change host/device only compilation to a driver mode

jhuber6 created this revision. jhuber6 added reviewers: tra, jdoerfert, JonChesterfield, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We use the flags `--offload-host-only` and

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 updated this revision to Diff 435571. jhuber6 added a comment. Fixing bug when capturing a StringRef by reference in a callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127246/new/ https://reviews.llvm.org/D127246 Files:

[PATCH] D127304: [LinkerWrapper] Embed OffloadBinaries for OpenMP offloading images

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, saiislam, JonChesterfield, tianshilei1992. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project:

<    3   4   5   6   7   8   9   10   11   12   >