[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

bob80905 added inline comments. Comment at: clang/test/SemaHLSL/entry_shader.hlsl:1 -// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-compute -x hlsl -hlsl-entry foo -o - %s -DSHADER='"anyHit"' -verify +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-compute -x hlsl

[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

bob80905 added inline comments. Comment at: clang/test/SemaHLSL/shader_type_attr.hlsl:30 // expected-error@+1 {{'shader' attribute parameters do not match the previous declaration}} +[shader("pixel")] I don't think we should expect this error, given that

[PATCH] D157911: clang: Add __builtin_exp10* and use new llvm.exp10 intrinsic

bob80905 added a comment. Release note for addition of exp10 builtin? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157911/new/ https://reviews.llvm.org/D157911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156737: clang: Add __builtin_elementwise_sqrt

bob80905 added a comment. Shouldn't this new builtin be mentioned in Release Notes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156737/new/ https://reviews.llvm.org/D156737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156178: [HLSL] add pow library function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf5137e984a6: [HLSL] add pow library function (authored by bob80905). Changed prior to commit:

[PATCH] D156178: [HLSL] add pow library function

bob80905 updated this revision to Diff 548296. bob80905 added a comment. - clang format pow.hlsl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156178/new/ https://reviews.llvm.org/D156178 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D156933: [HLSL] Add reversebits library function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe545392b1de3: [HLSL] Add reversebits library function (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156933: [HLSL] Add reversebits library function

bob80905 updated this revision to Diff 546618. bob80905 added a comment. - remove fnative half type from run line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156933/new/ https://reviews.llvm.org/D156933 Files:

[PATCH] D156933: [HLSL] Add reversebits library function

bob80905 updated this revision to Diff 546585. bob80905 added a comment. - rename file, make merge 2 Runs into 1 with enable16bit defined Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156933/new/ https://reviews.llvm.org/D156933 Files:

[PATCH] D156933: [HLSL] Add bitreverse library function

bob80905 updated this revision to Diff 546576. bob80905 added a comment. - change builtin name to reversebits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156933/new/ https://reviews.llvm.org/D156933 Files:

[PATCH] D156933: [HLSL] Add bitreverse library function

bob80905 created this revision. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156933 Files:

[PATCH] D156737: clang: Add __builtin_elementwise_sqrt

bob80905 added a comment. I think you need to mention this new builtin in clang/docs/ReleaseNotes.rst. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2548 +case Builtin::BI__builtin_sqrtf128: +case Builtin::BI__builtin_elementwise_sqrt: { llvm::Value *Call =

[PATCH] D156357: clang: Add elementwise bitreverse builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rG57f879cdd4c6: clang: Add elementwise bitreverse builtin (authored by bob80905). Changed prior to commit: https://reviews.llvm.org/D156357?vs=545251=545741#toc Repository: rG LLVM Github Monorepo

[PATCH] D156357: clang: Add elementwise bitreverse builtin

bob80905 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:634 the most negative integer remains the most negative integer - T __builtin_elementwise_fma(T x, T y, T z) fused multiply add, (x * y) + z.

[PATCH] D156357: clang: Add elementwise bitreverse builtin

bob80905 updated this revision to Diff 545251. bob80905 added a comment. - add float4 test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156357/new/ https://reviews.llvm.org/D156357 Files: clang/docs/LanguageExtensions.rst

[PATCH] D156357: clang: Add elementwise bitreverse builtin

bob80905 updated this revision to Diff 544830. bob80905 added a comment. - apply clang-format on CGBuiltin.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156357/new/ https://reviews.llvm.org/D156357 Files: clang/docs/LanguageExtensions.rst

[PATCH] D156357: clang: Add elementwise bitreverse builtin

bob80905 updated this revision to Diff 544610. bob80905 added a comment. - remove tests that only test floating point inputs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156357/new/ https://reviews.llvm.org/D156357 Files:

[PATCH] D156357: clang: Add elementwise bitreverse builtin

bob80905 updated this revision to Diff 544563. bob80905 added a comment. - remove strictfp test, add cgbuiltin case and update test in codegen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156357/new/ https://reviews.llvm.org/D156357 Files:

[PATCH] D156357: clang: Add elementwise bitreverse builtin

bob80905 updated this revision to Diff 544463. bob80905 added a comment. Herald added subscribers: wangpc, luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal,

[PATCH] D156357: clang: Add elementwise bitreverse builtin

bob80905 created this revision. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add codegen for llvm bitreverse elementwise builtin The bitreverse elementwise

[PATCH] D156178: [HLSL] add pow library function

bob80905 added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/pow.hlsl:10 +// CHECK: call half @llvm.pow.f16( +// NO_HALF: define noundef float @"?test_pow_half@@YA$halff@$halff@0@Z"( +// NO_HALF: call float @llvm.pow.f32( bogner wrote: > Why check

[PATCH] D156178: [HLSL] add pow library function

bob80905 updated this revision to Diff 543757. bob80905 added a comment. - add func name to checks, clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156178/new/ https://reviews.llvm.org/D156178 Files:

[PATCH] D156178: [HLSL] add pow library function

bob80905 added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/pow.hlsl:6 +// RUN: dxil-pc-shadermodel6.3-library %s -emit-llvm -disable-llvm-passes \ +// RUN: -D__HLSL_ENABLE_16_BIT -o - | FileCheck %s --check-prefix=NO_HALF + beanz wrote: >

[PATCH] D156178: [HLSL] add pow library function

bob80905 updated this revision to Diff 543731. bob80905 added a comment. - add eof newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156178/new/ https://reviews.llvm.org/D156178 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D156178: [HLSL] add pow library function

bob80905 updated this revision to Diff 543730. bob80905 added a comment. - remove non-floating-point func decls from header file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156178/new/ https://reviews.llvm.org/D156178 Files:

[PATCH] D156178: [HLSL] add pow library function

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change exposes the pow library

[PATCH] D153310: clang: Add elementwise pow builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a98e73169e1: clang: Add elementwise pow builtin (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153310/new/

[PATCH] D153310: Add codegen for llvm pow builtin

bob80905 added a comment. Ping, can someone please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153310/new/ https://reviews.llvm.org/D153310 ___ cfe-commits mailing list

[PATCH] D155729: [OptTable] Make explicitly included options override excluded ones

bob80905 added inline comments. Comment at: clang/include/clang/Driver/Options.h:40 + Ignored = (1 << 18), + TargetSpecific = (1 << 19), }; Given that the id for these flags have changed, does it make sense to write a test that makes sure these flags with

[PATCH] D153310: Add codegen for llvm pow builtin

bob80905 updated this revision to Diff 541721. bob80905 added a comment. - add newline EOF Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153310/new/ https://reviews.llvm.org/D153310 Files: clang/docs/LanguageExtensions.rst

[PATCH] D153310: Add codegen for llvm pow builtin

bob80905 updated this revision to Diff 541717. bob80905 added a comment. - add strictfp test, use emitbinarybuiltin, fix some whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153310/new/ https://reviews.llvm.org/D153310 Files:

[PATCH] D153310: Add builtin_elementwise_pow

bob80905 updated this revision to Diff 541651. bob80905 added a comment. - remove unimportant part of test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153310/new/ https://reviews.llvm.org/D153310 Files: clang/docs/LanguageExtensions.rst

[PATCH] D153310: Add builtin_elementwise_pow

bob80905 updated this revision to Diff 541294. bob80905 added a comment. fix void return, and incorrect expectation of arg count Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153310/new/ https://reviews.llvm.org/D153310 Files:

[PATCH] D155534: fix arg validation issue and void return issue, tests pass

bob80905 created this revision. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D155534 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 accepted this revision. bob80905 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 ___ cfe-commits mailing list

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added a comment. Should there be tests added for usage of scalable vector types for RISC-V / AArch64? I typically have added such tests in the past, as shown here: https://reviews.llvm.org/D135011 Also, would you be able to add something at the top of the strictfp file that states

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added a comment. I believe it's also necessary to declare the builtin_elementwise builtins in \clang\include\clang\Basic\Builtins.def. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 ___

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added a comment. I'd like to ask, is there a reason why there isn't a test for these new builtins under SemaCXX/builtins_elementwise_math.cpp? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added inline comments. Comment at: clang/test/CodeGen/strictfp-elementwise-bulitins.cpp:190 +// CHECK-NEXT: entry: +// CHECK-NEXT:[[ELT_TRUNC:%.*]] = tail call <4 x float> @llvm.canonicalize.v4f32(<4 x float> [[A]]) #[[ATTR4]] +// CHECK-NEXT:ret <4 x float>

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:18583 << Callee << CallerTCB; } } arsenm wrote: > arsenm wrote: > > bob80905 wrote: > > > I don't believe you intended to remove all this code in your latest > > >

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:656 + T __builtin_elementwise_nearbyint(T x) round x to the nearest integer value in floating point format, floating point types + rounding

[PATCH] D153310: Add builtin_elementwise_pow

bob80905 created this revision. Herald added subscribers: luke, Anastasia, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

bob80905 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:656 + T __builtin_elementwise_nearbyint(T x) round x to the nearest integer value in floating point format, floating point types + rounding

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c82050c5692: Add codegen for llvm exp/exp2 elementwise builtins (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145270/new/

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

bob80905 updated this revision to Diff 503511. bob80905 added a comment. - remove or to eliminate any ambiguity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145270/new/ https://reviews.llvm.org/D145270 Files: clang/docs/LanguageExtensions.rst

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz, fhahn. Herald added subscribers: luke, Anastasia, StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27,

[PATCH] D144309: [HLSL] add max/min library functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ac0551e77f4: [HLSL] add max/min library functions (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/

[PATCH] D144309: [HLSL] add max/min library functions

bob80905 updated this revision to Diff 502009. bob80905 added a comment. - only run tests if 16 bit is enabled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.org/D144309 Files:

[PATCH] D144309: [HLSL] add max/min library functions

bob80905 updated this revision to Diff 501963. bob80905 added a comment. - use already defined hlsl types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.org/D144309 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D144309: [HLSL] add max/min library functions

bob80905 updated this revision to Diff 501933. bob80905 added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.org/D144309 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D144309: [HLSL] add max/min library functions

bob80905 updated this revision to Diff 501250. bob80905 added a comment. - ushort is now unsigned Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.org/D144309 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D144309: [HLSL] add max/min library functions

bob80905 updated this revision to Diff 501248. bob80905 added a comment. - add support for these types: i16/u16/i32/u32/i64/u64/f16/f32/f64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.org/D144309 Files:

[PATCH] D144309: [HLSL] add max/min library functions

bob80905 updated this revision to Diff 500953. bob80905 added a comment. add int support for max/min. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.org/D144309 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D144802: clang: Add __builtin_elementwise_round

bob80905 added a comment. Should the addition of this builtin be mentioned in clang\docs\ReleaseNotes.rst? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144802/new/ https://reviews.llvm.org/D144802 ___ cfe-commits mailing list

[PATCH] D144309: [HLSL] add max/min library functions

bob80905 added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/min.hlsl:10 +// CHECK: call half @llvm.minnum.f16( +// NO_HALF: define noundef float @"?test_min_half@@YA$halff@$halff@0@Z"( +// NO_HALF: call float @llvm.minnum.f32( I had to add a 0

[PATCH] D144309: add max/min lib fxns

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [HLSL] add max/min library functions

[PATCH] D144120: [HLSL] add log library functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf842b7a6b8f4: [HLSL] add log library functions (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144120: [HLSL] add log library functions

bob80905 updated this revision to Diff 498051. bob80905 added a comment. - add newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144120/new/ https://reviews.llvm.org/D144120 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D144120: [HLSL] add log library functions This change exposes the log library functions for HLSL, excluding long, int, and long long doubles. The log functions are supported for all scalar, ve

bob80905 created this revision. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...missing in this patch because those types don't exist in HLSL. Int is missing

[PATCH] D143207: Add codegen for llvm log2/log10 elementwise builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG836249b1c2f0: Add codegen for llvm log2/log10 elementwise builtins (authored by bob80905). Changed prior to commit: https://reviews.llvm.org/D143207?vs=494477=495612#toc Repository: rG LLVM Github

[PATCH] D143207: Add codegen for llvm log10 elementwise builtin

bob80905 updated this revision to Diff 494477. bob80905 added a comment. - add log2 as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143207/new/ https://reviews.llvm.org/D143207 Files: clang/docs/LanguageExtensions.rst

[PATCH] D143207: Add codegen for llvm log10 elementwise builtin

bob80905 updated this revision to Diff 494471. bob80905 added a comment. include first commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143207/new/ https://reviews.llvm.org/D143207 Files: clang/docs/LanguageExtensions.rst

[PATCH] D143207: Add codegen for llvm log10 elementwise builtin

bob80905 updated this revision to Diff 494470. bob80905 added a comment. add release note line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143207/new/ https://reviews.llvm.org/D143207 Files: clang/docs/ReleaseNotes.rst Index:

[PATCH] D143231: add release note line

bob80905 created this revision. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D143231 Files: clang/docs/ReleaseNotes.rst Index:

[PATCH] D143208: Repair sphinx doc generation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa11a6752c15b: Repair sphinx doc generation (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143208: Repair sphinx doc generation

bob80905 created this revision. bob80905 added reviewers: beanz, python3kgae. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. mistake in the log commit neglected to place a space after the `` literal,

[PATCH] D143207: Add codegen for llvm log10 elementwise builtin

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz, craig.topper, fhahn. Herald added subscribers: luke, Anastasia, StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D140489: Add builtin_elementwise_log

This revision was automatically updated to reflect the committed changes. Closed by commit rG26eb70820fb8: Add builtin_elementwise_log (authored by bob80905). Changed prior to commit: https://reviews.llvm.org/D140489?vs=492581=494389#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D140489: Add builtin_elementwise_log

bob80905 updated this revision to Diff 492581. bob80905 added a comment. remove unrelated commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140489/new/ https://reviews.llvm.org/D140489 Files: clang/docs/LanguageExtensions.rst

[PATCH] D140489: Add builtin_elementwise_log

bob80905 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140489/new/ https://reviews.llvm.org/D140489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140489: Add builtin_elementwise_log

bob80905 added a comment. Herald added a subscriber: luke. Ping, can someone please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140489/new/ https://reviews.llvm.org/D140489 ___

[PATCH] D140489: Add builtin_elementwise_log

bob80905 updated this revision to Diff 488339. bob80905 added a comment. Herald added a reviewer: NoQ. - replace sin fxn with log Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140489/new/ https://reviews.llvm.org/D140489 Files:

[PATCH] D140489: Add builtin_elementwise_log

bob80905 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140489/new/ https://reviews.llvm.org/D140489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140992: clang: Add __builtin_elementwise_fma

bob80905 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2615 QualType ArgTy = TheCall->getArg(0)->getType(); -QualType EltTy = ArgTy; - -if (auto *VecTy = EltTy->getAs()) - EltTy = VecTy->getElementType(); -if (!EltTy->isFloatingType())

[PATCH] D140489: Add builtin_elementwise_log

bob80905 updated this revision to Diff 484633. bob80905 added a comment. Herald added subscribers: pcwang-thead, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal,

[PATCH] D140489: Add builtin_elementwise_log

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add codegen for llvm log elementwise

[PATCH] D139742: [HLSL] Add trunc library function

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fbcb3f4baa8: [HLSL] Add trunc library function (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139742/new/

[PATCH] D139742: [HLSL] Add acos library function

bob80905 updated this revision to Diff 481748. bob80905 added a comment. The commit still isn't included, adding ^ character Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139742/new/ https://reviews.llvm.org/D139742 Files:

[PATCH] D139742: [HLSL] Add acos library function

bob80905 updated this revision to Diff 481747. bob80905 added a comment. dont just paste the clang format commit onto the revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139742/new/ https://reviews.llvm.org/D139742 Files:

[PATCH] D139742: [HLSL] Add acos library function

bob80905 created this revision. bob80905 added reviewers: beanz, python3kgae. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D139137: add floor library function

This revision was automatically updated to reflect the committed changes. Closed by commit rG500e72924305: add floor library function (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139137/new/ https://reviews.llvm.org/D139137

[PATCH] D139137: add floor library function

bob80905 updated this revision to Diff 480218. bob80905 added a comment. - update with clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139137/new/ https://reviews.llvm.org/D139137 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D139137: add floor library function

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change exposes the floor library

[PATCH] D138161: add sin library function

bob80905 updated this revision to Diff 475952. bob80905 added a comment. [HLSL] add cos library function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138161/new/ https://reviews.llvm.org/D138161 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D138161: add sin library function

bob80905 created this revision. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138161 Files:

[PATCH] D134921: [HLSL] add cos library function

bob80905 updated this revision to Diff 475861. bob80905 added a comment. - clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ https://reviews.llvm.org/D134921 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h

[PATCH] D134921: [HLSL] add cos library function

bob80905 updated this revision to Diff 475633. bob80905 added a comment. - remove int overloads - remove double - update tests after new builtin landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ https://reviews.llvm.org/D134921

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 updated this revision to Diff 474628. bob80905 added a comment. - add dependency on architecture before testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files:

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 updated this revision to Diff 474570. bob80905 added a comment. - make format change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files: clang/docs/LanguageExtensions.rst

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. Ping, could someone please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 ___ cfe-commits mailing list

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 updated this revision to Diff 467201. bob80905 added a comment. - drop llvm from release notes description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files:

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135721: [HLSL] Added HLSL this as a reference

bob80905 added inline comments. Comment at: clang/test/AST/HLSL/this-reference.hlsl:62 +// CHECK-NEXT:`-ImplicitCastExpr 0x{{[0-9A-Fa-f]+}} 'Pair' lvalue +// CHECK-NEXT:`-CXXThisExpr 0x{{[0-9A-Fa-f]+}} 'PairInfo' lvalue implicit this One small nitpick I've

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 updated this revision to Diff 465446. bob80905 added a comment. - shorten builtin description, group sin and cos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files:

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 updated this revision to Diff 465236. bob80905 added a comment. - add new line to end of new files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files: clang/docs/LanguageExtensions.rst

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 updated this revision to Diff 465235. bob80905 added a comment. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso,

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. Here is the code I used to test the machine code output: typedef float float4 __attribute__((ext_vector_type(4))); void test_builtin_elementwise_sin(float f1, float f2, double d1, double d2, float4 vf1, float4 vf2) { f2 = __builtin_elementwise_sin(f1);

  1   2   >