Re: [PATCH] Warning for main returning a bool.

2016-11-13 Thread Joshua Hurwitz via cfe-commits
Friendly ping. Any further thoughts on this suggested warning? On Sat, Nov 5, 2016 at 1:48 PM Manuel Klimek wrote: > +richard > > On Fri, Oct 14, 2016 at 10:18 AM Joshua Hurwitz via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > See attached. > > Returning

Re: [PATCH] Warning for main returning a bool.

2016-11-21 Thread Joshua Hurwitz via cfe-commits
> >> >> To: "Joshua Hurwitz" > >> >> Cc: "cfe-commits" > >> >> Sent: Tuesday, November 15, 2016 12:17:28 PM > >> >> Subject: Re: [PATCH] Warning for main returning a bool. > >> >> > >> >

Re: [PATCH] Warning for main returning a bool.

2016-11-28 Thread Joshua Hurwitz via cfe-commits
, 2016 at 5:22 PM, Hal Finkel wrote: > >> > - Original Message - > >> >> From: "Aaron Ballman via cfe-commits" > >> >> To: "Joshua Hurwitz" > >> >> Cc: "cfe-commits" > >> >> Sent: Tuesday, N

[PATCH] Warning for main returning a bool.

2016-10-14 Thread Joshua Hurwitz via cfe-commits
See attached. Returning a bool from main is a special case of return type mismatch. The common convention when returning a bool is that 'true' (== 1) indicates success and 'false' (== 0) failure. But since main expects a return value of 0 on success, returning a bool is usually unintended. From 4b