[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D43341#1093117, @juliehockett wrote: > This will break things in clang-tools-extra without > https://reviews.llvm.org/D46615, so I'm going to hold off landing this until > that goes through Oops wrong patch disregard

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added a comment. This will break things in clang-tools-extra without https://reviews.llvm.org/D46615, so I'm going to hold off landing this until that goes through https://reviews.llvm.org/D43341 ___ cfe-commits mailing list

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

juliehockett updated this revision to Diff 145941. juliehockett marked 3 inline comments as done. juliehockett added a comment. Fixing formatting and tests. https://reviews.llvm.org/D46614 Files: include/clang/Lex/PPCallbacks.h include/clang/Lex/PreprocessingRecord.h

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

juliehockett updated this revision to Diff 145934. juliehockett added a comment. Adding test https://reviews.llvm.org/D46614 Files: include/clang/Lex/PPCallbacks.h include/clang/Lex/PreprocessingRecord.h lib/CodeGen/MacroPPCallbacks.cpp lib/CodeGen/MacroPPCallbacks.h

[PATCH] D46615: [tools] Updating PPCallbacks::InclusionDirective calls

juliehockett created this revision. juliehockett added a reviewer: aaron.ballman. juliehockett added a project: clang-tools-extra. Herald added subscribers: jkorous, kbarton, ioeric, nemanjai. [[ https://reviews.llvm.org/D46614 | [https://reviews.llvm.org/D46614] ]] adds

[PATCH] D46614: [clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective

juliehockett created this revision. juliehockett added a reviewer: aaron.ballman. juliehockett added a project: clang. Herald added subscribers: kbarton, nemanjai. Adding a SrcMgr::CharacteristicKind parameter to the InclusionDirective in PPCallbacks, and updating calls to that function. This

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett updated this revision to Diff 145788. juliehockett marked 10 inline comments as done. juliehockett added a comment. Made the check for system headers more comprehensive & fixed newline issues https://reviews.llvm.org/D43778 Files: clang-tidy/fuchsia/CMakeLists.txt

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett updated this revision to Diff 145547. juliehockett marked 9 inline comments as done. juliehockett edited the summary of this revision. juliehockett added a comment. Sorry for the delay in updating this -- check now restricts includes to a whitelist, rather than a blacklist, and only

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/RestrictIncludesCheck.cpp:75 +for (const auto : FileDirectives) { + auto D = Check.diag(Include.Loc, "restricted include found"); + aaron.ballman wrote: > I believe this check will be

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added inline comments. Comment at: clang-doc/Representation.cpp:53 + move(Namespace, std::move(Other.Namespace)); + extend(Description, std::move(Other.Description)); + return true; sammccall wrote: > is plain concatenation of comments what you

[PATCH] D46281: [clang-doc] Attaching a name to reference data

This revision was automatically updated to reflect the committed changes. juliehockett marked 2 inline comments as done. Closed by commit rL331539: [clang-doc] Attaching a name to reference data (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 144948. juliehockett marked 17 inline comments as done. juliehockett added a comment. Cleaning up and clarifying the merging process, and addressing comments https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp

[PATCH] D46281: [clang-doc] Attaching a name to reference data

juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:382 + emitRecord(R.USR, REFERENCE_USR); + emitRecord(R.Name, REFERENCE_NAME); + emitRecord((unsigned)R.RefType, REFERENCE_TYPE); lebedev.ri wrote: > >>! In D46281#1083806, @lebedev.ri

[PATCH] D46281: [clang-doc] Attaching a name to reference data

juliehockett updated this revision to Diff 144747. juliehockett marked 3 inline comments as done. juliehockett added a comment. Addressing a fixme and updating tests https://reviews.llvm.org/D46281 Files: clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/Representation.h

[PATCH] D46281: [clang-doc] Attaching a name to reference data

juliehockett updated this revision to Diff 144615. juliehockett marked 3 inline comments as done. juliehockett added a comment. Addressing comments https://reviews.llvm.org/D46281 Files: clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/Representation.h

[PATCH] D46281: [clang-doc] Attaching a name to reference data

juliehockett created this revision. juliehockett added reviewers: sammccall, jakehehrlich, lebedev.ri. juliehockett added a project: clang-tools-extra. This adds the name of the referenced decl, in addition to its USR, to the saved data, so that the backend can look at an info in isolation and

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett marked 5 inline comments as done. juliehockett added inline comments. Comment at: clang-doc/BitcodeReader.h:59 + + void storeData(llvm::SmallVectorImpl , llvm::StringRef Blob); + void storeData(bool , llvm::StringRef Blob); sammccall wrote: >

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 144011. juliehockett marked 17 inline comments as done. juliehockett added a comment. Reorganizing and streamlining, particularly in decoupling the reader from the reduce process and redesigning a bit to allow for more flexible reducing. Currently

[PATCH] D45447: [clang-tidy] Adding alias for anon namespaces in header (fuchsia module)

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE329720: [clang-tidy] Adding alias for anon namespaces in header (fuchsia module) (authored by juliehockett, committed by ). Changed prior to commit:

[PATCH] D43667: [clang-doc] Implement a YAML generator

juliehockett added a comment. In https://reviews.llvm.org/D43667#1062746, @Athosvk wrote: > I'm a bit late on this, but I'd say that YAML is usually not a 'final' > format. What would be the use-cases for this? And if is meant as an > alternative intermediate format, why not instead of having

[PATCH] D45468: [clang-tidy] Adding Fuchsia checker for human-readable logging

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a checker to the Fuchsia module to flag instances of attempting to log the system's numerical

[PATCH] D45447: [clang-tidy] Adding alias for anon namespaces in header (fuchsia module)

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Adding alias to google-build-namespaces to the Fuchsia module (checks for anonymous namespaces in

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 140275. juliehockett added a comment. Fixing assert on vector size. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt

[PATCH] D43667: [clang-doc] Implement a YAML generator

juliehockett updated this revision to Diff 140021. juliehockett added a comment. Updating to for adjustments to the internal representation & cleaning up duplication. https://reviews.llvm.org/D43667 Files: clang-doc/CMakeLists.txt clang-doc/Representation.h

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeReader.cpp:27 + assert(Record[0] == 20); + for (int I = 0, E = Record[0]; I < E; ++I) +Field[I] = Record[I + 1]; lebedev.ri wrote: > Ok, i don't understand what is going on here. > Where is

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 139972. juliehockett marked 4 inline comments as done. juliehockett added a comment. Small fixes to address comments https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 139869. juliehockett marked 13 inline comments as done. juliehockett added a comment. Addressing comments https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp

[PATCH] D44912: [clang-doc] Removing -Wunused-variable warning

This revision was automatically updated to reflect the committed changes. Closed by commit rL328588: [clang-doc] Removing -Wunused-variable warning (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

[PATCH] D44912: [clang-doc] Removing -Wunused-variable warning

juliehockett created this revision. juliehockett added reviewers: jakehehrlich, lebedev.ri, sammccall. juliehockett added a project: clang-tools-extra. Herald added subscribers: JDevlieghere, aprantl. Warning was appearing in release with debug info build, this removes it.

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 139644. juliehockett added a comment. Rebasing and updating. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt

[PATCH] D44743: [clang-tidy] Marking hicpp-no-assembler-msvc unsupported on Windows

juliehockett closed this revision. juliehockett added a comment. Committed in r328127. https://reviews.llvm.org/D44743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44743: [clang-tidy] Marking hicpp-no-assembler-msvc unsupported on Windows

juliehockett created this revision. juliehockett added reviewers: zturner, phosek. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. After changes to lit.site.cfg.in, the test is now running (and failing) on windows, so temporarily marking it unsupported. See

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

This revision was automatically updated to reflect the committed changes. Closed by commit rL328060: [lit] Adding config initialization to lit tests in clang-tools-extra (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. After much digging, it looks like the lit config is never initialized in clang-tools-extra like it is in the other projects. REQUIRES et.al. work properly once that's in there (see D44708 ). Once that lands I'll reland this and

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

juliehockett created this revision. juliehockett added reviewers: alexfh, mgorny. juliehockett added a project: clang-tools-extra. Adding the config initialization (the footer) to clang-tools-extra so that tests that use REQUIRES, UNSUPPORTED, and XFAIL based on platform or target triple work

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1041791, @lebedev.ri wrote: > Have you tried something more broad, like > `UNSUPPORTED: mingw32,win32` > ? That wasn't working either, confusingly, at least on the local windows machine I have. Repository: rL LLVM

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. I was just thinking of disabling the one test that has an issue (class-in-function) on Windows -- the filename is only used in generating *some* USRs, so all of the other ones are fine. We ran into some issues with that though, since `UNSUPPORTED: system-windows`

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

This revision was automatically updated to reflect the committed changes. juliehockett marked 2 inline comments as done. Closed by commit rL327590: [clang-tidy] Add Zircon module to clang-tidy (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett updated this revision to Diff 138470. juliehockett added a comment. Fixing a typo sorry https://reviews.llvm.org/D44346 Files: clang-tidy/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyMain.cpp clang-tidy/zircon/CMakeLists.txt

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett updated this revision to Diff 138468. juliehockett marked 3 inline comments as done. juliehockett added a comment. Updating docs. https://reviews.llvm.org/D44346 Files: clang-tidy/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyMain.cpp

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett updated this revision to Diff 138466. juliehockett marked 2 inline comments as done. juliehockett added a comment. Updating decl passed to warning string https://reviews.llvm.org/D44346 Files: clang-tidy/CMakeLists.txt clang-tidy/tool/CMakeLists.txt

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/FuchsiaTidyModule.cpp:44 +CheckFactories.registerCheck( +"fuchsia-zx-temporary-objects"); } aaron.ballman wrote: > Do we want a zircon module instead? I'm wondering about people

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett updated this revision to Diff 138392. juliehockett marked 3 inline comments as done. juliehockett added a comment. Fixing tests and updating docs https://reviews.llvm.org/D44346 Files: clang-tidy/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyMain.cpp

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett updated this revision to Diff 138286. juliehockett marked 3 inline comments as done. juliehockett added a comment. Addomg tests amd fixing documentation https://reviews.llvm.org/D44346 Files: clang-tidy/CMakeLists.txt clang-tidy/tool/CMakeLists.txt

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett updated this revision to Diff 138264. juliehockett marked 6 inline comments as done. juliehockett added a comment. Addressing comments https://reviews.llvm.org/D44346 Files: clang-tidy/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyMain.cpp

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett updated this revision to Diff 138241. juliehockett marked 8 inline comments as done. juliehockett retitled this revision from "[clang-tidy] Add Fuchsia checker for temporary objects" to "[clang-tidy] Add Zircon module to clang-tidy". juliehockett edited the summary of this revision.

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1034919, @lebedev.ri wrote: > Since the commit was reverted, did you mean to either recommit it, or reopen > this (with updated diff), so it does not get lost? Relanded in r327295. Comment at:

[PATCH] D44346: [clang-tidy] Add Fuchsia checker for temporary objects

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adding a checker to fuchsia-zx (for zircon) to flag instances where specific objects are

[PATCH] D43538: [clang-tidy] Update run-clang-tidy.py with config arg

This revision was automatically updated to reflect the committed changes. juliehockett marked an inline comment as done. Closed by commit rCTE327186: [clang-tidy] Update run-clang-tidy.py with config arg (authored by juliehockett, committed by ). Changed prior to commit:

[PATCH] D41102: Setup clang-doc frontend framework

This revision was automatically updated to reflect the committed changes. juliehockett marked 11 inline comments as done. Closed by commit rL327102: [clang-doc] Setup clang-doc frontend framework (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 137457. juliehockett marked 13 inline comments as done. juliehockett added a comment. Updating bitcode writer for hashed USRs, and re-running clang-format. Also cleaning up a couple of unused fields. https://reviews.llvm.org/D41102 Files:

[PATCH] D43667: [clang-doc] Implement a YAML generator

juliehockett updated this revision to Diff 137272. juliehockett marked 6 inline comments as done. juliehockett added a comment. Updating based on parent changes https://reviews.llvm.org/D43667 Files: clang-doc/CMakeLists.txt clang-doc/Representation.h clang-doc/generators/CMakeLists.txt

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeReader.cpp:19 + +void ClangDocBitcodeReader::storeData(llvm::SmallString<4> , + llvm::StringRef Blob) { lebedev.ri wrote: > I think all these `SmallString` can

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 137245. juliehockett marked 8 inline comments as done. juliehockett added a comment. Adding in support for mapper tests and addressing comments. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 137244. juliehockett added a comment. Adding hashing to reduce the size of USRs and updating tests. https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1028228, @Athosvk wrote: > This seems like quite a decent approach! That being said, I don't see the > pointer yet? I assume you mean that you will be adding this? Additionally, a > slight disadvantage of doing this generic

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/Representation.h:117 + bool IsDefinition = false; + llvm::Optional DefLoc; + llvm::SmallVector Loc; lebedev.ri wrote: > I meant that `IsDefinition` controls whether `DefLoc` will be

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136809. juliehockett marked an inline comment as done. juliehockett added a comment. Removing IsDefinition field. https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 136793. juliehockett added a comment. Updating for parent diff & refactoring reader. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136791. juliehockett marked 11 inline comments as done. juliehockett added a comment. Addressing comments https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 136660. juliehockett marked an inline comment as done. juliehockett added a comment. Cleaning up some and updating based on changes to the parent diff. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:196 +/// \brief Emits a record name to the BLOCKINFO block. +void ClangDocBitcodeWriter::emitRecordID(RecordId ID) { + assert(RecordIdNameMap[ID] && "Unknown Abbreviation"); lebedev.ri

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136650. juliehockett marked 16 inline comments as done. juliehockett added a comment. Adding tests, fixing comments, and removing an (as-of-yet) unused element of the CommentInfo struct. https://reviews.llvm.org/D41102 Files: CMakeLists.txt

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136520. juliehockett marked 14 inline comments as done. juliehockett added a comment. Fixing comments and adding tests https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136303. juliehockett marked 3 inline comments as done. juliehockett added a comment. Running clang-format and fixing newlines https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.h:37 + static constexpr unsigned SubblockIDSize = 4U; + static constexpr unsigned BoolSize = 1U; + static constexpr unsigned IntSize = 16U; lebedev.ri wrote: > Hmm, you build with asserts

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1020808, @lebedev.ri wrote: > Ok, great. > And it will also complain if you try to output a block within block? Um...no. Since you can have subblocks within blocks. Comment at: clang-doc/BitcodeWriter.cpp:191

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136161. juliehockett marked 15 inline comments as done. juliehockett added a comment. Fixing comments https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett updated this revision to Diff 136096. juliehockett marked 16 inline comments as done. juliehockett added a comment. Fixing comments and updating tests. https://reviews.llvm.org/D43778 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136010. juliehockett marked 10 inline comments as done. juliehockett added a comment. 1. Moved the serialization logic out of the Mapper class and into its own namespace 2. Updated tests 3. Addressing comments https://reviews.llvm.org/D41102 Files:

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1017918, @lebedev.ri wrote: > Is there some (internal to `BitstreamWriter`) logic that would 'assert()' if > trying to output some recordid > which is, according to the `BLOCKINFO_BLOCK`, should not be there? > E.g. outputting

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adding a check to restrict specific includes. Given a list of includes that should not be used,

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett updated this revision to Diff 135944. juliehockett marked 6 inline comments as done. juliehockett added a comment. After discussion, the goal of this checker slightly changed to target definitions in header files, rather than declarations. As a result, the check now adds the

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:52-53 + Finder->addMatcher( + functionDecl(allOf(hasAnyName(SmallVector(Names.begin(), + Names.end())), +

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135682. juliehockett added a comment. Fixing CMakeLists formatting https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt clang-doc/ClangDoc.h

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1017499, @Athosvk wrote: > Disadvantage is of course that you add complexity to certain parts of the > deserialization (/serialization) for nested types and inheritance, by either > having to do so in the correct order or having

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135678. juliehockett marked 29 inline comments as done. juliehockett added a comment. 1. Continued refactoring the bitcode writer 2. Added a USR attribute to infos 3. Created a Reference struct to replace the string references to other infos

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

juliehockett updated this revision to Diff 135583. juliehockett added a comment. Updating based on parent revision changes -- still rough, will continue to improve. https://reviews.llvm.org/D43424 Files: clang-doc/generators/CMakeLists.txt clang-doc/generators/Generators.h

[PATCH] D43667: [clang-doc] Implement a YAML generator

juliehockett created this revision. juliehockett added reviewers: klimek, jakehehrlich, sammccall, lebedev.ri. juliehockett added a project: clang-tools-extra. Herald added a subscriber: mgorny. juliehockett added a dependency: D43341: [clang-doc] Implement reducer portion of the frontend

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135559. juliehockett marked 10 inline comments as done. juliehockett added a comment. Refactoring bitcode writer https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 135520. juliehockett added a comment. Updating for parent diff changes https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:219 + +void ClangDocBitcodeWriter::emitIntRecord(int Value, RecordId ID) { + if (!Value) return; lebedev.ri wrote: > Now, all these three `emit*Record` functions now have the 'same

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135453. juliehockett marked 13 inline comments as done. juliehockett added a comment. Cleaning up bitcode writer https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135342. juliehockett marked 6 inline comments as done. juliehockett added a comment. Updating location creation and adding mapping from type to BlockId https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:407 + +void ClangDocBinaryWriter::writeBitstream(const EnumInfo , + BitstreamWriter , jakehehrlich wrote: > lebedev.ri wrote: > > juliehockett

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135305. juliehockett marked 20 inline comments as done. juliehockett added a comment. Cleaning up bitcode writer and fixing pointers for CommentInfos https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:407 + +void ClangDocBinaryWriter::writeBitstream(const EnumInfo , + BitstreamWriter , lebedev.ri wrote: > Hmm, common pattern again > ``` > void

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:68 + diag(MatchedDecl->getLocStart(), + "visibility attribute not set for specified function") + << MatchedDecl aaron.ballman wrote: > jakehehrlich

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett updated this revision to Diff 135181. juliehockett marked 10 inline comments as done. juliehockett added a comment. Updating check to allow for #pragma and command line visibility specs, and updating tests https://reviews.llvm.org/D43392 Files:

[PATCH] D43538: [clang-tidy] Update run-clang-tidy.py with config arg

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, alexfh. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Updating the run-clang-tidy.py script to allow specification of the config argument to the clang-tidy

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1011299, @lebedev.ri wrote: > I don't know the protocol, but i think it might be a good idea > to add a new entry to `CODE_OWNERS.TXT` for `clang-doc`? > > `clang-doc` going to be quite distinctive, and bigger/complicated > than

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135168. juliehockett marked 13 inline comments as done. juliehockett added a comment. 1. Updating mapper keys to use USRs instead of names 2. Also updating internal representation to use USRs instead of names 3. Renaming files (getting rid of the

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. > 2. I've mentioned it before as a comment, but to what extent will you be > parsing information in this frontend? Currently the links between types are > primarily stored as strings. Are you planning to have the backend that > generates the MarkDown parse those

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135009. juliehockett marked 27 inline comments as done. juliehockett added a comment. 1. Decoupled the mapper implementation from the main program, exposing only the function to generate the action factory 2. Implemented the matchers into a

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/ClangDoc.cpp:32 + ECtx.reportResult( + Name, Mapper.emitInfo(D, getComment(D), Name, getLine(D), getFile(D))); +} lebedev.ri wrote: > I wonder if `Name` should be `std::move()`'d ? Or not,

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/ClangDocBinary.cpp:88 + Stream.Emit((unsigned)'C', 8); + Stream.Emit((unsigned)'S', 8); +} lebedev.ri wrote: > General comment: shouldn't the bitcode be versioned? Possibly? My understanding of the

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 134855. juliehockett marked 14 inline comments as done. juliehockett added a comment. 1. Fixing docs 2. Adding static map from bitcode block/record id to block/record name 3. Pulling magic numbers into one struct 4. Cleaning up and clarifying command

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

juliehockett created this revision. juliehockett added reviewers: klimek, jakehehrlich, sammccall. juliehockett added a project: clang-tools-extra. Herald added subscribers: mgrang, mgorny. juliehockett added a dependency: D43341: [clang-doc] Implement reducer portion of the frontend framework.

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett updated this revision to Diff 134684. juliehockett marked 7 inline comments as done. juliehockett edited the summary of this revision. juliehockett added a comment. 1. Added visibility parameter 2. Updated Name parameter to be a list of names, as opposed to a single name 3. Fixed

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, alexfh. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adding a checker to find a function given its name and add a visibility attribute if none is present

<    1   2   3   4   5   >