[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 134546. juliehockett edited the summary of this revision. juliehockett added a comment. Moving the entire implementation of the bitcode reader to this patch (from the mapper patch, here ) and cleaning up implementation

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 134544. juliehockett edited the summary of this revision. juliehockett added a comment. Updating tests and moving the bitcode reader out (to the next patch) https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/CMakeLists.txt

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett created this revision. juliehockett added reviewers: klimek, sammccall, jakehehrlich. juliehockett added a project: clang-tools-extra. Herald added a subscriber: mgorny. juliehockett added a dependency: D41102: Setup clang-doc frontend framework. Implements a simple, in-memory

[PATCH] D43223: [clang-tidy] Update fuchsia-multiple-inheritance to not fail

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325015: [clang-tidy] Update fuchsia-multiple-inheritance to not fail (authored by juliehockett, committed by ). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43223 Files:

[PATCH] D43223: [clang-tidy] Update fuchsia-multiple-inheritance to not fail

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, alexfh. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Updating the fuchsia-multiple-inheritance to gracefully handle unknown record types (e.g. templatized classes)

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 133726. juliehockett added a comment. Updating documentation https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/CMakeLists.txt clang-doc/ClangDoc.cpp clang-doc/ClangDoc.h clang-doc/ClangDocBinary.cpp clang-doc/ClangDocBinary.h

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 133714. juliehockett marked 6 inline comments as done. juliehockett added a comment. 1. Implementing the bitstream decoder (and fixing the encoder) 2. Setting up new tests for the mapper output 3. Fixing comments https://reviews.llvm.org/D41102 Files:

[PATCH] D42918: [clang-tidy] Update fuchsia-multiple-inheritance to check for templates

This revision was automatically updated to reflect the committed changes. Closed by commit rL324432: [clang-tidy] Update fuchsia-multiple-inheritance to check for templates (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: tools/clang-doc/ClangDoc.h:29 +struct ClangDocContext { + // Which format in which to emit representation. + OutFormat EmitFormat; sammccall wrote: > juliehockett wrote: > > sammccall wrote: > > > Is this the

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 133108. juliehockett marked 27 inline comments as done. juliehockett edited the summary of this revision. juliehockett edited projects, added clang-tools-extra; removed clang. juliehockett added a comment. 1. Moved the tool to clang-tools-extra 1.

[PATCH] D42918: [clang-tidy] Update fuchsia-multiple-inheritance to check for templates

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, alexfh, hokein. Herald added a subscriber: xazax.hun. Updating fuchsia-multiple-inheritance to not crash when a record inherits a template. Fixes PR36052. https://reviews.llvm.org/D42918 Files:

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett planned changes to this revision. juliehockett added inline comments. Comment at: tools/clang-doc/ClangDoc.cpp:60 + +comments::FullComment *ClangDocVisitor::getComment(const Decl *D) { + RawComment *Comment = Context->getRawCommentForDeclNoCache(D);

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 132306. juliehockett marked 47 inline comments as done. juliehockett added a comment. 1. Changing the traversal pattern from using `RecursiveASTVisitor` to using matchers instead. This will allow for a more flexible API (e.g. allowing access to

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 132075. juliehockett edited the summary of this revision. juliehockett added a reviewer: jakehehrlich. juliehockett added a comment. 1. Updating and expanding tests 2. Updating output options (can now write to files) 3. Cleaning up pointers and whatnot

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 131481. juliehockett added a comment. Herald added a subscriber: hintonda. Cleaning up a few unnecessary copyings https://reviews.llvm.org/D41102 Files: test/CMakeLists.txt test/Tooling/clang-doc-basic.cpp test/lit.cfg.py tools/CMakeLists.txt

[PATCH] D42273: Add hasTrailingReturn AST matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rC323158: Add hasTrailingReturn AST matcher (authored by juliehockett, committed by ). Repository: rC Clang https://reviews.llvm.org/D42273 Files: docs/LibASTMatchersReference.html

[PATCH] D42273: Add hasTrailingReturn AST matcher

juliehockett updated this revision to Diff 130908. juliehockett added a comment. Adding test case -- thank you for the advice! https://reviews.llvm.org/D42273 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D42273: Add hasTrailingReturn AST matcher

juliehockett added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:5904 +return F->hasTrailingReturn(); + return false; +} lebedev.ri wrote: > There are no negative tests in the unittest that cover this false path. Is there a test case

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. juliehockett marked 4 inline comments as done. Closed by commit rCTE323011: [clang-tidy] Adding Fuchsia checker for multiple inheritance

[PATCH] D42273: Add hasTrailingReturn AST matcher

juliehockett updated this revision to Diff 130671. juliehockett marked 2 inline comments as done. juliehockett added a comment. Updating matcher and fixing semicolons https://reviews.llvm.org/D42273 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D42273: Add hasTrailingReturn AST matcher

juliehockett created this revision. juliehockett added a reviewer: aaron.ballman. Herald added a subscriber: klimek. Adds AST matcher for a FunctionDecl that has a trailing return type. https://reviews.llvm.org/D42273 Files: docs/LibASTMatchersReference.html

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 130427. juliehockett added a comment. Rebasing from trunk https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInheritanceCheck.cpp

[PATCH] D41963: [clang-tidy] Adding Fuchsia checker for thread local storage.

juliehockett abandoned this revision. juliehockett added a comment. After some discussion, we decided that the false positive risk for non-kernel code isn't worth the check. https://reviews.llvm.org/D41963 ___ cfe-commits mailing list

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322759: [clang-tidy] Adding Fuchsia checker for trailing returns (authored by juliehockett, committed by ). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42116 Files:

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

This revision was automatically updated to reflect the committed changes. Closed by commit rL322759: [clang-tidy] Adding Fuchsia checker for trailing returns (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett updated this revision to Diff 130242. juliehockett added a comment. Rebasing and updating decltypeType matcher https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/TrailingReturnCheck.cpp

[PATCH] D42120: [clang-tidy] Fixing Fuchsia overloaded operator warning message

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322692: [clang-tidy] Fixing Fuchsia overloaded operator warning message (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D42120?vs=129998=130205#toc

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett updated this revision to Diff 130200. juliehockett marked 8 inline comments as done. juliehockett added a comment. Updating matchers & fixing comments https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett updated this revision to Diff 130058. juliehockett added a comment. Good point -- updating checker to allow trailing returns if the decltype specifier is used. https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett added a comment. In https://reviews.llvm.org/D42116#977347, @aaron.ballman wrote: > Can you give some background on what problem the coding standard is trying to > avoid by banning this? For instance, if trailing return types are bad, are > deduced return types similarly bad, or

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett updated this revision to Diff 130027. juliehockett marked an inline comment as done. juliehockett added a comment. Updating checker to not warn for trailing returns on lambdas. https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt

[PATCH] D41708: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

juliehockett added a comment. The update to the message is also up for review here: D42120 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41708 ___ cfe-commits mailing list

[PATCH] D42120: [clang-tidy] Fixing Fuchsia overloaded operator warning message

juliehockett created this revision. juliehockett added a reviewer: alexfh. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Updating Fuchsia overloaded operator warning message for clarity. https://reviews.llvm.org/D42120 Files:

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, alexfh, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to the Fuchsia module to warn if a function has a trailing return. See

[PATCH] D41963: [clang-tidy] Adding Fuchsia checker for thread local storage.

juliehockett updated this revision to Diff 129647. juliehockett marked 3 inline comments as done. juliehockett added a comment. Fixing comments https://reviews.llvm.org/D41963 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

[PATCH] D41963: [clang-tidy] Adding Fuchsia checker for thread local storage.

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, alexfh, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to the Fuchsia module to warn if thread-local storage is used. See

[PATCH] D41546: [clang-tidy] Adding Fuchsia checker for statically constructed objects

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322310: [clang-tidy] Adding Fuchsia checker for statically constructed objects (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D41546?vs=129208=129505#toc

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 129498. juliehockett marked 8 inline comments as done. juliehockett added a comment. 1. Updating check and tests to address virtual inheritance 2. Rebasing from trunk https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt

[PATCH] D41546: [clang-tidy] Adding Fuchsia checker for statically constructed objects

juliehockett updated this revision to Diff 129208. juliehockett marked 5 inline comments as done. juliehockett added a comment. Updating matcher to catch dynamically initialized constructors and fixing comments. https://reviews.llvm.org/D41546 Files: clang-tidy/fuchsia/CMakeLists.txt

[PATCH] D41546: [clang-tidy] Adding Fuchsia checker for statically constructed objects

juliehockett updated this revision to Diff 128806. juliehockett marked 3 inline comments as done. juliehockett added a comment. 1. Narrowing check to only warn if the declaration is a global non-trivial object with explicit static storage, unless the object either has a `constexpr` constructor

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 128641. juliehockett added a comment. 1. Adding in a basic test setup for the framework 2. Pulling the YAML specs out into their own file 3. Expanding the representation to consider different types of declarations (namespace, tag, and function) and

[PATCH] D41708: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE321762: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D41708?vs=128548=128563#toc

[PATCH] D41708: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

juliehockett created this revision. juliehockett added a reviewer: alexfh. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Updating fuchsia-overloaded-operator check to not issue warnings for invalid locations. Fixes PR35803.

[PATCH] D41546: [clang-tidy] Adding Fuchsia checker for statically constructed objects

juliehockett updated this revision to Diff 128060. juliehockett marked 3 inline comments as done. https://reviews.llvm.org/D41546 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/StaticallyConstructedObjectsCheck.cpp

[PATCH] D41546: [clang-tidy] Adding Fuchsia checker for statically constructed objects

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, alexfh, hokein. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to the Fuchsia module to warn if statically-stored objects are created, unless constructed

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

This revision was automatically updated to reflect the committed changes. Closed by commit rL321363: [clang-tidy] Adding Fuchsia checker for overloaded operators (authored by juliehockett, committed by ). Herald added a subscriber: klimek. Changed prior to commit:

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

juliehockett added a comment. > Are the Fuchsia library headers intended to also comply with this rule? I > notice there's mention of a unique_ptr class, and I can't imagine that > working without overloading more operators than just assignment. Perhaps this > check should not be triggered for

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

juliehockett updated this revision to Diff 127960. juliehockett marked 5 inline comments as done. juliehockett added a comment. Fixing comments https://reviews.llvm.org/D41363 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

juliehockett updated this revision to Diff 127806. juliehockett added a comment. Updating matcher to include overloaded operators outside classes. https://reviews.llvm.org/D41363 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

juliehockett added inline comments. Comment at: docs/clang-tidy/checks/fuchsia-overloaded-operator.rst:17 + +See the features disallowed in Fuchsia at https://fuchsia.googlesource.com/zircon/+/master/docs/cxx.md JonasToth wrote: > Could you make the link

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

juliehockett updated this revision to Diff 127799. juliehockett marked 7 inline comments as done. juliehockett added a comment. Fixing comments https://reviews.llvm.org/D41363 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, alexfh, hokein. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to the Fuchsia module to warn if an operator is overloaded, except move and copy operators.

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

This revision was automatically updated to reflect the committed changes. juliehockett marked 4 inline comments as done. Closed by commit rL320841: [clang-tidy] Adding Fuchsia checker for virtual inheritance (authored by juliehockett, committed by ). Herald added a subscriber: klimek. Changed

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: tools/clang-doc/ClangDocReporter.h:35 + +struct StringPair { + std::string Key; JDevlieghere wrote: > Do you still need this? Yes, it's used to serialize the map to yaml. https://reviews.llvm.org/D41102

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 127053. juliehockett marked 8 inline comments as done. https://reviews.llvm.org/D41102 Files: tools/CMakeLists.txt tools/clang-doc/CMakeLists.txt tools/clang-doc/ClangDoc.cpp tools/clang-doc/ClangDoc.h tools/clang-doc/ClangDocReporter.cpp

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

juliehockett marked 3 inline comments as done. juliehockett added inline comments. Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:34-36 + // CHECK-MESSAGES: [[@LINE-1]]:28: warning: constructing a class that inherits a virtual base class is disallowed

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

juliehockett updated this revision to Diff 127033. juliehockett added a comment. Updating checker to only warn on declarations. https://reviews.llvm.org/D40813 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/VirtualInheritanceCheck.cpp

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: tools/clang-doc/ClangDocReporter.cpp:171 + CurrentCI->Name = getCommandName(C->getCommandID()); + for (unsigned i = 0, e = C->getNumArgs(); i > e; ++i) +CurrentCI->Args.push_back(C->getArgText(i)); JonasToth

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 126814. juliehockett marked 5 inline comments as done. juliehockett added a comment. Fixing typos https://reviews.llvm.org/D41102 Files: tools/CMakeLists.txt tools/clang-doc/CMakeLists.txt tools/clang-doc/ClangDoc.cpp

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

juliehockett added inline comments. Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:34-36 + // CHECK-MESSAGES: [[@LINE-1]]:28: warning: constructing a class that inherits a virtual base class is disallowed [fuchsia-virtual-inheritance] + // CHECK-NEXT: D(int

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

juliehockett updated this revision to Diff 126804. juliehockett marked an inline comment as done. juliehockett added a comment. Updated matcher to only match direct virtual base classes. https://reviews.llvm.org/D40813 Files: clang-tidy/fuchsia/CMakeLists.txt

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 126797. juliehockett marked 10 inline comments as done. juliehockett added a comment. Fixing comments https://reviews.llvm.org/D41102 Files: tools/CMakeLists.txt tools/clang-doc/CMakeLists.txt tools/clang-doc/ClangDoc.cpp

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: tools/clang-doc/ClangDocReporter.cpp:228 + for (comments::Comment *Child : + llvm::make_range(C->child_begin(), C->child_end())) { +CommentInfo ChildCI; JonasToth wrote: > Extract range into utility

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 126657. juliehockett added a comment. Updating formatting https://reviews.llvm.org/D41102 Files: tools/CMakeLists.txt tools/clang-doc/CMakeLists.txt tools/clang-doc/ClangDoc.cpp tools/clang-doc/ClangDoc.h tools/clang-doc/ClangDocReporter.cpp

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 126645. juliehockett marked 15 inline comments as done. juliehockett added a comment. Fixed comments and updated YAML output to use a StringMap. https://reviews.llvm.org/D41102 Files: tools/CMakeLists.txt tools/clang-doc/CMakeLists.txt

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett created this revision. juliehockett added a project: clang. Herald added a subscriber: mgorny. Setting up a basic frontend framework for a clang-doc tool. It creates a frontend action for traversing the AST to extract comments and declarations, with a flag to only extract

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

juliehockett updated this revision to Diff 125560. juliehockett marked 5 inline comments as done. https://reviews.llvm.org/D40813 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/VirtualInheritanceCheck.cpp

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett added inline comments. Comment at: test/clang-tidy/fuchsia-multiple-inheritance.cpp:48 +}; + +// Inherits from multiple concrete classes. aaron.ballman wrote: > The virtual base test cases I was thinking of were: > ``` > struct Base { virtual void

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 125449. juliehockett marked an inline comment as done. https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInheritanceCheck.cpp

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

juliehockett created this revision. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to the Fuchsia module to warn if classes are defined or created with virtual inheritance. See

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:60 + // To be an interface, all base classes must be interfaces as well. + for (const auto : Node->bases()) { +const auto *Ty = I.getType()->getAs();

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 125215. juliehockett marked 7 inline comments as done. juliehockett added a comment. Updating tests https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 125000. juliehockett marked 4 inline comments as done. https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInheritanceCheck.cpp

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 124949. juliehockett added a comment. Updated warning wording to more accurately reflect guidelines https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett added inline comments. Comment at: docs/clang-tidy/checks/fuchsia-multiple-inheritance.rst:46 + +See the features disallowed in Fuchsia at https://fuchsia.googlesource.com/zircon/+/master/docs/cxx.md alexfh wrote: > This is not about the check,

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 124853. juliehockett added a comment. Rebasing for updated Release Notes -- so much nicer :) https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

[PATCH] D40611: Add has definition AST matcher

juliehockett added a comment. That'd be great -- thank you! I did request commit rights, so hopefully I'll be able to do it myself next time. https://reviews.llvm.org/D40611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 124772. juliehockett marked 11 inline comments as done. juliehockett added a comment. Moved AST matcher to ASTMatchers.h (see D40611 ), addressing comments. https://reviews.llvm.org/D40580 Files:

[PATCH] D40611: Add has definition AST matcher

juliehockett created this revision. Herald added a subscriber: klimek. Adds AST matcher for the definition of a CXXRecordDecl. https://reviews.llvm.org/D40611 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 124675. juliehockett added a comment. Fixing typo https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInheritanceCheck.cpp

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 124669. juliehockett marked 4 inline comments as done. https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInheritanceCheck.cpp

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 124662. juliehockett marked 6 inline comments as done. https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInheritanceCheck.cpp

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett created this revision. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to the Fuchsia module to warn when a class inheritsfrom multiple classes that are not pure virtual. See

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett added a comment. If you could, that'd be great! Thank you! https://reviews.llvm.org/D40108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 124421. juliehockett marked an inline comment as done. juliehockett added a comment. Updating docs https://reviews.llvm.org/D40108 Files: clang-tidy/CMakeLists.txt clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/DefaultArgumentsCheck.cpp

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 124397. juliehockett marked 7 inline comments as done. juliehockett added a comment. Added new tests and updated wording in warning. https://reviews.llvm.org/D40108 Files: clang-tidy/CMakeLists.txt clang-tidy/fuchsia/CMakeLists.txt

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 123857. juliehockett marked 6 inline comments as done. juliehockett added a comment. Disabled the fix-it for `getDefaultArgRange()` that returns an empty range and for default args that come from a macro. https://reviews.llvm.org/D40108 Files:

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett added a comment. We're going to go with fuchsia-* for the module name, since the style applies to the broader project. Also, there may be zircon-specific checks at some point, so we want to leave the door open for that. Comment at:

[PATCH] D40261: Add default argument AST matcher

juliehockett added a comment. It'd be great if you could commit it -- I don't have commit privileges. Much appreciated! https://reviews.llvm.org/D40261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40261: Add default argument AST matcher

juliehockett updated this revision to Diff 123701. juliehockett marked an inline comment as done. https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 123677. juliehockett marked 8 inline comments as done. juliehockett added a comment. Moved AST matcher out to ASTMatchers.h (see D40261 ), fixing comments https://reviews.llvm.org/D40108 Files:

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/DefaultArgumentsCheck.cpp:22 + // Calling a function which uses default arguments is disallowed. + Finder->addMatcher(cxxDefaultArgExpr().bind("stmt"), this); + // Declaring default parameters is disallowed.

[PATCH] D40261: Add default argument AST matcher

juliehockett updated this revision to Diff 123654. juliehockett added a comment. Removed spurious semicolons https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D40261: Add default argument AST matcher

juliehockett updated this revision to Diff 123646. juliehockett added a comment. Updated Registry.cpp to include new matcher. https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D40261: Add default argument AST matcher

juliehockett created this revision. Herald added a subscriber: klimek. Adds AST matcher for declarations with default arguments. https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett added a comment. In https://reviews.llvm.org/D40108#928224, @Eugene.Zelenko wrote: > > I think it should use project-specific prefix, since it's open source > project. Google may have different coding guidelines for other projects. Reasonable. It makes sense to consider it on

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 123446. juliehockett marked 2 inline comments as done. juliehockett added a comment. Updated docs and added tests to check class methods. https://reviews.llvm.org/D40108 Files: clang-tidy/CMakeLists.txt clang-tidy/fuchsia/CMakeLists.txt

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett marked 2 inline comments as done. juliehockett added a comment. We do need to figure out what the right prefix for these checks is (whether fuchsia-* since they'll be used under the Fuchsia umbrella, zircon-* since the follow the Zircon section of the style guide linked above, or

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 123278. juliehockett edited the summary of this revision. juliehockett added a comment. Updated docs https://reviews.llvm.org/D40108 Files: clang-tidy/CMakeLists.txt clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/DefaultArgumentsCheck.cpp

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 123231. juliehockett marked an inline comment as done. juliehockett edited the summary of this revision. https://reviews.llvm.org/D40108 Files: clang-tidy/CMakeLists.txt clang-tidy/fuchsia/CMakeLists.txt

<    1   2   3   4   5   >