[PATCH] D138117: [clang][docs] Correct floating point option explanations

This revision was automatically updated to reflect the committed changes. Closed by commit rG498abe27dcf8: [clang][docs] Correct floating point option explanations (authored by kawashima-fj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138117/new/

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj updated this revision to Diff 479275. kawashima-fj edited the summary of this revision. kawashima-fj added a comment. Addressed to @zahiraam's comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138117/new/ https://reviews.llvm.org/D138117 Files:

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138117/new/ https://reviews.llvm.org/D138117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

This revision was automatically updated to reflect the committed changes. kawashima-fj marked an inline comment as done. Closed by commit rG3a95d7d0983a: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func (authored by kawashima-fj). Changed prior to commit:

[PATCH] D138088: [clang][docs] Use `option` directive in User's Manual

This revision was automatically updated to reflect the committed changes. Closed by commit rG799b6b9f3193: [clang][docs] Use `option` directive in Users Manual (authored by kawashima-fj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138088/new/

[PATCH] D138088: [clang][docs] Use `option` directive in User's Manual

kawashima-fj added a comment. In D138088#3937680 , @aaron.ballman wrote: > Thank you for this cleanup! In general, I thin this looks correct. However, I > know we've had to fix a bunch of options that cause the sphinx build to fail > (IIRC, oftentimes

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj added a comment. In D138117#3933644 , @zahiraam wrote: > What I meant was that the changes about the semantic mode approx-func that > you made here https://reviews.llvm.org/D138109 , should have included the > changes that you are making

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

kawashima-fj marked an inline comment as done. kawashima-fj added inline comments. Comment at: clang/test/Driver/fp-model.c:162 +// CHECK-FASTMATH-FPM-STRICT-NOT: "-ffast-math" +// CHECK-FASTMATH-FPM-STRICT-NOT: "-ffinite-math-only" zahiraam wrote: > Shouldn't

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

kawashima-fj updated this revision to Diff 475979. kawashima-fj added a comment. Update a test to include the `ffast-math -ffp-model=fast` pattern. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138109/new/ https://reviews.llvm.org/D138109 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj added a comment. In D138117#3931109 , @zahiraam wrote: > It would probably be better to make these changes with the appropriate code > changes you are making for each semantic mode. And may be keep this patch > only for the other changes

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj added a comment. I don't know it is inteded that `-fno-fast-math` does not imply `-ftrapping-math` and `-frounding-math`. `-ffast-math` and `-fno-fast-math` is not symmetric in RenderFloatingPointOptions

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj created this revision. kawashima-fj added reviewers: zahiraam, andrew.w.kaylor. kawashima-fj added a project: clang. Herald added a project: All. kawashima-fj requested review of this revision. Herald added a subscriber: cfe-commits. Explanations for options of floating point are

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

kawashima-fj added a comment. I found some errors in Clang Compiler User’s Manual . I will update of the Manual in another patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138109/new/

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

kawashima-fj created this revision. kawashima-fj added reviewers: masoud.ataei, zahiraam. kawashima-fj added a project: clang. Herald added a project: All. kawashima-fj requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. `-fapprox-func` should be disabled by

[PATCH] D138088: [clang][docs] Use `option` directive in User's Manual

kawashima-fj created this revision. kawashima-fj added a project: clang. Herald added a project: All. kawashima-fj requested review of this revision. Herald added a subscriber: cfe-commits. Sphinx has the `option` directive. Most option descriptions in `clang/docs/UsersManual.rst` used it but

[PATCH] D75594: [AArch64] Add support for Fujitsu A64FX

kawashima-fj closed this revision. kawashima-fj added a comment. Herald added subscribers: dexonsmith, danielkiss. In D75594#1927988 , @ikitayama wrote: > In D75594#1927959 , @kawashima-fj > wrote: > >> Yes,

[PATCH] D79921: [OPENMP] Fix mixture of omp and clang pragmas

This revision was automatically updated to reflect the committed changes. Closed by commit rGac2c5af67f03: [OPENMP] Fix mixture of omp and clang pragmas (authored by hishiguro, committed by kawashima-fj). Changed prior to commit: https://reviews.llvm.org/D79921?vs=265450=265667#toc

[PATCH] D75594: [AArch64] Add support for Fujitsu A64FX

kawashima-fj added a comment. In D75594#1927988 , @ikitayama wrote: > In D75594#1927959 , @kawashima-fj > wrote: > > > Yes, https://github.com/fujitsu/A64FX contains the official > > microarchitecture information

[PATCH] D75594: [AArch64] Add support for Fujitsu A64FX

kawashima-fj added a comment. Yes, https://github.com/fujitsu/A64FX contains the official microarchitecture information of A64FX. I wanted to include the URL in the Git commit message but the disclosure was not ready for it at the time. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D75594: [AArch64] Add support for Fujitsu A64FX

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8cd1a994d28: [AArch64] Add support for Fujitsu A64FX (authored by kawashima-fj). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES