[PATCH] D153352: [SystemZ] Fix regression in test macro-prefix-map-lambda.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e042871837b: [SystemZ] Fix regression in test macro-prefix-map-lambda.cpp (authored by Kai). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D142048: [Phabricator] Fix __ptr32 arguments passed to builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1d93da701b1: [Clang] Fix __ptr32 arguments passed to builtins (authored by Ariel-Burton, committed by Kai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

Kai added a comment. In D139444#3988544 , @probinson wrote: > Searching the buildbot console page for 'zos' turns up nothing; 's390' turns > up clang-s390x-linux, clang-s390x-linux-lnt, mlir-s390x-linux. Are there any > zos hosted bots? I.e., is this

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

Kai added a comment. In D139444#3978189 , @uweigand wrote: > In D139444#3975182 , @probinson > wrote: > >> The changes in this patch assume that there aren't any possible suffixes >> after the `-zos` part of the

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

Kai added a comment. In D139444#3982205 , @probinson wrote: > If you can tell me the `platform.system()` value to look for to detect z/OS, > I can do that. Probably as a separate patch, as it would be going beyond the > mechanical replacement that I'm

[PATCH] D129562: [SystemZ] Enable `-mtune=` option in clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rG880eb839e63f: [SystemZ] Enable `-mtune=` option in clang. (authored by Kai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129562/new/ https://reviews.llvm.

[PATCH] D129562: [SystemZ] Enable `-mtune=` option in clang.

Kai created this revision. Kai added reviewers: uweigand, jnspaulsson, yusra.syeda, Everybody0523. Herald added subscribers: luke957, s.egerton, simoncook. Herald added a project: All. Kai requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: cla

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

Kai added a comment. Some more nits, otherwise LGTM. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11150 + +const uint64_t XORWord = 0x; // XORing with 0b111...111 will never + // result in the original word

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

Kai added a comment. Did you consider to make this more generalized? From skimming through the change, I see only 2 ppc-specific things: - Loading of the canary word - Value of `XORWord` The first bullet is solved by the the other inline comment I made. The second bullet can be solved by using

[PATCH] D127498: [SystemZ/z/OS] Set DWARF version to 4 for z/OS.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5019ffc8efd: [SystemZ/z/OS] Set DWARF version to 4 for z/OS. (authored by Kai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127498/new/ https://reviews.l

[PATCH] D127498: [SystemZ/z/OS] Set DWARF version to 4 for z/OS.

Kai created this revision. Kai added reviewers: uweigand, jnspaulsson, abhina.sreeskantharajan, yusra.syeda. Herald added a project: All. Kai requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The DWARF version was raised to 5 for all

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

Kai accepted this revision. Kai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the documentation update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___

[PATCH] D83472: [SystemZ/ZOS] Add header file to encapsulate use of

This revision was automatically updated to reflect the committed changes. Closed by commit rGed07e1fe0ffd: [SystemZ/ZOS] Add header file to encapsulate use of (authored by Kai). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3aece05313e: [SystemZ/ZOS] Add binary format goff and operating system zos to the triple (authored by Kai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

Kai added reviewers: RKSimon, SjoerdMeijer, dexonsmith, rjmccall. Kai added a comment. Still looking for opinions on the clang part! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 ___ cfe-commits ma

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

Kai added a comment. Is there a comment on the clang part? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

Kai updated this revision to Diff 273004. Kai added a comment. - Added a `break;` in several places - Follow local formatting style in `triple.cpp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 Files: clang/lib/CodeGen/BackendUtil.cpp clan

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

Kai added a comment. I would like to get a 2nd opinion before committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

Kai updated this revision to Diff 272023. Kai added a comment. - In Triple.cpp: Keep list of binary formats sorted - In Triple.cpp: Use isOSzOS() for check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 Files: clang/lib/CodeGen/BackendUtil.cp

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

Kai marked 4 inline comments as done. Kai added inline comments. Comment at: llvm/include/llvm/Support/TargetRegistry.h:518 +case Triple::GOFF: + report_fatal_error("GOFF MCObjectStreamer not implemented yet."); } hubert.reinterpretcast wrote: > Th

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

Kai updated this revision to Diff 272010. Kai added a comment. - Relative order is now consistently GOFF before XCOFF - llvm_report_fatal() now follows guideline - Updated formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 Files: cla

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

Kai created this revision. Kai added reviewers: uweigand, yusra.syeda, kbarton, eli.friedman, MaskRay, hubert.reinterpretcast, cor3ntin, ldionne, tahonermann, simoll, kaz7, stuij. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, hiraditya. Herald added projects: clang, LLVM. Adds

[PATCH] D74146: [SytemZ] Disable vector ABI when using option -march=arch[8|9|10]

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5040d5ec97e: [SytemZ] Disable vector ABI when using option -march=arch[8|9|10] (authored by Kai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74146/new/

[PATCH] D74146: [SytemZ] Disable vector ABI when using option -march=arch[8|9|10]

Kai created this revision. Kai added a reviewer: uweigand. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. When specifying -march=arch[8|9|10], those CPU types do NOT support the vector extension. In this case the vector ABI must be disabled. Th