[PATCH] D97927: [clang-format] Rename case sorting

kentsommer accepted this revision. kentsommer added a comment. LGTM Sorry for the slow response! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97927/new/ https://reviews.llvm.org/D97927 ___ cfe-commits

[PATCH] D95017: [clang-format] Add case aware include sorting.

kentsommer updated this revision to Diff 320007. kentsommer added a comment. NFC rebase to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 319819. kentsommer added a comment. NFC Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNo

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 319806. kentsommer added a comment. Fixed release notes typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst clang/

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 319804. kentsommer added a comment. Added release notes, updated commit message and summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/Clang

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer added a comment. In D95017#2527512 , @curdeius wrote: > Concerning the `--sort-includes` command-line flag. I'd rather keep it as is > and, if need be, work on accepting an **optional** string argument. > Please update release notes. @curdeius

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 319786. kentsommer added a comment. Remove improper enum mapping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst cl

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer marked an inline comment as done. kentsommer added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2286 +**IncludeSortAlphabetically** (``bool``) + Specify if sorting should be done in an alphabetical and + case sensitive fashion.

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 319784. kentsommer added a comment. Turn SortIncludes into an enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer added a comment. In D95017#2522063 , @curdeius wrote: > Should we then revert ASAP and rework it later? @mydeveloperday Reverting would also be fine with me. I am happy to drive towards a feature (and flags) that everyone is comfortable with i

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2286 +**IncludeSortAlphabetically** (``bool``) + Specify if sorting should be done in an alphabetical and + case sensitive fashion. MyDeveloperDay wrote: > Are you sure `Includ

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 31. kentsommer added a comment. Undo some accidental comment formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptio

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2039 +**IncludeSortCaseAware** (``bool``) + Specify if sorting should be done in a case aware fashion. MyDeveloperDay wrote: > curdeius wrote: > > The name is somewhat awkward

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 318886. kentsommer marked 5 inline comments as done. kentsommer added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/do

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer added a comment. I do not have commit access. Full Name: Kent Sommer Email: w...@kentsommer.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 ___ cf

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer added a comment. @HazardyKnusperkeks let me know if the additions to the unit test are along the lines you were hoping for or not, I think this captures what you had in mind. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ http

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 318111. kentsommer added a comment. Expanded unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst clang/includ

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 317790. kentsommer added a comment. Fix unittests Fixes both failing unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyle

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer added a comment. I'll work on fixing the unit tests. Thought they ran with check-cpang-format but I was obviously wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 _

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer created this revision. kentsommer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Adds an option to [clang-format] which sorts headers in an alphabetical manner using case only for tie-breakers. The options is off by default i

[PATCH] D94287: [clang-format] Fix include sorting bug

kentsommer abandoned this revision. kentsommer added a comment. In D94287#2486099 , @curdeius wrote: > Seems to be a duplicate of D94206 . Right you are! Thanks for catching that! I'll abandon this one in favor of the one

[PATCH] D94287: [clang-format] Fix include sorting bug

kentsommer created this revision. kentsommer added a project: clang-format. kentsommer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Fixes a bug that caused `// clang-format off` in a includes section to disabled include sorting even a