Re: [PATCH] D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types

ksuther updated this revision to Diff 72578. ksuther added a comment. Added a unit test. https://reviews.llvm.org/D15643 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

Re: [PATCH] D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types

ksuther updated this revision to Diff 68930. ksuther added a comment. This was accepted a few months ago but it got buried and was never committed. The diff has been updated so that it can be committed cleanly. https://reviews.llvm.org/D15643 Files: lib/Format/TokenAnnotator.cpp Index:

[PATCH] D17922: [clang-format] Don't add a space before Obj-C selector methods that are also clang-format keywords

ksuther created this revision. ksuther added a reviewer: djasper. ksuther added a subscriber: cfe-commits. Herald added a subscriber: klimek. The following Obj-C methods will get formatted with an extra space between the right paren and the name: `- (void)delete:(id)sender` `-

Re: [PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

ksuther updated this revision to Diff 49928. ksuther added a comment. Thanks for the comments. I've made some changes that eliminates reverting r236598 and instead makes the behavior part of `IndentNestedBlocks`. That allows the Google Obj-C code style

Re: [PATCH] D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types

ksuther added a comment. Thank you! I don't have commit access, so could this be committed by someone who does? http://reviews.llvm.org/D15643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

ksuther created this revision. ksuther added a reviewer: djasper. ksuther added a subscriber: cfe-commits. Herald added a subscriber: klimek. Changes to clang-format's Objective-C block formatting over the past year have made clang-format's output deviate from what is expected (in my opinion).

Re: [PATCH] D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types

ksuther added a comment. This patch got buried, giving it a bump to see if anyone can take a look at it. http://reviews.llvm.org/D15643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D15643: Don't allow newline after uppercase Obj-C block return types

ksuther created this revision. ksuther added a reviewer: djasper. ksuther added a subscriber: cfe-commits. Herald added a subscriber: klimek. Fixes the following: BOOL (^aaa)(void) = ^BOOL { }; The first BOOL's token was getting set to TT_FunctionAnnotationRParen incorrectly, which was causing

Re: [PATCH] D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key

ksuther added a comment. This patch is still awaiting a commit. Sorry to repeatedly post about this, just don't want it to get lost. Thanks! http://reviews.llvm.org/D12501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key

ksuther added a comment. Do I need to do anything else about this and http://reviews.llvm.org/D12489, or do they eventually get committed by someone else? Thanks! http://reviews.llvm.org/D12501 ___ cfe-commits mailing list

Re: [PATCH] D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key

ksuther added a comment. I do not. http://reviews.llvm.org/D12501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12489: [clang-format] Fixed missing space between Obj-C for/in and a typecast

ksuther added a comment. Adding another comment in hopes of getting some visibility on this. Do I need to add other people as reviewers? http://reviews.llvm.org/D12489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key

ksuther added a comment. Adding another comment in hopes of getting some visibility on this. Do I need to add other people as reviewers? http://reviews.llvm.org/D12501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key

ksuther added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:377 @@ -376,1 +376,3 @@ +(!Contexts.back().ColonIsDictLiteral || + Style.Language != FormatStyle::LK_Cpp)) || Style.Language == FormatStyle::LK_Proto) &&

Re: [PATCH] D12489: [clang-format] Fixed missing space between Obj-C for/in and a typecast

ksuther updated this revision to Diff 33947. ksuther added a comment. Added two tests: One of a for/in loop with a cast, and one without. http://reviews.llvm.org/D12489 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

Re: [PATCH] D12489: [clang-format] Fixed missing space between Obj-C for/in and a typecast

ksuther added a reviewer: djasper. ksuther added a comment. This is my first commit and I'm trying to figure out the system, hope I'm doing this right. http://reviews.llvm.org/D12489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key

ksuther created this revision. ksuther added a reviewer: djasper. ksuther added a subscriber: cfe-commits. Herald added a subscriber: klimek. Fixes this bug: https://llvm.org/bugs/show_bug.cgi?id=22647 The following dictionary was getting formatted oddly: NSDictionary *query = @{ (__bridge