kmclaughlin created this revision.
kmclaughlin added reviewers: c-rhodes, sdesmalen, rovka.
Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett.
Herald added a project: LLVM.
kmclaughlin added a parent revision: D68021: [IntrinsicEmitter] Add overloaded
type
kmclaughlin created this revision.
kmclaughlin added reviewers: c-rhodes, sdesmalen, rovka.
Herald added subscribers: jdoerfert, hiraditya, tschuett.
Herald added a project: LLVM.
This allows intrinsics such as the following to be defined:
- declare @llvm.something.nxv4f32(, , )
...where is
kmclaughlin created this revision.
kmclaughlin added reviewers: sdesmalen, rovka.
Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a project: LLVM.
Adds the following two intrinsics:
- int_aarch64_sve_punpkhi
-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL372380: [IntrinsicEmitter] Add overloaded types for SVE
intrinsics (Subdivide2 … (authored by kmclaughlin, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D67549?vs=220886=220988#toc
kmclaughlin updated this revision to Diff 220886.
kmclaughlin added a comment.
- Some minor changes, including removing an unnecessary break
- Simplified checks of D.Kind in Function.cpp to determine if it is a
Subdivide2Argument or Subdivide4Argument
CHANGES SINCE LAST ACTION
kmclaughlin added a comment.
Thanks for reviewing this patch, @rovka and @sdesmalen!
Comment at: include/llvm/IR/Intrinsics.h:130
+ Kind == PtrToElt || Kind == VecElementArgument ||
+ Kind == Subdivide2Argument || Kind == Subdivide4Argument);
kmclaughlin updated this revision to Diff 220845.
kmclaughlin marked 5 inline comments as done.
kmclaughlin added a reviewer: rovka.
kmclaughlin added a comment.
- Moved getNarrowerFpElementVectorType logic into getTruncatedElementVectorType
- Shared code which handles Subdivide2Argument and
This revision was automatically updated to reflect the committed changes.
Closed by commit rL371967: [SVE][Inline-Asm] Add constraints for SVE predicate
registers (authored by kmclaughlin, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D66524?vs=219526=220299#toc
kmclaughlin created this revision.
kmclaughlin added reviewers: sdesmalen, SjoerdMeijer, greened.
Herald added subscribers: psnobl, rkruppe, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
kmclaughlin added a parent revision: D67549: [IntrinsicEmitter] Add overloaded
types for SVE
kmclaughlin created this revision.
kmclaughlin added reviewers: sdesmalen, SjoerdMeijer, greened.
Herald added subscribers: psnobl, rkruppe, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
kmclaughlin added a parent revision: D67549: [IntrinsicEmitter] Add overloaded
types for SVE
kmclaughlin created this revision.
kmclaughlin added reviewers: sdesmalen, SjoerdMeijer, greened.
Herald added subscribers: jdoerfert, tschuett.
Herald added a project: LLVM.
Both match the type of another intrinsic parameter of a vector type, but where
each element is subdivided to form a
kmclaughlin marked 3 inline comments as done.
kmclaughlin added inline comments.
Comment at: docs/LangRef.rst:3818
+- ``Upl``: One of the low eight SVE predicate registers (P0 to P7)
+- ``Upa``: Any of the SVE predicate registers (P0 to P15)
greened wrote:
>
kmclaughlin updated this revision to Diff 219526.
kmclaughlin added a comment.
- Renamed the //isPredicateConstraint// function to //parsePredicateConstraint//
- Added more thorough checks to the tests in aarch64-sve-asm.ll
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66524/new/
kmclaughlin marked an inline comment as done.
kmclaughlin added a subscriber: ruiu.
kmclaughlin added a comment.
Thank you to @gribozavr & @ruiu for spotting the warning caused by this patch,
and the suggestions to use -Wimplicit-fallthrough!
Comment at:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL370769: [SVE][Inline-Asm] Fix -Wimplicit-fallthrough in
AArch64ISelLowering.cpp (authored by kmclaughlin, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D67095?vs=218443=218463#toc
kmclaughlin created this revision.
kmclaughlin added reviewers: sdesmalen, rovka, cameron.mcinally, greened,
gribozavr, ruiu.
Herald added subscribers: psnobl, rkruppe, kristof.beyls, tschuett, javed.absar.
Herald added a project: LLVM.
Adds break to 'x' case in getRegForInlineAsmConstraint
This revision was automatically updated to reflect the committed changes.
Closed by commit rL370673: [SVE][Inline-Asm] Support for SVE asm operands
(authored by kmclaughlin, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D66302?vs=216655=218376#toc
Repository:
rL LLVM
kmclaughlin updated this revision to Diff 218071.
kmclaughlin added a comment.
- Added isPredicateConstraint function to AArch64ISelLowering.cpp, which
returns Upl, Upa or Invalid. This is used to replace some repeated checks of
the predicate type
- Minor changes to InlineAsm.cpp
CHANGES
kmclaughlin updated this revision to Diff 216655.
kmclaughlin added a comment.
- Removed a confusing comment from AArch64AsmPrinter.cpp
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66302/new/
https://reviews.llvm.org/D66302
Files:
docs/LangRef.rst
kmclaughlin updated this revision to Diff 216574.
kmclaughlin added a comment.
- Changed printAsmRegInClass in AArch64AsmPrinter.cpp to accept //unsigned
AltName// instead of //bool isVector//
- Added a comment to explain the test in aarch64-sve-asm-negative.ll
CHANGES SINCE LAST ACTION
kmclaughlin created this revision.
kmclaughlin added reviewers: t.p.northover, sdesmalen, rovka, momchil.velikov,
cameron.mcinally, greened.
Herald added subscribers: psnobl, rkruppe, tschuett, javed.absar.
Herald added a reviewer: rengolin.
Herald added a project: LLVM.
kmclaughlin added a
kmclaughlin updated this revision to Diff 216178.
kmclaughlin added a comment.
- Added a new test file, aarch64-sve-asm-negative.ll
- Updated description of the 'y' constraint in LangRef.rst
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66302/new/
https://reviews.llvm.org/D66302
kmclaughlin created this revision.
kmclaughlin added reviewers: t.p.northover, sdesmalen, rovka, momchil.velikov.
Herald added subscribers: psnobl, rkruppe, tschuett, javed.absar.
Herald added a reviewer: rengolin.
Herald added a project: LLVM.
Adds the following inline asm constraints for SVE:
kmclaughlin updated this revision to Diff 211264.
kmclaughlin added a comment.
- Removed second test in aarch64-sve-inline-asm.c which didn't use
//-emit-llvm//
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64739/new/
https://reviews.llvm.org/D64739
Files:
kmclaughlin updated this revision to Diff 24.
kmclaughlin added a comment.
- Updated test to remove unused variable 't'
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64739/new/
https://reviews.llvm.org/D64739
Files:
clang/lib/Basic/Targets/AArch64.cpp
kmclaughlin updated this revision to Diff 210821.
kmclaughlin retitled this revision from "[SVE][Inline-Asm] Add support to clang
for SVE inline assembly" to "[SVE][Inline-Asm] Add support to specify SVE
registers in the clobber list".
kmclaughlin added a comment.
- Removed typo fixes from this
kmclaughlin created this revision.
kmclaughlin added reviewers: erichkeane, sdesmalen, cfe-commits.
Herald added subscribers: psnobl, rkruppe, tschuett, javed.absar.
Herald added a reviewer: rengolin.
Herald added a project: clang.
Adds the SVE vector and predicate registers to the list of known
201 - 227 of 227 matches
Mail list logo