Author: kfunk
Date: Mon Nov 27 23:17:01 2017
New Revision: 319148
URL: http://llvm.org/viewvc/llvm-project?rev=319148=rev
Log:
run-clang-tidy: Use check_call instead of check_output
Summary:
Streamlines the output under Python 3.x.
Before:
```
b'Enabled checks:\n
Author: kfunk
Date: Tue Sep 5 05:36:33 2017
New Revision: 312532
URL: http://llvm.org/viewvc/llvm-project?rev=312532=rev
Log:
Make run-clang-tidy compatible with Python 3.x
Reviewers: alexfh
Reviewed By: alexfh
Subscribers: cfe-commits, JDevlieghere
Tags: #clang-tools-extra
Differential
Author: kfunk
Date: Tue Jul 25 07:39:08 2017
New Revision: 308975
URL: http://llvm.org/viewvc/llvm-project?rev=308975=rev
Log:
[clang-tidy] Fixup clang-apply-replacements/invalid-files test
Modified:
clang-tools-extra/trunk/test/clang-apply-replacements/invalid-files.cpp
Modified:
Author: kfunk
Date: Tue Jul 25 07:28:16 2017
New Revision: 308974
URL: http://llvm.org/viewvc/llvm-project?rev=308974=rev
Log:
[clang-tidy] clang-apply-replacements: Don't insert null entry
Summary:
[clang-tidy] clang-apply-replacements: Don't insert null entry
Fix crash when running
Author: kfunk
Date: Fri Feb 24 02:29:46 2017
New Revision: 296098
URL: http://llvm.org/viewvc/llvm-project?rev=296098=rev
Log:
Add clazy to external Clang examples page
Reviewers: silvas, rizsotto.mailinglist, sergio.martins
Reviewed By: rizsotto.mailinglist
Differential Revision:
Author: kfunk
Date: Tue Dec 20 03:56:56 2016
New Revision: 290172
URL: http://llvm.org/viewvc/llvm-project?rev=290172=rev
Log:
Fix for clang_Cursor_getSpellingNameRange()
Summary:
Fixes spelling name ranges for user-defined string literal operators.
Example:
constexpr int
kfunk added a comment.
@other LLVM devs: Please review so we can finally ship this?
Comment at: tools/libclang/CIndex.cpp:4311
@@ -4311,1 +4310,3 @@
+ C.kind == CXCursor_ConversionFunction ||
+ C.kind == CXCursor_FunctionDecl) {
if (pieceIndex > 0)
kfunk added a subscriber: kfunk.
kfunk added a comment.
In http://reviews.llvm.org/D21279#455923, @klimek wrote:
> Generally, please subscribe cfe-commits when sending patches via phab.
> See http://llvm.org/docs/Phabricator.html
You should set up a Herald rule then:
kfunk updated this revision to Diff 50720.
kfunk added a comment.
Remove unrelated hunk
http://reviews.llvm.org/D15729
Files:
include/clang/Frontend/CompilerInstance.h
lib/Frontend/ASTUnit.cpp
lib/Frontend/CompilerInstance.cpp
lib/FrontendTool/ExecuteCompilerInvocation.cpp
kfunk added inline comments.
Comment at: tools/libclang/CXType.cpp:990
@@ -987,1 +989,3 @@
+CXType clang_getNamedTypeUnderlyingElaboratedType(CXType CT){
+ QualType T = GetQualType(CT);
I'm not happy with this name either. If you look through the libclang API,
kfunk added a comment.
@bkramer: Thoughts about my patch? I wonder if this makes your "work-around" in
http://reviews.llvm.org/D17808 redundant.
http://reviews.llvm.org/D15729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: kfunk
Date: Tue Mar 8 04:34:23 2016
New Revision: 262922
URL: http://llvm.org/viewvc/llvm-project?rev=262922=rev
Log:
Bump libclang API version after r262318
Modified:
cfe/trunk/include/clang-c/Index.h
Modified: cfe/trunk/include/clang-c/Index.h
URL:
kfunk added a comment.
Okay, just gave this another look. Unit test seems fine as-is. Let's call
`loadPlugins` there explicitly.
@LLVM/Clang devs: Please review!
I'm especially interested in whether you think there's a better location for
calling `CompilerInstance::loadPlugins` than in
kfunk updated this revision to Diff 4.
kfunk added a comment.
This revision is now accepted and ready to land.
Remove TODO statement
http://reviews.llvm.org/D15729
Files:
include/clang/Frontend/CompilerInstance.h
lib/Frontend/ASTUnit.cpp
lib/Frontend/CompilerInstance.cpp
kfunk added a comment.
@realincubus: Sorry, I didn't know you had put this up for review already.
So back to this patch. Yes, it works fine for me *without* amending
libclang.exports. I'm injecting the arguments to `clang_parseTranslationUnit2`.
See this patch here for reference:
kfunk updated this revision to Diff 9.
kfunk added a comment.
Update, add (non-working) test
Just uploading my WIP patch, now that the branching comes close. I added a
test, unfortunately it doesn't do what I expect.
Please see the FIXME.
Didn't have the time to investigate yet, so any
kfunk added a comment.
By the way; prove that it really works:
http://wstaw.org/m/2015/12/23/kdevelop-clazy.png (loving it!) :)
http://reviews.llvm.org/D15729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kfunk added a comment.
Doing as requested by
http://lists.llvm.org/pipermail/cfe-dev/2014-October/039381.html, let's put
this up for review in its initial form, so we can discuss a better approach.
http://reviews.llvm.org/D15729
___
cfe-commits
kfunk accepted this revision.
kfunk added a comment.
Looks good to me now. I'd also appreciate another +1 from somone else, though.
http://reviews.llvm.org/D10833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kfunk added inline comments.
Comment at: bindings/python/clang/cindex.py:1589
@@ +1588,3 @@
+def is_assignment(self):
+return BinaryOperator.Assign.value <= self.value <
BinaryOperator.Comma.value
+
TIL chaining comparisons in Python is OK... :)
I
20 matches
Mail list logo
