[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev added a comment. Sounds good, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev added a comment. The difference is that `clang-rename` is a stand-alone binary with CLI whereas `clangd` isn't typically used as such (it can be, but it's a weird use-case). I don't know if there are any existing users out there, if there are then I assume there are very few. It was c

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev added a comment. Thanks Aaron! Yes, fair enough, that looks good to me, probably no need to move a sanity check to the front of `main()` in this case. Also, just as a note: I don't know how many people use `clang-rename` anymore (especially with `clangd` being present), I rewrote a lo

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. Yeah, this should be a right approach! Thanks! Comment at: clang/test/clang-rename/NonExistFile.cpp:1 +// RUN: not clang-rename -offset=0 -new-name=plop asdasd

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev added a comment. Oh, wait, I'm sorry, I didn't look into it closely :( Yeah, the `Input` file is not really needed, most of the time the users of `clang-rename` (not sure there are many with `clangd` being developed) use CLI flags for that. It's better to revert this patch. My bad, sho

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/tools/clang-rename/ClangRename.cpp:130 + } else { +errs() << "clang-rename: No input provided.\n"; +return 1; Probably so

[PATCH] D125930: [clangd] WIP: Experimental support for "IWYU pragma: export"

kbobyrev created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github M

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40f361ace3e9: [clangd] Include Cleaner: ignore headers with IWYU export pragmas (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 429637. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files: clang-

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 429619. kbobyrev added a comment. Also rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files: clang-tools-extra/clangd/Headers.cpp clang-t

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 429618. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address review comments: the structure is a bit different but the bug is now actually removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 428949. kbobyrev added a comment. Remove redundant comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files: clang-tools-extra/clangd/Headers.cpp clang-too

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 428947. kbobyrev added a comment. Remove unwanted formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files: clang-tools-extra/clangd/Headers.cpp

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev created this revision. kbobyrev added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-e

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

kbobyrev added a comment. In D125088#3499649 , @nridge wrote: > Is there a related change that explains what this setting does? Yes: https://reviews.llvm.org/D123488 It seems that I forgot to add the YAML parser logic :( CHANGES SINCE LAST ACTION ht

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/ConfigYAMLTests.cpp:259 + Fragment::parseYAML(YAML.code(), "config.yaml", Diags.callback()); + ASSERT_THAT(Diags.Diagnostics, IsEmpty()); + ASSERT_EQ(Results.size(), 1u); kbobyr

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/ConfigYAMLTests.cpp:259 + Fragment::parseYAML(YAML.code(), "config.yaml", Diags.callback()); + ASSERT_THAT(Diags.Diagnostics, IsEmpty()); + ASSERT_EQ(Results.size(), 1u); A ==

[PATCH] D124170: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f05b111ee1f: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export (authored by kbobyrev). Repository: rG LLVM Github Monore

[PATCH] D124166: [clangd] Correctly identify self-contained headers included rercursively

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1c0d2fb8272: [clangd] Correctly identify self-contained headers included rercursively (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D124170: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export

kbobyrev updated this revision to Diff 424205. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124170/new/ https://reviews.llvm.org/D124170 Files: clang-tools-ex

[PATCH] D124166: [clangd] Correctly identify self-contained headers included rercursively

kbobyrev updated this revision to Diff 424192. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124166/new/ https://reviews.llvm.org/D124166 Files: clang-too

[PATCH] D124170: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export

kbobyrev updated this revision to Diff 424189. kbobyrev added a comment. Use strlen for performance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124170/new/ https://reviews.llvm.org/D124170 Files: clang-tools-extra/clangd/Headers.cpp clang-t

[PATCH] D124170: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-

[PATCH] D124166: [clangd] Correctly identify self-contained headers included rercursively

kbobyrev updated this revision to Diff 424176. kbobyrev added a comment. Remove unused include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124166/new/ https://reviews.llvm.org/D124166 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-

[PATCH] D124166: [clangd] Correctly identify self-contained headers included rercursively

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks, this looks good; just few nits regarding the comments. Comment at: clang/include/clang/Testing/TestAST.h:9 +// +// In normal operation of clang, the FrontendActio

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbdf0b757d593: [clangd] IncludeCleaner: Add filtering mechanism (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev updated this revision to Diff 423601. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123488/new/ https://reviews.llvm.org/D123488 Files: clang-tools-e

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev added a comment. Oops, sorry, I linked the wrong revision; here's the prototype: we plan to start rolling it out gradually https://reviews.llvm.org/D122677 and then have a common library that we could share between both clangd and Clang-Tidy (and potentially other tools). Repository:

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev added a comment. In D123488#3444900 , @dsanders11 wrote: > Cool stuff! Chiming in randomly here, but I've been keeping a loose eye on > the progress of IncludeCleaner. > > I've been using IncludeCleaner to power include cleanup in the Chromium

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev updated this revision to Diff 48. kbobyrev added a comment. Fix the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123488/new/ https://reviews.llvm.org/D123488 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/cla

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev updated this revision to Diff 47. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Resolve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123488/new/ https://reviews.llvm.org/D123488 Files: clang-tools-e

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Th

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

kbobyrev added a comment. LG to me with the comments that Haojian made! Comment at: llvm/cmake/modules/AddLLVM.cmake:1827 +# Convert a target name like check-clangd to a variable name like CLANG. +function(umbrella_lit_testsuite_var target outvar) hokein wrot

[PATCH] D121838: [WIP] Generalize "check-all" umbrella targets, use for check-clang-tools

kbobyrev added a comment. I think this is no longer [WIP] but rather review-ready, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121838/new/ https://reviews.llvm.org/D121838 ___ cfe-commits mailin

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev added a comment. In D123031#3429801 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/55690/step_9.txt > > please take a look, etc :) Should be fixed in https://github.com/llvm/llvm-project/commit/211df7319af

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3de4d5e6dd66: [clangd] Use stable keys for CanonicalIncludes mappings (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420500. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Fix the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420462. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420426. kbobyrev added a comment. Rebase correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tool

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420425. kbobyrev added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420423. kbobyrev added a comment. Switch to stable file UniqueIDs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-extra/clangd/IncludeCleaner.c

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:73 + auto Filename = SM.getFileEntryForID(SM.getFileID(Range.getBegin())) + ->tryGetRealPathName(); + Includes->addMapping(Filename, isLiteralInclud

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev added a comment. In D123031#3426382 , @kadircet wrote: >> Right! I think I also need to do that in SymbolCollector.cpp. > > Now that you mentioned this too, it feels like the issue is not about being > consistent, as I think all of the places th

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev added a comment. In D123031#3426303 , @kadircet wrote: > note that you seem to be using `auto PublicHeader = > CanonIncludes.mapHeader(Entry->getName());` (i.e. `getName`) in D120306 > and not `tryGetRealPathN

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev added a comment. This is required for D120306 which was landed but later reverted because of the failing Windows tests (different slash types for filenames requested during preamble parsing and in the main file). Repository: rG LLVM Github Monorepo

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420175. kbobyrev added a comment. Fix the behavior: get Real Path instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-extra/clangd/index/Ca

[PATCH] D123031: [clangd] Use consistent header paths in CanonicalIncludes mappings

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cb38bfe76b7: [clangd] IncludeCleaner: Add support for IWYU pragma private (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 419378. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120306/new/ https://reviews.llvm.org/D120306 Files: clang-

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 418160. kbobyrev added a comment. Use better name for header recorder lambda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120306/new/ https://reviews.llvm.org/D120306 Files: clang-tools-extra/clangd/Inclu

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 418159. kbobyrev added a comment. Add some docs, rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120306/new/ https://reviews.llvm.org/D120306 Files: clang-tools-extra/clangd/IncludeClea

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 418155. kbobyrev added a comment. Fix a bug, add tests for diagnostics. This is ready for a review now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120306/new/ https://reviews.llvm.org/D120306 Files: clan

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 417940. kbobyrev added a comment. Herald added a project: All. Switch to a different model of recording includes that differentiates between user includes and public headers recored through IWYU pragmas. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

kbobyrev added a comment. Hi! I'm glad you're excited about IncludeCleaner and having a tool to try it out seems like a cool idea! > I'm not sure why include-cleaner wasn't integrated in clang-tidy, but I > suspect there's a good reason. The problem with IncludeCleaner as of right now is that

[PATCH] D119842: [clangd] NFC: Cleanup IncludeCleaner API

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5106c8f973b: [clangd] NFC: Cleanup IncludeCleaner API (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119842/new/ https://reviews.llv

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev added a comment. In D120306#3337374 , @sammccall wrote: > In D120306#3337288 , @kbobyrev > wrote: > >> In D120306#3337212 , @sammccall >> wrote: >> >>> What's t

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev updated this revision to Diff 410490. kbobyrev added a comment. Move suffix map to CanonicalIncludes (where it logically belongs), remove component limit there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120306/new/ https://reviews.llvm

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev added a comment. In D120306#3337212 , @sammccall wrote: > What's the policy this patch intends to implement? > > I'm a little concerned by building up maps of filenames with segment limits - > it looks like some kind of heuristic/partial matchin

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev planned changes to this revision. kbobyrev added a comment. The patch is working but I didn't add tests yet. Also, I think I should move the suffix mapping to `CanonicalIncludes` structure rather than `Headers`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D120306: [clangd] IncludeCleaner: Add support for IWYU pragma private

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM

[PATCH] D119842: [clangd] NFC: Cleanup IncludeCleaner API

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Make a further improv

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

kbobyrev added a comment. In D118847#3307497 , @Febbe wrote: > Can I still add a diff, or does this cause a revoke (apply the rest of the > feedback)? > Also, is the commit added automatically to the repo, or do I / another one > have to rebase it. > >

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LG, thanks! Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type-cxx20.cpp:71 + template + requires(T{0}) // + friend conste

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

kbobyrev added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:407 - if (F->getLocation().isInvalid()) + // operator<=> generates also the AST of e.g. operator==, which is implicit + if (F->getLocation().isInvalid() || F->i

[PATCH] D118847: Added early exit for defaulted FunctionDecls. This prevents matching of defaulted comparison operators. fixes llvm#53355

kbobyrev added a comment. Mostly LG with few nits. I think it might be able to make it into the 14 release if we cherry-pick into the release branch. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:407 - if (F->getLocation().isInvalid()) +

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev added a comment. In D119130#3307333 , @paulwalker-arm wrote: > After this commit I am seeing the link time error > > ld.lld: error: undefined symbol: clang::DeclContext::isInlineNamespace() > const > >>> referenced by StandardLibrary.cpp:11

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46a6f5ae148a: [clangd] NFC: Move stdlib headers handling to Clang (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D11913

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev added a comment. In D119130#3307222 , @sammccall wrote: > In D119130#3304505 , @kbobyrev > wrote: > >> Oh, and also regarding the Python generator scripts: they don't seem to work >> with the latest arc

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev updated this revision to Diff 407093. kbobyrev marked an inline comment as done. kbobyrev added a comment. Add a test for C Standard Library symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev updated this revision to Diff 406827. kbobyrev added a comment. Fix the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-tools-extra/clangd/CSymbolMap.inc clang-tools-extra/

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev added a comment. Oh, and also regarding the Python generator scripts: they don't seem to work with the latest archives :( 2018 mentioned in the docs (works perfectly) but 2019 crashes. Probably not very relevant if we switch to libc++ eventually. Repository: rG LLVM Github Monorepo

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev updated this revision to Diff 406800. kbobyrev added a comment. Fix the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-tools-extra/clangd/CSymbolMap.inc clang-tools-extra

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev updated this revision to Diff 406794. kbobyrev added a comment. Add a comment for the helper function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-tools-extra/clangd/CSymbolMap

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev updated this revision to Diff 406793. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-too

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev added a comment. In D119130#3300780 , @kadircet wrote: > Regarding the include mapping generator, I think it would've been better if > we had some sort of list directly from libc++ (as this is now being part of > clang rather than just clangd),

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StandardLibrary.h:37 + static llvm::Optional named(llvm::StringRef Scope, + llvm::StringRef Name); + kadircet wrote: > should scope have trail

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev updated this revision to Diff 406741. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev updated this revision to Diff 406401. kbobyrev added a comment. Move include-mapping generators to clang and re-generate the files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-

[PATCH] D119116: [clangd] Pull AST printer helpers to Clang

kbobyrev updated this revision to Diff 406367. kbobyrev added a comment. Fix the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119116/new/ https://reviews.llvm.org/D119116 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/

[PATCH] D119116: [clangd] Pull AST printer helpers to Clang

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This will be ne

[PATCH] D118882: [clangd] IncludeCleaner: Decrease API dependency on clangd

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG089d9c50b29e: [clangd] IncludeCleaner: Decrease API dependency on clangd (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D118882: [clangd] IncludeCleaner: Decrease API dependency on clangd

kbobyrev updated this revision to Diff 405598. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118882/new/ https://reviews.llvm.org/D118882 Files: clang-

[PATCH] D118882: [clangd] IncludeCleaner: Decrease API dependency on clangd

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM

[PATCH] D117461: [clangd] IncludeCleaner: Attach "insert prgama keep" fix-it to diagnostic

kbobyrev updated this revision to Diff 405238. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117461/new/ https://reviews.llvm.org/D117461 Files: clang-

[PATCH] D118592: [cte] Add release notes for clangd-14

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks for taking care of this! Comment at: clang-tools-extra/docs/ReleaseNotes.rst:54 + +- Diagnostics and fixes for unused include directives, according to IWYU style.

[PATCH] D118247: [clang] NFC: Use flush() idiomatically

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2fe81f32c3a: [clang] NFC: Use flush() idiomatically (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D118247: [clang] NFC: Use flush() idiomatically

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. kbobyrev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using both `raw_ostream::flush()` and `raw_ostream::str()` consecutively is redundant. The alternatives are: - Us

[PATCH] D118245: [clang][DeclPrinter] Fix printing for noexcept expressions

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118245/new/ https://reviews.llvm.org/D118245

[PATCH] D117491: [clangd] Remove redundant check for renamed symbol origin

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d9198cec994: [clangd] Remove redundant check for renamed symbol origin (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117491/new/ ht

[PATCH] D117491: [clangd] Remove redundant check for renamed symbol origin

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is a follow-up on D116643

[PATCH] D117461: [clangd] IncludeCleaner: Attach "insert prgama keep" fix-it to diagnostic

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Now that IWYU pragma: keep supr

[PATCH] D116643: [clangd] Don't rename on symbols from system headers.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LG, thanks! Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:171 +return true; + // FIXME: Remove this std symbol list, as they should be covered by the + /

[PATCH] D116643: [clangd] Don't rename on symbols from system headers.

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:1202 +TEST(RenameTest, NoRenameOnSymbolsFromSystemHeaders) { + // filter out references not from main file. + llvm::StringRef Test = Nit: capitalization. Repository

[PATCH] D116643: [clangd] Don't rename on symbols from system headers.

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:163 +// By default, we exclude symbols from system headers and protobuf symbols as +// rename these symbols would change system/generated files which are unlikely +// to be modified.

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LG with a nit, thanks! Comment at: clang-tools-extra/clangd/Headers.h:330 + static inline clang::clangd::stdlib::Header getEmptyKey() { +return clang::clangd::stdlib

[PATCH] D115345: [clangd] Suppress IncludeCleaner warnings for headers behind pragma keep

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb673bc36eacd: [clangd] Suppress IncludeCleaner warnings for headers behind pragma keep (authored by kbobyrev). Repository: rG LLVM Github Monorepo

[PATCH] D115345: [clangd] Suppress IncludeCleaner warnings for headers behind pragma keep

kbobyrev updated this revision to Diff 392810. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115345/new/ https://reviews.llvm.org/D115345 Files: clang-

[PATCH] D115345: [clangd] Suppress IncludeCleaner warnings for headers behind pragma keep

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. D114072

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeecfc73ae4b9: [clangd] Record IWYU pragma keep in the IncludeStructure (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE

  1   2   3   4   5   6   7   8   9   10   >