Author: kbarton
Date: Mon Aug 27 12:53:19 2018
New Revision: 340770
URL: http://llvm.org/viewvc/llvm-project?rev=340770&view=rev
Log:
[PPC] Remove Darwin support from POWER backend.
This patch removes uses of the Darwin ABI for PowerPC related test cases. This
is the first step in removing Darwin
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM, but I'd like @nemanjai to have a quick look at the
__builtin_vsx_insertword and __builtin_vsx_extractuword too.
Repository:
rL LLVM
https://reviews.llvm.org/D26546
_
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
kbarton added a comment.
There are several inline comments that need to be addressed.
I also think it's worthwhile putting a comment at the top of the review
indicating the (assumed) semantics for the vec_sube and vec_subec instructions
that are being implemented (i.e., the behaviour mimics the
kbarton added a comment.
Did you upload a new patch? The diff doesn't appear to change for me.
Repository:
rL LLVM
https://reviews.llvm.org/D26546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
kbarton added inline comments.
Comment at: lib/Headers/altivec.h:12014
+#define vec_insert4b(__a, __b, __c) \
+ ((vector unsigned char)__builtin_vsx_xxinsertw((__a), (__b), (__c) & 0xF))
+#endif
nemanjai wrote:
> As far as I can tell by looking at this patch and
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D26534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26519
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D26479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
With the suggestions above, this LGTM.
https://reviews.llvm.org/D26304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D26308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D26271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
kbarton added a comment.
Aside from one minor comment, this LGTM.
Comment at: lib/Basic/Targets.cpp:1364
@@ -1358,3 +1363,3 @@
// Handle explicit options being passed to the compiler here: if we've
// explicitly turned off vsx and turned on power8-vector or direct-move then
/
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D19684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
, 2016 at 11:33 AM Kit Barton via cfe-commits <cfe-commits@lists.llvm.org> wrote:
Author: kbartonDate: Wed Mar 9 13:28:31 2016New Revision: 263051URL: http://llvm.org/viewvc/llvm-project?rev=263051&view=revLog:[PPC] FE support for generating VSX [negated] absolute value instructionsIncl
Eric Christopher To: Kit Barton/Toronto/IBM@IBMCA, cfe-commits@lists.llvm.orgCc:Subject: Re: r263051 - [PPC] FE support for generating VSX [negated] absolute value instructionsDate: Wed, Mar 9, 2016 5:36 PM
On Wed, Mar 9, 2016 at 11:33 AM Kit Barton via cfe-commits <cfe-commits@lists.llvm.org> wr
kbarton closed this revision.
kbarton added a comment.
Committed r263051
http://reviews.llvm.org/D17816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kbarton
Date: Wed Mar 9 13:28:31 2016
New Revision: 263051
URL: http://llvm.org/viewvc/llvm-project?rev=263051&view=rev
Log:
[PPC] FE support for generating VSX [negated] absolute value instructions
Includes new built-in, conversion of built-in to target-independent intrinsic
and update
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
kbarton closed this revision.
kbarton added a comment.
Committed r262359
http://reviews.llvm.org/D17637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kbarton
Date: Tue Mar 1 12:11:28 2016
New Revision: 262359
URL: http://llvm.org/viewvc/llvm-project?rev=262359&view=rev
Log:
[PPC64][VSX] Add short, char, and bool data type for vec_vsx_ld and vec_vsx_st
intrinsics
Issue: https://llvm.org/bugs/show_bug.cgi?id=26720
Fix compile error wh
kbarton added a comment.
This failed testing:
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
1 warning(s) in tests.
Testing Time: 225.81s
Failing Tests (1):
Clang :: CodeGen/builtins-ppc-vsx.c
Expected Passes: 25406
Expecte
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM.
I will commit this a bit later, when I'll be around to watch the bots.
http://reviews.llvm.org/D17637
___
cfe-commits mailing list
cfe-co
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D15589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
29 matches
Mail list logo