[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis added a comment. In D75229#2406758 , @jfb wrote: > Most of the tests as written should be failing right now, at least on macOS > and Linux, because they likely should be identified as POSIX, right? Yes, now it fails on my system too. What woul

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 306690. abelkocsis added a comment. Fix, `MacroName == "__unix__"` seems really necessary. Without that, it throws a warning for me on Linux. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 306543. abelkocsis added a comment. Fixes, `PPCallbacks` class add Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: clang-tools-extra/clang-tidy/bugprone/Bugp

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

abelkocsis updated this revision to Diff 306080. abelkocsis added a comment. Fixes, `std::atomic` variables add Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77493/new/ https://reviews.llvm.org/D77493 Files: clang-tools-extra/clang-tidy/bugprone/

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.cpp:68 +const SourceManager &SM, Preprocessor *pp, Preprocessor *ModuleExpanderPP) { + PP = pp; +} whisperity wrote: > Global state is alw

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 305439. abelkocsis added a comment. Fixes Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clan

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 305388. abelkocsis added a comment. Some fixes. Needs further improvement Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: clang-tools-extra/clang-tidy/bugpro

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis added a comment. I have managed to improve the checker, but could not set up the test files to work only in POSIX platforms. Could you help me or show me an example? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://review

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 282472. abelkocsis marked 5 inline comments as done. abelkocsis added a comment. Fixes Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: clang-tools-extra/clan

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 271789. abelkocsis added a comment. Small comment fix Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModul

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis marked an inline comment as done. abelkocsis added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:88 // C checkers // CON Eugene.Zelenko wrote: > Please use //check// here. Should I replace the `// C++ che

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

abelkocsis added a comment. Would you give me some feedback according to this checker? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77493/new/ https://reviews.llvm.org/D77493 ___ cfe-commits mailing li

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 271414. abelkocsis added a comment. Fixes on description and documentation Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: asd.diff clang-tools-extra/clang

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 255250. abelkocsis added a comment. Small fixes Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

abelkocsis updated this revision to Diff 255170. abelkocsis added a comment. Small fixes in doc and test files. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77493/new/ https://reviews.llvm.org/D77493 Files: clang-tools-extra/clang-tidy/bugprone/

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 255169. abelkocsis marked an inline comment as done. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.c

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis marked 2 inline comments as done. abelkocsis added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.cpp:33-50 +void SignalInMultithreadedProgramCheck::registerMatchers(MatchFinder *Finder) { + auto signalCall = +

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f4c70dd3ec6: [clang-tidy] Add spuriously-wake-up-functions check (authored by abelkocsis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https:/

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 251829. abelkocsis added a comment. Format fix Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 247833. abelkocsis added a comment. Configurable callers option and new test cases add. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: clang-tools-extra/cla

[PATCH] D75229: Add signal-in-multithreaded-program check

abelkocsis created this revision. abelkocsis added reviewers: aaron.ballman, alexfh, hokein, jfb. abelkocsis added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, mgehre, dexonsmith, mgorny. According to https://wiki.sei.cmu.edu/confluence/display/c/CON37-C.+Do+not+call

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 245113. abelkocsis added a comment. Test cases adding, checker modifying to pass new cases. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 Files: clang-tools-extra

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 244098. abelkocsis added a comment. docs/list.rst update Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyMo

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 243779. abelkocsis added a comment. Checker update to analyse language, separated checks for C and C++. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 Files: clang

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 235469. abelkocsis marked an inline comment as done. abelkocsis added a comment. Checker fixes, updates test file adding test cases for `doWhile` and `for` statements, test headers deleted. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis marked 11 inline comments as done. abelkocsis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/bugprone-spuriously-wake-up-functions.cpp:2 +// RUN: %check_clang_tidy %s bugprone-spuriously-wake-up-functions %t -- -- -I %S/Inputs/bugprone-spuriousl

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 235232. abelkocsis added a comment. `docs/clang-tidy/checks/lsit.rst` update Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 Files: clang-tools-extra/clang-tidy/bug

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 235212. abelkocsis added a comment. Adding matcher for `cnd_timedwait` and test cases. Small fix in documentation Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 File

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 235180. abelkocsis added a comment. Checker is moved to bugprone section, tests added. C checker is improved, and documentations are synchronised. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ htt

[PATCH] D70876: Add spuriously-wake-up-functions check

abelkocsis created this revision. abelkocsis added reviewers: aaron.ballman, alexfh, hokein, jfb. abelkocsis added projects: clang-tools-extra, clang. Herald added subscribers: cfe-commits, mgehre, dexonsmith, mgorny. According to https://wiki.sei.cmu.edu/confluence/display/cplusplus/CON54-CPP.+W

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 226746. abelkocsis added a comment. Alias added to //cert// module Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 Files: clang-tools-extra/clang-tidy/bugprone/BadS

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 226648. abelkocsis added a comment. Small fix in documentation Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 Files: clang-tools-extra/clang-tidy/bugprone/BadSigna

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 226598. abelkocsis marked an inline comment as done. abelkocsis added a comment. Small fixes Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 Files: clang-tools-extr

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 226596. abelkocsis marked 4 inline comments as done. abelkocsis added a comment. Checker moved to bugprone module, cert alias added. Small fixes in checker file, warning message updated. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION ht

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis marked 3 inline comments as done. abelkocsis added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-bad-signal-to-kill-thread.rst:8 +``SIGTERM`` signal and the signal kills the entire process, not just the +individual thread. Use any signal e

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 225834. abelkocsis added a comment. Findig SIGTERM replaced on checker Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 Files: clang-tools-extra/clang-tidy/misc/BadS

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 225788. abelkocsis added a comment. The documentation of the checker updated. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 Files: clang-tools-extra/clang-tidy/mi

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 225786. abelkocsis added a comment. Test clang-formatted. Uncaught word removed from documentations. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 Files: clang-to

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 225784. abelkocsis marked an inline comment as done. abelkocsis added a comment. Header documentation and Release Notes synchronised. Documentation of checker updated. Type changed to auto type when necessary. Repository: rCTE Clang Tools Extra CHANGE

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 225769. abelkocsis added a comment. Auto types replaced on checker files. New lines added when necessary. Reordered ReleaseNotes by alphabetical order. Checker name is updated on ReleaseNotes, compliant solution is wrote to the documentation. Another two

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis added a comment. Thank you for the reviews! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis created this revision. abelkocsis added reviewers: aaron.ballman, alexfh, JonasToth, steakhal, Charusso. abelkocsis added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre, jfb, dexonsmith, steven_wu, hiraditya, xazax.hun, mgorny, mehdi_amini. Herald added a r